Re: Review Request 61420: GEODE-3307 CI failure: Uncaught exception in thread Thread[Geode Membership View Creator

2017-08-08 Thread Udo Kohlmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61420/#review182441
---


Ship it!




Ship It!

- Udo Kohlmeyer


On Aug. 3, 2017, 10:07 p.m., Hitesh Khamesra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61420/
> ---
> 
> (Updated Aug. 3, 2017, 10:07 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, Udo Kohlmeyer, and Brian Rowe.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Now we catch DistributedSystemDisconnectedException in ViewCreatoe thread and 
> then mark shutdown true
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
>  40a4254 
> 
> 
> Diff: https://reviews.apache.org/r/61420/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Hitesh Khamesra
> 
>

Re: Review Request 61420: GEODE-3307 CI failure: Uncaught exception in thread Thread[Geode Membership View Creator

2017-08-08 Thread Alexander Murmann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61420/#review182413
---


Ship it!





geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
Lines 2083 (patched)


since we do the same thing in both cases why not do
```
catch (InterruptedException | DistributedSystemDisconnectedException e) {...
```


- Alexander Murmann


On Aug. 3, 2017, 10:07 p.m., Hitesh Khamesra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61420/
> ---
> 
> (Updated Aug. 3, 2017, 10:07 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, Udo Kohlmeyer, and Brian Rowe.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Now we catch DistributedSystemDisconnectedException in ViewCreatoe thread and 
> then mark shutdown true
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
>  40a4254 
> 
> 
> Diff: https://reviews.apache.org/r/61420/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Hitesh Khamesra
> 
>

Re: Review Request 61420: GEODE-3307 CI failure: Uncaught exception in thread Thread[Geode Membership View Creator

2017-08-04 Thread Bruce Schuchardt 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61420/#review182214
---


Ship it!




Ship It!

- Bruce Schuchardt


On Aug. 3, 2017, 3:07 p.m., Hitesh Khamesra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61420/
> ---
> 
> (Updated Aug. 3, 2017, 3:07 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, Udo Kohlmeyer, and Brian Rowe.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Now we catch DistributedSystemDisconnectedException in ViewCreatoe thread and 
> then mark shutdown true
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
>  40a4254 
> 
> 
> Diff: https://reviews.apache.org/r/61420/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Hitesh Khamesra
> 
>

Re: Review Request 61420: GEODE-3307 CI failure: Uncaught exception in thread Thread[Geode Membership View Creator

2017-08-03 Thread Brian Rowe 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61420/#review182179
---


Ship it!




Ship It!

- Brian Rowe


On Aug. 3, 2017, 10:07 p.m., Hitesh Khamesra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61420/
> ---
> 
> (Updated Aug. 3, 2017, 10:07 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen 
> O'Sullivan, Udo Kohlmeyer, and Brian Rowe.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Now we catch DistributedSystemDisconnectedException in ViewCreatoe thread and 
> then mark shutdown true
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
>  40a4254 
> 
> 
> Diff: https://reviews.apache.org/r/61420/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Hitesh Khamesra
> 
>