[GitHub] incubator-geode issue #259: Feature/geode 1952 2

Github user upthewaterspout commented on the issue: https://github.com/apache/incubator-geode/pull/259 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] incubator-geode pull request #259: Feature/geode 1952 2

Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/259 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Review Request 52896: GEODE-706 Fixed race condition between expiry thread and put thread.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52896/ --- Review request for geode, Bruce Schuchardt, Darrel Schneider, and Udo Kohlmeyer.

Re: Coding practices/standards

+1 to a) embracing https://google.github.io/styleguide/javaguide.html 100%, b) adopting the google formatters for IntelliJ and Eclipse, c)using spotless On Fri, Oct 14, 2016 at 6:56 AM, Jacob Barrett wrote: > +1 > > On Thu, Oct 13, 2016 at 10:04 AM Kevin Duling

Re: Coding practices/standards

+1 - The formatting looks better now. -Dan On Thu, Oct 13, 2016 at 11:06 AM, Jared Stewart wrote: > I agree that the formatter needs fixing up. Our wiki < > https://cwiki.apache.org/confluence/display/GEODE/Code+Style+Guide> says > that we follow the Google Java Style

[GitHub] incubator-geode pull request #261: Added pulse UI tests to the combined test...

GitHub user jaredjstewart opened a pull request: https://github.com/apache/incubator-geode/pull/261 Added pulse UI tests to the combined test report You can merge this pull request into a Git repository by running: $ git pull https://github.com/jaredjstewart/incubator-geode

Jenkins build is back to normal : Geode-nightly #622

See

[GitHub] incubator-geode pull request #260: Added TemporaryFileRule JUnit rule for te...

Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/260#discussion_r83450662 --- Diff: geode-junit/src/main/java/org/apache/geode/test/junit/rules/temporary_file/TemporaryFileRule.java --- @@ -0,0 +1,95 @@ +/*

Re: Coding practices/standards

+1 On Thu, Oct 13, 2016 at 10:04 AM Kevin Duling wrote: > Given that, +1 from me! > > On Thu, Oct 13, 2016 at 9:51 AM, Jared Stewart > wrote: > > > The task is fully suppressible with -x spotlessCheck. Also, if you have > > any formatter errors you can

Review Request 52903: Adding a docker container to build and view the geode docs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52903/ --- Review request for geode, Anthony Baker, Joey McAllister, and Karen Miller.

Review Request 52891: GEODE-538: Add check for persistent data recovery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52891/ --- Review request for geode, anilkumar gingade, Darrel Schneider, Eric Shu, Scott

Re: Coding practices/standards

+1 The Google style guide is what we chose for Geode when we couldn't use the Elements book Le 10/14/2016 à 4:03 PM, Kirk Lund a écrit : +1 to a) embracing https://google.github.io/styleguide/javaguide.html 100%, b) adopting the google formatters for IntelliJ and Eclipse, c)using spotless

Re: Review Request 52889: GEODE-1993: refactor tests to use rules rather than abstract classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52889/ --- (Updated Oct. 14, 2016, 5:25 p.m.) Review request for geode, Jared Stewart,

Re: Review Request 52889: GEODE-1993: refactor tests to use rules rather than abstract classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52889/#review152694 --- Many usages of ServerStarter have to specify

Re: Review Request 52889: GEODE-1993: refactor tests to use rules rather than abstract classes

> On Oct. 14, 2016, 5:12 p.m., Kirk Lund wrote: > > geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java, > > line 66 > > > > > > This is still a DistributedTest if it uses the

Re: Review Request 52889: GEODE-1993: refactor tests to use rules rather than abstract classes

> On Oct. 14, 2016, 5:12 p.m., Kirk Lund wrote: > > Consider having *Rule in the name of the new rules. > > > > Fix issues and Ship It! I struggled with this too. The thing is: LocatorStarter and ServerStarter can be used not as a rule. they don't even have a before() method. See

Re: Review Request 52889: GEODE-1993: refactor tests to use rules rather than abstract classes

> On Oct. 14, 2016, 5:12 p.m., Kirk Lund wrote: > > geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java, > > line 66 > > > > > > This is still a DistributedTest if it uses the

[GitHub] incubator-geode issue #259: Feature/geode 1952 2

Github user upthewaterspout commented on the issue: https://github.com/apache/incubator-geode/pull/259 @joeymcallister - Ok, the parallel directories makes more sense now. We can always move stuff around after 1.0 if we decide to. I also had to do bundle install in the

Re: Review Request 52889: GEODE-1993: refactor tests to use rules rather than abstract classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52889/#review152695 --- Fix it, then Ship it! Consider having *Rule in the name of the

Review Request 52889: GEODE-1993: refactor tests to use rules rather than abstract classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52889/ --- Review request for geode. Repository: geode Description --- * created

Re: Review Request 52889: GEODE-1993: refactor tests to use rules rather than abstract classes

Review board requests can be updated and you can see the changes between diffs. Anthony > On Oct 14, 2016, at 10:42 AM, Jared Stewart wrote: > > If we used github PRs instead of review board, your second set of changes > could show up in this same review request! > > >

Re: Review Request 52889: GEODE-1993: refactor tests to use rules rather than abstract classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52889/ --- (Updated Oct. 14, 2016, 6:37 p.m.) Review request for geode, Jared Stewart,

Re: Review Request 52889: GEODE-1993: refactor tests to use rules rather than abstract classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52889/#review152719 --- Ship it! Ship It! - Jared Stewart On Oct. 14, 2016, 6:41

Re: Review Request 52889: GEODE-1993: refactor tests to use rules rather than abstract classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52889/ --- (Updated Oct. 14, 2016, 6:41 p.m.) Review request for geode, Jared Stewart,

Re: Review Request 52889: GEODE-1993: refactor tests to use rules rather than abstract classes

> On Oct. 14, 2016, 5:21 p.m., Jared Stewart wrote: > > Many usages of ServerStarter have to specify > > "org/apache/geode/management/internal/security/clientServer.json". I think > > it would be convenient to have some static factory methods like > > ServerStarter.startWithSecurity() that

Re: Review Request 52889: GEODE-1993: refactor tests to use rules rather than abstract classes

My mistake, thank you for the info. Your comment led me here , and I think RBTools will soothe the pain I had downloads and manually applying diffs. > On Oct 14, 2016, at 11:13 AM, Anthony Baker

Re: Review Request 52889: GEODE-1993: refactor tests to use rules rather than abstract classes

> On Oct. 14, 2016, 5:21 p.m., Jared Stewart wrote: > > Many usages of ServerStarter have to specify > > "org/apache/geode/management/internal/security/clientServer.json". I think > > it would be convenient to have some static factory methods like > > ServerStarter.startWithSecurity() that

[GitHub] incubator-geode issue #259: Feature/geode 1952 2

Github user joeymcallister commented on the issue: https://github.com/apache/incubator-geode/pull/259 Tweaked the build instructions to include `build install` before `rackup`. Also moved the README, which focuses on building the docs, to the `geode-book` dir (and pointed to it from

[GitHub] incubator-geode pull request #260: Added TemporaryFileRule JUnit rule for te...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/260 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-geode issue #259: Feature/geode 1952 2

Github user metatype commented on the issue: https://github.com/apache/incubator-geode/pull/259 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if