Re: Review Request 53745: when a sender was stopped before becoming a primary, the wait thread should be closed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53745/ --- (Updated Nov. 15, 2016, 12:27 a.m.) Review request for geode, anilkumar

Re: Review Request 53745: when a sender was stopped before becoming a primary, the wait thread should be closed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53745/ --- (Updated Nov. 15, 2016, 1:33 a.m.) Review request for geode, anilkumar gingade

Review Request 53752: Removing the Flaky Tag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53752/ --- Review request for geode, Barry Oglesby, Jason Huynh, Dan Smith, and xiaojian

Review Request 53750: GEODE-2110 Add gfsh start server user and password options

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53750/ --- Review request for geode, Dave Barnes, Jinmei Liao, and Joey McAllister.

Re: Review Request 53745: when a sender was stopped before becoming a primary, the wait thread should be closed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53745/ --- (Updated Nov. 15, 2016, 12:25 a.m.) Review request for geode, anilkumar

Re: Review Request 53750: GEODE-2110 Add gfsh start server user and password options

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53750/#review155877 --- Ship it! Ship It! - Dave Barnes On Nov. 15, 2016, 1:55

Re: Review Request 53745: when a sender was stopped before becoming a primary, the wait thread should be closed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53745/#review155874 --- Ship it! Ship It! - Dan Smith On Nov. 15, 2016, 1:33 a.m.,

Re: Review Request 53750: GEODE-2110 Add gfsh start server user and password options

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53750/#review155879 --- Ship it! Ship It! - Jinmei Liao On Nov. 15, 2016, 1:55

Build failed in Jenkins: Geode-nightly #653

See -- [...truncated 526 lines...] :geode-cq:compileTestJavaNote: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. Note: Some input files use

[GitHub] incubator-geode pull request #283: GEODE-2098: Moved gfsh history file locat...

GitHub user davinash opened a pull request: https://github.com/apache/incubator-geode/pull/283 GEODE-2098: Moved gfsh history file location from .gemfire to .geode Made the code changes and added a test for the same. Following Test is failing with precheckin, but works fine

[GitHub] incubator-geode issue #283: GEODE-2098: Moved gfsh history file location fro...

Github user davinash commented on the issue: https://github.com/apache/incubator-geode/pull/283 Thanks @kirklund @metatype @upthewaterspout. Do I need to mark the JIRA for release notes ? If not I will merge this PR, please let me know. --- If your project is set up for it, you can

[GitHub] incubator-geode issue #283: GEODE-2098: Moved gfsh history file location fro...

Github user davinash commented on the issue: https://github.com/apache/incubator-geode/pull/283 @kirklund What OS does DiskSpaceLimitIntegrationTest fail on for you? [ Avinash ] Linux --- If your project is set up for it, you can reply to this email and have your reply

Re: GMSJoinLeaveJUnitTest format is broken?

This is fixed now. I will not apologize for breaking the build though. I formatted the code that I checked in with the provided formatter configuration for Idea and that should pass the spotlessCheck task. We should turn off spotlessCheck until the IDE formatters conform to the

Re: Review Request 53737: GEODE-2101 Improve WAN topology terminology in docs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53737/#review155846 --- Ship it! Ship It! - Joey McAllister On Nov. 14, 2016, 8:16

Re: Review Request 53685: GEODE-1955: properly disconnect gfsh session so that it won't leave heartbeat thread around to pollute other tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53685/ --- (Updated Nov. 14, 2016, 8:56 p.m.) Review request for geode, Kevin Duling,

Review Request 53737: GEODE-2101 Improve WAN topology terminology in docs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53737/ --- Review request for geode, Dave Barnes and Joey McAllister. Repository: geode

Review Request 53736: fix GEODE-2088 Incorrect TransactionDataNotColocatedException is thrown after bucket has been moved due to rebalance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53736/ --- Review request for geode, anilkumar gingade and Darrel Schneider. Bugs:

Re: Review Request 53737: GEODE-2101 Improve WAN topology terminology in docs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53737/#review155826 ---

GMSJoinLeaveJUnitTest format is broken?

* What went wrong: Execution failed for task ':geode-core:spotlessJavaCheck'. > Format violations were found. Run 'gradlew spotlessApply' to fix them. ../../geode/geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java * Try: Run with

Re: GMSJoinLeaveJUnitTest format is broken?

Everyone should always run ./gradlew On Mon, Nov 14, 2016 at 10:35 AM, Bruce Schuchardt wrote: > This is fixed now. I will not apologize for breaking the build though. I > formatted the code that I checked in with the provided formatter > configuration for Idea and

[GitHub] incubator-geode issue #283: GEODE-2098: Moved gfsh history file location fro...

Github user kirklund commented on the issue: https://github.com/apache/incubator-geode/pull/283 I recommend discussing backwards compatibility of .gemfire vs .geode directory (which contains gfsh history file) on the dev list. I don't really feel strongly one way or the other

[GitHub] incubator-geode issue #283: GEODE-2098: Moved gfsh history file location fro...

Github user upthewaterspout commented on the issue: https://github.com/apache/incubator-geode/pull/283 IMO losing your gfsh history on an upgrade is probably not a big deal. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Re: GMSJoinLeaveJUnitTest format is broken?

Sent that too soon! I think everyone should always run ./gradlew build before pushing changes to avoid breaking the build. I'm not sure what the solution is for spotless, but we should be checking things before pushing them. One thing to consider is adding a pre-push hook to force a build to run

[GitHub] incubator-geode issue #283: GEODE-2098: Moved gfsh history file location fro...

Github user kirklund commented on the issue: https://github.com/apache/incubator-geode/pull/283 Since Geode 1.0 released using .gemfire history file, we should probably read and use .gemfire if .geode does not exist. If both files exist then .geode should take precedence.

DiskSpaceLimitIntegrationTest flakiness

I have fixed the flakiness in DiskSpaceLimitIntegrationTest in 64da18 to the best of my ability. If you see any flaky failures in this test after 64da18, please email the dev list (or me) with the stack trace. Also if you have any further ideas on fixing the flakiness, please add that as well.

Re: Review Request 53736: fix GEODE-2088 Incorrect TransactionDataNotColocatedException is thrown after bucket has been moved due to rebalance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53736/#review155860 --- Ship it! Ship It! - Darrel Schneider On Nov. 14, 2016,

Review Request 53746: GEODE-2105 Remove docs about log collection utility

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53746/ --- Review request for geode, Dave Barnes and Joey McAllister. Repository: geode

Review Request 53745: when a sender was stopped before becoming a primary, the wait thread should be closed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53745/ --- Review request for geode, anilkumar gingade and Dan Smith. Bugs: geode-2107

Review Request 53743: CI Failure: GMSHealthMonitorJUnitTest.testHMNextNeighborAfterTimeout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53743/ --- Review request for geode, Hitesh Khamesra and Udo Kohlmeyer. Bugs: GEODE-2073

Re: Review Request 53737: GEODE-2101 Improve WAN topology terminology in docs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53737/ --- (Updated Nov. 14, 2016, 8:16 p.m.) Review request for geode, Dave Barnes and

[GitHub] incubator-geode issue #283: GEODE-2098: Moved gfsh history file location fro...

Github user metatype commented on the issue: https://github.com/apache/incubator-geode/pull/283 Agreed. This could be handled in a release note: “If you want to preserve your gfsh history, please copy…” Anthony > On Nov 14, 2016, at 10:57 AM, Dan Smith

Re: Review Request 53746: GEODE-2105 Remove docs about log collection utility

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53746/#review155862 --- Ship it! Ship It! - Joey McAllister On Nov. 14, 2016, 11:02

Re: Review Request 53746: GEODE-2105 Remove docs about log collection utility

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53746/#review155863 --- Ship it! Ship It! - Dave Barnes On Nov. 14, 2016, 11:02

Re: Review Request 53737: GEODE-2101 Improve WAN topology terminology in docs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53737/#review155864 --- Ship it! Ship It! - Dave Barnes On Nov. 14, 2016, 8:16