GitHub user jinmeiliao opened a pull request:
https://github.com/apache/incubator-geode/pull/34
GEODE-543: upgrade the Jline and Spring Shell libraries and fix the câ¦
â¦ompilation erros
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user jinmeiliao opened a pull request:
https://github.com/apache/incubator-geode/pull/31
GEODE-516: increase the trylock timeout to make sure the deadlock wouâ¦
â¦ld happen.
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user jinmeiliao opened a pull request:
https://github.com/apache/incubator-geode/pull/37
GEODE-390: removing PartitionManager and related tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jinmeiliao/incubator-geode
GitHub user jinmeiliao opened a pull request:
https://github.com/apache/incubator-geode/pull/58
Feature/geode 663: adding more security test code into open source
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jinmeiliao
GitHub user jinmeiliao opened a pull request:
https://github.com/apache/incubator-geode/pull/52
GEM-164: move the security tests in gemfire-test module inside the coâ¦
â¦m.gemstone.gemfire.security packages to the open side.
and related resource files
You can merge
GitHub user jinmeiliao opened a pull request:
https://github.com/apache/incubator-geode/pull/59
GEODE-568: wait at most 5 seconds before checking the size of the intâ¦
â¦ernal region to allow eviction to complete
You can merge this pull request into a Git repository by running
GitHub user jinmeiliao opened a pull request:
https://github.com/apache/incubator-geode/pull/56
Feature/gem 164: move security tests from closed to open and remove pivotal
license and use ASF license
â¦ompilation erros
Closes #34
(cherry picked from commit
Github user jinmeiliao closed the pull request at:
https://github.com/apache/incubator-geode/pull/56
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user jinmeiliao opened a pull request:
https://github.com/apache/incubator-geode/pull/67
GEODE-401: upgrade log4j from 2.1 to 2.5. Remove our own configuratioâ¦
â¦n watcher since log4j now has an almost the same implementation.
You can merge this pull request into a Git
GitHub user jinmeiliao opened a pull request:
https://github.com/apache/incubator-geode/pull/64
GEODE-649: add more logging to see the reason of future failure.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jinmeiliao
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/153
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/151
I don't think this would fix the problem. The problem is that the following
two queries would return different results. Your change would still make them
do that.
query --query
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/151
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/151
Not sure if this works, the example it gives are those queries
echo "query --query=\"select count(*) from /replicatedRegion.keySet\"" >>
query_region.gf
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/150
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/161
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/166
+1. I'll pull this in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/170
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/161
I'll pull this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user jinmeiliao opened a pull request:
https://github.com/apache/incubator-geode/pull/80
GEODE-852: refactor gemfire-pulse not to generate a pulseverion.propeâ¦
â¦rties file but copy it from gemfire-core
You can merge this pull request into a Git repository by running
Github user jinmeiliao commented on the pull request:
https://github.com/apache/incubator-geode/pull/80#issuecomment-175766150
To avoid confusion, do not rename the properties file copied from
gemfire-core
---
If your project is set up for it, you can reply to this email and have
Github user jinmeiliao commented on the pull request:
https://github.com/apache/incubator-geode/pull/80#issuecomment-175786454
Good point. Will create another pull request for this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user jinmeiliao opened a pull request:
https://github.com/apache/incubator-geode/pull/81
GEODE-852: copyPulsePropFile needs to make sure gemfire-core builds fâ¦
â¦irst
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user jinmeiliao commented on the pull request:
https://github.com/apache/incubator-geode/pull/99#issuecomment-187281359
I'll pull this in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user jinmeiliao opened a pull request:
https://github.com/apache/incubator-geode/pull/73
GEODE-749: refactor the code to look for the war file in multiple plaâ¦
â¦ces w/o version number and look for them in the classpath as well.
You can merge this pull request into a Git
Github user jinmeiliao closed the pull request at:
https://github.com/apache/incubator-geode/pull/78
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jinmeiliao commented on the pull request:
https://github.com/apache/incubator-geode/pull/78#issuecomment-175088490
this fix needs a dependency in gemfire-core. Will not use this fix.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user jinmeiliao opened a pull request:
https://github.com/apache/incubator-geode/pull/75
GEODE-12: license file update
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jinmeiliao/incubator-geode feature/GEODE-12
Github user jinmeiliao commented on the pull request:
https://github.com/apache/incubator-geode/pull/94#issuecomment-184875550
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jinmeiliao commented on the pull request:
https://github.com/apache/incubator-geode/pull/111#issuecomment-193958882
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/227
+1. I'll pull this in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/214
+1. I'll pull this in
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/210
I'll rebase this onto the current develop, and handle the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/210
I rebased it, and rewrite the GMSAuthenticator. The review is here:
https://reviews.apache.org/r/50245/
---
If your project is set up for it, you can reply to this email and have
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/198
I'll handle this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/201
I think it's probably safe to get the storage team involved to review this
PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/207
this seems to have some conflict with the current develop branch. Please
rebase again.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/190
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/192#discussion_r70113962
--- Diff:
geode-core/src/test/java/com/gemstone/gemfire/security/IntegratedSecurityCacheLifecycleDistributedTest.java
---
@@ -0,0 +1,151
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/192#discussion_r70114209
--- Diff:
geode-core/src/test/java/com/gemstone/gemfire/security/IntegratedSecurityCacheLifecycleDistributedTest.java
---
@@ -0,0 +1,151
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/192#discussion_r70114133
--- Diff:
geode-core/src/test/java/com/gemstone/gemfire/security/IntegratedSecurityCacheLifecycleDistributedTest.java
---
@@ -0,0 +1,151
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/192#discussion_r70114470
--- Diff:
geode-core/src/test/java/com/gemstone/gemfire/security/IntegratedSecurityCacheLifecycleDistributedTest.java
---
@@ -0,0 +1,151
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/193
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/228#discussion_r73898764
--- Diff:
geode-core/src/main/java/org/apache/geode/security/templates/SampleSecurityManager.java
---
@@ -126,26 +126,33 @@ public boolean
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/228#discussion_r73898847
--- Diff:
geode-core/src/test/java/org/apache/geode/security/templates/SampleSecurityManagerTest.java
---
@@ -65,6 +65,16 @@ public void setUp
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/228#discussion_r73898883
--- Diff:
geode-core/src/test/java/org/apache/geode/security/templates/SampleSecurityManagerTest.java
---
@@ -65,6 +65,16 @@ public void setUp
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/224#discussion_r73212878
--- Diff:
geode-core/src/main/java/com/gemstone/gemfire/management/internal/ManagementAgent.java
---
@@ -447,8 +449,7 @@ public synchronized
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/224#discussion_r73213204
--- Diff:
geode-core/src/main/java/com/gemstone/gemfire/management/internal/ManagementAgent.java
---
@@ -509,8 +510,7 @@ private void
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/224#discussion_r73207985
--- Diff:
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/AbstractDistributionConfig.java
---
@@ -498,6 +502,29 @@ protected
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/223#discussion_r73215457
--- Diff:
geode-core/src/main/java/com/gemstone/gemfire/internal/security/IntegratedSecurityService.java
---
@@ -0,0 +1,164 @@
+package
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/224#discussion_r73211230
--- Diff:
geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java
---
@@ -471,16 +499,27 @@ public static
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/183
the fix looks good. Where is the test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/183
For now, add at least a test that would cover deleting a region that has
"-" and "_" in it. Later, you can expand your tests that would have all sorts
o
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/240
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/254
Have we decided whether we want to put uiTest in precheckin or start a new
pipeline?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/254#discussion_r82066319
--- Diff:
geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAbstractTest.java
---
@@ -166,18 +197,28 @@ public static void
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/254#discussion_r82065904
--- Diff: .gitignore ---
@@ -13,6 +13,8 @@ build/
build-eclipse/
--- End diff --
do we need to checkin this file?
---
If your
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/254#discussion_r82066044
--- Diff:
geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAbstractTest.java
---
@@ -136,6 +146,29 @@
private
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/251
This is pulled into realase/1.0.0.incubating branch, but somehow github is
not watching the checkin on that branch to close this PR.
---
If your project is set up for it, you can reply
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/250#discussion_r81788504
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java ---
@@ -156,7 +166,14 @@ protected static Properties
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/250#discussion_r81417136
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java ---
@@ -156,7 +166,14 @@ protected static Properties
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/250#discussion_r81416934
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java ---
@@ -156,7 +166,14 @@ protected static Properties
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/248
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/271#discussion_r84983273
--- Diff: geode-assembly/src/test/resources/expected_jars.txt ---
@@ -37,10 +37,6 @@ jline
jna
--- End diff --
Why is this file
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/271#discussion_r84983163
--- Diff: LICENSE ---
@@ -329,8 +302,6 @@ Apache Geode bundles the following files under the MIT
license:
Copyright (c) 2011 Sencha Inc
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/276#discussion_r86821510
--- Diff:
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityPostProcessorTest.java
---
@@ -0,0 +1,185
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/276#discussion_r86820194
--- Diff:
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityPostProcessorTest.java
---
@@ -0,0 +1,185
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/276#discussion_r86836714
--- Diff:
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/BaseControllerAdvice.java
---
@@ -50,6 +52,11
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/276#discussion_r86836201
--- Diff:
geode-core/src/main/java/org/apache/geode/security/PostProcessor.java ---
@@ -44,6 +47,9 @@ default void init(Properties securityProps
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/276#discussion_r86836263
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java
---
@@ -87,6 +89,12 @@
Object postProcess
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/276#discussion_r86836374
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java
---
@@ -409,6 +435,34 @@ public Object
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/276#discussion_r86819415
--- Diff:
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityPostProcessorTest.java
---
@@ -0,0 +1,185
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/276#discussion_r86836287
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java
---
@@ -87,6 +89,12 @@
Object postProcess
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/276#discussion_r86822375
--- Diff:
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityPostProcessorTest.java
---
@@ -0,0 +1,185
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/276#discussion_r86836336
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java
---
@@ -409,6 +435,34 @@ public Object
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/276#discussion_r86822046
--- Diff:
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityPostProcessorTest.java
---
@@ -0,0 +1,185
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/276#discussion_r86920722
--- Diff:
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/BaseControllerAdvice.java
---
@@ -50,6 +52,11
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/276#discussion_r86920671
--- Diff:
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityPostProcessorTest.java
---
@@ -0,0 +1,185
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/276
A few changes requested:
1. use Autowire to auto wire the RestSecurityService.
2. In your RestSecurityPostProcessorTest, considering only using
"customers&qu
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/265#discussion_r84501406
--- Diff:
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/FunctionAccessController.java
---
@@ -93,8 +93,7
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/265#discussion_r84500905
--- Diff:
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/SwaggerVerificationTest.java
---
@@ -0,0 +1,57
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/286
LGTM. build it and start up gfsh and play with it with different options
and see if it's not having some side effects. After that I can pull this in.
---
If your project is set up
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/273#discussion_r85375614
--- Diff:
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/SwaggerVerificationTest.java
---
@@ -42,6 +44,7 @@
static
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/276
A few things:
1. In your RestSecurityPostProcessorTest, in the before method, you can get
ahold of the region you created and pre populate the regions with a few keys
and values
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/256#discussion_r82900331
--- Diff: geode-pulse/build.gradle ---
@@ -68,6 +68,11 @@ dependencies {
testCompile project(':geode-core')
testCompile files
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/256#discussion_r82900400
--- Diff: geode-pulse/src/main/webapp/WEB-INF/spring-security.xml ---
@@ -20,15 +20,14 @@
xmlns:context="http://www.springframewor
86 matches
Mail list logo
