[GitHub] incubator-geode pull request #237: GEODE-1821: fix termination of invokeAsyn...

2016-09-02 Thread pdxrunner
GitHub user pdxrunner opened a pull request: https://github.com/apache/incubator-geode/pull/237 GEODE-1821: fix termination of invokeAsync threads You can merge this pull request into a Git repository by running: $ git pull https://github.com/pdxrunner/incubator-geode feature

[GitHub] incubator-geode pull request #244: Feature/geode-1128-2

2016-09-21 Thread pdxrunner
GitHub user pdxrunner opened a pull request: https://github.com/apache/incubator-geode/pull/244 Feature/geode-1128-2 Added a section to the output of the gfsh command show missing-disk-stores to list any missing colocated regions See review: https://reviews.apache.org/r/52052

[GitHub] incubator-geode pull request #264: Feature/geode 538

2016-10-19 Thread pdxrunner
GitHub user pdxrunner opened a pull request: https://github.com/apache/incubator-geode/pull/264 Feature/geode 538 Changes have been reviewed at https://reviews.apache.org/r/52891/ You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-geode pull request #279: GEODE-1821: Adjust timing to wait for asy...

2016-11-03 Thread pdxrunner
GitHub user pdxrunner opened a pull request: https://github.com/apache/incubator-geode/pull/279 GEODE-1821: Adjust timing to wait for async thread Increased timeout for waiting on aysnc thread termination. The wait timeout in DUnit test did not allow sufficient margin over the time

[GitHub] incubator-geode pull request: Feature/geode 735

2016-01-25 Thread pdxrunner
GitHub user pdxrunner opened a pull request: https://github.com/apache/incubator-geode/pull/77 Feature/geode 735 Added OffHeapHelperJUnitTest class You can merge this pull request into a Git repository by running: $ git pull https://github.com/pdxrunner/incubator-geode feature

[GitHub] incubator-geode pull request: Feature/geode 735

2016-01-26 Thread pdxrunner
Github user pdxrunner closed the pull request at: https://github.com/apache/incubator-geode/pull/77 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-geode pull request: Feature/geode 735

2016-01-26 Thread pdxrunner
Github user pdxrunner commented on the pull request: https://github.com/apache/incubator-geode/pull/77#issuecomment-175138618 Looks like my fork wasn't clean when I created the PR. Closing this one, will open a new one when I get things clean. --- If your project is set up f

[GitHub] incubator-geode pull request: GEODE-735: Create JUnit tests for Of...

2016-01-26 Thread pdxrunner
GitHub user pdxrunner opened a pull request: https://github.com/apache/incubator-geode/pull/79 GEODE-735: Create JUnit tests for OffHeapHelper Added OffHeapHelperJUnitTest class Pre-checkin run - 2 failures, both previously reported and not related to OffHeap You can

[GitHub] incubator-geode pull request: Fixes GEODE-874

2016-01-29 Thread pdxrunner
GitHub user pdxrunner opened a pull request: https://github.com/apache/incubator-geode/pull/82 Fixes GEODE-874 Replaced gradlew commands with gradle in text files. Corrected classpath shown for compiling and running app in Geode in 5 Minutes section of README.md You can

[GitHub] incubator-geode pull request: Fixes GEODE-874

2016-01-29 Thread pdxrunner
Github user pdxrunner commented on the pull request: https://github.com/apache/incubator-geode/pull/82#issuecomment-176913037 You're correct. I should have changed "./gradlew" to just "gradle" for the .txt and .md files I updated. I also agree that gradlew, no

[GitHub] incubator-geode pull request: Fixes GEODE-874

2016-02-01 Thread pdxrunner
Github user pdxrunner commented on the pull request: https://github.com/apache/incubator-geode/pull/82#issuecomment-178041809 I'm closing this PR in favor of looking at the longer term solution of gradlew vs. gradle in the release distros. The secondary problem I found (path err

[GitHub] incubator-geode pull request: Fixes GEODE-874

2016-02-01 Thread pdxrunner
Github user pdxrunner closed the pull request at: https://github.com/apache/incubator-geode/pull/82 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-geode pull request: GEODE-887: correct paths in README.m...

2016-02-01 Thread pdxrunner
GitHub user pdxrunner opened a pull request: https://github.com/apache/incubator-geode/pull/86 GEODE-887: correct paths in README.md Corrected classpath shown for compiling and running app in Geode in 5 Minutes section of README.md You can merge this pull request into a Git

[GitHub] incubator-geode pull request: Feature/geode 855

2016-02-17 Thread pdxrunner
GitHub user pdxrunner opened a pull request: https://github.com/apache/incubator-geode/pull/97 Feature/geode 855 GEODE-855: New test class for com.gemstone.gemfire.internal.offheap.Fragment to give complete unit test coverage of the class. Testing

[GitHub] incubator-geode pull request: Feature/geode 855

2016-02-18 Thread pdxrunner
Github user pdxrunner closed the pull request at: https://github.com/apache/incubator-geode/pull/97 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-geode pull request: Feature/geode 855

2016-02-18 Thread pdxrunner
Github user pdxrunner commented on the pull request: https://github.com/apache/incubator-geode/pull/97#issuecomment-185765507 Closing the PR per the preceding comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-geode pull request: GEODE-52: Remove @author tags from J...

2016-02-19 Thread pdxrunner
Github user pdxrunner commented on the pull request: https://github.com/apache/incubator-geode/pull/100#issuecomment-186370929 In some cases, removing the @author tag leaves an empty javadoc. I think it would be better to remove the entire block for these cases. As an

[GitHub] incubator-geode pull request: Feature/geode 856

2016-02-23 Thread pdxrunner
GitHub user pdxrunner opened a pull request: https://github.com/apache/incubator-geode/pull/102 Feature/geode 856 New unit test class to give coverage for MemoryBlockNode. See reviews: https://reviews.apache.org/r/43681/ You can merge this pull request into a Git repository by

[GitHub] incubator-geode pull request: Feature/geode 856

2016-02-23 Thread pdxrunner
Github user pdxrunner closed the pull request at: https://github.com/apache/incubator-geode/pull/102 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-geode pull request: Feature/geode 856

2016-02-23 Thread pdxrunner
Github user pdxrunner commented on the pull request: https://github.com/apache/incubator-geode/pull/102#issuecomment-187877454 Closing this PR so that I can squash all the intermediate commits and generate a clean branch for a new PR. --- If your project is set up for it, you can

[GitHub] incubator-geode pull request: GEODE-856: New unit test class for c...

2016-02-23 Thread pdxrunner
GitHub user pdxrunner opened a pull request: https://github.com/apache/incubator-geode/pull/103 GEODE-856: New unit test class for covering MemoryBlockNode New unit test class to give coverage for MemoryBlockNode. See reviews: https://reviews.apache.org/r/43681/ This PR

[GitHub] incubator-geode pull request: Feature/geode 856.1

2016-02-29 Thread pdxrunner
GitHub user pdxrunner opened a pull request: https://github.com/apache/incubator-geode/pull/108 Feature/geode 856.1 Unit test coverage for TinyMemoryBlock. (Review request https://reviews.apache.org/r/44107/) Precheckin was run. You can merge this pull request into a Git

[GitHub] incubator-geode pull request: GEODE-874: Place all build-from-sour...

2016-03-19 Thread pdxrunner
Github user pdxrunner commented on the pull request: https://github.com/apache/incubator-geode/pull/114#issuecomment-197399738 +1 A note on BUILDING.md - Should the verification steps reinforce that the GEODE install bin directory (geode-assembly\build\install\apache-geode

[GitHub] incubator-geode pull request: GEODE-1288: Correct entry expiration...

2016-04-22 Thread pdxrunner
Github user pdxrunner commented on the pull request: https://github.com/apache/incubator-geode/pull/136#issuecomment-213604710 There's a mismatch in the fail() message and the loop logic. The full wait time is 10,000 millis, but the message (and preceding comments) say it's

[GitHub] incubator-geode pull request: Feature/geode 1278

2016-04-26 Thread pdxrunner
GitHub user pdxrunner opened a pull request: https://github.com/apache/incubator-geode/pull/138 Feature/geode 1278 See review https://reviews.apache.org/r/46660/ You can merge this pull request into a Git repository by running: $ git pull https://github.com/pdxrunner/incubator

[GitHub] incubator-geode pull request: GEODE-1296: change conditional in ge...

2016-05-17 Thread pdxrunner
GitHub user pdxrunner opened a pull request: https://github.com/apache/incubator-geode/pull/145 GEODE-1296: change conditional in getRawBytes to assert Made suggested change to getRawBytes. Updated corresponding unit test. See review request https://reviews.apache.org/r/47479

[GitHub] incubator-geode pull request: GEODE-1296: change conditional in ge...

2016-05-25 Thread pdxrunner
Github user pdxrunner commented on the pull request: https://github.com/apache/incubator-geode/pull/145#issuecomment-221624715 Precheckin passed with my most recent update. I think this one is ready to go now. --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-geode pull request: GEODE-1296: change conditional in ge...

2016-05-25 Thread pdxrunner
Github user pdxrunner commented on the pull request: https://github.com/apache/incubator-geode/pull/145#issuecomment-221722725 This was checked in by dschneider. Closing the PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-geode pull request: GEODE-1296: change conditional in ge...

2016-05-25 Thread pdxrunner
Github user pdxrunner closed the pull request at: https://github.com/apache/incubator-geode/pull/145 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-geode pull request #234: GEODE-1128: Fixes for colocation configur...

2016-08-18 Thread pdxrunner
GitHub user pdxrunner opened a pull request: https://github.com/apache/incubator-geode/pull/234 GEODE-1128: Fixes for colocation configuration problems 1) Test parent regions on child region creates and throw IllegalStateException if parent region does not exist. Missing