Re: [VOTE] Release new versions of the Geronimo bundle components
My +1.
Thanks Rick, rat:check runs fine with a clean checkout.
On Tue, Jul 20, 2010 at 4:05 PM, Rick McGuire rick...@gmail.com wrote:
Meant to send this to the list, not directly to Vamsi.
On 7/20/2010 2:38 AM, Vamsavardhana Reddy wrote:
I am getting an error with rat:check on Windows XP SP3, maven-2.2.1.
Build output given below.
If you run rat:check after building the code, the rat step is picking up
the velocity.log file that is left over from the plugin that creates the
merged LICENSE and NOTICE files. The rat check passes cleanly if you delete
the velocity.log file or run it against a clean checkout.
Rick
C:\G\bundles\tags\aspectjrt-1.6.8_1mvn rat:check -e
+ Error stacktraces are turned on.
[INFO] Scanning for projects...
[INFO] Searching repository for plugin with prefix: 'rat'.
[INFO]
[INFO] Building Apache Geronimo Bundles: aspectjrt-1.6.8
[INFO]task-segment: [rat:check]
[INFO]
[INFO] [rat:check {execution: default-cli}]
[INFO]
[ERROR] BUILD FAILURE
[INFO]
[INFO] Too many unapproved licenses: 4
[INFO]
[INFO] Trace
org.apache.maven.BuildFailureException: Too many unapproved licenses: 4
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:715)
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeStandaloneGoal(DefaultLifecycleExecutor.java:569)
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:539)
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:387)
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:348)
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:180)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:328)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:138)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:362)
at
org.apache.maven.cli.compat.CompatibleMain.main(CompatibleMain.java:60)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
at
org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
Caused by: org.codehaus.mojo.rat.RatCheckException: Too many unapproved
licenses: 4
at org.codehaus.mojo.rat.RatCheckMojo.check(RatCheckMojo.java:224)
at org.codehaus.mojo.rat.RatCheckMojo.check(RatCheckMojo.java:216)
at
org.codehaus.mojo.rat.RatCheckMojo.execute(RatCheckMojo.java:172)
at
org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:490)
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:694)
... 17 more
[INFO]
[INFO] Total time: 2 seconds
[INFO] Finished at: Tue Jul 20 12:04:30 IST 2010
[INFO] Final Memory: 16M/38M
[INFO]
C:\G\bundles\tags\aspectjrt-1.6.8_1mvn -version
Apache Maven 2.2.1 (r801777; 2009-08-07 00:46:01+0530)
Java version: 1.6.0_20
Java home: C:\SUNJDK160\jre
Default locale: en_US, platform encoding: Cp1252
OS name: windows xp version: 5.1 arch: x86 Family: windows
On Tue, Jul 13, 2010 at 8:13 PM, Rick McGuire rick...@gmail.commailto:
rick...@gmail.com wrote:
To allow the Geronimo trunk release to upgrade the some of the
components used by the server, I'd like
release new versions of some of the Geronimo bundle components.
This components are versions of external
Geronimo dependencies that have been converted into OSGi jars.
This is a single vote for multiple upgraded bundles used by the
Geronimo 3.0 trunk branch.
The RAT and IANAL plugins have been run against of the projects.
All tag svn versions have been
successfully built.
Vote will be open for 72 hours.
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)
Staging repo:
Re: [VOTE] Release new versions of the Geronimo bundle components
I am getting an error with rat:check on Windows XP SP3, maven-2.2.1. Build
output given below.
C:\G\bundles\tags\aspectjrt-1.6.8_1mvn rat:check -e
+ Error stacktraces are turned on.
[INFO] Scanning for projects...
[INFO] Searching repository for plugin with prefix: 'rat'.
[INFO]
[INFO] Building Apache Geronimo Bundles: aspectjrt-1.6.8
[INFO]task-segment: [rat:check]
[INFO]
[INFO] [rat:check {execution: default-cli}]
[INFO]
[ERROR] BUILD FAILURE
[INFO]
[INFO] Too many unapproved licenses: 4
[INFO]
[INFO] Trace
org.apache.maven.BuildFailureException: Too many unapproved licenses: 4
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:715)
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeStandaloneGoal(DefaultLifecycleExecutor.java:569)
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:539)
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:387)
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:348)
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:180)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:328)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:138)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:362)
at
org.apache.maven.cli.compat.CompatibleMain.main(CompatibleMain.java:60)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
at
org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
Caused by: org.codehaus.mojo.rat.RatCheckException: Too many unapproved
licenses: 4
at org.codehaus.mojo.rat.RatCheckMojo.check(RatCheckMojo.java:224)
at org.codehaus.mojo.rat.RatCheckMojo.check(RatCheckMojo.java:216)
at org.codehaus.mojo.rat.RatCheckMojo.execute(RatCheckMojo.java:172)
at
org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:490)
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:694)
... 17 more
[INFO]
[INFO] Total time: 2 seconds
[INFO] Finished at: Tue Jul 20 12:04:30 IST 2010
[INFO] Final Memory: 16M/38M
[INFO]
C:\G\bundles\tags\aspectjrt-1.6.8_1mvn -version
Apache Maven 2.2.1 (r801777; 2009-08-07 00:46:01+0530)
Java version: 1.6.0_20
Java home: C:\SUNJDK160\jre
Default locale: en_US, platform encoding: Cp1252
OS name: windows xp version: 5.1 arch: x86 Family: windows
On Tue, Jul 13, 2010 at 8:13 PM, Rick McGuire rick...@gmail.com wrote:
To allow the Geronimo trunk release to upgrade the some of the components
used by the server, I'd like
release new versions of some of the Geronimo bundle components. This
components are versions of external
Geronimo dependencies that have been converted into OSGi jars.
This is a single vote for multiple upgraded bundles used by the Geronimo
3.0 trunk branch.
The RAT and IANAL plugins have been run against of the projects. All tag
svn versions have been
successfully built.
Vote will be open for 72 hours.
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)
Staging repo:
https://repository.apache.org/content/repositories/orgapachegeronimo-056/
All source repos are relative to location
https://svn.apache.org/repos/asf/geronimo/bundles/tags
and have the same final element as the artifact name.
The following components are being voted on (the bundles-parent has already
been promoted):
aspectjrt-1.6.8_1
aspectjweaver-1.6.8_1
derby-all-10.6.1.0_1
sxc-jaxb-0.7.3_1
sxc-runtime-0.7.3_1
woodstox-4.0.6_1_1
--
Vamsi
Re: [VOTE] Release new versions of the Geronimo bundle components
Meant to send this to the list, not directly to Vamsi.
On 7/20/2010 2:38 AM, Vamsavardhana Reddy wrote:
I am getting an error with rat:check on Windows XP SP3, maven-2.2.1.
Build output given below.
If you run rat:check after building the code, the rat step is picking up
the velocity.log file that is left over from the plugin that creates the
merged LICENSE and NOTICE files. The rat check passes cleanly if you
delete the velocity.log file or run it against a clean checkout.
Rick
C:\G\bundles\tags\aspectjrt-1.6.8_1mvn rat:check -e
+ Error stacktraces are turned on.
[INFO] Scanning for projects...
[INFO] Searching repository for plugin with prefix: 'rat'.
[INFO]
[INFO] Building Apache Geronimo Bundles: aspectjrt-1.6.8
[INFO]task-segment: [rat:check]
[INFO]
[INFO] [rat:check {execution: default-cli}]
[INFO]
[ERROR] BUILD FAILURE
[INFO]
[INFO] Too many unapproved licenses: 4
[INFO]
[INFO] Trace
org.apache.maven.BuildFailureException: Too many unapproved licenses: 4
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:715)
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeStandaloneGoal(DefaultLifecycleExecutor.java:569)
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:539)
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:387)
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:348)
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:180)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:328)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:138)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:362)
at
org.apache.maven.cli.compat.CompatibleMain.main(CompatibleMain.java:60)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
at
org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
Caused by: org.codehaus.mojo.rat.RatCheckException: Too many
unapproved licenses: 4
at org.codehaus.mojo.rat.RatCheckMojo.check(RatCheckMojo.java:224)
at org.codehaus.mojo.rat.RatCheckMojo.check(RatCheckMojo.java:216)
at
org.codehaus.mojo.rat.RatCheckMojo.execute(RatCheckMojo.java:172)
at
org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:490)
at
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:694)
... 17 more
[INFO]
[INFO] Total time: 2 seconds
[INFO] Finished at: Tue Jul 20 12:04:30 IST 2010
[INFO] Final Memory: 16M/38M
[INFO]
C:\G\bundles\tags\aspectjrt-1.6.8_1mvn -version
Apache Maven 2.2.1 (r801777; 2009-08-07 00:46:01+0530)
Java version: 1.6.0_20
Java home: C:\SUNJDK160\jre
Default locale: en_US, platform encoding: Cp1252
OS name: windows xp version: 5.1 arch: x86 Family: windows
On Tue, Jul 13, 2010 at 8:13 PM, Rick McGuire rick...@gmail.com
mailto:rick...@gmail.com wrote:
To allow the Geronimo trunk release to upgrade the some of the
components used by the server, I'd like
release new versions of some of the Geronimo bundle components.
This components are versions of external
Geronimo dependencies that have been converted into OSGi jars.
This is a single vote for multiple upgraded bundles used by the
Geronimo 3.0 trunk branch.
The RAT and IANAL plugins have been run against of the projects.
All tag svn versions have been
successfully built.
Vote will be open for 72 hours.
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)
Staging repo:
https://repository.apache.org/content/repositories/orgapachegeronimo-056/
All source repos are relative to location
Re: [VOTE] Release new versions of the Geronimo bundle components
On Jul 20, 2010, at 6:35 AM, Rick McGuire wrote: Meant to send this to the list, not directly to Vamsi. On 7/20/2010 2:38 AM, Vamsavardhana Reddy wrote: I am getting an error with rat:check on Windows XP SP3, maven-2.2.1. Build output given below. If you run rat:check after building the code, the rat step is picking up the velocity.log file that is left over from the plugin that creates the merged LICENSE and NOTICE files. The rat check passes cleanly if you delete the velocity.log file or run it against a clean checkout. I failed to mention in my vote, that the velocity.log files are being included in the source distributions. Although this is undesirable, it does not, in and of itself (IMO), justify a -1. Also, because the files are machine generated, they don't need a source license header. --kevan
Re: [VOTE] Release new versions of the Geronimo bundle components
Looks good. Two comments: 1) some of the NOTICE files contain a mix of Unix and Windows line endings. I'm assuming that this is because they were built on a Windows system. I don't see anything that is wrong or would cause an error, but another reminder of problems we're encountering with Windows builds 2) I note that the generated Woodstox NOTICE file does not contain the NOTICE file from the original. Although I was concerned, at first, after reviewing the original notice file, I'm not so worried. The contents are rather boilerplate and I don't see anything that really *must* be carried over: This product currently only contains code developed by authors of specific components, as identified by the source code files. Since product implements StAX API, it has dependencies to StAX API classes. For additional credits (generally to people who reported problems) see CREDITS file. So, here's my +1 --kevan On Jul 13, 2010, at 10:43 AM, Rick McGuire wrote: To allow the Geronimo trunk release to upgrade the some of the components used by the server, I'd like release new versions of some of the Geronimo bundle components. This components are versions of external Geronimo dependencies that have been converted into OSGi jars. This is a single vote for multiple upgraded bundles used by the Geronimo 3.0 trunk branch. The RAT and IANAL plugins have been run against of the projects. All tag svn versions have been successfully built. Vote will be open for 72 hours. [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) Staging repo: https://repository.apache.org/content/repositories/orgapachegeronimo-056/ All source repos are relative to location https://svn.apache.org/repos/asf/geronimo/bundles/tags and have the same final element as the artifact name. The following components are being voted on (the bundles-parent has already been promoted): aspectjrt-1.6.8_1 aspectjweaver-1.6.8_1 derby-all-10.6.1.0_1 sxc-jaxb-0.7.3_1 sxc-runtime-0.7.3_1 woodstox-4.0.6_1_1
Re: [VOTE] Release new versions of the Geronimo bundle components
+1 Was able to build all 6 from their tags and each passed rat:check. Note: The version on woodstox has an extra _1 and should be listed as woodstox-4.0.6_1. -Donald On 7/13/10 10:43 AM, Rick McGuire wrote: To allow the Geronimo trunk release to upgrade the some of the components used by the server, I'd like release new versions of some of the Geronimo bundle components. This components are versions of external Geronimo dependencies that have been converted into OSGi jars. This is a single vote for multiple upgraded bundles used by the Geronimo 3.0 trunk branch. The RAT and IANAL plugins have been run against of the projects. All tag svn versions have been successfully built. Vote will be open for 72 hours. [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) Staging repo: https://repository.apache.org/content/repositories/orgapachegeronimo-056/ All source repos are relative to location https://svn.apache.org/repos/asf/geronimo/bundles/tags and have the same final element as the artifact name. The following components are being voted on (the bundles-parent has already been promoted): aspectjrt-1.6.8_1 aspectjweaver-1.6.8_1 derby-all-10.6.1.0_1 sxc-jaxb-0.7.3_1 sxc-runtime-0.7.3_1 woodstox-4.0.6_1_1
