Re: [config] trunk version is 1.3?

2018-06-07 Thread Mark Struberg
I'll tinker a test and check whether my gut feeling is wrong or right. LieGrue, strub > Am 07.06.2018 um 14:05 schrieb Romain Manni-Bucau : > > Not sure what it means Mark, do you have an example handy? > > Le jeu. 7 juin 2018 11:55, Mark Struberg a écrit : > No the lookup is wrong as it uss

Re: [config] trunk version is 1.3?

2018-06-07 Thread Romain Manni-Bucau
Not sure what it means Mark, do you have an example handy? Le jeu. 7 juin 2018 11:55, Mark Struberg a écrit : > No the lookup is wrong as it uss an illegal shortcut. > You would have to 'normalize' both ends to do it that way. > > LiGrue, > strub > > > > Am 07.06.2018 um 11:06 schrieb Romain

Re: [config] trunk version is 1.3?

2018-06-07 Thread Mark Struberg
No the lookup is wrong as it uss an illegal shortcut. You would have to 'normalize' both ends to do it that way. LiGrue, strub > Am 07.06.2018 um 11:06 schrieb Romain Manni-Bucau : > > Well the version is breaking people relying on snapshots for now > > The lookup is not "wrong" but maybe

Re: [config] trunk version is 1.3?

2018-06-07 Thread Romain Manni-Bucau
Well the version is breaking people relying on snapshots for now The lookup is not "wrong" but maybe not "final" ;) The expensive part is quite not true since you will not evaluate it a lot in general and even in such a case it is a light algorithm normally. The current impl is wrongly using

Re: [config] trunk version is 1.3?

2018-06-07 Thread Mark Struberg
The lookup logic is also wrong. I know emily pushes for more replacements, but we discussed this through in ConfigJSR and so far most are opposed to such a wide framed replacement. The code is wrong as you cannot do just 1 fallback but you would have to do multiple fallback lookups. Which might

Re: [config] trunk version is 1.3?

2018-06-06 Thread Romain Manni-Bucau
Oki, thanks JL. Le jeu. 7 juin 2018 00:12, Jean-Louis MONTEIRO a écrit : > If I forget, just ping me in the morning > > Le jeu. 7 juin 2018 à 00:11, Jean-Louis MONTEIRO a > écrit : > >> I can do tomorrow if you want >> >> >> Le mer. 6 juin 2018 à 20:25, Romain Manni-Bucau >> a écrit : >> >>>

Re: [config] trunk version is 1.3?

2018-06-06 Thread Jean-Louis MONTEIRO
If I forget, just ping me in the morning Le jeu. 7 juin 2018 à 00:11, Jean-Louis MONTEIRO a écrit : > I can do tomorrow if you want > > > Le mer. 6 juin 2018 à 20:25, Romain Manni-Bucau a > écrit : > >> Oki, do you revert it (or i can do it tomorrow)? >> >> Le mer. 6 juin 2018 19:51,

Re: [config] trunk version is 1.3?

2018-06-06 Thread Jean-Louis MONTEIRO
I can do tomorrow if you want Le mer. 6 juin 2018 à 20:25, Romain Manni-Bucau a écrit : > Oki, do you revert it (or i can do it tomorrow)? > > Le mer. 6 juin 2018 19:51, Jean-Louis MONTEIRO a > écrit : > >> I think so. Mistake maybe >> >> Le mer. 6 juin 2018 à 14:28, Romain Manni-Bucau >> a

Re: [config] trunk version is 1.3?

2018-06-06 Thread Romain Manni-Bucau
Oki, do you revert it (or i can do it tomorrow)? Le mer. 6 juin 2018 19:51, Jean-Louis MONTEIRO a écrit : > I think so. Mistake maybe > > Le mer. 6 juin 2018 à 14:28, Romain Manni-Bucau a > écrit : > >> Ok, >> >> seems it comes from the PR apply of >>

Re: [config] trunk version is 1.3?

2018-06-06 Thread Jean-Louis MONTEIRO
I think so. Mistake maybe Le mer. 6 juin 2018 à 14:28, Romain Manni-Bucau a écrit : > Ok, > > seems it comes from the PR apply of > https://github.com/apache/geronimo-config/commit/c2be10837190eb8ab30da6f491979cc54e445243 > > can it be reverted please (just the version)? > > > Romain

Re: [config] trunk version is 1.3?

2018-06-06 Thread Romain Manni-Bucau
Ok, seems it comes from the PR apply of https://github.com/apache/geronimo-config/commit/c2be10837190eb8ab30da6f491979cc54e445243 can it be reverted please (just the version)? Romain Manni-Bucau @rmannibucau | Blog | Old