[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2758: [Gobblin-902] Enable gobblin yarn app luncher class configurable

2019-10-08 Thread GitBox 
sv2000 commented on a change in pull request #2758: [Gobblin-902] Enable 
gobblin yarn app luncher class configurable
URL: https://github.com/apache/incubator-gobblin/pull/2758#discussion_r332782796
 
 

 ##
 File path: 
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java
 ##
 @@ -734,11 +738,11 @@ private LogCopier buildLogCopier(Config config, Path 
sinkLogDir, Path appWorkDir
 rawLocalFs.initialize(URI.create(ConfigurationKeys.LOCAL_FS_URI), new 
Configuration());
 
 LogCopier.Builder builder = LogCopier.newBuilder()
-.useSrcFileSystem(this.fs)
-.useDestFileSystem(rawLocalFs)
-.readFrom(getHdfsLogDir(appWorkDir))
-.writeTo(sinkLogDir)
-
.acceptsLogFileExtensions(ImmutableSet.of(ApplicationConstants.STDOUT, 
ApplicationConstants.STDERR));
+.useSrcFileSystem(this.fs)
 
 Review comment:
   Looks like this is code reformat.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2758: [Gobblin-902] Enable gobblin yarn app luncher class configurable

2019-10-08 Thread GitBox 
sv2000 commented on a change in pull request #2758: [Gobblin-902] Enable 
gobblin yarn app luncher class configurable
URL: https://github.com/apache/incubator-gobblin/pull/2758#discussion_r332782648
 
 

 ##
 File path: 
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java
 ##
 @@ -313,8 +317,8 @@ public void run() {
 if 
(!this.config.hasPath(GobblinYarnConfigurationKeys.LOG_COPIER_DISABLE_DRIVER_COPY)
 ||
 
!this.config.getBoolean(GobblinYarnConfigurationKeys.LOG_COPIER_DISABLE_DRIVER_COPY))
 {
   services.add(buildLogCopier(this.config,
-new Path(this.sinkLogRootDir, this.applicationName + Path.SEPARATOR + 
this.applicationId.get().toString()),
-GobblinClusterUtils.getAppWorkDirPath(this.fs, this.applicationName, 
this.applicationId.get().toString(;
+  new Path(this.sinkLogRootDir, this.applicationName + Path.SEPARATOR 
+ this.applicationId.get().toString()),
+  GobblinClusterUtils.getAppWorkDirPath(this.fs, this.applicationName, 
this.applicationId.get().toString(;
 
 Review comment:
   Same comment.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2758: [Gobblin-902] Enable gobblin yarn app luncher class configurable

2019-10-08 Thread GitBox 
sv2000 commented on a change in pull request #2758: [Gobblin-902] Enable 
gobblin yarn app luncher class configurable
URL: https://github.com/apache/incubator-gobblin/pull/2758#discussion_r332782619
 
 

 ##
 File path: 
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java
 ##
 @@ -313,8 +317,8 @@ public void run() {
 if 
(!this.config.hasPath(GobblinYarnConfigurationKeys.LOG_COPIER_DISABLE_DRIVER_COPY)
 ||
 
!this.config.getBoolean(GobblinYarnConfigurationKeys.LOG_COPIER_DISABLE_DRIVER_COPY))
 {
   services.add(buildLogCopier(this.config,
-new Path(this.sinkLogRootDir, this.applicationName + Path.SEPARATOR + 
this.applicationId.get().toString()),
-GobblinClusterUtils.getAppWorkDirPath(this.fs, this.applicationName, 
this.applicationId.get().toString(;
+  new Path(this.sinkLogRootDir, this.applicationName + Path.SEPARATOR 
+ this.applicationId.get().toString()),
 
 Review comment:
   Looks like this is all reformatting code.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2758: [Gobblin-902] Enable gobblin yarn app luncher class configurable

2019-10-08 Thread GitBox 
sv2000 commented on a change in pull request #2758: [Gobblin-902] Enable 
gobblin yarn app luncher class configurable
URL: https://github.com/apache/incubator-gobblin/pull/2758#discussion_r332782155
 
 

 ##
 File path: 
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/CopySource.java
 ##
 @@ -403,11 +403,11 @@ private void setWorkUnitWatermark(WorkUnit workUnit, 
Optional