[jira] [Work logged] (GOBBLIN-1210) Force AM to read from token file to update token when start up
[ https://issues.apache.org/jira/browse/GOBBLIN-1210?focusedWorklogId=462664=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-462664 ] ASF GitHub Bot logged work on GOBBLIN-1210: --- Author: ASF GitHub Bot Created on: 23/Jul/20 19:01 Start Date: 23/Jul/20 19:01 Worklog Time Spent: 10m Work Description: asfgit closed pull request #3068: URL: https://github.com/apache/incubator-gobblin/pull/3068 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 462664) Time Spent: 2h (was: 1h 50m) > Force AM to read from token file to update token when start up > -- > > Key: GOBBLIN-1210 > URL: https://issues.apache.org/jira/browse/GOBBLIN-1210 > Project: Apache Gobblin > Issue Type: Task >Reporter: Zihan Li >Priority: Major > Time Spent: 2h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-1210) Force AM to read from token file to update token when start up
[ https://issues.apache.org/jira/browse/GOBBLIN-1210?focusedWorklogId=462295=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-462295 ] ASF GitHub Bot logged work on GOBBLIN-1210: --- Author: ASF GitHub Bot Created on: 22/Jul/20 23:10 Start Date: 22/Jul/20 23:10 Worklog Time Spent: 10m Work Description: ZihanLi58 closed pull request #3057: URL: https://github.com/apache/incubator-gobblin/pull/3057 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 462295) Time Spent: 1h 40m (was: 1.5h) > Force AM to read from token file to update token when start up > -- > > Key: GOBBLIN-1210 > URL: https://issues.apache.org/jira/browse/GOBBLIN-1210 > Project: Apache Gobblin > Issue Type: Task >Reporter: Zihan Li >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-1210) Force AM to read from token file to update token when start up
[ https://issues.apache.org/jira/browse/GOBBLIN-1210?focusedWorklogId=462296=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-462296 ] ASF GitHub Bot logged work on GOBBLIN-1210: --- Author: ASF GitHub Bot Created on: 22/Jul/20 23:10 Start Date: 22/Jul/20 23:10 Worklog Time Spent: 10m Work Description: ZihanLi58 commented on pull request #3057: URL: https://github.com/apache/incubator-gobblin/pull/3057#issuecomment-662742101 Open replace PR https://github.com/apache/incubator-gobblin/pull/3068 to fix the conflicts This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 462296) Time Spent: 1h 50m (was: 1h 40m) > Force AM to read from token file to update token when start up > -- > > Key: GOBBLIN-1210 > URL: https://issues.apache.org/jira/browse/GOBBLIN-1210 > Project: Apache Gobblin > Issue Type: Task >Reporter: Zihan Li >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-1210) Force AM to read from token file to update token when start up
[
https://issues.apache.org/jira/browse/GOBBLIN-1210?focusedWorklogId=462294=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-462294
]
ASF GitHub Bot logged work on GOBBLIN-1210:
---
Author: ASF GitHub Bot
Created on: 22/Jul/20 23:09
Start Date: 22/Jul/20 23:09
Worklog Time Spent: 10m
Work Description: ZihanLi58 opened a new pull request #3068:
URL: https://github.com/apache/incubator-gobblin/pull/3068
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1210
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
Call handle token update method in constructor to force AM to read from
token file to update token when start up
fix conflicts for original pr
https://github.com/apache/incubator-gobblin/pull/3057
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 462294)
Time Spent: 1.5h (was: 1h 20m)
> Force AM to read from token file to update token when start up
> --
>
> Key: GOBBLIN-1210
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1210
> Project: Apache Gobblin
> Issue Type: Task
>Reporter: Zihan Li
>Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-1210) Force AM to read from token file to update token when start up
[ https://issues.apache.org/jira/browse/GOBBLIN-1210?focusedWorklogId=462264=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-462264 ] ASF GitHub Bot logged work on GOBBLIN-1210: --- Author: ASF GitHub Bot Created on: 22/Jul/20 21:06 Start Date: 22/Jul/20 21:06 Worklog Time Spent: 10m Work Description: sv2000 commented on pull request #3057: URL: https://github.com/apache/incubator-gobblin/pull/3057#issuecomment-662696736 @ZihanLi58 there are some merge conflicts. Can you check? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 462264) Time Spent: 1h 20m (was: 1h 10m) > Force AM to read from token file to update token when start up > -- > > Key: GOBBLIN-1210 > URL: https://issues.apache.org/jira/browse/GOBBLIN-1210 > Project: Apache Gobblin > Issue Type: Task >Reporter: Zihan Li >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-1210) Force AM to read from token file to update token when start up
[
https://issues.apache.org/jira/browse/GOBBLIN-1210?focusedWorklogId=462060=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-462060
]
ASF GitHub Bot logged work on GOBBLIN-1210:
---
Author: ASF GitHub Bot
Created on: 22/Jul/20 13:26
Start Date: 22/Jul/20 13:26
Worklog Time Spent: 10m
Work Description: sv2000 commented on a change in pull request #3057:
URL: https://github.com/apache/incubator-gobblin/pull/3057#discussion_r458786811
##
File path:
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnHelixUtils.java
##
@@ -65,6 +71,23 @@ public static void writeTokenToFile(Token token, Path
credentials.writeTokenStorageFile(tokenFilePath, configuration);
}
+ /**
+ * Update {@link Token} with token file in resources.
+ *
+ * @param
+ * @throws IOException
+ */
+ public void updateToken() throws IOException{
Review comment:
Can this method be made static?
##
File path:
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnTaskRunner.java
##
@@ -201,6 +201,8 @@ public static void main(String[] args) {
if (!Strings.isNullOrEmpty(helixInstanceTags)) {
config =
config.withValue(GobblinClusterConfigurationKeys.HELIX_INSTANCE_TAGS_KEY,
ConfigValueFactory.fromAnyRef(helixInstanceTags));
}
+ YarnHelixUtils utils = new YarnHelixUtils();
Review comment:
Do you need to new the utils class? Can't the updateToken() be made
public static?
##
File path:
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java
##
@@ -877,18 +880,17 @@ private Path getHdfsLogDir(Path appWorkDir) throws
IOException {
return logRootDir;
}
- private AbstractYarnAppSecurityManager buildSecurityManager() throws
IOException {
+ private AbstractYarnAppSecurityManager buildSecurityManager(boolean
isReconnected) throws IOException {
Path tokenFilePath = new Path(this.fs.getHomeDirectory(),
this.applicationName + Path.SEPARATOR +
GobblinYarnConfigurationKeys.TOKEN_FILE_NAME);
ClassAliasResolver aliasResolver = new
ClassAliasResolver<>(
AbstractYarnAppSecurityManager.class);
try {
- return
(AbstractYarnAppSecurityManager)ConstructorUtils.invokeConstructor(Class.forName(aliasResolver.resolve(
+ return (AbstractYarnAppSecurityManager)
GobblinConstructorUtils.invokeLongestConstructor(Class.forName(aliasResolver.resolve(
ConfigUtils.getString(config,
GobblinYarnConfigurationKeys.SECURITY_MANAGER_CLASS,
GobblinYarnConfigurationKeys.DEFAULT_SECURITY_MANAGER_CLASS))), this.config,
this.helixManager, this.fs,
- tokenFilePath);
-} catch (NoSuchMethodException | IllegalAccessException |
InvocationTargetException | InstantiationException
-| ClassNotFoundException e) {
+ tokenFilePath, isReconnected);
+} catch (ReflectiveOperationException e) {
Review comment:
+1 on consolidating all the exceptions into ReflectiveOperationException.
##
File path:
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnHelixUtils.java
##
@@ -24,12 +24,14 @@
import java.util.Map;
import org.apache.commons.lang3.StringUtils;
+import org.apache.gobblin.cluster.GobblinClusterUtils;
Review comment:
This looks like an unused import.
##
File path:
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinApplicationMaster.java
##
@@ -227,7 +227,8 @@ public static void main(String[] args) throws Exception {
printUsage(options);
System.exit(1);
}
-
+ YarnHelixUtils utils = new YarnHelixUtils();
Review comment:
See comment below about making the updateToken() method static.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 462060)
Time Spent: 1h 10m (was: 1h)
> Force AM to read from token file to update token when start up
> --
>
> Key: GOBBLIN-1210
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1210
> Project: Apache Gobblin
> Issue Type: Task
>Reporter: Zihan Li
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-1210) Force AM to read from token file to update token when start up
[
https://issues.apache.org/jira/browse/GOBBLIN-1210?focusedWorklogId=458874=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-458874
]
ASF GitHub Bot logged work on GOBBLIN-1210:
---
Author: ASF GitHub Bot
Created on: 14/Jul/20 18:47
Start Date: 14/Jul/20 18:47
Worklog Time Spent: 10m
Work Description: sv2000 commented on a change in pull request #3057:
URL: https://github.com/apache/incubator-gobblin/pull/3057#discussion_r454569680
##
File path:
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinApplicationMaster.java
##
@@ -229,6 +227,8 @@ public static void main(String[] args) throws Exception {
printUsage(options);
System.exit(1);
}
+ Config config = ConfigFactory.load();
Review comment:
Also it would be good to add a comment explaining why the token update
is done in the main() i.e "Because AM is restarted with the original
AppSubmissionContext, it may have outdated delegation tokens. So the refreshed
tokens should be added into the container's UGI before any HDFS/Hive/RM access
is performed."
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 458874)
Time Spent: 1h (was: 50m)
> Force AM to read from token file to update token when start up
> --
>
> Key: GOBBLIN-1210
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1210
> Project: Apache Gobblin
> Issue Type: Task
>Reporter: Zihan Li
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-1210) Force AM to read from token file to update token when start up
[
https://issues.apache.org/jira/browse/GOBBLIN-1210?focusedWorklogId=458418=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-458418
]
ASF GitHub Bot logged work on GOBBLIN-1210:
---
Author: ASF GitHub Bot
Created on: 14/Jul/20 02:05
Start Date: 14/Jul/20 02:05
Worklog Time Spent: 10m
Work Description: sv2000 commented on a change in pull request #3057:
URL: https://github.com/apache/incubator-gobblin/pull/3057#discussion_r454053098
##
File path:
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinApplicationMaster.java
##
@@ -227,6 +227,8 @@ public static void main(String[] args) throws Exception {
printUsage(options);
System.exit(1);
}
+ Config config = ConfigFactory.load();
Review comment:
Can we replace the ConfigFactory.load() in line 240 with the config
variable created here?
##
File path:
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnHelixUtils.java
##
@@ -65,6 +71,27 @@ public static void writeTokenToFile(Token token, Path
credentials.writeTokenStorageFile(tokenFilePath, configuration);
}
+ /**
+ * Update {@link Token} with the configured token path.
+ *
+ * @param config a {@link Config} object carrying Hadoop configuration
properties and token path config
+ * @throws IOException
+ */
+ public static void updateToken(Config config) throws IOException{
+FileSystem fs = GobblinClusterUtils.buildFileSystem(config, new
Configuration());
+Path tokenPath = new Path(fs.getHomeDirectory(),
+config.getString(GobblinYarnConfigurationKeys.APPLICATION_NAME_KEY) +
Path.SEPARATOR
++ GobblinYarnConfigurationKeys.TOKEN_FILE_NAME);
+if(fs.exists(tokenPath)) {
+ Credentials credentials = Credentials.readTokenStorageFile(tokenPath,
fs.getConf());
Review comment:
Can lines 86-91 be refactored out into a separate addCredentials()
method, which can be called also from YarnContainerSecurityManager?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 458418)
Time Spent: 50m (was: 40m)
> Force AM to read from token file to update token when start up
> --
>
> Key: GOBBLIN-1210
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1210
> Project: Apache Gobblin
> Issue Type: Task
>Reporter: Zihan Li
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-1210) Force AM to read from token file to update token when start up
[
https://issues.apache.org/jira/browse/GOBBLIN-1210?focusedWorklogId=457309=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-457309
]
ASF GitHub Bot logged work on GOBBLIN-1210:
---
Author: ASF GitHub Bot
Created on: 10/Jul/20 19:03
Start Date: 10/Jul/20 19:03
Worklog Time Spent: 10m
Work Description: sv2000 commented on a change in pull request #3057:
URL: https://github.com/apache/incubator-gobblin/pull/3057#discussion_r453027666
##
File path:
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinApplicationMaster.java
##
@@ -104,7 +104,9 @@ public GobblinApplicationMaster(String applicationName,
String applicationId, Co
if (UserGroupInformation.isSecurityEnabled()) {
LOGGER.info("Adding YarnContainerSecurityManager since security is
enabled");
-
this.applicationLauncher.addService(buildYarnContainerSecurityManager(this.config,
this.fs));
+ YarnContainerSecurityManager yarnContainerSecurityManager =
buildYarnContainerSecurityManager(this.config, this.fs);
Review comment:
One more comment: For safety, it may make sense to do the same action on
the worker nodes as well i.e. on start up read the latest tokens from the token
file.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 457309)
Time Spent: 40m (was: 0.5h)
> Force AM to read from token file to update token when start up
> --
>
> Key: GOBBLIN-1210
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1210
> Project: Apache Gobblin
> Issue Type: Task
>Reporter: Zihan Li
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-1210) Force AM to read from token file to update token when start up
[
https://issues.apache.org/jira/browse/GOBBLIN-1210?focusedWorklogId=456959=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-456959
]
ASF GitHub Bot logged work on GOBBLIN-1210:
---
Author: ASF GitHub Bot
Created on: 10/Jul/20 03:34
Start Date: 10/Jul/20 03:34
Worklog Time Spent: 10m
Work Description: sv2000 commented on a change in pull request #3057:
URL: https://github.com/apache/incubator-gobblin/pull/3057#discussion_r452604276
##
File path:
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinApplicationMaster.java
##
@@ -104,7 +104,9 @@ public GobblinApplicationMaster(String applicationName,
String applicationId, Co
if (UserGroupInformation.isSecurityEnabled()) {
LOGGER.info("Adding YarnContainerSecurityManager since security is
enabled");
-
this.applicationLauncher.addService(buildYarnContainerSecurityManager(this.config,
this.fs));
+ YarnContainerSecurityManager yarnContainerSecurityManager =
buildYarnContainerSecurityManager(this.config, this.fs);
Review comment:
We need to be a little careful on when we add the tokens on AM restart.
In particular, we need to ensure that the new tokens are added into the UGI
before any HDFS/Hive/RM access happens. Your fix may be ok, but in the future,
this detail may easily be forgotten and may introduce unintentional bugs.
Do you think it would be safer to add the credentials inside the main() of
the GobblinApplicationMaster? Also, instead of sending a
DelegationTokenUpdateEvent, a cleaner approach maybe to make the
readCredentials and addCredentials methods public static and call them directly
in the main?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 456959)
Time Spent: 0.5h (was: 20m)
> Force AM to read from token file to update token when start up
> --
>
> Key: GOBBLIN-1210
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1210
> Project: Apache Gobblin
> Issue Type: Task
>Reporter: Zihan Li
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-1210) Force AM to read from token file to update token when start up
[ https://issues.apache.org/jira/browse/GOBBLIN-1210?focusedWorklogId=456943=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-456943 ] ASF GitHub Bot logged work on GOBBLIN-1210: --- Author: ASF GitHub Bot Created on: 10/Jul/20 02:26 Start Date: 10/Jul/20 02:26 Worklog Time Spent: 10m Work Description: ZihanLi58 commented on pull request #3057: URL: https://github.com/apache/incubator-gobblin/pull/3057#issuecomment-656444855 @sv2000 Can you take a look at this minor change? Thx! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 456943) Time Spent: 20m (was: 10m) > Force AM to read from token file to update token when start up > -- > > Key: GOBBLIN-1210 > URL: https://issues.apache.org/jira/browse/GOBBLIN-1210 > Project: Apache Gobblin > Issue Type: Task >Reporter: Zihan Li >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-1210) Force AM to read from token file to update token when start up
[
https://issues.apache.org/jira/browse/GOBBLIN-1210?focusedWorklogId=456294=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-456294
]
ASF GitHub Bot logged work on GOBBLIN-1210:
---
Author: ASF GitHub Bot
Created on: 08/Jul/20 18:53
Start Date: 08/Jul/20 18:53
Worklog Time Spent: 10m
Work Description: ZihanLi58 opened a new pull request #3057:
URL: https://github.com/apache/incubator-gobblin/pull/3057
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-1210] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1210
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
Call handle token update method in constructor to force AM to read from
token file to update token when start up
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
minor change
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 456294)
Remaining Estimate: 0h
Time Spent: 10m
> Force AM to read from token file to update token when start up
> --
>
> Key: GOBBLIN-1210
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1210
> Project: Apache Gobblin
> Issue Type: Task
>Reporter: Zihan Li
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
