[jira] [Commented] (GOSSIP-65) Implement crdt LWW-Element-Set

[Edward Capriolo (JIRA)]

[ 
https://issues.apache.org/jira/browse/GOSSIP-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16055060#comment-16055060
 ] 

Edward Capriolo commented on GOSSIP-65:
---

Great feature. Thanks much

> Implement crdt LWW-Element-Set 
> ---
>
> Key: GOSSIP-65
> URL: https://issues.apache.org/jira/browse/GOSSIP-65
> Project: Gossip
>  Issue Type: New Feature
>Reporter: Edward Capriolo
>Assignee: Maxim Rusak
> Fix For: 0.1.3
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GOSSIP-65) Implement crdt LWW-Element-Set

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GOSSIP-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16053299#comment-16053299
 ] 

ASF GitHub Bot commented on GOSSIP-65:
--

Github user edwardcapriolo commented on a diff in the pull request:

https://github.com/apache/incubator-gossip/pull/54#discussion_r122599122
  
--- Diff: gossip-base/src/test/java/org/apache/gossip/crdt/LWWSetTest.java 
---
@@ -0,0 +1,142 @@
+/*
--- End diff --

MeanGirls has this definition:

{
  'type': 'lww-e-set',
  'bias': 'a',
  'e': [
['a', 0],
['b', 1, 2],
['c', 2, 1],
['d', 3, 3]
  ]
}

a was created at 0 and still exists.
b was deleted after creation; it does not exist.
c was created after deletion; it exists
d was created and deleted at the same time. Bias a means we prefer adds, so 
it exists.

Try to implement these cases directly as one or more tests


> Implement crdt LWW-Element-Set 
> ---
>
> Key: GOSSIP-65
> URL: https://issues.apache.org/jira/browse/GOSSIP-65
> Project: Gossip
>  Issue Type: New Feature
>Reporter: Edward Capriolo
>Assignee: Maxim Rusak
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GOSSIP-65) Implement crdt LWW-Element-Set

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GOSSIP-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16053300#comment-16053300
 ] 

ASF GitHub Bot commented on GOSSIP-65:
--

Github user edwardcapriolo commented on a diff in the pull request:

https://github.com/apache/incubator-gossip/pull/54#discussion_r122598947
  
--- Diff: gossip-base/src/main/java/org/apache/gossip/crdt/LWWSet.java ---
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gossip.crdt;
+
+import org.apache.gossip.manager.Clock;
+import org.apache.gossip.manager.SystemClock;
+
+import java.util.*;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+
--- End diff --

Documentation here. You should at least mentioned that this implementation 
is bias for add since isPresent ranks add > remove


> Implement crdt LWW-Element-Set 
> ---
>
> Key: GOSSIP-65
> URL: https://issues.apache.org/jira/browse/GOSSIP-65
> Project: Gossip
>  Issue Type: New Feature
>Reporter: Edward Capriolo
>Assignee: Maxim Rusak
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GOSSIP-65) Implement crdt LWW-Element-Set

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GOSSIP-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16053298#comment-16053298
 ] 

ASF GitHub Bot commented on GOSSIP-65:
--

Github user edwardcapriolo commented on the issue:

https://github.com/apache/incubator-gossip/pull/54
  
You need to add end-to-end tests, and likely changes to CrdtModule and 
se/de tests.I do not think this will work end-to-end as is now.


> Implement crdt LWW-Element-Set 
> ---
>
> Key: GOSSIP-65
> URL: https://issues.apache.org/jira/browse/GOSSIP-65
> Project: Gossip
>  Issue Type: New Feature
>Reporter: Edward Capriolo
>Assignee: Maxim Rusak
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GOSSIP-65) Implement crdt LWW-Element-Set

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GOSSIP-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16053194#comment-16053194
 ] 

ASF GitHub Bot commented on GOSSIP-65:
--

GitHub user makrusak opened a pull request:

https://github.com/apache/incubator-gossip/pull/54

GOSSIP-65 Implement crdt LWW-Element-Set



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/makrusak/incubator-gossip GOSSIP-65

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-gossip/pull/54.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #54


commit 14895e222e706d6692aefac0ad4c9baf5f4c51f1
Author: Maxim Rusak 
Date:   2017-06-18T13:27:46Z

GOSSIP-65 Implement crdt LWW-Element-Set




> Implement crdt LWW-Element-Set 
> ---
>
> Key: GOSSIP-65
> URL: https://issues.apache.org/jira/browse/GOSSIP-65
> Project: Gossip
>  Issue Type: New Feature
>Reporter: Edward Capriolo
>Assignee: Maxim Rusak
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)