[GitHub] guacamole-server pull request #:

2018-03-16 Thread necouchman
Github user necouchman commented on the pull request: https://github.com/apache/guacamole-server/commit/f75579de7eecd39b3f28e9eda20a4393b49ac1c9#commitcomment-28119913 A couple of things: - First, a systemd file isn't really a script, it's more of a configuration file that tells

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-03-16 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r175180850 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/QuickConnectDirectory.java --- @@ -0,0

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-03-16 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r175185303 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/QuickConnection.java --- @@ -0,0 +1,181

[GitHub] guacamole-server pull request #160: GUACAMOLE-30: Implement systemd startup ...

2018-03-16 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/160#discussion_r175202657 --- Diff: src/guacd/systemd/guacd.service.in --- @@ -0,0 +1,11 @@ +[Unit] +Description=Guacamole Server +Documentation=man:guacd(8)

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-03-16 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r175181207 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/QuickConnection.java --- @@ -0,0 +1,181

[GitHub] guacamole-server pull request #160: GUACAMOLE-30: Implement systemd startup ...

2018-03-16 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/160#discussion_r175201377 --- Diff: src/guacd/systemd/guacd.service.in --- @@ -0,0 +1,11 @@ +[Unit] --- End diff -- Do systemd unit files support

[GitHub] guacamole-client pull request #264: GUACAMOLE-525: Fix issues with SQL Serve...

2018-03-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/guacamole-client/pull/264 ---

Jenkins build is back to normal : guacamole-server-coverity #22

2018-03-16 Thread Apache Jenkins Server
See

[GitHub] guacamole-server pull request #160: GUACAMOLE-30: Implement systemd startup ...

2018-03-16 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/160#discussion_r175207725 --- Diff: src/guacd/systemd/guacd.service.in --- @@ -0,0 +1,11 @@ +[Unit] +Description=Guacamole Server +Documentation=man:guacd(8)

[GitHub] guacamole-server pull request #160: GUACAMOLE-30: Implement systemd startup ...

2018-03-16 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/160#discussion_r175207766 --- Diff: src/guacd/systemd/guacd.service.in --- @@ -0,0 +1,11 @@ +[Unit] --- End diff -- Probably so...will add it. ---

Jenkins build is back to normal : guacamole-client-coverity #26

2018-03-16 Thread Apache Jenkins Server
See

[GitHub] guacamole-server pull request #160: GUACAMOLE-30: Implement systemd startup ...

2018-03-16 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/160#discussion_r175213905 --- Diff: src/guacd/systemd/guacd.service.in --- @@ -0,0 +1,11 @@ +[Unit] --- End diff -- Added. ---