[GitHub] guacamole-client pull request #194: GUACAMOLE-221: Support for Connection Pr...

2018-03-31 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/194#discussion_r178438303 --- Diff: guacamole/src/main/webapp/app/prompt/services/guacPrompt.js --- @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Found

[GitHub] guacamole-client pull request #194: GUACAMOLE-221: Support for Connection Pr...

2018-03-29 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/194#discussion_r178082252 --- Diff: guacamole/src/main/webapp/app/prompt/services/guacPrompt.js --- @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Found

[GitHub] guacamole-client pull request #194: GUACAMOLE-221: Support for Connection Pr...

2018-03-29 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/194#discussion_r178081985 --- Diff: guacamole/src/main/webapp/app/client/types/ManagedClient.js --- @@ -503,27 +504,70 @@ angular.module('client').factory('ManagedClient',

[GitHub] guacamole-client pull request #194: GUACAMOLE-221: Support for Connection Pr...

2018-03-29 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/194#discussion_r178056624 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/net/auth/simple/SimpleConnection.java --- @@ -98,6 +99,10 @@ public void setAttribut

[GitHub] guacamole-client pull request #194: GUACAMOLE-221: Support for Connection Pr...

2018-03-29 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/194#discussion_r178056419 --- Diff: guacamole/src/main/webapp/app/client/types/ManagedClient.js --- @@ -503,27 +504,70 @@ angular.module('client').factory('ManagedClient',

[GitHub] guacamole-client pull request #194: GUACAMOLE-221: Support for Connection Pr...

2018-03-29 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/194#discussion_r178052016 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/net/auth/simple/SimpleConnection.java --- @@ -98,6 +99,10 @@ public void setAttribut

[GitHub] guacamole-client pull request #194: GUACAMOLE-221: Support for Connection Pr...

2018-03-29 Thread uvtrip
Github user uvtrip commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/194#discussion_r178046477 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/net/auth/simple/SimpleConnection.java --- @@ -98,6 +99,10 @@ public void setAttributes(M

[GitHub] guacamole-client pull request #194: GUACAMOLE-221: Support for Connection Pr...

2018-03-29 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/194#discussion_r178045959 --- Diff: guacamole/src/main/webapp/app/prompt/services/guacPrompt.js --- @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Found

[GitHub] guacamole-client pull request #194: GUACAMOLE-221: Support for Connection Pr...

2018-03-29 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/194#discussion_r178045884 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/net/auth/simple/SimpleConnection.java --- @@ -98,6 +99,10 @@ public void setAttribut

[GitHub] guacamole-client pull request #194: GUACAMOLE-221: Support for Connection Pr...

2018-03-29 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/194#discussion_r178039519 --- Diff: guacamole/src/main/webapp/app/client/types/ManagedClient.js --- @@ -503,27 +504,70 @@ angular.module('client').factory('ManagedClient',

[GitHub] guacamole-client pull request #194: GUACAMOLE-221: Support for Connection Pr...

2018-03-29 Thread uvtrip
Github user uvtrip commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/194#discussion_r174723573 --- Diff: guacamole/src/main/webapp/app/client/types/ManagedClient.js --- @@ -503,27 +504,70 @@ angular.module('client').factory('ManagedClient', ['

[GitHub] guacamole-client pull request #194: GUACAMOLE-221: Support for Connection Pr...

2018-03-29 Thread uvtrip
Github user uvtrip commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/194#discussion_r174737727 --- Diff: guacamole/src/main/webapp/app/prompt/services/guacPrompt.js --- @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] guacamole-client pull request #194: GUACAMOLE-221: Support for Connection Pr...

2018-03-29 Thread uvtrip
Github user uvtrip commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/194#discussion_r174724059 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/net/auth/simple/SimpleConnection.java --- @@ -98,6 +99,10 @@ public void setAttributes(M

[GitHub] guacamole-client pull request #194: GUACAMOLE-221: Support for Connection Pr...

2018-03-13 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/194#discussion_r174090051 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/token/StandardTokens.java --- @@ -50,6 +50,16 @@ */ public static

[GitHub] guacamole-client pull request #194: GUACAMOLE-221: Support for Connection Pr...

2018-03-13 Thread uvtrip
Github user uvtrip commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/194#discussion_r174033036 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/token/StandardTokens.java --- @@ -50,6 +50,16 @@ */ public static fina

[GitHub] guacamole-client pull request #194: GUACAMOLE-221: Support for Connection Pr...

2018-01-15 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/194#discussion_r161638782 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/token/PromptEntry.java --- @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache

[GitHub] guacamole-client pull request #194: GUACAMOLE-221: Support for Connection Pr...

2018-01-15 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/194#discussion_r161610676 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/token/PromptEntry.java --- @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache S

[GitHub] guacamole-client pull request #194: GUACAMOLE-221: Support for Connection Pr...

2018-01-13 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/194#discussion_r161386520 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/token/PromptEntry.java --- @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache