This has landed in branch-2. Your assumption on the configuration toggle is
correct: we should expect no changes to the output of these jobs (and thus
no downstream impact in other jobs). The new directory structure is toggled
via hbase.hfileoutputformat.tablename.namespace.inclusive, which I've
I assume supporting either directory structure with a configuration toggle
means existing code can coexist (in other jobs) with the backup feature,
and so it will be fine to port this into a code line that will release a
new minor. Sounds like a plan. +1
On Tue, Jan 17, 2023 at 5:21 PM Bryan
Thanks Bryan for taking care of this!
Bryan Beaudreault 于2023年1月18日周三 09:21写道：
>
> Hey all,
>
> I reviewed the entirety of the backport PR. It's almost all net-new code,
> which matches identically with what was already reviewed and approved in
> the original implementation. There are some minor
Hey all,
I reviewed the entirety of the backport PR. It's almost all net-new code,
which matches identically with what was already reviewed and approved in
the original implementation. There are some minor changes to
HFileOutputFormat2 and WALPlayer (and related tests).
Of the changes to those 2
Agreed that the open tasks are not essential before considering a backport
for (near term) release. We have often released backported features from
the main branch in new minors with documentation -- release notes and
updates to the online book, typically -- describing them as "experimental",
Thanks for taking care of this. I've been helping Mallikarjun to
improve backup but it is a bit hard for me to catch up.
It will be good if someone could revisit the design and implementation
of the whole backup feature, improve it and use it in
production, so it will be used by more users in the
