Re: [DISCUSS] changes in shell behavior wrt returning values

2018-04-06 Thread Apekshit Sharma
lgtm. On Fri, Apr 6, 2018 at 1:24 PM, Sean Busbey wrote: > FYI, HBASE-20276 has now been committed to all impacted branches. > > If folks have a chance to review the proposed release note, that'd be > grand. > > On Fri, Apr 6, 2018 at 2:55 PM, Josh Elser

Re: [DISCUSS] changes in shell behavior wrt returning values

2018-04-06 Thread Sean Busbey
FYI, HBASE-20276 has now been committed to all impacted branches. If folks have a chance to review the proposed release note, that'd be grand. On Fri, Apr 6, 2018 at 2:55 PM, Josh Elser wrote: > +1 ditto -- this one is better to revert and ask forgiveness on from users, >

Re: [DISCUSS] changes in shell behavior wrt returning values

2018-04-06 Thread Josh Elser
+1 ditto -- this one is better to revert and ask forgiveness on from users, IMO. On 4/3/18 3:27 PM, Apekshit Sharma wrote: +1 on going back to old behavior, i.e. returning values, in branch-1 and 2.0 release. bq. Open question: should we also revert this change in branch-1.4, even though it

Re: [DISCUSS] changes in shell behavior wrt returning values

2018-04-03 Thread Sean Busbey
Oh right, also branch-1 currently has HBASE-19858. so we might be a bit from a 1.5 release. On Tue, Apr 3, 2018 at 7:25 PM, Sean Busbey wrote: > I dunno. I'd defer to others on the release suitability of branch-1 > code. I look at nightly and all I see is red. > > > > On Tue,

Re: [DISCUSS] changes in shell behavior wrt returning values

2018-04-03 Thread Sean Busbey
I dunno. I'd defer to others on the release suitability of branch-1 code. I look at nightly and all I see is red. On Tue, Apr 3, 2018 at 2:27 PM, Apekshit Sharma wrote: > +1 on going back to old behavior, i.e. returning values, in branch-1 and > 2.0 release. > > bq. Open

Re: [DISCUSS] changes in shell behavior wrt returning values

2018-04-03 Thread Apekshit Sharma
+1 on going back to old behavior, i.e. returning values, in branch-1 and 2.0 release. bq. Open question: should we also revert this change in branch-1.4, even though it means the shell will behave very differently between maintenance releases? Earlier, i was inclining towards reverting the