Re: HttpClient for Android Question

2019-02-16 Thread Oscar Bastidas
Hello Oleg, Thank you for your kind response. I have Android 8.1 on my device and I think I'd like to give the 5.0 package a shot. That being said, I do have two follow-up questions that I would like to ask you: 1) I noticed that to get the 4.3.5.1 package via the link you gave me, I need to

Re: HttpCore 5.0 BETA7?

2019-02-16 Thread Oleg Kalnichevski
On Sat, 2019-02-16 at 09:18 -0500, Gary Gregory wrote: > ... > I get a compiler error with the above patch: > > Description Resource Path Location Type > The method > setLookupRegistry(LookupRegistry > >) in > the type AsyncServerBootstrap is not applicable for the arguments > (new >

[GitHub] cstamas commented on a change in pull request #137: URIBuilder and URIUtils improvements

2019-02-16 Thread GitBox
cstamas commented on a change in pull request #137: URIBuilder and URIUtils improvements URL: https://github.com/apache/httpcomponents-client/pull/137#discussion_r257466056 ## File path: httpclient-cache/src/main/java/org/apache/http/impl/client/cache/CacheKeyGenerator.java

[GitHub] cstamas commented on a change in pull request #137: URIBuilder and URIUtils improvements

2019-02-16 Thread GitBox
cstamas commented on a change in pull request #137: URIBuilder and URIUtils improvements URL: https://github.com/apache/httpcomponents-client/pull/137#discussion_r257471476 ## File path: httpclient-cache/src/main/java/org/apache/http/impl/client/cache/CacheKeyGenerator.java

[GitHub] ok2c commented on a change in pull request #137: URIBuilder and URIUtils improvements

2019-02-16 Thread GitBox
ok2c commented on a change in pull request #137: URIBuilder and URIUtils improvements URL: https://github.com/apache/httpcomponents-client/pull/137#discussion_r257466031 ## File path: httpclient-cache/src/main/java/org/apache/http/impl/client/cache/CacheKeyGenerator.java

[GitHub] ok2c commented on issue #109: Fixed broken generics in server bootstrap classes

2019-02-16 Thread GitBox
ok2c commented on issue #109: Fixed broken generics in server bootstrap classes URL: https://github.com/apache/httpcomponents-core/pull/109#issuecomment-464363078 @garydgregory Please let me know if there is anything else that needs fixing.

Re: HttpCore 5.0 BETA7?

2019-02-16 Thread Oleg Kalnichevski
On Sat, 2019-02-16 at 08:45 -0500, Gary Gregory wrote: > ... > This is what Eclipse says for one of the call sites: > > Description Resource Path Location Type > > LookupRegistry is a raw type. References to generic type > LookupRegistry > should be parameterized AsyncServerBootstrap.java >

[GitHub] ok2c commented on a change in pull request #137: URIBuilder and URIUtils improvements

2019-02-16 Thread GitBox
ok2c commented on a change in pull request #137: URIBuilder and URIUtils improvements URL: https://github.com/apache/httpcomponents-client/pull/137#discussion_r257466146 ## File path: httpclient-cache/src/main/java/org/apache/http/impl/client/cache/CacheKeyGenerator.java

[GitHub] ok2c opened a new pull request #109: Fixed broken generics in server bootstrap classes

2019-02-16 Thread GitBox
ok2c opened a new pull request #109: Fixed broken generics in server bootstrap classes URL: https://github.com/apache/httpcomponents-core/pull/109 This is an automated message from the Apache Git Service. To respond to the

Re: HttpCore 5.0 BETA7?

2019-02-16 Thread Gary Gregory
On Sat, Feb 16, 2019 at 9:11 AM Oleg Kalnichevski wrote: > On Sat, 2019-02-16 at 08:45 -0500, Gary Gregory wrote: > > > > ... > > > > This is what Eclipse says for one of the call sites: > > > > Description Resource Path Location Type > > > > LookupRegistry is a raw type. References to generic

Re: [httpcomponents-client] branch 4.5.x updated: HTTPCLIENT-1968: Make normalization of URI paths optional

2019-02-16 Thread Gary Gregory
On these below, the @since are off. Gary On Sat, Feb 16, 2019 at 5:55 AM wrote: > This is an automated email from the ASF dual-hosted git repository. > > olegk pushed a commit to branch 4.5.x > in repository > https://gitbox.apache.org/repos/asf/httpcomponents-client.git > > > The following

[GitHub] cstamas commented on a change in pull request #137: URIBuilder and URIUtils improvements

2019-02-16 Thread GitBox
cstamas commented on a change in pull request #137: URIBuilder and URIUtils improvements URL: https://github.com/apache/httpcomponents-client/pull/137#discussion_r257464571 ## File path: httpclient-cache/src/main/java/org/apache/http/impl/client/cache/CacheKeyGenerator.java

[GitHub] cstamas commented on a change in pull request #137: URIBuilder and URIUtils improvements

2019-02-16 Thread GitBox
cstamas commented on a change in pull request #137: URIBuilder and URIUtils improvements URL: https://github.com/apache/httpcomponents-client/pull/137#discussion_r257464571 ## File path: httpclient-cache/src/main/java/org/apache/http/impl/client/cache/CacheKeyGenerator.java

[GitHub] ok2c commented on issue #136: HTTPCLIENT-1968

2019-02-16 Thread GitBox
ok2c commented on issue #136: HTTPCLIENT-1968 URL: https://github.com/apache/httpcomponents-client/pull/136#issuecomment-464335564 @cstamas Awesome. Could you please rebase off 4.5.x HEAD and squash intermediate commits? I'll merge the PR as soon as it is done. I also have fixed the

[GitHub] cstamas commented on issue #136: HTTPCLIENT-1968

2019-02-16 Thread GitBox
cstamas commented on issue #136: HTTPCLIENT-1968 URL: https://github.com/apache/httpcomponents-client/pull/136#issuecomment-464335865 @ok2c done This is an automated message from the Apache Git Service. To respond to the

[GitHub] ok2c merged pull request #136: HTTPCLIENT-1968

2019-02-16 Thread GitBox
ok2c merged pull request #136: HTTPCLIENT-1968 URL: https://github.com/apache/httpcomponents-client/pull/136 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[jira] [Commented] (HTTPCLIENT-1968) Encoded forward slashes are not preserved when rewriting URI

2019-02-16 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770083#comment-16770083 ] ASF subversion and git services commented on HTTPCLIENT-1968: - Commit

[jira] [Commented] (HTTPCLIENT-1968) Encoded forward slashes are not preserved when rewriting URI

2019-02-16 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770082#comment-16770082 ] ASF subversion and git services commented on HTTPCLIENT-1968: - Commit

[jira] [Commented] (HTTPCLIENT-1968) Encoded forward slashes are not preserved when rewriting URI

2019-02-16 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770081#comment-16770081 ] ASF subversion and git services commented on HTTPCLIENT-1968: - Commit

[GitHub] cstamas commented on a change in pull request #136: HTTPCLIENT-1968

2019-02-16 Thread GitBox
cstamas commented on a change in pull request #136: HTTPCLIENT-1968 URL: https://github.com/apache/httpcomponents-client/pull/136#discussion_r257453283 ## File path: httpclient/src/main/java/org/apache/http/client/utils/URIUtils.java ## @@ -45,6 +46,51 @@ */ public

[jira] [Commented] (HTTPCLIENT-1968) Encoded forward slashes are not preserved when rewriting URI

2019-02-16 Thread Cservenak, Tamas (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770058#comment-16770058 ] Cservenak, Tamas commented on HTTPCLIENT-1968: -- [~kullfar] There is ongoing work to

[GitHub] ok2c opened a new pull request #138: Test code improvement

2019-02-16 Thread GitBox
ok2c opened a new pull request #138: Test code improvement URL: https://github.com/apache/httpcomponents-client/pull/138 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] ok2c merged pull request #138: Test code improvement

2019-02-16 Thread GitBox
ok2c merged pull request #138: Test code improvement URL: https://github.com/apache/httpcomponents-client/pull/138 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] ok2c commented on issue #136: HTTPCLIENT-1968

2019-02-16 Thread GitBox
ok2c commented on issue #136: HTTPCLIENT-1968 URL: https://github.com/apache/httpcomponents-client/pull/136#issuecomment-464343182 @cstamas It turned out this change-set had broken backward compatibility with 4.4. Fixed with c7985395635cbc7bd630abb4204534536cbdf8ce.

Re: HttpClient for Android Question

2019-02-16 Thread Oleg Kalnichevski
On Fri, 2019-02-15 at 20:27 -0600, Oscar Bastidas wrote: > Hello, > > I am getting into Java software development totally developed on my > Android > tablet-no use of a "real" computer. I have noticed that the Java > package I > am using (the ecj compiler on the Termux emulator) doesn't have the

[GitHub] garydgregory opened a new pull request #108: Add a "quiet" option to AsyncReverseProxyExample.

2019-02-16 Thread GitBox
garydgregory opened a new pull request #108: Add a "quiet" option to AsyncReverseProxyExample. URL: https://github.com/apache/httpcomponents-core/pull/108 This is an automated message from the Apache Git Service. To respond

Re: HttpCore 5.0 BETA7?

2019-02-16 Thread Gary Gregory
On Fri, Feb 15, 2019 at 5:31 PM Oleg Kalnichevski wrote: > On Fri, 2019-02-15 at 16:06 -0500, Gary Gregory wrote: > > On Wed, Feb 6, 2019 at 7:49 PM Gary Gregory > > wrote: > > > > > Oleg and all: > > > > > > Would you please take a look > > > at > > >

[GitHub] cstamas commented on issue #136: HTTPCLIENT-1968

2019-02-16 Thread GitBox
cstamas commented on issue #136: HTTPCLIENT-1968 URL: https://github.com/apache/httpcomponents-client/pull/136#issuecomment-464349249 Ouch! Yes, i forgot to provide subst/old signature method for this.. Tx This is an

[GitHub] ok2c commented on issue #108: Add a "quiet" option to AsyncReverseProxyExample.

2019-02-16 Thread GitBox
ok2c commented on issue #108: Add a "quiet" option to AsyncReverseProxyExample. URL: https://github.com/apache/httpcomponents-core/pull/108#issuecomment-464349357 @garydgregory Looks OK to me. You still might to keep the PR open for a while in case you decide to re-work some of your