[GitHub] [httpcomponents-core] ufolr commented on issue #195: Fix CharArrayBuffer.subSequence(beganIndex, endIndex) to return right result.

ufolr commented on issue #195: Fix CharArrayBuffer.subSequence(beganIndex,endIndex) to return right result. URL: https://github.com/apache/httpcomponents-core/pull/195#issuecomment-615688514 @ok2c Yep. I saw that performance waste of performance. So I make **CharArrayBuffer** can reuse

[GitHub] [httpcomponents-core] ufolr edited a comment on issue #195: Fix CharArrayBuffer.subSequence(beganIndex, endIndex) to return right result.

ufolr edited a comment on issue #195: Fix CharArrayBuffer.subSequence(beganIndex,endIndex) to return right result. URL: https://github.com/apache/httpcomponents-core/pull/195#issuecomment-615688514 @ok2c Yep. I saw that performance waste of performance. So I make **CharArrayBuffer** can

[GitHub] [httpcomponents-core] ok2c commented on issue #195: Fix CharArrayBuffer.subSequence(beganIndex, endIndex) to return right result.

ok2c commented on issue #195: Fix CharArrayBuffer.subSequence(beganIndex,endIndex) to return right result. URL: https://github.com/apache/httpcomponents-core/pull/195#issuecomment-615873724 @ufolr Cool! Many thanks for contributing the fix!

[GitHub] [httpcomponents-core] ok2c merged pull request #195: Fix CharArrayBuffer.subSequence(beganIndex, endIndex) to return right result.

ok2c merged pull request #195: Fix CharArrayBuffer.subSequence(beganIndex,endIndex) to return right result. URL: https://github.com/apache/httpcomponents-core/pull/195 This is an automated message from the Apache Git

[jira] [Commented] (HTTPCORE-627) URIBuilder::Adding query parameters result in removing the scheme specific part of an URI

[ https://issues.apache.org/jira/browse/HTTPCORE-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086410#comment-17086410 ] Oleg Kalnichevski commented on HTTPCORE-627: [~torstenr] This is what RFC 2396 section 3

[jira] [Created] (HTTPCORE-628) URIBuilder:: query parameters are encoded differently compared to java.lang.URI

Torsten Rendelmann created HTTPCORE-628: --- Summary: URIBuilder:: query parameters are encoded differently compared to java.lang.URI Key: HTTPCORE-628 URL: https://issues.apache.org/jira/browse/HTTPCORE-628

[GitHub] [httpcomponents-core] ok2c commented on issue #195: Fix CharArrayBuffer.subSequence(beganIndex, endIndex) to return right result.

ok2c commented on issue #195: Fix CharArrayBuffer.subSequence(beganIndex,endIndex) to return right result. URL: https://github.com/apache/httpcomponents-core/pull/195#issuecomment-615801608 @ufolr I am sorry but this is too much so that "sub noodle could be a noodle". Let's just fix the

[GitHub] [httpcomponents-core] ufolr edited a comment on issue #195: Fix CharArrayBuffer.subSequence(beganIndex, endIndex) to return right result.

ufolr edited a comment on issue #195: Fix CharArrayBuffer.subSequence(beganIndex,endIndex) to return right result. URL: https://github.com/apache/httpcomponents-core/pull/195#issuecomment-615688514 @ok2c Yep. I saw that waste of performance. So I make **CharArrayBuffer** can reuse the

[GitHub] [httpcomponents-core] ufolr edited a comment on issue #195: Fix CharArrayBuffer.subSequence(beganIndex, endIndex) to return right result.

ufolr edited a comment on issue #195: Fix CharArrayBuffer.subSequence(beganIndex,endIndex) to return right result. URL: https://github.com/apache/httpcomponents-core/pull/195#issuecomment-615688514 @ok2c Yep. I saw that waste of performance. So I make **CharArrayBuffer** can reuse the

[jira] [Created] (HTTPCORE-627) URIBuilder::Adding query parameters result in removing the scheme specific part of an URI

Torsten Rendelmann created HTTPCORE-627: --- Summary: URIBuilder::Adding query parameters result in removing the scheme specific part of an URI Key: HTTPCORE-627 URL:

[jira] [Commented] (HTTPASYNC-160) InternalHttpAsyncClient doesn't close gracefully

[ https://issues.apache.org/jira/browse/HTTPASYNC-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086401#comment-17086401 ] Oleg Kalnichevski commented on HTTPASYNC-160: - [~altaiezior] Please review the proposed

[GitHub] [httpcomponents-core] ufolr commented on issue #195: Fix CharArrayBuffer.subSequence(beganIndex, endIndex) to return right result.

ufolr commented on issue #195: Fix CharArrayBuffer.subSequence(beganIndex,endIndex) to return right result. URL: https://github.com/apache/httpcomponents-core/pull/195#issuecomment-615839174 > @ufolr I am sorry but this is too much so that "sub noodle could be a noodle". Let's just fix

[jira] [Commented] (HTTPASYNC-160) InternalHttpAsyncClient doesn't close gracefully

[ https://issues.apache.org/jira/browse/HTTPASYNC-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086587#comment-17086587 ] Oleg Kalnichevski commented on HTTPASYNC-160: - [~altaiezior] Please review

[jira] [Commented] (HTTPASYNC-160) InternalHttpAsyncClient doesn't close gracefully

[ https://issues.apache.org/jira/browse/HTTPASYNC-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086565#comment-17086565 ] Anurag Agarwal commented on HTTPASYNC-160: -- This should work fine, few review comments: 1.

[jira] [Commented] (HTTPASYNC-160) InternalHttpAsyncClient doesn't close gracefully

[ https://issues.apache.org/jira/browse/HTTPASYNC-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086590#comment-17086590 ] Anurag Agarwal commented on HTTPASYNC-160: -- Just one thing, that since now it will go in the

[jira] [Commented] (HTTPASYNC-160) InternalHttpAsyncClient doesn't close gracefully

[ https://issues.apache.org/jira/browse/HTTPASYNC-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086592#comment-17086592 ] Oleg Kalnichevski commented on HTTPASYNC-160: - > Just one thing, that since now it will go

[jira] [Commented] (HTTPASYNC-160) InternalHttpAsyncClient doesn't close gracefully

[ https://issues.apache.org/jira/browse/HTTPASYNC-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086588#comment-17086588 ] Anurag Agarwal commented on HTTPASYNC-160: -- (y) > InternalHttpAsyncClient doesn't close

[jira] [Resolved] (HTTPASYNC-160) InternalHttpAsyncClient doesn't close gracefully

[ https://issues.apache.org/jira/browse/HTTPASYNC-160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski resolved HTTPASYNC-160. - Fix Version/s: HttpClient 5.0 4.1.5 Resolution:

[jira] [Commented] (HTTPCORE-628) URIBuilder:: query parameters are encoded differently compared to java.lang.URI

[ https://issues.apache.org/jira/browse/HTTPCORE-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086459#comment-17086459 ] ASF subversion and git services commented on HTTPCORE-628: -- Commit

[jira] [Commented] (HTTPCORE-627) URIBuilder::Adding query parameters result in removing the scheme specific part of an URI

[ https://issues.apache.org/jira/browse/HTTPCORE-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086498#comment-17086498 ] Michael Osipov commented on HTTPCORE-627: - [~olegk], I wouldn't. Unless RFC 3986 mandates it

[jira] [Comment Edited] (HTTPCORE-627) URIBuilder::Adding query parameters result in removing the scheme specific part of an URI

[ https://issues.apache.org/jira/browse/HTTPCORE-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086498#comment-17086498 ] Michael Osipov edited comment on HTTPCORE-627 at 4/18/20, 3:31 PM: ---

[jira] [Commented] (HTTPCORE-627) URIBuilder::Adding query parameters result in removing the scheme specific part of an URI

[ https://issues.apache.org/jira/browse/HTTPCORE-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086508#comment-17086508 ] Torsten Rendelmann commented on HTTPCORE-627: - Think [~michael-o] is right: I was lead to

[jira] [Commented] (HTTPCORE-627) URIBuilder::Adding query parameters result in removing the scheme specific part of an URI

[ https://issues.apache.org/jira/browse/HTTPCORE-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086511#comment-17086511 ] Oleg Kalnichevski commented on HTTPCORE-627: [~michael-o] Agreed. As far as the name goes

[jira] [Updated] (HTTPCORE-627) URIBuilder::Adding query parameters result in removing the scheme specific part of an URI

[ https://issues.apache.org/jira/browse/HTTPCORE-627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski updated HTTPCORE-627: --- Fix Version/s: (was: Future) 5.1 Issue Type:

[jira] [Commented] (HTTPCORE-627) URIBuilder::Adding query parameters result in removing the scheme specific part of an URI

[ https://issues.apache.org/jira/browse/HTTPCORE-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086513#comment-17086513 ] Oleg Kalnichevski commented on HTTPCORE-627: [~torstenr] We will happily take a PR at

[jira] [Commented] (HTTPCORE-628) URIBuilder:: query parameters are encoded differently compared to java.lang.URI

[ https://issues.apache.org/jira/browse/HTTPCORE-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086460#comment-17086460 ] Oleg Kalnichevski commented on HTTPCORE-628: [~torstenr] Please review

[jira] [Commented] (HTTPCORE-628) URIBuilder:: query parameters are encoded differently compared to java.lang.URI

[ https://issues.apache.org/jira/browse/HTTPCORE-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086663#comment-17086663 ] Torsten Rendelmann commented on HTTPCORE-628: - yeah, cool. Thanks - looks good to me. >