Re: HC 5.0 scope and design decisions

2016-09-30 Thread Julian Sedding
Hi all I am not familiar with log4j2, but have used slf4j extensively over the last years. As I understand log4j2 clearly separates its API from the implementation. If this is true, are there any major benefits to using the log4j2 API over the slf4j API? If this is not the case, and the

Re: Collaborate implementing HTTP 2.0 support - HTTPCORE-432

2016-11-22 Thread Julian Sedding
It may be worthwhile to check out WireMock[0]. It allows setting up a lightweight mock server designed for unit testing. Regards Julian [0] http://wiremock.org On Tuesday, November 22, 2016, Gary Gregory > wrote:

Re: One Git repo per major version

2017-05-15 Thread Julian Sedding
I am in favour of using a single repository and branches (with a clean convention). Having a repo per version IMHO sends the wrong message, namely that the new version is completely different. Again IMHO, we should strive to improve our backwards compatibility with version 6.x (with regard to

Re: Do not commit to HttpCore SVN!

2017-05-15 Thread Julian Sedding
Force pushing is considered a bad practice in Git for good reasons, thus rewriting history of published branches is IMHO a no-go. It makes everybody's life harder (and developers less experienced with Git may not be able to integrate the rewritten history at all). Don't get me wrong. I do a lot

Re: One Git repo per major version

2017-05-15 Thread Julian Sedding
Hi Oleg On Mon, May 15, 2017 at 11:06 AM, Oleg Kalnichevski <ol...@apache.org> wrote: > On Mon, 2017-05-15 at 10:09 +0200, Julian Sedding wrote: >> I am in favour of using a single repository and branches (with a >> clean >> convention). Having a repo per version I

Re: Git policies and practices / of tendency for good intentions to turn into s..t

2017-05-17 Thread Julian Sedding
Hi Oleg and Michael I understand your frustration with a messy commit log. Personally I strive to give context so that the commit can more easily be understood. Normally that includes a JIRA ID and the title. There are cases where I prefer to have several commits for one JIRA, but only if the

Re: Git policies and practices / of tendency for good intentions to turn into s..t

2017-05-19 Thread Julian Sedding
Hi Michael On Wed, May 17, 2017 at 10:57 AM, Michael Osipov <micha...@apache.org> wrote: > Hi Julian, > > Am 2017-05-17 um 09:30 schrieb Julian Sedding: >> >> Hi Oleg and Michael >> >> I understand your frustration with a messy commit log. >&

Re: HttpCore / HttpClient fully migrated to Git

2017-05-19 Thread Julian Sedding
Thanks Oleg for taking care of the migration to Git! I have no strong opinion regarding the repos, just a slight preference to keep it simple: httpcomponents-project. Regards Julian On Wed, May 17, 2017 at 3:53 PM, Oleg Kalnichevski wrote: > Folks > > HttpCore / HttpClient

Re: Git policies and practices

2017-05-19 Thread Julian Sedding
Hi Oleg As I explained in the thread branched from this one, I fear that rewriting public history will irritate/alienate potential contributors as well as existing committers. In my opinion deterring contributors is a hefty price to pay in order to satisfy your desire for an immaculate public

Re: Git policies and practices

2017-05-19 Thread Julian Sedding
On Fri, May 19, 2017 at 3:30 PM, Oleg Kalnichevski <ol...@apache.org> wrote: > On Fri, 2017-05-19 at 15:14 +0200, Julian Sedding wrote: >> Hi Oleg >> >> As I explained in the thread branched from this one, I fear that >> rewriting public history will irritate/a

Re: Limiting the blast radius of connection leaks

2020-08-04 Thread Julian Sedding
Hi I don't know if Java's "reachability" of responses would be a good indicator for when a connection has erroneously not been returned to a pool. If that is the case (and the stated memory leak makes me think it might be), then the below information may be helpful. I'll share some (positive)

Re: Time to say goodbye to Clirr; Re: Upgrade 5.1 branches to Java 1.8

2020-12-05 Thread Julian Sedding
I'm not familiar with Clirr, but I think the "bnd-baseline-maven-plugin" does something similar. It's geared towards OSGi bundles, but may work with regular jars as well. It compares two OSGi bundles (or jar files) and reports API changes classified according to semantic versioning rules. I'm

[jira] [Commented] (HTTPCLIENT-1811) Security : Authorization header should not be printed in debug log

2017-02-01 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848608#comment-15848608 ] Julian Sedding commented on HTTPCLIENT-1811: I'm against swallowing the header value

[jira] [Created] (HTTPCLIENT-1813) [OSGi] ServiceRegistration properties of OSGiProxyConfiguration not updated

2017-02-09 Thread Julian Sedding (JIRA)
Julian Sedding created HTTPCLIENT-1813: -- Summary: [OSGi] ServiceRegistration properties of OSGiProxyConfiguration not updated Key: HTTPCLIENT-1813 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1813

[jira] [Created] (HTTPCLIENT-1777) [OSGi] remove duplication between OSGiClientBuilderFactory and OSGiCachingClientBuilderFactory

2016-10-04 Thread Julian Sedding (JIRA)
Julian Sedding created HTTPCLIENT-1777: -- Summary: [OSGi] remove duplication between OSGiClientBuilderFactory and OSGiCachingClientBuilderFactory Key: HTTPCLIENT-1777 URL: https://issues.apache.org/jira

[jira] [Resolved] (HTTPCLIENT-1777) [OSGi] remove duplication between OSGiClientBuilderFactory and OSGiCachingClientBuilderFactory

2016-10-04 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding resolved HTTPCLIENT-1777. Resolution: Fixed Fix Version/s: 5.0 Alpha2 4.5.3

[jira] [Resolved] (HTTPCLIENT-1778) [OSGi] simplify handling of ManagedService based configurations

2016-10-04 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding resolved HTTPCLIENT-1778. Resolution: Fixed Fix Version/s: 5.0 Alpha2 4.5.3

[jira] [Closed] (HTTPCLIENT-1778) [OSGi] simplify handling of ManagedService based configurations

2016-10-04 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding closed HTTPCLIENT-1778. -- > [OSGi] simplify handling of ManagedService based configurati

[jira] [Created] (HTTPCLIENT-1778) [OSGi] simplify handling of ManagedService based configurations

2016-10-04 Thread Julian Sedding (JIRA)
Julian Sedding created HTTPCLIENT-1778: -- Summary: [OSGi] simplify handling of ManagedService based configurations Key: HTTPCLIENT-1778 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1778

[jira] [Updated] (HTTPCLIENT-1778) [OSGi] simplify handling of ManagedService based configurations

2016-10-04 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding updated HTTPCLIENT-1778: --- Description: The handling of both the {{ProxyConfigurations

[jira] [Closed] (HTTPCLIENT-1777) [OSGi] remove duplication between OSGiClientBuilderFactory and OSGiCachingClientBuilderFactory

2016-10-04 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding closed HTTPCLIENT-1777. -- > [OSGi] remove duplication between OSGiClientBuilderFact

[jira] [Closed] (HTTPCLIENT-1782) [OSGi] List of tracked HTTPClients is mutable but not thread-safe

2016-10-04 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding closed HTTPCLIENT-1782. -- > [OSGi] List of tracked HTTPClients is mutable but not thread-s

[jira] [Resolved] (HTTPCLIENT-1782) [OSGi] List of tracked HTTPClients is mutable but not thread-safe

2016-10-04 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding resolved HTTPCLIENT-1782. Resolution: Fixed Fixed in {{trunk}} in [r1763285|https://svn.apache.org

[jira] [Resolved] (HTTPCLIENT-1779) [OSGi] support NTLM proxy authentication

2016-10-04 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding resolved HTTPCLIENT-1779. Resolution: Fixed Fix Version/s: 5.0 Alpha2 4.5.3

[jira] [Created] (HTTPCLIENT-1781) [OSGi] OSGiTrustedHostsConfiguration is mutable but not thread-safe

2016-10-04 Thread Julian Sedding (JIRA)
Julian Sedding created HTTPCLIENT-1781: -- Summary: [OSGi] OSGiTrustedHostsConfiguration is mutable but not thread-safe Key: HTTPCLIENT-1781 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1781

[jira] [Created] (HTTPCLIENT-1782) [OSGi] List of tracked HTTPClients is mutable but not thread-safe

2016-10-04 Thread Julian Sedding (JIRA)
Julian Sedding created HTTPCLIENT-1782: -- Summary: [OSGi] List of tracked HTTPClients is mutable but not thread-safe Key: HTTPCLIENT-1782 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1782

[jira] [Closed] (HTTPCLIENT-1779) [OSGi] support NTLM proxy authentication

2016-10-04 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding closed HTTPCLIENT-1779. -- > [OSGi] support NTLM proxy authenticat

[jira] [Created] (HTTPCLIENT-1780) [OSGi] ProxyConfiguration is mutable but not thread-safe

2016-10-04 Thread Julian Sedding (JIRA)
Julian Sedding created HTTPCLIENT-1780: -- Summary: [OSGi] ProxyConfiguration is mutable but not thread-safe Key: HTTPCLIENT-1780 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1780 Project

[jira] [Created] (HTTPCLIENT-1770) [OSGi] metatype for org.apache.http.proxyconfigurator missing factoryPid

2016-09-22 Thread Julian Sedding (JIRA)
Julian Sedding created HTTPCLIENT-1770: -- Summary: [OSGi] metatype for org.apache.http.proxyconfigurator missing factoryPid Key: HTTPCLIENT-1770 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1770

[jira] [Created] (HTTPCLIENT-1771) [OSGi] improve webconsole display for org.apache.http.proxyconfigurator

2016-09-22 Thread Julian Sedding (JIRA)
Julian Sedding created HTTPCLIENT-1771: -- Summary: [OSGi] improve webconsole display for org.apache.http.proxyconfigurator Key: HTTPCLIENT-1771 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1771

[jira] [Updated] (HTTPCLIENT-1771) [OSGi] improve webconsole display for org.apache.http.proxyconfigurator

2016-09-22 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding updated HTTPCLIENT-1771: --- Attachment: before.png after.png HTTPCLIENT-1771

[jira] [Updated] (HTTPCLIENT-1770) [OSGi] metatype for org.apache.http.proxyconfigurator missing factoryPid

2016-09-22 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding updated HTTPCLIENT-1770: --- Attachment: HTTPCLIENT-1770-jsedding.patch Attached patch fixes the issue

[jira] [Updated] (HTTPCLIENT-1773) [OSGi] HttpProxyConfigurationActivator does not unregister HttpClientBuilderFactory

2016-09-27 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding updated HTTPCLIENT-1773: --- Attachment: (was: HTTPCLIENT-1773-jsedding.patch) > [O

[jira] [Created] (HTTPCLIENT-1772) [OSGi] WeakList needs to support "clear" method

2016-09-27 Thread Julian Sedding (JIRA)
Julian Sedding created HTTPCLIENT-1772: -- Summary: [OSGi] WeakList needs to support "clear" method Key: HTTPCLIENT-1772 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1772

[jira] [Updated] (HTTPCLIENT-1773) [OSGi] HttpProxyConfigurationActivator does not unregister HttpClientBuilderFactory

2016-09-27 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding updated HTTPCLIENT-1773: --- Attachment: HTTPCLIENT-1773-jsedding.patch Replaced the patch. I noticed I had

[jira] [Created] (HTTPCLIENT-1773) [OSGi] HttpProxyConfigurationActivator does not unregister HttpClientBuilderFactory

2016-09-27 Thread Julian Sedding (JIRA)
Julian Sedding created HTTPCLIENT-1773: -- Summary: [OSGi] HttpProxyConfigurationActivator does not unregister HttpClientBuilderFactory Key: HTTPCLIENT-1773 URL: https://issues.apache.org/jira/browse

[jira] [Updated] (HTTPCLIENT-1773) [OSGi] HttpProxyConfigurationActivator does not unregister HttpClientBuilderFactory

2016-09-30 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding updated HTTPCLIENT-1773: --- Assignee: Julian Sedding Affects Version/s: (was: 5.0 Alpha1

[jira] [Resolved] (HTTPCLIENT-1773) [OSGi] HttpProxyConfigurationActivator does not unregister HttpClientBuilderFactory

2016-09-30 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding resolved HTTPCLIENT-1773. Resolution: Fixed Fix Version/s: 4.5.3 Fixed in 4.5.x [r1762930|https

[jira] [Comment Edited] (HTTPCLIENT-1773) [OSGi] HttpProxyConfigurationActivator does not unregister HttpClientBuilderFactory

2016-09-30 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15536393#comment-15536393 ] Julian Sedding edited comment on HTTPCLIENT-1773 at 9/30/16 4:24 PM

[jira] [Created] (HTTPCLIENT-1775) [OSGi] Proxy Configuration PID changed between 4.x and 5.x branches

2016-09-30 Thread Julian Sedding (JIRA)
Julian Sedding created HTTPCLIENT-1775: -- Summary: [OSGi] Proxy Configuration PID changed between 4.x and 5.x branches Key: HTTPCLIENT-1775 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1775

[jira] [Updated] (HTTPCLIENT-1772) [OSGi] WeakList needs to support "clear" method

2016-09-27 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding updated HTTPCLIENT-1772: --- Attachment: HTTPCLIENT-1772-jsedding.patch The patch [^HTTPCLIENT-1772

[jira] [Updated] (HTTPCLIENT-1773) [OSGi] HttpProxyConfigurationActivator does not unregister HttpClientBuilderFactory

2016-09-27 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding updated HTTPCLIENT-1773: --- Attachment: HTTPCLIENT-1773-jsedding.patch The attached patch [^HTTPCLIENT-1773

[jira] [Closed] (HTTPCLIENT-1771) [OSGi] improve webconsole display for org.apache.http.proxyconfigurator

2016-09-27 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding closed HTTPCLIENT-1771. -- Thank you very much [~olegk] for the quick resolution! I tested a local build

[jira] [Resolved] (HTTPCLIENT-1772) [OSGi] WeakList needs to support "clear" method

2016-09-30 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding resolved HTTPCLIENT-1772. Resolution: Fixed Fix Version/s: 5.0 Alpha2 4.5.3

[jira] [Closed] (HTTPCLIENT-1772) [OSGi] WeakList needs to support "clear" method

2016-09-30 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding closed HTTPCLIENT-1772. -- > [OSGi] WeakList needs to support "clear

[jira] [Assigned] (HTTPCLIENT-1772) [OSGi] WeakList needs to support "clear" method

2016-09-30 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding reassigned HTTPCLIENT-1772: -- Assignee: Julian Sedding > [OSGi] WeakList needs to support &qu

[jira] [Assigned] (HTTPCLIENT-1787) OSGiHttpRoutePlanner should leverage target scheme while building proxy-ed uri

2016-11-11 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding reassigned HTTPCLIENT-1787: -- Assignee: Julian Sedding > OSGiHttpRoutePlanner should leverage tar

[jira] [Commented] (HTTPCLIENT-1787) OSGiHttpRoutePlanner should leverage target scheme while building proxy-ed uri

2016-11-11 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15656492#comment-15656492 ] Julian Sedding commented on HTTPCLIENT-1787: [~srbhatna] Thanks for your report. If I

[jira] [Resolved] (HTTPCLIENT-1791) Proxy exceptions not honoured in HttpClient-osgi module

2016-12-06 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding resolved HTTPCLIENT-1791. Resolution: Duplicate This looks like a duplicate of HTTPCLIENT-1710

[jira] [Updated] (HTTPCLIENT-1864) [OSGi] Allow to configure the OSGi client default timeouts

2017-08-02 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding updated HTTPCLIENT-1864: --- Labels: (was: stuck volunteers-wanted) > [OSGi] Allow to configure the O

[jira] [Commented] (HTTPCLIENT-1864) [OSGi] Allow to configure the OSGi client default timeouts

2017-08-02 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1641#comment-1641 ] Julian Sedding commented on HTTPCLIENT-1864: [~marett] I have an experimental bundle

[jira] [Assigned] (HTTPCLIENT-1864) [OSGi] Allow to configure the OSGi client default timeouts

2017-08-02 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding reassigned HTTPCLIENT-1864: -- Assignee: Julian Sedding > [OSGi] Allow to configure the OSGi cli

[jira] [Resolved] (HTTPCLIENT-1787) OSGiHttpRoutePlanner should leverage target scheme while building proxy-ed uri

2017-05-02 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding resolved HTTPCLIENT-1787. Resolution: Cannot Reproduce Closing this as there was no reply to clarify