[GitHub] httpclient pull request: Being able to inject RequestConfig with C...

2015-02-27 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpclient/pull/27#issuecomment-76464277 Committed to SVN trunk http://svn.apache.org/r1662807 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] httpclient pull request: Being able to inject RequestConfig with C...

2015-02-28 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpclient/pull/27#issuecomment-76522716 Yes, please do so. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] httpclient pull request: Provide convenience functions for constru...

2015-03-13 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpclient/pull/29#issuecomment-79344099 I committed your changes to SVN trunk with some minor tweaks http://svn.apache.org/r1666565 Please review. --- If your project is set up for it, you

[GitHub] httpcore pull request: Reuse of SessionInputBuffer and SessionOutp...

2015-03-19 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpcore/pull/9#issuecomment-83630948 What number in percent are we looking at? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] httpcore pull request: Reuse of SessionInputBuffer and SessionOutp...

2015-03-19 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpcore/pull/9#issuecomment-83640151 Thread locals are really a double-edged sword and should be used sparingly in low level libraries. Can we provide a strategy interface similar to

[GitHub] httpasyncclient pull request: Add dnsResolver in HttpAsyncClientBu...

2015-04-29 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpasyncclient/pull/3#issuecomment-97368843 Committed to SVN trunk http://svn.apache.org/viewvc?view=revision&revision=1676697 http://svn.apache.org/viewvc?view=revision&revision=1676698 ---

[GitHub] httpclient pull request: Fix regression in FileBody constructor

2015-05-27 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpclient/pull/30#issuecomment-105929690 Committed to SVN trunk and 4.5.x branch. Oleg --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] httpclient pull request: Fix regression in FileBody constructor

2015-05-27 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpclient/pull/30#issuecomment-105947434 Likely within two weeks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] httpcore pull request: Enable https protocol for TestHttpsAsyncTim...

2015-06-03 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpcore/pull/10#issuecomment-108560258 Committed to SVN and 4.4.x branch http://svn.apache.org/r1683402 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] httpclient pull request: Cache request line in HttpRequestWrapper

2015-06-04 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpclient/pull/32#issuecomment-108767608 Committed to SVN trunk and 4.5.x branch. http://svn.apache.org/r1683475 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] httpclient pull request: HTTPCLIENT-1673: revert change, which was...

2015-08-16 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpclient/pull/34#issuecomment-131556296 Changes committed to SVN trunk and 4.5.x branch. Many thanks, Benson, for contributing them. --- If your project is set up for it, you can reply to this email and have

[GitHub] httpclient pull request: HTTPCLIENT-1673: revert change, which was...

2015-08-17 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpclient/pull/34#issuecomment-131831413 Hi Benson, There turned out to be a complication with the patch. It looks like some of the dependencies introduced by the patch required Java 1.7 or newer. Ideally

[GitHub] httpcore pull request: Httpcore-405: osgi tests

2015-08-25 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpcore/pull/11#issuecomment-134546155 Patch committed to SVN trunk and 4.4.x branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] httpclient pull request: URIBuilder extended for new method for em...

2015-08-25 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpclient/pull/35#issuecomment-134549644 Sebastian We cannot commit this patch to 4.5.x due to its changing the API signature of URIBuilder. There is unlikely to ever be a 4.6 series so this change can be

[GitHub] httpcore pull request: Httpcore-406: more tests

2015-08-26 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpcore/pull/12#issuecomment-135003876 Change-set committed to SVN trunk and 4.4.x branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] httpclient pull request: URIBuilder extended for new method for em...

2015-08-26 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpclient/pull/35#issuecomment-135077944 I am fine with committing the patch to the trunk (5.0). Michael, do you think? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] httpclient pull request: URIBuilder extended for new method for em...

2015-08-27 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpclient/pull/35#issuecomment-135368968 @michael-o Yes, that is the case. URIBuilder has not been reviewed for RFC 3986 conformance. --- If your project is set up for it, you can reply to this email and have

[GitHub] httpcore pull request: HTTPCORE-407: Add a ByteBufferEntity.

2015-08-30 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpcore/pull/13#issuecomment-136124713 Patch committed to SVN trunk http://svn.apache.org/r1700104 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] httpclient pull request: Allow usage of MultipartFormEntity in Htt...

2015-10-12 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpclient/pull/36#issuecomment-147330073 If you want this patch committed to the stable 4.5 branch could you please make your code Java 1.6 compatible and also avoid using * imports? Any development

[GitHub] httpclient pull request: Allow usage of MultipartFormEntity in Htt...

2015-10-13 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpclient/pull/36#issuecomment-147699032 I would add one last thing here. I think it would be reasonable to not attempt to buffer the entity content if it is too large or its length is unknown. I would put a

[GitHub] httpclient pull request: Allow usage of MultipartFormEntity in Htt...

2015-10-14 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpclient/pull/36#issuecomment-147998982 One can always use BufferedHttpEntity to explicitly buffer entities of arbitrary length or explicitly write multipart content out to a byte[]. What I avoid is causing

[GitHub] httpclient pull request: Allow usage of MultipartFormEntity in Htt...

2015-10-21 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpclient/pull/36#issuecomment-149882164 Committed to SVN trunk and 4.5.x branch with some modifications http://svn.apache.org/viewvc?rev=1709814&view=rev --- If your project is set up for it, you

[GitHub] httpcore pull request: HTTPCORE-412 trailers as Header[] and getEx...

2015-11-10 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpcore/pull/17#issuecomment-155397983 DefaultHttpRequestWriter is the wrong place to add headers. This should be done by a protocol interceptor. But I can take from there. --- If your project is set up for

[GitHub] httpcore pull request: HTTPCORE-412 trailers as Header[] and getEx...

2015-11-12 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpcore/pull/17#issuecomment-156049332 Patch with changes committed to SVN trunk http://svn.apache.org/viewvc?rev=1713993&view=rev --- If your project is set up for it, you can reply to this email and

[GitHub] httpclient pull request: Set socker buffer send/receive sizes from...

2015-12-16 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpclient/pull/37#issuecomment-165163769 Committed with changes to SVN trunk and 4.5.x branch http://svn.apache.org/viewvc?rev=1720386&view=rev --- If your project is set up for it, you can reply to

[GitHub] httpcore pull request: Http PATCH method implemented

2015-12-18 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpcore/pull/18#issuecomment-165787792 Committed to SVN trunk and 4.4.x branch http://svn.apache.org/viewvc?rev=1720791&view=rev --- If your project is set up for it, you can reply to this email and

[GitHub] httpclient pull request: String format fix

2015-12-22 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpclient/pull/38#issuecomment-166608233 Committed to SVN trunk and 4.5.x branch http://svn.apache.org/viewvc?rev=1721386&view=rev --- If your project is set up for it, you can reply to this email and

[GitHub] httpclient pull request: HTTPCLIENT-1710 - fixes - examine all exc...

2016-01-02 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpclient/pull/41#issuecomment-168395979 Committed to SVN trunk and 4.5.x branch. http://svn.apache.org/viewvc?rev=1722632&view=rev --- If your project is set up for it, you can reply to this email

[GitHub] httpclient pull request: Add DNSResolver to HttpClientBuilder

2016-01-26 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpclient/pull/44#issuecomment-174970078 There will be no more releases from 4.3.x branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] httpclient pull request: Add DNSResolver to HttpClientBuilder

2016-01-26 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpclient/pull/43#issuecomment-174970186 There will be no more releases from 4.4.x branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] httpclient pull request: make constructor of Content public

2016-02-05 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpclient/pull/45#issuecomment-180428386 I am certainly fine with it, but we ought not add new methods to stable branches like 4.5.x. Trunk is a whole different story. --- If your project is set up for

[GitHub] httpcore pull request: Fix race condition in org.apache.http.nio.p...

2016-02-07 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpcore/pull/21#issuecomment-181090412 Good catch. I'll review and commit the patch in the coming days. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] httpcore pull request: Fix race condition in org.apache.http.nio.p...

2016-02-15 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpcore/pull/21#issuecomment-184227762 Dmitry, Curiously enough I had to fix a very similar race condition not that long ago. See 4c5947e4913c983b905d9d79db123a5b900a8b9a. Would you be OK with a

[GitHub] httpclient pull request: HTTPCLIENT-1718 and HTTPCLIENT-1719 chang...

2016-02-15 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpclient/pull/46#issuecomment-184228986 @enenum Is 967056f necessary? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] httpclient pull request: HTTPCLIENT-1718 and HTTPCLIENT-1719 chang...

2016-02-15 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpclient/pull/46#issuecomment-184230864 @enenum Essentially, I should only merge 8ac1fe5? Please confirm. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] httpcore pull request: Fix race condition in org.apache.http.nio.p...

2016-02-15 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpcore/pull/21#issuecomment-184235584 Wonderful. I'll commit the fix to the ASF repository once I get your confirmation. --- If your project is set up for it, you can reply to this email and have your

[GitHub] httpcore pull request: Fix race condition in org.apache.http.nio.p...

2016-02-17 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpcore/pull/21#issuecomment-185209079 Committed to SVN trunk and 4.4.x branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] httpclient pull request: HTTPCLIENT-1718 and HTTPCLIENT-1719 chang...

2016-02-17 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpclient/pull/46#issuecomment-185217991 Committed to SVN trunk and 4.5.x branch. Please verify and close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] httpcore pull request: Asymetric number of invocations of onLease/...

2016-03-10 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpcore/pull/22#issuecomment-195036782 @dbantchovski Do you think you could also add a test case for this defect? See src/test/java/org/apache/http/pool/TestConnPool.java --- If your project is set up for it

[GitHub] httpcore pull request: Code quality fix - Collapsible "if" stateme...

2016-03-11 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpcore/pull/25#issuecomment-195361845 The build is currently broken due to style check violations https://builds.apache.org/job/httpcomponents-core-5.x/93/ --- If your project is set up for it, you can

[GitHub] httpcore pull request: Asymetric number of invocations of onLease/...

2016-03-19 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpcore/pull/22#issuecomment-197276005 committed to SVN trunk and 4.4.x branch http://svn.apache.org/viewvc?rev=1735209&view=rev Please review and close. --- If your project is set up for it, you

[GitHub] httpcore pull request: Support 64-bit chunk headers

2016-04-06 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpcore/pull/28#issuecomment-206178824 Patch committed to SVN trunk and 4.4.x branch. Please review and close --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] httpcore pull request: Fixed copy-paste mistake in JavaDoc

2016-04-08 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpcore/pull/29#issuecomment-207440860 Committed to SVN 4.4.x branch http://svn.apache.org/viewvc?rev=1738245&view=rev Please review and close. --- If your project is set up for it, you can repl

[GitHub] httpclient pull request: Allow usage of MultipartFormEntity in Htt...

2016-04-09 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpclient/pull/36#issuecomment-207750257 You are welcome to contribute improved javadocs / documentation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] httpclient pull request: Backport HTTPCLIENT-1685

2016-05-16 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpclient/pull/49#issuecomment-219511546 Committed to SVN 4.4.x branch. Please review and close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] httpclient pull request: Add osgi source manifest

2016-05-16 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpclient/pull/50#issuecomment-219511824 What branch is this patch intended for? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] httpclient pull request: Add osgi source manifest

2016-05-17 Thread ok2c
Github user ok2c commented on the pull request: https://github.com/apache/httpclient/pull/50#issuecomment-219699597 The actual stable branch is 4.5.x [1]. There will be no more releases off 4.4.x branch. [1] https://github.com/apache/httpclient/tree/4.5.x --- If your

[GitHub] httpclient issue #51: Override LaxRedirectStrategy's INSTANCE field

2016-06-03 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/51 Committed to SVN 4.5.x http://svn.apache.org/viewvc?rev=1746752&view=rev Please review and close --- If your project is set up for it, you can reply to this email and have your r

[GitHub] httpclient issue #52: HTTPCLIENT-1748: fix for proxy authentication issue / ...

2016-06-25 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/52 Sebastien What was the reason for changing AuthScope class and including a URL attribute in the auth scope? Based on my reading of the HTTP spec authentication context is defined by the realm of

[GitHub] httpclient issue #52: HTTPCLIENT-1748: fix for proxy authentication issue / ...

2016-06-27 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/52 Sebastien, Nothing should stop you from getting the actual request URI by reading the [HTTP_REQUEST](http://hc.apache.org/httpcomponents-core-4.4.x/httpcore/apidocs/org/apache/http/protocol

[GitHub] httpclient issue #52: HTTPCLIENT-1748: fix for proxy authentication issue / ...

2016-06-28 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/52 I have no problem of what so ever with changing CredentialsProvider in 5.0 if it is justified. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] httpclient issue #52: HTTPCLIENT-1748: fix for proxy authentication issue / ...

2016-06-28 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/52 I have a question. Why cannot you build the URL from AuthScope attributes if effectively you only need the authority part (scheme://host:port)? --- If your project is set up for it, you can reply

[GitHub] httpclient pull request #55: HTTPCLIENT-1748: fix for trunk

2016-07-19 Thread ok2c
Github user ok2c commented on a diff in the pull request: https://github.com/apache/httpclient/pull/55#discussion_r71292523 --- Diff: httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/SystemDefaultCredentialsProvider.java --- @@ -88,35 +93,51 @@ public void

[GitHub] httpclient pull request #56: HTTPCLIENT-1752 - Allow to configure the OSGI c...

2016-07-25 Thread ok2c
Github user ok2c commented on a diff in the pull request: https://github.com/apache/httpclient/pull/56#discussion_r72047002 --- Diff: httpclient5-osgi/src/main/java/org/apache/hc/client5/http/osgi/impl/RelaxedLayeredConnectionSocketFactory.java --- @@ -0,0 +1,101

[GitHub] httpclient issue #58: All services registered in the OSGi service registry p...

2016-08-13 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/58 Committed to SVN 4.5.x branch. Please review and close the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] httpclient issue #57: All services registered in the OSGi service registry p...

2016-08-13 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/57 Committed to SVN trunk. Please review and close the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] httpclient issue #55: HTTPCLIENT-1748: fix for trunk

2016-08-13 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/55 Committed to SVN trunk. Please review and close the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] httpclient issue #52: HTTPCLIENT-1748: fix for proxy authentication issue / ...

2016-08-13 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/52 Obsoleted by #55. Please close --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] httpasyncclient issue #5: fix HttpAsyncMethods.createPost/createPut(URI,byte...

2016-08-28 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpasyncclient/pull/5 Committed to SVN trunk and 4.1.x branch. Please review and close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] httpclient issue #59: Typo in comment

2016-08-28 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/59 Committed to SVN 4.5.x branch. Please review and close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] httpclient issue #60: Support changing system default ProxySelector

2016-08-28 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/60 Committed to SVN trunk and 4.5.x branch. Please review and close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] httpclient issue #61: HTTPCLIENT-1767: Null pointer dereference in EofSensor...

2016-09-13 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/61 Committed to SVN trunk and 4.5.x branch. Please review and close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] httpcore issue #31: (HTTPCLIENT-1759) Contribute new tests that use the in-p...

2016-10-08 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpcore/pull/31 Committed to SVN trunk. Please review and close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] httpcore issue #32: HTTPCORE-439: Basicheader override of equals and hashcod...

2016-12-22 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpcore/pull/32 Committed to SVN trunk with some changes http://svn.apache.org/viewvc?rev=1775588&view=rev Please review and close. --- If your project is set up for it, you can reply to this e

[GitHub] httpcore issue #32: HTTPCORE-439: Basicheader override of equals and hashcod...

2016-12-23 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpcore/pull/32 Committed to SVN trunk URL: http://svn.apache.org/viewvc?rev=1775806&view=rev Please review and close. PS: The 5.0-alpha2 release vote is ongoing. However due to the time of

[GitHub] httpcore issue #33: Minor documentation and formatting changes.

2016-12-23 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpcore/pull/33 Committed to SVN trunk http://svn.apache.org/viewvc?rev=1775805&view=rev Please review and close. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] httpcore issue #34: Restoring documentation removed from testing.framework c...

2016-12-23 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpcore/pull/34 This has certainly nothing to do with your changes. It may not even be a bug. It is conceivable that server was overloaded and the request timed out after 5 seconds. --- If your project is set up

[GitHub] httpcore issue #34: Restoring documentation removed from testing.framework c...

2016-12-23 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpcore/pull/34 I think Gary owns the Travis CI job and only he can trigger job executions. Ignore it for now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] httpclient issue #62: HTTPCLIENT-1800: wrap redirect around retry in execCha...

2017-01-07 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/62 Committed to SVN trunk and 4.5.x branch. Please review and close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] httpcore issue #35: [HTTPCLIENT-1808] Fixing potential overflow for connecti...

2017-01-28 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpcore/pull/35 Fixed in SVN trunk and 4.4.x branch. Please review and close. Oleg --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] httpclient pull request #64: [HTTPCLIENT-1810] URIBuilder.toString() always ...

2017-02-07 Thread ok2c
Github user ok2c commented on a diff in the pull request: https://github.com/apache/httpclient/pull/64#discussion_r99915066 --- Diff: httpclient/src/main/java/org/apache/http/client/utils/URIBuilder.java --- @@ -26,18 +26,18 @@ */ package org.apache.http.client.utils

[GitHub] httpclient pull request #64: [HTTPCLIENT-1810] URIBuilder.toString() always ...

2017-02-07 Thread ok2c
Github user ok2c commented on a diff in the pull request: https://github.com/apache/httpclient/pull/64#discussion_r99915529 --- Diff: httpclient/src/main/java/org/apache/http/client/utils/URIBuilder.java --- @@ -492,8 +492,8 @@ public String toString() { private

[GitHub] httpclient issue #64: [HTTPCLIENT-1810] URIBuilder.toString() always adds '/...

2017-02-08 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/64 Committed to SVN 4.5.x branch. Please review and close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] httpcore issue #37: [HTTPCLIENT-1810] URIBuilder.toString() always adds '/' ...

2017-02-08 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpcore/pull/37 Committed to SVN trunk. Please review and close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] httpclient issue #65: Make some package protected classes public as we need ...

2017-02-22 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/65 +1 to @fxbonnet's comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] httpclient issue #65: Make some package protected classes public as we need ...

2017-02-23 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/65 @pmouawad I'll happily help with the migration (either to 4.5 or 5.0 depending on your preference) but opening up deprecated APIs looks wrong to me. --- If your project is set up for it, yo

[GitHub] httpclient issue #65: Make some package protected classes public as we need ...

2017-02-26 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/65 @pmouawad it is one thing to back-port a fix or a feature that has no API impact but this is a whole different thing to start opening up private methods. It will take a while for 5.0 to mature

[GitHub] httpclient issue #66: CredSSP implementation, NTLM engine reworked

2017-03-11 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/66 Radovan, NTLM used to be legal a legal minefield in the past. I still feel a bit uncomfortable just pulling in code related to Microsoft proprietary protocols without some due diligence. Was

[GitHub] httpclient issue #66: CredSSP implementation, NTLM engine reworked

2017-03-13 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/66 The issue has been discussed with ASF legal ([see LEGAL-80](https://issues.apache.org/jira/browse/LEGAL-80?jql=project%20%3D%20LEGAL%20AND%20text%20~%20NTLM)). Given you are an existing ASF

[GitHub] httpclient issue #66: CredSSP implementation, NTLM engine reworked

2017-03-14 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/66 @DaddyWri Karl, Do you think you could review changes to NTLMScheme and just ignore the rest? We could incorporate those changes if they make sense to you and leave the rest. --- If your project

[GitHub] httpclient issue #66: CredSSP implementation, NTLM engine reworked

2017-03-14 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/66 @DaddyWri I am not feeling comfortable committing code that we are not able to maintain properly and the original contributor is unwilling to put any extra work into. --- If your project is set up

[GitHub] httpclient issue #66: CredSSP implementation, NTLM engine reworked

2017-03-15 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/66 @DaddyWri I leave this patch at your mercy. You are the only person on the project both capable and willing to put some effort into NTLM related code, therefore your opinion matters most. Do not

[GitHub] httpclient issue #66: CredSSP implementation, NTLM engine reworked

2017-03-15 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/66 @semancik Try contributing to a larger ASF project such as CXF that impose _very_ strict style requirements and conformance with static code analysis rules and then come back. HC style check barely

[GitHub] httpclient issue #66: CredSSP implementation, NTLM engine reworked

2017-03-15 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/66 @semancik do not change formatting of existing classes and you will be fine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] httpclient issue #66: CredSSP implementation, NTLM engine reworked

2017-03-15 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/66 @semancik You were politely requested to reformat your code to reduce noise in the change set due to different formatting in order to make the changes easier to understand. This has nothing to do

[GitHub] httpclient issue #66: CredSSP implementation, NTLM engine reworked

2017-03-16 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/66 @DaddyWri Ignore HttpClient 5 entirely for now. Develop your code against 4.5 APIs either on GitHub or on a branch in SVN. I'll merge the changes to trunk once everything is ready. --- If

[GitHub] httpcore issue #38: Adding extra argument support for httpcore5-ab: TimeLimi...

2017-03-18 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpcore/pull/38 Patch committed to SVN trunk. Please review and close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] httpclient issue #28: Httpclient-Win: If the proxy is requesting authenticat...

2017-03-18 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/28 Committed to SVN trunk and 4.5.x branch. Please review and close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] httpclient issue #66: CredSSP implementation, NTLM engine reworked

2017-03-20 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/66 The original change set has been committed to SVN 4.5.x, 4.6.x and trunk (5.0). Please review and close --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] httpcore pull request #40: add a provider parameter in SSLContextBuilder

2017-03-31 Thread ok2c
Github user ok2c commented on a diff in the pull request: https://github.com/apache/httpcore/pull/40#discussion_r109109041 --- Diff: httpcore/src/main/java/org/apache/http/ssl/SSLContextBuilder.java --- @@ -272,6 +274,20 @@ public SSLContext build() throws

[GitHub] httpcore pull request #40: add a provider parameter in SSLContextBuilder

2017-03-31 Thread ok2c
Github user ok2c commented on a diff in the pull request: https://github.com/apache/httpcore/pull/40#discussion_r109145659 --- Diff: httpcore/src/main/java/org/apache/http/ssl/SSLContextBuilder.java --- @@ -272,6 +274,20 @@ public SSLContext build() throws

[GitHub] httpcore issue #41: add a provider parameter in SSLContextBuilder In 5.0 bra...

2017-03-31 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpcore/pull/41 @lujianbo Builders with mutually exclusive settings have been causing a lot of grief in HC 4.x. We are trying to not repeat the same mistake in HC 5.0. I think `#useProvider(String)` could be dropped

[GitHub] httpcore issue #41: add a provider parameter in SSLContextBuilder In 5.0 bra...

2017-03-31 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpcore/pull/41 You can push to the same branch. No need to create a new PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] httpcore issue #41: add a provider parameter in SSLContextBuilder In 5.0 bra...

2017-04-01 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpcore/pull/41 We have already repeatedly violated this policy in 4.4.x, so we might as well do it again, as long as it is just a setter method. --- If your project is set up for it, you can reply to this email and

[GitHub] httpclient issue #73: trunk

2017-04-03 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/73 Committed to SVN trunk, 4.5.x branch and 4.6.x branch. Please review and close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] httpclient issue #73: trunk

2017-04-04 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/73 No immediate plans --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] httpclient issue #74: WIP: OpenTracing integration

2017-04-28 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/74 @pavolloffay I am still working on a redesign of request execution pipeline in my private branch (both classic and async). It will likely take me another week or two to complete. Please just bear

[GitHub] httpclient issue #75: Add Brotli support

2017-05-01 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/75 @pmouawad I am not sure it is a good idea to introduce a hard dependency on an external library for a single decompression codec, especially given it is quite easy to plug it in with

[GitHub] httpclient issue #75: Add Brotli support

2017-05-01 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/75 What we can do is to add org.brotli:dec as an optional dependency (mandatory at compile and optional at runtime) and wire it up _only_ if it is actually on the classpath. Users would need to

[GitHub] httpclient issue #76: Allow to add exec interceptor as the first and the las...

2017-05-09 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpclient/pull/76 Looks good to me. Could you please do the same for the async client builder? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

  1   2   3   4   >