Re: Review Request 65304: HIVE-18513 Query results caching

> On Jan. 29, 2018, 6:26 p.m., Jesús Camacho Rodríguez wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Lines 3699 (patched) > > > > > > Is this the permission for each results directory?

[jira] [Created] (HIVE-18575) ACID properties usage in jobconf is ambiguous for MM tables

Sergey Shelukhin created HIVE-18575: --- Summary: ACID properties usage in jobconf is ambiguous for MM tables Key: HIVE-18575 URL: https://issues.apache.org/jira/browse/HIVE-18575 Project: Hive

Re: Review Request 65276: HIVE-18516

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65276/ --- (Updated Jan. 29, 2018, 11:10 p.m.) Review request for hive, Eugene Koifman

Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65413/ --- Review request for hive and Eugene Koifman. Repository: hive-git Description

Re: Review Request 65342: HIVE-18546

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65342/#review196454 ---

[jira] [Created] (HIVE-18574) LLAP: Ship netty3 as part of LLAP install tarball

Gopal V created HIVE-18574: -- Summary: LLAP: Ship netty3 as part of LLAP install tarball Key: HIVE-18574 URL: https://issues.apache.org/jira/browse/HIVE-18574 Project: Hive Issue Type: Bug

Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf is ambiguous for MM tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65413/ --- (Updated Jan. 29, 2018, 11:12 p.m.) Review request for hive and Eugene

[jira] [Created] (HIVE-18573) Use proper Calcite operator instead of UDFs

slim bouguerra created HIVE-18573: - Summary: Use proper Calcite operator instead of UDFs Key: HIVE-18573 URL: https://issues.apache.org/jira/browse/HIVE-18573 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-18571) stats issue for MM tables

Sergey Shelukhin created HIVE-18571: --- Summary: stats issue for MM tables Key: HIVE-18571 URL: https://issues.apache.org/jira/browse/HIVE-18571 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-18570) ACID IOW implemented using base may delete too much data

Sergey Shelukhin created HIVE-18570: --- Summary: ACID IOW implemented using base may delete too much data Key: HIVE-18570 URL: https://issues.apache.org/jira/browse/HIVE-18570 Project: Hive

[jira] [Created] (HIVE-18572) The record readers; InputFormat needs to be fixed for Tez as it generates 1 split

gurmukh singh created HIVE-18572: Summary: The record readers; InputFormat needs to be fixed for Tez as it generates 1 split Key: HIVE-18572 URL: https://issues.apache.org/jira/browse/HIVE-18572

Re: Review Request 65304: HIVE-18513 Query results caching

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65304/#review196440 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java Lines

Re: Review Request 65356: HIVE-18536 IOW + DP is broken for insert-only ACID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65356/ --- (Updated Jan. 30, 2018, 1:15 a.m.) Review request for hive and Eugene Koifman.

[jira] [Created] (HIVE-18564) Add a mapper to make plan transformations more easily understandable

Zoltan Haindrich created HIVE-18564: --- Summary: Add a mapper to make plan transformations more easily understandable Key: HIVE-18564 URL: https://issues.apache.org/jira/browse/HIVE-18564 Project:

[jira] [Created] (HIVE-18565) Set some timeout to all CliDriver tests

Zoltan Haindrich created HIVE-18565: --- Summary: Set some timeout to all CliDriver tests Key: HIVE-18565 URL: https://issues.apache.org/jira/browse/HIVE-18565 Project: Hive Issue Type:

[jira] [Created] (HIVE-18563) "Load data into table" behavior is different between 1.2.1 and 1.2.1000

Junichi Oda created HIVE-18563: -- Summary: "Load data into table" behavior is different between 1.2.1 and 1.2.1000 Key: HIVE-18563 URL: https://issues.apache.org/jira/browse/HIVE-18563 Project: Hive

Re: Review Request 65353: Create tests to cover getTableMeta method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65353/#review196416 --- Thanks for the patch Adam. I was only be able to come up 1 more

Review Request 65380: HIVE-18566: Create tests to cover adding partitions from PartitionSpec

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65380/ --- Review request for hive, Peter Vary and Adam Szita. Bugs: HIVE-18566

Re: Review Request 65349: HIVE-18544: Create tests to cover methods for appending Partitions

> On Jan. 29, 2018, 11:15 a.m., Adam Szita wrote: > > Thanks for the patch Marta, it looks very thourough! I've added my 2 cents: > > small observations regarding helper methods only. Thanks a lot Adam for the review. > On Jan. 29, 2018, 11:15 a.m., Adam Szita wrote: > >

Re: Review Request 65349: HIVE-18544: Create tests to cover methods for appending Partitions

> On Jan. 26, 2018, 1:53 p.m., Peter Vary wrote: > > Ship It! Thanks a lot Peter for the review. - Marta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65349/#review196338

[jira] [Created] (HIVE-18567) ObjectStore.getPartitionNamesNoTxn doesn't handle max param properly

Adam Szita created HIVE-18567: - Summary: ObjectStore.getPartitionNamesNoTxn doesn't handle max param properly Key: HIVE-18567 URL: https://issues.apache.org/jira/browse/HIVE-18567 Project: Hive

[jira] [Created] (HIVE-18568) Hive doesn't complain about duplicate column unless it is a CTAS query

Siddhant Saraf created HIVE-18568: - Summary: Hive doesn't complain about duplicate column unless it is a CTAS query Key: HIVE-18568 URL: https://issues.apache.org/jira/browse/HIVE-18568 Project: Hive

[jira] [Created] (HIVE-18566) Create tests to cover adding partitions from PartitionSpec

Marta Kuczora created HIVE-18566: Summary: Create tests to cover adding partitions from PartitionSpec Key: HIVE-18566 URL: https://issues.apache.org/jira/browse/HIVE-18566 Project: Hive

Re: Review Request 65349: HIVE-18544: Create tests to cover methods for appending Partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65349/ --- (Updated Jan. 29, 2018, 12:49 p.m.) Review request for hive, Peter Vary and

Re: Review Request 65349: HIVE-18544: Create tests to cover methods for appending Partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65349/#review196418 --- Thanks for the patch Marta, it looks very thourough! I've added

Re: Review Request 65349: HIVE-18544: Create tests to cover methods for appending Partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65349/#review196428 --- Ship it! Ship It! - Adam Szita On Jan. 29, 2018, 12:49

Re: Review Request 65380: HIVE-18566: Create tests to cover adding partitions from PartitionSpec

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65380/#review196431 --- Nice throughout test cases. Thanks Marta! Fix it and ship it!

Long running time for recently added tests in standalone-metastore

With all of the added tests in standalone-metastore/…/client directory, the runtime of ‘mvn test’ in standalone-metastore went from 6 minutes to 26 on my humble laptop. We do not want to get ourselves back where the rest of Hive is; currently Hive developers don’t run the unit tests themselves

Re: Long running time for recently added tests in standalone-metastore

Quite reasonable. +1 On Mon, Jan 29, 2018 at 4:19 PM, Alan Gates wrote: > With all of the added tests in standalone-metastore/…/client directory, the > runtime of ‘mvn test’ in standalone-metastore went from 6 minutes to 26 on > my humble laptop. We do not want to get

Re: Long running time for recently added tests in standalone-metastore

+1 On Mon, Jan 29, 2018 at 4:38 PM, Alexander Kolbasov wrote: > Quite reasonable. > +1 > > On Mon, Jan 29, 2018 at 4:19 PM, Alan Gates wrote: > > > With all of the added tests in standalone-metastore/…/client directory, > the > > runtime of ‘mvn test’

[jira] [Created] (HIVE-18576) Support to read nested complex type with Parquet in vectorization mode

Colin Ma created HIVE-18576: --- Summary: Support to read nested complex type with Parquet in vectorization mode Key: HIVE-18576 URL: https://issues.apache.org/jira/browse/HIVE-18576 Project: Hive

[jira] [Created] (HIVE-18577) SemanticAnalyzer.validate has some pointless metastore calls

Sergey Shelukhin created HIVE-18577: --- Summary: SemanticAnalyzer.validate has some pointless metastore calls Key: HIVE-18577 URL: https://issues.apache.org/jira/browse/HIVE-18577 Project: Hive

[jira] [Created] (HIVE-18579) Changes from HIVE-18495 introduced import paths from shaded jars

Deepesh Khandelwal created HIVE-18579: - Summary: Changes from HIVE-18495 introduced import paths from shaded jars Key: HIVE-18579 URL: https://issues.apache.org/jira/browse/HIVE-18579 Project:

Review Request 65415: HIVE-18571 stats issues for MM tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65415/ --- Review request for hive and Eugene Koifman. Repository: hive-git Description

Re: Review Request 65415: HIVE-18571 stats issues for MM tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65415/#review196500 ---

[jira] [Created] (HIVE-18578) Some class has missed the ASF header

Saijin Huang created HIVE-18578: --- Summary: Some class has missed the ASF header Key: HIVE-18578 URL: https://issues.apache.org/jira/browse/HIVE-18578 Project: Hive Issue Type: Bug

Re: Review Request 65276: HIVE-18516

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65276/#review196499 --- ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Lines

Re: Review Request 65276: HIVE-18516

> On Jan. 30, 2018, 3:09 a.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java > > Lines 3821 (patched) > > > > > > So only non-bucketed ACID tables get the file rename to 00_0

Re: Review Request 65380: HIVE-18566: Create tests to cover adding partitions from PartitionSpec

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65380/#review196430 --- Nice patch with well covered cases. Since this is a lot of test

[jira] [Created] (HIVE-18569) Hive Druid indexing not dealing with decimals in correct way.

Nishant Bangarwa created HIVE-18569: --- Summary: Hive Druid indexing not dealing with decimals in correct way. Key: HIVE-18569 URL: https://issues.apache.org/jira/browse/HIVE-18569 Project: Hive

Re: Review Request 65356: HIVE-18536 IOW + DP is broken for insert-only ACID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65356/#review196437 --- ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java Line

Re: Review Request 65356: HIVE-18536 IOW + DP is broken for insert-only ACID

> On Jan. 29, 2018, 5:13 p.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java > > Line 4077 (original), 4077 (patched) > > > > > > as far as I can tell every call to this

Re: Review Request 65342: HIVE-18546

> On Jan. 29, 2018, 7:23 p.m., Ashutosh Chauhan wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > > Line 1919 (original), 1894 (patched) > > > > > > I wonder whether

Re: Review Request 65342: HIVE-18546

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65342/ --- (Updated Jan. 30, 2018, 6:36 a.m.) Review request for hive and Ashutosh