Review Request 68496: Optimized & cleaned up HBaseQTest runner

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68496/ --- Review request for hive, Marta Kuczora and Peter Vary. Bugs: HIVE-20394

Re: Review Request 68496: Optimized & cleaned up HBaseQTest runner

> On Aug. 24, 2018, 8:17 a.m., Peter Vary wrote: > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreHBaseCliDriver.java > > Line 82 (original), 82 (patched) > > > > > > Since we removed

Re: Review Request 68518: ProxyFileSystem.listStatusIterator function override required once migrated to Hadoop 3.2.0+

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68518/ --- (Updated Aug. 28, 2018, 11:34 a.m.) Review request for hive, Marta Kuczora and

Re: Review Request 68496: Optimized & cleaned up HBaseQTest runner

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68496/ --- (Updated Aug. 28, 2018, 11:33 a.m.) Review request for hive, Zoltan Haindrich,

Re: Review Request 68523: Improve org.apache.hadoop.hive.ql.exec.FunctionTask Experience

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68523/ --- (Updated Aug. 28, 2018, 1:50 p.m.) Review request for hive, Marta Kuczora,

Review Request 68518: ProxyFileSystem.listStatusIterator function override required once migrated to Hadoop 3.2.0+

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68518/ --- Review request for hive, Marta Kuczora and Peter Vary. Bugs: HIVE-20465

Review Request 68523: Improve org.apache.hadoop.hive.ql.exec.FunctionTask Experience

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68523/ --- Review request for hive, Marta Kuczora and Peter Vary. Bugs: HIVE-20466

Review Request 68683: Add new configuration to set the size of the global compile lock

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/ --- Review request for hive, Zoltan Haindrich, Zoltan Haindrich, and Peter Vary.

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69022/ --- (Updated Oct. 15, 2018, 7:21 p.m.) Review request for hive, Sahil Takiar and

Review Request 69022: HIVE-20737: LocalHiveSparkClient.close() and SparkSession.open() race condition fix

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69022/ --- Review request for hive, Sahil Takiar and Adam Szita. Bugs: HIVE-20737

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java > > Line 125 (original), 120 (patched) > > > > > > we might need to re-think how

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/LocalHiveSparkClient.java > > Line 73 (original), 73 (patched) > > > > > > if we expect multiple sessions to

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69022/ --- (Updated Oct. 16, 2018, 4:49 p.m.) Review request for hive, Sahil Takiar and

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java > > Line 352 (original) > > > > > > why remove this? > > denys kuzmenko wrote: >

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java > > Line 352 (original) > > > > > > why remove this? > > denys kuzmenko wrote: >

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java > > Line 125 (original), 120 (patched) > > > > > > we might need to re-think how

Re: Review Request 69022: HIVE-20737: SparkContext is shared between user sessions and should be closed only when there is no active one

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69022/ --- (Updated Oct. 15, 2018, 4:54 p.m.) Review request for hive, Sahil Takiar and

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/LocalHiveSparkClient.java > > Line 73 (original), 73 (patched) > > > > > > if we expect multiple sessions to

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java > > Lines 112-116 (original) > > > > > > do we have unit tests that cover this? >

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java > > Lines 112-116 (original) > > > > > > do we have unit tests that cover this? >

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java > > Line 352 (original) > > > > > > why remove this? > > denys kuzmenko wrote: >

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java > > Line 352 (original) > > > > > > why remove this? > > denys kuzmenko wrote: >

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java > > Line 352 (original) > > > > > > why remove this? > > denys kuzmenko wrote: >

Re: Review Request 69167: HIVE-20796: jdbc URL can contain sensitive information that should not be logged

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69167/#review210088 --- Ship it! Ship It! - Denys Kuzmenko On Oct. 26, 2018, 10:34

Re: Review Request 69167: HIVE-20796: jdbc URL can contain sensitive information that should not be logged

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69167/#review210044 ---

Re: Review Request 69167: HIVE-20796: jdbc URL can contain sensitive information that should not be logged

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69167/#review210045 ---

Re: Review Request 69167: HIVE-20796: jdbc URL can contain sensitive information that should not be logged

> On Oct. 25, 2018, 10:46 p.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java > > Lines 1172 (patched) > > > > > >

Re: Review Request 69167: HIVE-20796: jdbc URL can contain sensitive information that should not be logged

> On Oct. 25, 2018, 10:46 p.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java > > Lines 1172 (patched) > > > > > >

Re: Review Request 69167: HIVE-20796: jdbc URL can contain sensitive information that should not be logged

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69167/#review210059 ---

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java > > Line 352 (original) > > > > > > why remove this? > > denys kuzmenko wrote: >

Re: Review Request 69341: HIVE-20891: Call alter_partition in batch when dynamically loading partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69341/#review210568 --- ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Lines

Re: Review Request 69341: HIVE-20891: Call alter_partition in batch when dynamically loading partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69341/#review210569 ---

Re: Review Request 69341: HIVE-20891: Call alter_partition in batch when dynamically loading partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69341/#review210570 --- ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Lines

Re: Review Request 69341: HIVE-20891: Call alter_partition in batch when dynamically loading partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69341/#review210571 --- ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Line

Re: Review Request 69341: HIVE-20891: Call alter_partition in batch when dynamically loading partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69341/#review210572 --- ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Lines

Re: Review Request 68895: HadoopVer was ignored in QTestUtil

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68895/ --- (Updated Oct. 5, 2018, 10 a.m.) Review request for hive, Zoltan Haindrich and

Review Request 68960: Race Condition when Multi-Threading in SessionState.createRootHDFSDir

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68960/ --- Review request for hive, Jason Dere and Peter Vary. Bugs: HIVE-20711

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/ --- (Updated Oct. 1, 2018, 11:42 a.m.) Review request for hive, Zoltan Haindrich,

Review Request 68895: HadoopVer was ignored in QTestUtil

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68895/ --- Review request for hive, Zoltan Haindrich and Peter Vary. Bugs: HIVE-20647

Re: Review Request 68767: HIVE-20551: Create PreparedStatement query dynamically when IN clause is used

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68767/#review208827 ---

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

> On Sept. 26, 2018, 11:47 a.m., Antal Sinkovits wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Lines 3062 (patched) > > > > > > Why is the default value -1? All the checks seems to go

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/ --- (Updated Sept. 26, 2018, 1:08 p.m.) Review request for hive, Zoltan Haindrich,

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

> On Sept. 24, 2018, 11:14 p.m., Peter Vary wrote: > > Hi Denys, > > > > Could you please think a little about separating the Manager/Factory and > > the tryAcquire mess? > > > > Incomplete thoughts, but I had to run > > > > Thanks, and sorry :( > > Peter Please review new patch. Really

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

> On Sept. 17, 2018, 9:15 a.m., Zoltan Haindrich wrote: > > I'm not sure but I feel that it would be probably simpler to add something > > which covers some reentrant-s and semaphores. > > It feels like this lock handling is a littlebit scattered around...I think > > it would be better to have

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/ --- (Updated Sept. 25, 2018, 10:19 a.m.) Review request for hive, Zoltan

Re: Review Request 68474: HIVE-20440: Create better cache eviction policy for SmallTableCache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68474/#review208793 ---

Review Request 69801: HADOOP_CREDSTORE_PASSWORD is not populated under yarn.app.mapreduce.am.admin.user.env

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69801/ --- Review request for hive, Peter Vary and Vihang Karajgaonkar. Bugs: HIVE-21116

Re: Review Request 69801: HADOOP_CREDSTORE_PASSWORD is not populated under yarn.app.mapreduce.am.admin.user.env

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69801/ --- (Updated Jan. 21, 2019, 1:13 p.m.) Review request for hive, Peter Vary and

Re: Review Request 69801: HADOOP_CREDSTORE_PASSWORD is not populated under yarn.app.mapreduce.am.admin.user.env

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69801/ --- (Updated Jan. 21, 2019, 1:34 p.m.) Review request for hive, Peter Vary and

Re: Review Request 69550: Add credential store env properties redaction in JobConf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69550/ --- (Updated Dec. 12, 2018, 3:31 p.m.) Review request for hive, Peter Vary and

Re: Review Request 69560: HIVE-21035: Race condition in SparkUtilities#getSparkSession

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69560/#review211237 --- Ship it! Ship It! - Denys Kuzmenko On Dec. 12, 2018, 3:13

Re: Review Request 69550: Add credential store env properties redaction in JobConf

> On Dec. 11, 2018, 4:30 p.m., Vihang Karajgaonkar wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java > > Lines 217 (patched) > > > > > > Do we need to do redact for the Spark config as well?

Review Request 69550: Add credential store env properties redaction in JobConf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69550/ --- Review request for hive, Peter Vary and Vihang Karajgaonkar. Repository:

Re: Review Request 69550: Add credential store env properties redaction in JobConf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69550/ --- (Updated Dec. 11, 2018, 12:43 p.m.) Review request for hive, Peter Vary and

Re: Review Request 69432: HIVE-20964 Create a test that checks the level of the parallel compilation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69432/#review210800 --- Ship it! Ship It! - Denys Kuzmenko On Nov. 22, 2018, 3:19

Re: Review Request 68523: Improve org.apache.hadoop.hive.ql.exec.FunctionTask Experience

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68523/ --- (Updated Sept. 17, 2018, 3:24 p.m.) Review request for hive, Marta Kuczora,

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/ --- (Updated Sept. 17, 2018, 5:55 p.m.) Review request for hive, Zoltan Haindrich,

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/ --- (Updated Sept. 13, 2018, 8:18 p.m.) Review request for hive, Zoltan Haindrich,

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/ --- (Updated Sept. 19, 2018, 9:37 a.m.) Review request for hive, Zoltan Haindrich,

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

> On Sept. 17, 2018, 9:15 a.m., Zoltan Haindrich wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java > > Line 507 (original), 666 (patched) > > > > > > please don't make this method more visible; use

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

> On Sept. 17, 2018, 9:15 a.m., Zoltan Haindrich wrote: > > I'm not sure but I feel that it would be probably simpler to add something > > which covers some reentrant-s and semaphores. > > It feels like this lock handling is a littlebit scattered around...I think > > it would be better to have

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/ --- (Updated Sept. 17, 2018, 12:52 p.m.) Review request for hive, Zoltan

Re: Review Request 70934: HIVE-18735: Create table like loses transactional attribute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70934/#review216090 ---

Re: Review Request 71589: Create read-only transactions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71589/ --- (Updated Oct. 31, 2019, 3:21 p.m.) Review request for hive, Laszlo Pinter and

Re: Review Request 71589: Create read-only transactions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71589/ --- (Updated Oct. 30, 2019, 12:23 p.m.) Review request for hive, Laszlo Pinter and

Re: Review Request 71589: Create read-only transactions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71589/ --- (Updated Oct. 31, 2019, 3:20 p.m.) Review request for hive, Laszlo Pinter and

Re: Review Request 71792: COMPLETED_TXN_COMPONENTS table is never cleaned up unless Compactor runs

> On Nov. 20, 2019, 3:19 p.m., Denys Kuzmenko wrote: > > Not ready. Need to handle aborted and currently active compactions. > > Denys Kuzmenko wrote: > Handling above cases would complicate the Initiator logic and make > preliminare check longer. Not sure how critial it is that in case of

Re: Review Request 71792: COMPLETED_TXN_COMPONENTS table is never cleaned up unless Compactor runs

> On Nov. 20, 2019, 3:19 p.m., Denys Kuzmenko wrote: > > Not ready. Need to handle aborted and currently active compactions. Handling above cases would complicate the Initiator logic and make preliminare check longer. Not sure how critial it is that in case of unsuccessful compaction attempt,

Re: Review Request 71792: COMPLETED_TXN_COMPONENTS table is never cleaned up unless Compactor runs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71792/ --- (Updated Nov. 21, 2019, 5:35 p.m.) Review request for hive, Laszlo Pinter and

Review Request 71888: HIVE-22568: Process compaction candidates in parallel by the Initiator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71888/ --- Review request for hive, Laszlo Pinter and Peter Vary. Bugs: HIVE-22568

Re: Review Request 71589: Create read-only transactions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71589/ --- (Updated Oct. 28, 2019, 1:40 p.m.) Review request for hive, Laszlo Pinter and

Re: Review Request 71589: Create read-only transactions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71589/ --- (Updated Oct. 22, 2019, 1:24 p.m.) Review request for hive, Laszlo Pinter and

Re: Review Request 71589: Create read-only transactions

> On Oct. 17, 2019, 11:10 a.m., Peter Vary wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java > > Line 992 (original), 1003 (patched) > > > > > > Why is this a List of Pairs, why not just a Map? Is the

Re: Review Request 71589: Create read-only transactions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71589/ --- (Updated Oct. 17, 2019, 12:37 p.m.) Review request for hive, Laszlo Pinter and

Re: Review Request 71589: Create read-only transactions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71589/ --- (Updated Oct. 17, 2019, 8:41 a.m.) Review request for hive, Laszlo Pinter and

Review Request 71792: COMPLETED_TXN_COMPONENTS table is never cleaned up unless Compactor runs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71792/ --- Review request for hive, Laszlo Pinter and Peter Vary. Bugs: HIVE-21917

Re: Review Request 71792: COMPLETED_TXN_COMPONENTS table is never cleaned up unless Compactor runs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71792/#review218723 --- Not ready. Need to handle aborted and currently active

Re: Review Request 71812: HIVE-22534: ACID: Improve Compactor thread logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71812/#review218847 ---

Re: Review Request 71705: HIVE-22420: DbTxnManager.stopHeartbeat() should be thread-safe

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71705/#review218490 --- ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java

Re: Review Request 71705: HIVE-22420: DbTxnManager.stopHeartbeat() should be thread-safe

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71705/#review218491 --- LGTM, just minor comments. Also you mentioned unit test, do not

Re: Review Request 71589: Create read-only transactions

> On Oct. 10, 2019, 7:46 a.m., Peter Vary wrote: > > ql/src/test/org/apache/hadoop/hive/ql/parse/TestParseUtils.java > > Lines 47 (patched) > > > > > > What about CREATE TABLE AS SELECT * FROM...? > > We still

Re: Review Request 71589: Create read-only transactions

> On Oct. 10, 2019, 7:46 a.m., Peter Vary wrote: > > ql/src/test/org/apache/hadoop/hive/ql/parse/TestParseUtils.java > > Lines 47 (patched) > > > > > > What about CREATE TABLE AS SELECT * FROM...? > > We still

Re: Review Request 71589: Create read-only transactions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71589/ --- (Updated Oct. 10, 2019, 4:09 p.m.) Review request for hive, Laszlo Pinter and

Re: Review Request 71589: Create read-only transactions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71589/ --- (Updated Oct. 10, 2019, 4:09 p.m.) Review request for hive, Laszlo Pinter and

Review Request 71589: Create read-only transactions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71589/ --- Review request for hive, Laszlo Pinter and Peter Vary. Bugs: HIVE-21114

Re: Review Request 72129: HIVE-22850: Optimise lock acquisition in TxnHandler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72129/#review219572 ---

Re: Review Request 72129: HIVE-22850: Optimise lock acquisition in TxnHandler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72129/#review219575 ---

Re: Review Request 72151: HIVE-22376: Cancelled query still prints exception if it was stuck in waiting for lock

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72151/#review219612 --- ql/src/java/org/apache/hadoop/hive/ql/Driver.java Lines 400

Re: Review Request 72129: HIVE-22850: Optimise lock acquisition in TxnHandler

> On Feb. 13, 2020, 3:08 p.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 4546 (patched) > > > > > > Hi Rajesh,

Re: Review Request 71988: HIVE-22703: Compaction configuration check when starting HMS/HS2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71988/#review219268 --- Ship it! Ship It! - Denys Kuzmenko On Jan. 13, 2020, 2:12

Re: Review Request 71988: HIVE-22703: Compaction configuration check when starting HMS/HS2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71988/#review219237 --- LGTM, just minor comments

Re: Review Request 72028: HIVE-22729: Provide a failure reason for failed compactions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72028/#review219335 --- Ship it! LGTM, 1 minor comment

Re: Review Request 72324: HIVE-22750: Consolidate LockType naming

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72324/#review220256 --- metastore/scripts/upgrade/hive/hive-schema-4.0.0.hive.sql Line

Re: Review Request 72324: HIVE-22750: Consolidate LockType naming

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72324/#review220258 --- LGTM, just few more comments

Re: Review Request 72324: HIVE-22750: Consolidate LockType naming

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72324/#review220265 --- Ship it! Ship It! - Denys Kuzmenko On April 8, 2020, 3:09

Re: Review Request 72324: HIVE-22750: Consolidate LockType naming

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72324/#review220239 --- LGTM, some comments

Re: Review Request 72387: Locks: Add new lock implementations for always zero-wait readers

> On April 20, 2020, 4:55 p.m., Peter Vary wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Lines 2727-2730 (original), 2727-2730 (patched) > > > > > > Is this config still needed in this

Re: Review Request 72387: Locks: Add new lock implementations for always zero-wait readers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72387/ --- (Updated April 20, 2020, 8:50 p.m.) Review request for hive, Marton Bod and

Re: Review Request 72387: Locks: Add new lock implementations for always zero-wait readers

> On April 20, 2020, 4:55 p.m., Peter Vary wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Lines 2732 (patched) > > > > > > Maybe rephrase? > > Manages concurrency levels for ACID

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

> On April 20, 2020, 10:40 a.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Line 172 (original), 225 (patched) > > > > > >

  1   2   >