Re: Review Request 51755: Support Intersect Distinct

2016-10-18 Thread pengcheng xiong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51755/ --- (Updated Oct. 19, 2016, 1:36 a.m.) Review request for hive and Ashutosh

Re: Review Request 51755: Support Intersect Distinct

2016-10-18 Thread pengcheng xiong
> On Oct. 18, 2016, 3:31 p.m., Ashutosh Chauhan wrote: > > ql/src/test/org/apache/hadoop/hive/ql/parse/TestSQL11ReservedKeyWordsNegative.java, > > line 41 > > > > > > Any reason for adding Minus as reserved word?

Re: Review Request 51755: Support Intersect Distinct

2016-10-18 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51755/#review153186 ---

Re: Review Request 51755: Support Intersect Distinct

2016-10-18 Thread Ashutosh Chauhan
> On Oct. 7, 2016, 2:57 a.m., Ashutosh Chauhan wrote: > > Took first pass look. You may wait to address these comments till I finish full review. - Ashutosh --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 51755: Support Intersect Distinct

2016-10-18 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51755/#review153098 --- itests/src/test/resources/testconfiguration.properties (line 53)

Re: Review Request 51755: Support Intersect Distinct

2016-10-14 Thread pengcheng xiong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51755/ --- (Updated Oct. 15, 2016, 4:10 a.m.) Review request for hive and Ashutosh

Re: Review Request 51755: Support Intersect Distinct

2016-10-12 Thread pengcheng xiong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51755/ --- (Updated Oct. 13, 2016, 12:01 a.m.) Review request for hive and Ashutosh

Re: Review Request 51755: Support Intersect Distinct

2016-10-11 Thread pengcheng xiong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51755/ --- (Updated Oct. 11, 2016, 10:42 p.m.) Review request for hive and Ashutosh

Re: Review Request 51755: Support Intersect Distinct

2016-10-11 Thread pengcheng xiong
> On Oct. 7, 2016, 2:57 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveIntersectMergeRule.java, > > line 59 > > > > > > Is this check not required on

Re: Review Request 51755: Support Intersect Distinct

2016-10-06 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51755/#review148788 ---