Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

> On Dec. 17, 2018, 8:35 p.m., Vihang Karajgaonkar wrote: > > Thanks for the changes. Couple of minor comments. Rest looks good to me. Thanks. Will make these minor changes right away. > On Dec. 17, 2018, 8:35 p.m., Vihang Karajgaonkar wrote: > >

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69534/ --- (Updated Dec. 17, 2018, 9:17 p.m.) Review request for hive, Adam Holley,

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69534/#review211367 --- Fix it, then Ship it! Thanks for the changes. Couple of minor

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

> On Dec. 14, 2018, 10:43 p.m., Vihang Karajgaonkar wrote: > > Thanks for the feedback. > On Dec. 14, 2018, 10:43 p.m., Vihang Karajgaonkar wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > > Lines 462 (patched) > >

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69534/ --- (Updated Dec. 16, 2018, 3:11 a.m.) Review request for hive, Adam Holley,

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69534/#review211343 ---

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

> On Dec. 14, 2018, 2:58 a.m., Karthik Manamcheri wrote: > > Ship It! LGTM! Make sure you get someone else to review it as well. Thanks. - Karthik --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69534/#review211318 --- Ship it! Ship It! - Karthik Manamcheri On Dec. 14, 2018,

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69534/ --- (Updated Dec. 14, 2018, 1:25 a.m.) Review request for hive, Adam Holley,

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69534/ --- (Updated Dec. 14, 2018, 1:26 a.m.) Review request for hive, Adam Holley,

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69534/ --- (Updated Dec. 14, 2018, 1:23 a.m.) Review request for hive, Adam Holley,

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

> On Dec. 12, 2018, 10:54 p.m., Karthik Manamcheri wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > > Lines 472 (patched) > > > > > > Is this

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69534/#review211260 ---

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69534/ --- (Updated Dec. 10, 2018, 8:51 p.m.) Review request for hive, Adam Holley,

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69534/ --- (Updated Dec. 10, 2018, 8:46 p.m.) Review request for hive, Adam Holley,

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

> On Dec. 8, 2018, 7:49 p.m., Karthik Manamcheri wrote: > > Thanks for the feedback! > On Dec. 8, 2018, 7:49 p.m., Karthik Manamcheri wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > > Lines 460 (patched) > >

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69534/ --- (Updated Dec. 10, 2018, 8:40 p.m.) Review request for hive, Adam Holley,

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69534/ --- (Updated Dec. 10, 2018, 8:39 p.m.) Review request for hive, Adam Holley,

Re: Review Request 69534: HIVE-20992: Split the property "hive.metastore.dbaccess.ssl.properties" into more coherent and user-friendly properties.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69534/#review211129 ---