Re: Review Request: Review request for HIVE-2225

2011-06-22 Thread John Sichi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/940/#review888 ---

Re: Review Request: Review request for HIVE-2225

2011-06-22 Thread John Sichi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/940/#review889 --- trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java

Re: Review Request: Review request for HIVE-2225

2011-06-22 Thread John Sichi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/940/#review890 --- trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java

Re: Review Request: Review request for HIVE-2225

2011-06-22 Thread John Sichi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/940/#review891 ---

Re: Review Request: Review request for HIVE-2225

2011-06-22 Thread Ashutosh Chauhan
On 2011-06-22 23:07:05, John Sichi wrote: trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/EventCleanerThread.java, line 1 https://reviews.apache.org/r/940/diff/1/?file=21415#file21415line1 New files need Apache headers Added. - Ashutosh

Re: Review Request: Review request for HIVE-2225

2011-06-22 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/940/ --- (Updated 2011-06-23 02:55:08.540561) Review request for hive, Carl Steinbach and

Re: Review Request: Review request for HIVE-2225

2011-06-22 Thread Ashutosh Chauhan
On 2011-06-22 23:07:46, John Sichi wrote: trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 221 https://reviews.apache.org/r/940/diff/1/?file=21411#file21411line221 If you agree about making this disabled by default, we could use a special value such as 0 for

Re: Review Request: Review request for HIVE-2225

2011-06-22 Thread Ashutosh Chauhan
On 2011-06-22 23:18:43, John Sichi wrote: trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, line 259 https://reviews.apache.org/r/940/diff/1/?file=21412#file21412line259 Why is this using a Thread instead of a Timer? Agreed timer is better suited here

Review Request: Review request for HIVE-2225

2011-06-21 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/940/ --- Review request for hive, Carl Steinbach and John Sichi. Summary --- This