Re: Linux atomic ops was Re: Leader fails to compile

2002-04-20 Thread Joe Orton
On Sat, Apr 20, 2002 at 01:11:33PM -0700, Justin Erenkrantz wrote: > On Sat, Apr 20, 2002 at 01:05:54PM -0700, Brian Pane wrote: > > The problem only appears in leader/follower because it's the only MPM > > that currently uses apr_atomic.h. > > > > I think this is one more reason to stop using i

[PATCH] cruft in install-*

2002-05-20 Thread Joe Orton
The install- targets have "{} \;" left in the rm -rf invocation which removes CVS directories, presumably a leftover from being a find -exec. --- Makefile.in 13 May 2002 07:45:15 - 1.112 +++ Makefile.in 20 May 2002 12:46:01 - @@ -109,25 +109,25 @@ @test -d $(htdocs-srcdir) &&

[PATCH] remove blank line from httpd -t

2002-05-21 Thread Joe Orton
The "Syntax OK" message from httpd -t includes two linefeeds at the moment since log_error_core appends one too. Index: server/main.c === RCS file: /home/cvspublic/httpd-2.0/server/main.c,v retrieving revision 1.128 diff -u -r1.128 m

[PATCH] improve config dir processing

2002-05-27 Thread Joe Orton
Currently config directory processing isn't very useful in practice because all files in the config dir are loaded - so if you use an editor which creates backup files, the backup file will still be loaded. A simple way to fix this is to only load files in the config dir which match the pattern "

Re: [PATCH] improve config dir processing

2002-05-27 Thread Joe Orton
On Mon, May 27, 2002 at 08:02:13AM -0400, Joshua Slive wrote: > Joe Orton wrote: > > Currently config directory processing isn't very useful in practice > > because all files in the config dir are loaded - so if you use an editor > > which creates backup files, the

Re: [PATCH] improve config dir processing

2002-05-28 Thread Joe Orton
On Mon, May 27, 2002 at 10:43:32PM -0700, Brian Pane wrote: > As a compromise solution, how about: > > * Implement user-defined patterns for now, using apr_fnmatch(), but > restrict the patterns to matching a single directory (so that we > only need fnmatch and not full glob support). >

Re: [PATCH] improve config dir processing

2002-05-28 Thread Joe Orton
On Tue, May 28, 2002 at 07:32:10AM -0700, Justin Erenkrantz wrote: > On Tue, May 28, 2002 at 02:04:47PM +0100, Joe Orton wrote: > > This removes support for "Include ", by the argument that > > include dirs will just trip people up unexpectedly, and "Include > &

Re: Include conf.d/*.conf patch from redhat

2002-09-10 Thread Joe Orton
On Tue, Sep 10, 2002 at 09:21:17PM -0700, Justin Erenkrantz wrote: > On Tue, Sep 10, 2002 at 04:04:31PM -0700, Ian Holsman wrote: > > does anyone recall if there was a good reason not to include this patch > > in the main distribution ? > > What patch is this? -- justin I hadn't had time to sub

Re: SSL Upgrade support.

2002-10-07 Thread Joe Orton
On Sun, Oct 06, 2002 at 11:50:04PM -0400, Ryan Bloom wrote: > Just a heads up. I wrote SSL Upgrade support this weekend for Apache > 2.0. In my (currently) limited testing, things look pretty good. We > currently respond to all requests correctly, and I think I have the SSL > filters being inse

Re: cvs commit: httpd-2.0/server core.c util_script.c

2002-10-09 Thread Joe Orton
On Wed, Oct 02, 2002 at 03:54:18PM -0700, Joshua Slive wrote: > > On Wed, 2 Oct 2002, Marc Slemko wrote: > > Lets not encode env variables, as we discussed earlier. > > > > Escaping them is bogus and doesn't solve anything since there are all > > sorts of variables that aren't and shouldn't be en

[PATCH] prevent apxs from inserting AddModule

2002-11-27 Thread Joe Orton
If an httpd.conf has commented out AddModule directives, apxs -i -a will add an un-commented AddModule directive for the new module, which breaks the config. Here's a fix: --- support/apxs.in 19 Sep 2002 05:43:16 - 1.47 +++ support/apxs.in 27 Nov 2002 16:12:00 - @@ -490,9 +49

Re: cvs commit: httpd-2.0/server .cvsignore Makefile.in

2002-11-29 Thread Joe Orton
On Fri, Nov 29, 2002 at 11:05:59AM -, [EMAIL PROTECTED] wrote: ># full path required to keep BSD make happy > -$(top_builddir)/server/exports.c: > - $(AWK) -f $(top_srcdir)/build/make_exports.awk $(EXPORT_FILES) > $@ > +$(top_builddir)/server/exports.c: export_files > + $(AWK) -

Re: Linux + TCP_CORK + IPv6 = Broken [PATCH]

2002-12-04 Thread Joe Orton
On Wed, Dec 04, 2002 at 08:21:36AM -0500, Jeff Trawick wrote: > Colm MacCárthaigh <[EMAIL PROTECTED]> writes: > > > On Wed, Dec 04, 2002 at 12:25:49PM +, Colm MacCárthaigh wrote: > > > My tests (and patch) were based on apr and apr-util from CVS , > > > with the 2.0.43 codebase, because CVS s

Re: Linux + TCP_CORK + IPv6 = Broken [PATCH]

2002-12-04 Thread Joe Orton
On Wed, Dec 04, 2002 at 11:38:06PM +, Colm MacCárthaigh wrote: > On Wed, Dec 04, 2002 at 11:05:21PM +0000, Joe Orton wrote: > > Colm, can you try running the apr/test/sendfile binary with your > > machines? > > It was one of the first things I tried when I was debugging

Re: Linux + TCP_CORK + IPv6 = Broken [PATCH]

2002-12-05 Thread Joe Orton
On Thu, Dec 05, 2002 at 10:54:53AM +, Colm MacCárthaigh wrote: .. > telnet [v6addr] 80 > GET / HTTP/1.1 > Host: madeup.tld > > Have you verified with tcpdump/ethereal etc that this hang is because the server is not sending the packets? What does netstat -t show for this connection? That tes

Re: Linux + TCP_CORK + IPv6 = Broken [PATCH]

2002-12-05 Thread Joe Orton
To summarize some off-list dicussion - the kernel guys have said that using sendfile on IPv6 sockets may trigger bugs in cards which do hardware TCP checksumming for card/driver/OS combinations which support that. (since the cards have to know about IPv6, and that probably doesn't get tested much).

[PATCH] prevent apxs from inserting AddModule

2002-12-09 Thread Joe Orton
Resend. I found a bug report on this as well: http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11212 - Forwarded message from Joe Orton <[EMAIL PROTECTED]> - From: Joe Orton <[EMAIL PROTECTED]> To: [EMAIL PROTECTED] Mail-Followup-To: [EMAIL PROTECTED] Date: Wed, 27 Nov 2

Re: SSL upgrade [was: Final patch for a long time]

2002-12-12 Thread Joe Orton
On Thu, Dec 12, 2002 at 01:08:08AM -0600, William Rowe wrote: > My proposed solution is to review the patch and apply it to cvs HEAD. Get it > committed. Of course there are no test suites right now, and there won't be > for a little while yet. But once the code exists, it will be simpler to kee

Re: cvs commit: httpd-2.0/modules/experimental mod_cache.c

2002-12-17 Thread Joe Orton
On Tue, Dec 17, 2002 at 05:10:05PM -, Bill Stoddard wrote: > Fix PR 15113, a core dump in cache_in_filter when > a redirect occurs. The code was passing a format string and > integer to apr_pstrcat. Changed to apr_psprintf. [Paul J. Reder] > > PR: 15113 ... >else if (exps

[PATCH] don't install pcre's config.h and internal.h

2001-12-07 Thread Joe Orton
Currently pcre/config.h and pcre/internal.h are getting installed - it seems they aren't used, and adding a rogue config.h into the include path can cause problems for a module which picks it up. joe Index: Makefile.in === RCS file:

Re: Tagging 1.3.23

2002-01-21 Thread Joe Orton
On Mon, Jan 21, 2002 at 03:10:36PM -0500, Ken Coar wrote: > : > gcc -c -I../../os/unix -I../../include -DLINUX=22 -DNO_DBM_REWRITEMAP >-DUSE_HSREGEX -DUSE_EXPAT -I../../lib/expat-lite -g > -O2 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow `../../apaci` -fpic >-DSHARED_MODULE

Re: cvs commit: httpd-2.0/modules/ssl ssl_scache_shmcb.c ssl_util_table.c

2002-03-15 Thread Joe Orton
On Fri, Mar 15, 2002 at 01:46:47AM -, [EMAIL PROTECTED] wrote: >/* This is necessary simply so that the size passed to memset() is not a > * compile-time constant, preventing the compiler from optimising it. */ > +#if 0 > +/* XXX: this isn't used, is it needed? */ >static void

Re: [PATCH] reversion mod_ssl (showstopper)

2002-03-22 Thread Joe Orton
On Thu, Mar 21, 2002 at 03:20:15PM -0500, Jeff Trawick wrote: > What am I missing here? Why shouldn't the mod_ssl version just be the > Apache version since with Apache 2.0 mod_ssl is now a core module? I'd guess this was done since mod_ssl for 1.3 is already at version 2.8, so then calling it "

Re: proxy and 100 Continue

2002-03-22 Thread Joe Orton
On Thu, Mar 21, 2002 at 02:47:35PM +0200, Graham Leggett wrote: > When I access www.hotmail.com using Netscape v4.7 (an HTTP/1.0 client), > and try to use the "block" feature in the Hotmail service, I get > Netscape complain that it received a message it did not understand: > "100!". A trace shows

[PATCH] 1.3: config.layout update for Red Hat Linux

2002-03-27 Thread Joe Orton
This updates config.layout for recent Red Hat Linux systems (bugzilla #7422): --- config.layout~ Mon Jan 14 09:39:25 2002 +++ config.layout Wed Mar 27 16:35:40 2002 @@ -115,7 +115,7 @@ proxycachedir: $runtimedir/proxy -# RedHat 5.x layout +# Red Hat Linux 7.x layout

Re: Fwd: FYI: change to travis-ci emailer could cause moderation headaches

2022-01-26 Thread Joe Orton
On Wed, Jan 26, 2022 at 08:58:14AM -0500, Eric Covener wrote: > I noticed I stopped getting "Travis CI" emails for httpd around 10/21. > But I see people still discussing CI failures, so I am a little > confused. Maybe they are only seeing it in the context of PRs. > > Did we lose notifications to

Re: svn commit: r1898566 - in /httpd/httpd/branches/2.4.x: ./ modules/aaa/ modules/cache/ modules/dav/fs/ modules/dav/lock/ modules/mappers/ modules/proxy/

2022-03-03 Thread Joe Orton
On Thu, Mar 03, 2022 at 01:30:47PM -, j...@apache.org wrote: > Author: jim > Date: Thu Mar 3 13:30:46 2022 > New Revision: 1898566 > > URL: http://svn.apache.org/viewvc?rev=1898566&view=rev > Log: > dbm backport approved and merged This has broken the CI with several new warnings and empty A

Re: svn commit: r1898566 - in /httpd/httpd/branches/2.4.x: ./ modules/aaa/ modules/cache/ modules/dav/fs/ modules/dav/lock/ modules/mappers/ modules/proxy/

2022-03-03 Thread Joe Orton
On Thu, Mar 03, 2022 at 05:11:52PM +0100, Ruediger Pluem wrote: > On 3/3/22 4:49 PM, Joe Orton wrote: > > Folks (in no way pointing a finger at Jim who just did merging duty), it > > is not hard to test your backport proposals, either in an SVN branch or > > a github

Re: svn commit: r1898566 - in /httpd/httpd/branches/2.4.x: ./ modules/aaa/ modules/cache/ modules/dav/fs/ modules/dav/lock/ modules/mappers/ modules/proxy/

2022-03-08 Thread Joe Orton
On Fri, Mar 04, 2022 at 09:24:37AM +0100, Stefan Eissing wrote: > > Am 04.03.2022 um 08:32 schrieb Ruediger Pluem : > > On 3/3/22 5:40 PM, Joe Orton wrote: > >> Oh, good question. I'm not sure how the "branch" variable appears in an > >> arbitrary br

Re: backports

2022-03-08 Thread Joe Orton
On Fri, Mar 04, 2022 at 09:40:49AM -0800, Roy T. Fielding wrote: > > On Mar 4, 2022, at 6:17 AM, Eric Covener wrote: > > > > On Fri, Mar 4, 2022 at 9:05 AM Jim Jagielski wrote: > >> > >> A question: Would it be easier for all this if we moved to being Github > >> canon? > > > > I think it is

Re: backports

2022-03-08 Thread Joe Orton
On Mon, Mar 07, 2022 at 01:28:19PM +0200, Graham Leggett wrote: > On 07 Mar 2022, at 11:21, Stefan Eissing wrote: > > > I'd really like, as a reviewer of backports, you can: > > - see that it passes all our tests. No need to patch/compile/test locally. > > “No need to patch/compile locally" is n

Re: backports

2022-03-08 Thread Joe Orton
On Sun, Mar 06, 2022 at 05:56:36PM +0200, Graham Leggett wrote: > I am however strongly opposed for Github to be our only promotion process. > > CI is great right until the point you get your first unrelated test failure, > then it is a nightmare. The collectd project was completely stuck unable

Re: candidate branch/tag names

2022-03-08 Thread Joe Orton
On Mon, Mar 07, 2022 at 01:46:51PM +0100, Stefan Eissing wrote: > Joe, > > I'll change the release candidate tag/branch names and if that works, > you can strip some regex from the travis setup. Looks good to me, thanks Stefan. I've updated the regexes. Regards, Joe

Re: [VOTE] Release httpd-2.4.53-rc1 as httpd-2.4.53

2022-03-08 Thread Joe Orton
On Mon, Mar 07, 2022 at 04:55:54PM +0100, Stefan Eissing wrote: > Hi all, > > Please find below the proposed release tarball and signatures: > > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few days to release > this candidate tarball httpd-2.4.53-r

Re: [VOTE] Release httpd-2.4.53-rc1 as httpd-2.4.53

2022-03-08 Thread Joe Orton
On Tue, Mar 08, 2022 at 02:01:42PM +0100, Ruediger Pluem wrote: > > I got a new "may be uninitialized" warning with with the GCC 12 shapshot > > used in Fedora 36 (which is still under development and can be > > unreliable). I think it's unreachable, if we enter here: > > > > https://github.com/

Re: [VOTE] Release httpd-2.4.53-rc2 as httpd-2.4.53

2022-03-10 Thread Joe Orton
On Wed, Mar 09, 2022 at 05:19:22PM +0100, Stefan Eissing wrote: > Hi all, > > Please find below the proposed release tarball and signatures: > > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few days to release > this candidate tarball httpd-2.4.53-r

Re: Fwd: FYI: change to travis-ci emailer could cause moderation headaches

2022-05-10 Thread Joe Orton
On Wed, Jan 26, 2022 at 08:58:14AM -0500, Eric Covener wrote: > I noticed I stopped getting "Travis CI" emails for httpd around 10/21. > But I see people still discussing CI failures, so I am a little > confused. Maybe they are only seeing it in the context of PRs. > > Did we lose notifications to

Re: Trouble in rusttls land?

2022-05-11 Thread Joe Orton
On Tue, May 10, 2022 at 10:50:12PM +0200, Stefan Eissing wrote: > Will look at it tomorrow. Could we cache the crates if building them is the source of unreliability? It looks like we just have to add a couple of extra directories to the cache list: https://docs.travis-ci.com/user/caching/#rus

Re: strcasecmp raises its...

2022-05-18 Thread Joe Orton
On Wed, May 18, 2022 at 12:53:57PM +0200, Ruediger Pluem wrote: > > > On 5/18/22 12:19 PM, Stefan Eissing wrote: > > 2022 and we discuss strcasecmp() again? > > > > Background: OpenSSL 3.0.3 added OPENSSL_strcasecmp() and friends and there > > are several issue around their implementation. Up t

Re: strcasecmp raises its...

2022-05-19 Thread Joe Orton
On Wed, May 18, 2022 at 05:34:22PM +0200, Ruediger Pluem wrote: > On 5/18/22 4:55 PM, Joe Orton wrote: > > I think for httpd it is only safe and sane to run httpd with LANG=C, we > > do this in the default service scripts in Fedora/RHEL for a very long > > time. Other than

Re: [VOTE] Release httpd-2.4.54-rc3 as httpd-2.4.54

2022-06-07 Thread Joe Orton
On Mon, Jun 06, 2022 at 04:25:31PM +0200, Stefan Eissing wrote: > Here we go again! Sorry for the repeats, but that is why we build candidates, > right? > > Hi all, > > Please find below the proposed release tarball and signatures: > > https://dist.apache.org/repos/dist/dev/httpd/ > > I would

Re: svn commit: r1894982 - /httpd/apreq/trunk/library/util.c

2022-08-17 Thread Joe Orton
On Fri, Nov 12, 2021 at 06:12:58PM -, yla...@apache.org wrote: > Author: ylavic > Date: Fri Nov 12 18:12:58 2021 > New Revision: 1894982 > > URL: http://svn.apache.org/viewvc?rev=1894982&view=rev > Log: > apreq_header_attribute: Search for the exact attribute name. > > Improve the parsing of

Re: svn commit: r1894982 - /httpd/apreq/trunk/library/util.c

2022-08-17 Thread Joe Orton
On Wed, Aug 17, 2022 at 02:05:09PM +0100, Joe Orton wrote: > On Fri, Nov 12, 2021 at 06:12:58PM -, yla...@apache.org wrote: > > Author: ylavic > > Date: Fri Nov 12 18:12:58 2021 > > New Revision: 1894982 > > > > URL: http://svn.apache.org/vi

Re: svn commit: r1894982 - /httpd/apreq/trunk/library/util.c

2022-08-18 Thread Joe Orton
On Wed, Aug 17, 2022 at 06:17:23PM +0200, Yann Ylavic wrote: > I fixed it in r1903496 by requiring that the name in a name=value pair > only be a token, with no equal sign the attribute is a value only. Thanks a lot for committing all the fixes, test suite is passing here now. Regards, Joe

[VOTE] Release libapreq2-2.17

2022-08-18 Thread Joe Orton
Hi, I've prepared a candidate release tarball for libapreq2 v2.17 here: https://dist.apache.org/repos/dist/dev/httpd/libapreq/ I would like to call a VOTE over the next week to release this candidate tarball as v2.17: [ ] +1: It's not just good, it's good enough! [ ] +0: Let's have a talk. [ ]

Re: [VOTE] Release libapreq2-2.17

2022-08-25 Thread Joe Orton
On Thu, Aug 18, 2022 at 12:31:56PM +0100, Joe Orton wrote: > Hi, I've prepared a candidate release tarball for libapreq2 v2.17 here: > > https://dist.apache.org/repos/dist/dev/httpd/libapreq/ > > I would like to call a VOTE over the next week to release this candidate

[RESULT: PASS] Re: [VOTE] Release libapreq2-2.17

2022-08-25 Thread Joe Orton
Thanks for testing. The release is approved: PMC votes: +1 from ylavic, jfclere, jorton I will promote the release and announce it. Regards, Joe

CVE-2022-22728: libapreq2: libapreq2 multipart form parse memory corruption

2022-08-25 Thread Joe Orton
Severity: important Description: A flaw in libapreq2 versions 2.16 and earlier could cause a buffer overflow while processing multipart form uploads. A remote attacker could send a request causing a process crash which could lead to a denial of service attack.

Re: [libapreq2] nits to pick about the patches to util.c over the past few years

2022-10-31 Thread Joe Orton
On Sun, Oct 30, 2022 at 12:09:02AM -0400, Joe Schaefer wrote: > Forgive me for summarizing, but I didn’t come here expecting help, much > less collaboration on a solution. I came here expecting to be scolded for > having the temerity to critique the quality of the patch sets you’ve been > shipping

New committer: Emmanuel Dreyfus

2022-11-08 Thread Joe Orton
The Project Management Committee (PMC) for the Apache HTTP Server has invited Emmanuel Dreyfus to become a committer and we are pleased to announce that they have accepted. Welcome, Emmanuel! Regards, Joe

Re: MS-WDV (was Re: Help with buckets)

2022-12-02 Thread Joe Orton
On Fri, Dec 02, 2022 at 08:53:07AM +, Emmanuel Dreyfus wrote: > Hello > > I made some progress with the combined GET+PROPFIND specified > by MS-WDV (for a summary, see > https://lists.apache.org/thread/57s1vvl6k9qpdv5ym7mtcl29bd933w7k ) > > Attached is the diff against trunk, form comments.

Re: svn commit: r1906487 - /httpd/httpd/trunk/modules/dav/main/util.c

2023-01-09 Thread Joe Orton
On Mon, Jan 09, 2023 at 04:47:33PM +0100, Ruediger Pluem wrote: > On 1/9/23 1:01 PM, jor...@apache.org wrote: > > Author: jorton > > Date: Mon Jan 9 12:01:56 2023 > > New Revision: 1906487 > > > > URL: http://svn.apache.org/viewvc?rev=1906487&view=rev > > Log: > > * modules/dav/main/util.c (dav_p

Re: svn commit: r1906487 - /httpd/httpd/trunk/modules/dav/main/util.c

2023-01-10 Thread Joe Orton
On Tue, Jan 10, 2023 at 07:30:37AM +0100, Ruediger Pluem wrote: > On 1/9/23 5:16 PM, Joe Orton wrote: > > It seems consistent with other error cases to return straight away, but > > I'm not following the second part, can you explain more? An 'N' > > followe

Re: [VOTE] Release httpd-2.4.55-rc1 as httpd-2.4.55

2023-01-10 Thread Joe Orton
On Tue, Jan 10, 2023 at 08:40:52AM -0500, Eric Covener wrote: > Hi all, > > Please find below the proposed release tarball and signatures: > > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few days to release > this candidate tarball httpd-2.4.55-rc1

Re: [VOTE] Release httpd-2.4.55-rc1 as httpd-2.4.55

2023-01-10 Thread Joe Orton
On Tue, Jan 10, 2023 at 10:21:55AM -0500, Eric Covener wrote: > On Tue, Jan 10, 2023 at 10:17 AM Giovanni Bechis wrote: ... > > In file included from /usr/include/openssl/asn1.h:27, > > from /usr/include/openssl/rsa.h:21, > > from ab.c:169: > > /usr/include/openss

CI status update: Travis out, GitHub Actions in

2023-02-15 Thread Joe Orton
Support for Travis has now been dropped, so we are relying only on GitHub Actions for CI from today. There are some gaps in the GHA configuration compared to what we had running in Travis: notably, we're currently only testing on the latest Ubuntu release, and nothing has been ported back to 2.

[VOTE] broader RTC exception for 2.4.x CI changes

2023-02-15 Thread Joe Orton
Per my previous Travis is dead, long live GitHub actions. I propose to broaden the RTC exception in 2.4.x/STATUS to allow CI config changes and scripts to be merged from trunk: Index: STATUS === --- STATUS (revision 1907679) ++

Re: svn commit: r1907680 - /httpd/httpd/trunk/modules/dav/main/ms_wdv.c

2023-02-15 Thread Joe Orton
On Wed, Feb 15, 2023 at 02:07:14PM -, m...@apache.org wrote: > Author: manu > Date: Wed Feb 15 14:07:14 2023 > New Revision: 1907680 > > URL: http://svn.apache.org/viewvc?rev=1907680&view=rev > Log: > Fix warnings Thanks! There are a still a couple more warnings with GCC 10 from a %s argumen

Re: [VOTE] broader RTC exception for 2.4.x CI changes

2023-02-21 Thread Joe Orton
Thanks all, applied in r1907783. Regards, Joe

Re: svn commit: r1907974 - in /httpd/httpd/trunk: CMakeLists.txt modules/dav/fs/config6.m4 modules/dav/fs/mod_dav_fs.c modules/dav/fs/mod_dav_fs.dsp modules/dav/fs/repos.c modules/dav/fs/repos.h modul

2023-03-02 Thread Joe Orton
On Thu, Mar 02, 2023 at 02:36:32PM -, m...@apache.org wrote: > Author: manu > Date: Thu Mar 2 14:36:31 2023 > New Revision: 1907974 > > URL: http://svn.apache.org/viewvc?rev=1907974&view=rev > Log: > Add RFC4331 quotas for mod_dav_fs Hi Emmanuel - looks like you forgot to "svn add" the new q

Re: [VOTE] [VOTE] Release httpd-2.4.56-rc1 as httpd-2.4.56

2023-03-06 Thread Joe Orton
On Sun, Mar 05, 2023 at 04:31:34PM -0500, Eric Covener wrote: > Hi all, > > Please find below the proposed release tarball and signatures: > > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few days to release > this candidate tarball httpd-2.4.56-rc1

Re: svn commit: r1908060 - in /httpd/httpd/trunk/test/modules: http1/htdocs/cgi/ http2/ http2/htdocs/cgi/ md/ tls/ tls/htdocs/a.mod-tls.test/ tls/htdocs/b.mod-tls.test/

2023-03-06 Thread Joe Orton
[resent to dev@] On Sat, Mar 04, 2023 at 01:40:39PM -, ic...@apache.org wrote: > Author: icing > Date: Sat Mar 4 13:40:38 2023 > New Revision: 1908060 > > URL: http://svn.apache.org/viewvc?rev=1908060&view=rev > Log: > Test case updates related to macOS ventura changes: > > - python 3.11 de

Re: svn commit: r1908060 - in /httpd/httpd/trunk/test/modules: http1/htdocs/cgi/ http2/ http2/htdocs/cgi/ md/ tls/ tls/htdocs/a.mod-tls.test/ tls/htdocs/b.mod-tls.test/

2023-03-07 Thread Joe Orton
On Tue, Mar 07, 2023 at 09:15:59AM +0100, Stefan Eissing via dev wrote: > > > > Am 06.03.2023 um 17:53 schrieb Joe Orton : > > > > [resent to dev@] > > > > On Sat, Mar 04, 2023 at 01:40:39PM -, ic...@apache.org wrote: > >> Author: icing > >

Re: svn commit: r1908537 - /httpd/httpd/trunk/modules/ssl/

2023-03-20 Thread Joe Orton
On Sun, Mar 19, 2023 at 09:30:47PM -, yla...@apache.org wrote: > Author: ylavic > Date: Sun Mar 19 21:30:47 2023 > New Revision: 1908537 > > URL: http://svn.apache.org/viewvc?rev=1908537&view=rev > Log: > mod_ssl: Fix deprecation warnings with openssl-3. Great stuff, thank you Yann!

Re: svn commit: r1908684 - in /httpd/httpd/trunk: docs/log-message-tags/next-number modules/cache/mod_cache_disk.c

2023-03-28 Thread Joe Orton
On Fri, Mar 24, 2023 at 08:50:19AM -, gbec...@apache.org wrote: > Author: gbechis > Date: Fri Mar 24 08:50:19 2023 > New Revision: 1908684 > > URL: http://svn.apache.org/viewvc?rev=1908684&view=rev > Log: > add error message when storing data to temp file fails. > Github: closes #182 Hi Giova

Re: svn commit: r1908835 - /httpd/httpd/trunk/.github/workflows/linux.yml

2023-03-31 Thread Joe Orton
On Fri, Mar 31, 2023 at 09:47:05AM +0200, Yann Ylavic wrote: > On Fri, Mar 31, 2023 at 9:22 AM wrote: > > > > Author: jorton > > Date: Fri Mar 31 07:21:37 2023 > > New Revision: 1908835 > > > > URL: http://svn.apache.org/viewvc?rev=1908835&view=rev > > Log: > > Try running CI for 2.* tags. [skip c

Re: [VOTE] Release httpd-2.4.57-rc1 as httpd-2.4.57

2023-04-03 Thread Joe Orton
On Sun, Apr 02, 2023 at 12:10:25PM -0400, Eric Covener wrote: > Please find below the proposed release tarball and signatures: > > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few days to release > this candidate tarball httpd-2.4.57-rc1 as 2.4.57: >

Re: svn commit: r1909135 - in /httpd/httpd/trunk: CHANGES include/ap_mmn.h server/core.c

2023-04-21 Thread Joe Orton
On Wed, Apr 19, 2023 at 08:08:49PM +0200, Yann Ylavic wrote: > On Fri, Apr 14, 2023 at 4:02 PM wrote: > > > > Author: minfrin > > Date: Fri Apr 14 14:02:11 2023 > > New Revision: 1909135 > > > > URL: http://svn.apache.org/viewvc?rev=1909135&view=rev > > Log: > > core: Be explicit if an enclosing d

Re: ci vs PR approvals? (was: [apache/httpd] Fix a possible NULL pointer dereference in hook_uri2file (PR #355))

2023-05-04 Thread Joe Orton
On Wed, May 03, 2023 at 02:31:35PM -0500, Daniel Gruno wrote: > I am +1 on moving. I do not have any particular love for git or svn on their > own, and I realize that the proposed change does make outside contributions > and certain workflows easier. +1 for the same reasons here. Might be better t

Re: [VOTE] Switch read/write repository from Subversion to Git

2023-05-04 Thread Joe Orton
On Thu, May 04, 2023 at 10:34:32AM +0200, Ruediger Pluem wrote: > This is a formal vote on whether we should move our read/write repository > from Subversion to Git. > This means that our latest read/write repository will be no longer available > via svn.apache.org. It > will be available via Git

Re: svn commit: r1910820 - in /httpd/httpd/branches/2.4.x: ./ changes-entries/pr60182.txt modules/ssl/ssl_util_stapling.c

2023-07-07 Thread Joe Orton
On Thu, Jul 06, 2023 at 10:58:07PM +0200, Christophe JAILLET wrote: > Le 06/07/2023 à 18:11, jor...@apache.org a écrit : > > Author: jorton > > Date: Thu Jul 6 16:11:56 2023 > > New Revision: 1910820 > > > > URL: http://svn.apache.org/viewvc?rev=1910820&view=rev > > Log: > > Merge r1875355 from t

Re: svn commit: r1910861 - /httpd/httpd/trunk/support/ab.c

2023-07-10 Thread Joe Orton
On Fri, Jul 07, 2023 at 03:52:46PM -, yla...@apache.org wrote: > Author: ylavic > Date: Fri Jul 7 15:52:45 2023 > New Revision: 1910861 > > URL: http://svn.apache.org/viewvc?rev=1910861&view=rev > Log: > ab: Fix accounting of started connections. > > Revert when a kept alive connection is ab

Re: svn commit: r1910861 - /httpd/httpd/trunk/support/ab.c

2023-07-10 Thread Joe Orton
On Mon, Jul 10, 2023 at 11:12:09AM +0200, Yann Ylavic wrote: > I think this is not reached with rtnevents == POLLOUT|POLLHUP because > it takes the first POLLIN|POLLHUP continue-branch. > I moved the check for POLLOUT first in r1910911, which fixed the issue for me. Perfect, works for me too - tha

Re: svn commit: r1911908 - /httpd/httpd/branches/2.4.x/STATUS

2023-08-25 Thread Joe Orton
On Fri, Aug 25, 2023 at 12:11:38PM +0200, Ruediger Pluem wrote: > > == > > --- httpd/httpd/branches/2.4.x/STATUS (original) > > +++ httpd/httpd/branches/2.4.x/STATUS Fri Aug 25 07:52:31 2023 > > @@ -225,11 +225,12 @@ PATCHE

Re: mod_ssl SSL_OP_IGNORE_UNEXPECTED_EOF: "unexpected eof while reading"

2023-09-07 Thread Joe Orton
On Wed, Aug 30, 2023 at 01:21:11PM +0200, Rainer Jung wrote: > Hi there, > > OpenSSL 3 flags some abortive shutdowns as an error different to what 1.1.1 > did. This results in info log output in httpd: > > [Tue Aug 29 12:33:06.787210 2023] [ssl:info] [pid 1994673:tid 1994737] SSL > Library Error:

Re: mod_ssl SSL_OP_IGNORE_UNEXPECTED_EOF: "unexpected eof while reading"

2023-09-08 Thread Joe Orton
On Thu, Sep 07, 2023 at 06:46:01PM +0200, Yann Ylavic wrote: > On Thu, Sep 7, 2023 at 6:09 PM Yann Ylavic wrote: > > > > On Wed, Aug 30, 2023 at 1:22 PM Rainer Jung wrote: > > > > > > OpenSSL 3 flags some abortive shutdowns as an error different to what > > > 1.1.1 did. This results in info log o

[PATCH] fix mod_h2 with older nghttp2

2023-10-16 Thread Joe Orton
Looks like this broke with the websockets backport. mod_h2 is failing to compile on versions of nghttp2 without NGHTTP2_SETTINGS_ENABLE_CONNECT_PROTOCOL - looks like this was added in nghttp2 v1.34.0 [1] so how about something like this, or is there a better way? (configure check for a declara

Re: [PATCH] fix mod_h2 with older nghttp2

2023-10-16 Thread Joe Orton
BTW is modules/http2 really CTR for 2.4.x? STATUS says only mod_proxy_http2 is. Anyway: I am +1 for r1913005 and r1913019 for 2.4.x, latter was sufficient to get 2.4 building on RHEL8 again (if only we had a CI to do this, oh...). Regards, Joe

Re: svn commit: r1913019 - in /httpd/httpd/trunk/modules/http2: h2_session.c h2_ws.c

2023-10-16 Thread Joe Orton
On Mon, Oct 16, 2023 at 02:54:58PM +0200, Ruediger Pluem wrote: > Fails for me as well. Not sure what fails for Joe such that he removed the > include, but if it fails in case H2_USE_WEBSOCKETS is > not 1 I guess we could move the include (or even all) below the > > #if H2_USE_WEBSOCKETS > > lin

Re: svn commit: r1913006 - in /httpd/httpd/branches/2.4.x: ./modules/http2/h2.h

2023-10-16 Thread Joe Orton
On Mon, Oct 16, 2023 at 03:12:24PM +0200, SteffenAL wrote: > > checkout. > > > Looks like h2_ws.h : > > > Generating Code... > h2_ws.h > C:\VS17\Win32\httpd-2.4\modules\http2\h2.h(173,17): error C2143: syntax > error: missing ';' before '*' > C:\VS17\Win32\httpd-2.4\modules\http2\h2.h(173,17):

Re: windows block

2023-10-16 Thread Joe Orton
On Mon, Oct 16, 2023 at 04:45:29PM +0200, Stefan Eissing via dev wrote: > Do I make an rc3 nevertheless? Do we know someone else using VC? > > Advice appreciated. +1 for rc3 at r1913027. Someone using VC needs to work out how to fix that rather than just report it's broken, it shouldn't hold pr

Re: [VOTE] Release httpd-2.4.58-rc3 as httpd-2.4.58

2023-10-16 Thread Joe Orton
On Mon, Oct 16, 2023 at 05:08:11PM +0200, Stefan Eissing via dev wrote: > Hi all, > > after fixing my merge mistake in rc2 (sorry!), we go again: > > Please find below the proposed release tarball and signatures: > > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE

mod_dav_fs locking / Re: apr_dbm and concurrency

2023-11-23 Thread Joe Orton
Adding dev@httpd to a dev@apr thread about apr_dbm locking being broken. On Sun, Nov 12, 2023 at 07:43:13AM -0600, Greg Stein wrote: > Or, apps can stick to an older APR. ... we don't have to carry this forward > into future versions of APR (IMO). > > To your point, it is probably a single page w

Re: mod_dav_fs locking / Re: apr_dbm and concurrency

2023-11-24 Thread Joe Orton
On Thu, Nov 23, 2023 at 05:42:10PM +, Emmanuel Dreyfus wrote: > On Thu, Nov 23, 2023 at 05:36:06PM +0000, Joe Orton wrote: > > 3) in the mean time I worked up a PR for mod_dav_fs which adds a global > > mutex around the dbm lockdb use. This passes my stress tests for the

Re: svn commit: r1914365 - in /httpd/httpd/trunk: changes-entries/ssl-providers.txt docs/log-message-tags/next-number docs/manual/mod/mod_ssl.xml modules/ssl/ssl_engine_init.c modules/ssl/ssl_engine_p

2023-12-13 Thread Joe Orton
On Wed, Dec 06, 2023 at 01:02:01PM +0100, Yann Ylavic wrote: > Oh, scratch that. Actually the engine API requires a "SSLCryptoDevice > pkcs11" too, so we wouldn't take the !mc->szCryptoDevice path. > Sorry for the noise. Yes it should remain compatible like that, though you prompted me to re-read

Re: svn commit: r1914365 - in /httpd/httpd/trunk: changes-entries/ssl-providers.txt docs/log-message-tags/next-number docs/manual/mod/mod_ssl.xml modules/ssl/ssl_engine_init.c modules/ssl/ssl_engine_p

2023-12-13 Thread Joe Orton
On Wed, Dec 13, 2023 at 11:33:16AM +0100, Ingo Franzki wrote: > On 13.12.2023 10:55, Joe Orton wrote: > > On Wed, Dec 06, 2023 at 01:02:01PM +0100, Yann Ylavic wrote: > >> Oh, scratch that. Actually the engine API requires a "SSLCryptoDevice > >> pkcs11&q

Re: svn commit: r1914045 - in /httpd/httpd/trunk: changes-entries/ab-source-address.txt docs/man/ab.1 support/ab.c

2023-12-19 Thread Joe Orton
On Wed, Nov 22, 2023 at 05:19:50PM -, minf...@apache.org wrote: > Author: minfrin > Date: Wed Nov 22 17:19:49 2023 > New Revision: 1914045 > > URL: http://svn.apache.org/viewvc?rev=1914045&view=rev > Log: > Add an option to specify a source address. Saw this in the backports list - doesn't th

Re: [PATCH] mod_deflate: remove filter after seeing EOS

2023-12-20 Thread Joe Orton
On Mon, Oct 30, 2023 at 10:47:44AM -0400, Eric Norris via dev wrote: > Hello again, > > I'd like to politely bump this message to see if anyone would mind > taking a look at this patch, either here or on GitHub. Apologies, I got quite distracted by the "rapid reset" security stuff earlier in the

Re: [PATCH] mod_deflate: remove filter after seeing EOS

2023-12-20 Thread Joe Orton
On Wed, Dec 20, 2023 at 10:07:19AM -0500, Eric Norris via dev wrote: > Thanks Joe, and no need to apologize, that's totally understandable. > > I also appreciate you taking a look at the chunk filter behavior as that > was actually going to be the next patch I proposed. I had written it here: > ht

Re: [PATCH] mod_deflate: remove filter after seeing EOS

2023-12-20 Thread Joe Orton
On Wed, Dec 20, 2023 at 04:24:32PM +0100, Ruediger Pluem wrote: > On 12/20/23 4:08 PM, Yann Ylavic wrote: > > On Wed, Dec 20, 2023 at 2:40 PM Joe Orton wrote: > >> https://github.com/apache/httpd/pull/400 > > > > Thanks, looks good to me. > > +1 Thanks a

Re: svn commit: r1914804 - in /httpd/httpd/trunk: changes-entries/flushing-chunks.txt modules/http/chunk_filter.c

2023-12-20 Thread Joe Orton
On Wed, 20 Dec 2023, 16:30 Yann Ylavic, wrote: > On Wed, Dec 20, 2023 at 5:20 PM Yann Ylavic wrote: > > > > On Wed, Dec 20, 2023 at 4:56 PM wrote: > > > > > > Author: jorton > > > Date: Wed Dec 20 15:56:15 2023 > > > New Revision: 1914804 > > > > > > URL: http://svn.apache.org/viewvc?rev=191480

Re: PR #363

2024-01-25 Thread Joe Orton
On Thu, Jan 25, 2024 at 08:12:24AM +0100, Ruediger Pluem wrote: > Tried it in r1915391 and it seems to work. Not sure if there are > general downsides / objections with regards to symlinks in our > repository. But trunk is CTR :-). Oh, that looks really nice. +1 Thanks to you, Rich, and Mayank

CVE-2013-5704 fix breaks mod_wsgi

2015-01-09 Thread Joe Orton
Since Jim is talking 2.4.11, I should report this now. We discovered this week in Fedora: mod_wsgi does some interesting things in daemon mode, notably that it allocates a request_rec internally which ends up getting used by httpd. Reason is, the fix for CVE-2013-5704 extends the request_rec:

Re: CVE-2013-5704 fix breaks mod_wsgi

2015-01-12 Thread Joe Orton
On Sat, Jan 10, 2015 at 09:04:12AM +1100, Graham Dumpleton wrote: > 1. Verify that recompiling mod_wsgi is actually sufficient given than my > direct use of request_rec isn't going to populate the extra fields and they > will remain NULL still. As trailers shouldn't be expected in context the > req

Re: CVE-2013-5704 fix breaks mod_wsgi

2015-01-12 Thread Joe Orton
On Sat, Jan 10, 2015 at 07:38:03AM -0500, Jeff Trawick wrote: > On Fri, Jan 9, 2015 at 3:48 PM, Jeff Trawick wrote: > > * Add helper functions to allocate a request_rec, conn_rec, server_rec. > > It doesn't solve all possible problems of course but can drastically reduce > > the frequency of needi

Re: CVE-2013-5704 fix breaks mod_wsgi

2015-01-12 Thread Joe Orton
On Mon, Jan 12, 2015 at 11:25:53AM -0500, Eric Covener wrote: > On Fri, Jan 9, 2015 at 3:23 PM, Joe Orton wrote: > > Either way, the fix for CVE-2013-5704 ends up breaking backwards > > compatibility with existing 2.4.x builds of mod_wsgi, which is kind of > > Bad. I don&#

Re: namespacing in mod_ssl

2015-04-20 Thread Joe Orton
On Thu, Apr 16, 2015 at 06:42:04AM +0200, Kaspar Brand wrote: > On 15.04.2015 18:36, Stefan Sperling wrote: > > However, the actual issue here is that mod_ssl is squatting the SSL_ > > namespace. > > Historically this may have made sense (it seems mod_ssl and OpenSSL have > > shared history/author

Re: Using UPN from subjectAltName with SSLUserName

2015-07-13 Thread Joe Orton
On Sat, Jul 11, 2015 at 04:40:20PM +0200, Kaspar Brand wrote: > @@ -1902,5 +1907,7 @@ apr_status_t ssl_init_ModuleKill(void *data) > > free_dh_params(); > > +OBJ_cleanup(); > + > return APR_SUCCESS; >From being burnt previously three or four times, I get scared by OpenSSL proces

Re: Using UPN from subjectAltName with SSLUserName

2015-08-03 Thread Joe Orton
On Sun, Aug 02, 2015 at 09:33:48AM +0200, Kaspar Brand wrote: > On 19.07.2015 17:24, Kaspar Brand wrote: > > But, to be on the safe side, I think we could a) move the OBJ_create() > > call to ssl_hook_pre_config and b) omit OBJ_cleanup(). Do you concur? > > For the record: I have now committed thi

Re: logio problem with SSL

2015-09-25 Thread Joe Orton
On Fri, Sep 25, 2015 at 09:50:04AM +0200, Yann Ylavic wrote: > On Fri, Sep 25, 2015 at 1:00 AM, Yann Ylavic wrote: > > On Fri, Sep 25, 2015 at 12:22 AM, Eric Covener wrote: > >> > >> two logs (http/https) sorted to top of autoindex here: > >> http://people.apache.org/~covener/ > > > > Looks like

  1   2   3   4   5   6   7   8   9   10   >