Re: [Regression in httpd 2.4.52] mod_dav: Potentially unbounded memory usage in PROPFIND with dav_get_props() and dav_propfind_walker()

2022-01-18 Thread Ruediger Pluem
On 1/18/22 2:58 PM, Evgeny Kotkov wrote: > Ruediger Pluem writes: > >> Can you please check if the below patch fixes your issue? > > I have to say that the reason and the original intention of using > resource->pool's userdata here are still somewhat unclear to me. An application seems to be

Re: [Regression in httpd 2.4.52] mod_dav: Potentially unbounded memory usage in PROPFIND with dav_get_props() and dav_propfind_walker()

2022-01-18 Thread Evgeny Kotkov
Ruediger Pluem writes: > Can you please check if the below patch fixes your issue? I have to say that the reason and the original intention of using resource->pool's userdata here are still somewhat unclear to me. But it does look like the patch performs the allocation only once per resource->p

Re: [Regression in httpd 2.4.52] mod_dav: Potentially unbounded memory usage in PROPFIND with dav_get_props() and dav_propfind_walker()

2022-01-14 Thread Ruediger Pluem
On 1/14/22 1:57 PM, Evgeny Kotkov wrote: > Hi, > > I might have stumbled across a regression in httpd 2.4.52 where mod_dav was > changed in a way where dav_get_props() now allocates data in resource->pool. > > I think that r1879889 [1] is the change that is causing the new behavior. > This cha

Re: [Regression in httpd 2.4.49] mod_dav: REPORT requests no longer return errors

2021-09-23 Thread Ruediger Pluem
On 9/22/21 4:08 PM, Ruediger Pluem wrote: > > > On 9/22/21 3:49 PM, Evgeny Kotkov wrote: >> Ruediger Pluem writes: >> >>> Does the attached patch solve your issue? >> >> It does appear to solve the problem with missing errors, thanks! >> >> I haven't checked that in detail, but I think there

Re: [Regression in httpd 2.4.49] mod_dav: REPORT requests no longer return errors

2021-09-22 Thread Ruediger Pluem
On 9/22/21 3:49 PM, Evgeny Kotkov wrote: > Ruediger Pluem writes: > >> Does the attached patch solve your issue? > > It does appear to solve the problem with missing errors, thanks! > > I haven't checked that in detail, but I think there might be a discrepancy > in how `err` is handled in th

Re: [Regression in httpd 2.4.49] mod_dav: REPORT requests no longer return errors

2021-09-22 Thread Evgeny Kotkov
Ruediger Pluem writes: > Does the attached patch solve your issue? It does appear to solve the problem with missing errors, thanks! I haven't checked that in detail, but I think there might be a discrepancy in how `err` is handled in the patch and for example when calling the method_preconditio

Re: [Regression in httpd 2.4.49] mod_dav: REPORT requests no longer return errors

2021-09-21 Thread Ruediger Pluem
Does the attached patch solve your issue? Regards Rüdiger On 9/20/21 8:01 PM, Evgeny Kotkov wrote: > Hi, > > I think that I have stumbled across a significant regression in httpd 2.4.49 > where mod_dav has been changed in a way that makes it ignore the errors > returned by a versioning provider

Re: Regression?

2019-02-19 Thread Stefan Eissing
> Am 18.02.2019 um 23:55 schrieb Gregg Smith : > > When setting a header it used to set the header case-sensitive as configured. > Now with 2.4.38 it sets in all lower case. Regression? > > Header always set X-Xss-Protection "1; mode=block" > Result; > 2.4.37: X-Xss-Protection: 1; mode=block

Re: Regression?

2019-02-18 Thread Marion & Christophe JAILLET
Le 18/02/2019 à 23:55, Gregg Smith a écrit : When setting a header it used to set the header case-sensitive as configured. Now with 2.4.38 it sets in all lower case. Regression? Header always set X-Xss-Protection "1; mode=block" Result; 2.4.37: X-Xss-Protection: 1; mode=block 2.4.38: x-xss-pr

[RESOLVED] Re: Regression with CMake Windows builds, 2.4.29 is the last one passing

2018-07-20 Thread Michal Karm
On 07/19/2018 08:18 PM, William A Rowe Jr wrote: > Hi Michal, thanks for your report. > > On Thu, Jul 19, 2018 at 10:36 AM, Michal Karm > wrote: > > Hi guys, > > I would like to ask whether there are any plans on > accepting [1] patch to 2.4.x as it kee

Re: Regression with CMake Windows builds, 2.4.29 is the last one passing

2018-07-19 Thread William A Rowe Jr
FWIW, the correct fix seems to be to fix the regression in http://svn.apache.org/viewvc?rev=1832609&view=rev rather than the windows build. On Thu, Jul 19, 2018, 13:18 William A Rowe Jr wrote: > Hi Michal, thanks for your report. > > On Thu, Jul 19, 2018 at 10:36 AM, Michal Karm > wrote: > >> H

Re: Regression with CMake Windows builds, 2.4.29 is the last one passing

2018-07-19 Thread William A Rowe Jr
Hi Michal, thanks for your report. On Thu, Jul 19, 2018 at 10:36 AM, Michal Karm wrote: > Hi guys, > > I would like to ask whether there are any plans on > accepting [1] patch to 2.4.x as it keeps failing the CMake Windows build. > > Furthermore, there is a regression [2] in 2.4.34 CMake Windows

Re: Regression: mod_http2 continues to process abandoned connection

2016-06-18 Thread Michael Kaufmann
Hi Stefan, Yes, the patch solves the problem for me :-) Thanks a bunch! Regards, Michael Zitat von Stefan Eissing : Michael, I can reproduce the problem and habe a fix. Can you test if the following patch also solves the problem for you? Thanks! Index: modules/http2/h2_mplx.c

Re: Regression: mod_http2 continues to process abandoned connection

2016-06-18 Thread Stefan Eissing
Michael, I can reproduce the problem and habe a fix. Can you test if the following patch also solves the problem for you? Thanks! Index: modules/http2/h2_mplx.c === --- modules/http2/h2_mplx.c (revision 1748955) +++ modules/http2

Re: Regression: mod_http2 continues to process abandoned connection

2016-06-17 Thread Stefan Eissing
Ok, need to verify this tomorrow in order to reproduce and assess. I see from your log that the whole thing gets cleaned up eventually. But relying on Timeout to save the day is not good... -Stefan > Am 17.06.2016 um 16:40 schrieb Michael Kaufmann : > > Hi, > > I have found a regression in mo

Re: regression in r1698239

2015-08-28 Thread Stefan Eissing
Works fine here. Thanks! > Am 28.08.2015 um 15:14 schrieb Eric Covener : > > Thanks -- back in 1698334 with loops that actually move. > > On Fri, Aug 28, 2015 at 8:55 AM, Eric Covener wrote: >> On Fri, Aug 28, 2015 at 8:54 AM, Stefan Eissing >> wrote: >>> Change 1698239 brings t/apache/pr17629

Re: regression in r1698239

2015-08-28 Thread Eric Covener
Thanks -- back in 1698334 with loops that actually move. On Fri, Aug 28, 2015 at 8:55 AM, Eric Covener wrote: > On Fri, Aug 28, 2015 at 8:54 AM, Stefan Eissing > wrote: >> Change 1698239 brings t/apache/pr17629.t into an endless loop now. I built >> on r1698322 in trunk (OSX + Ubuntu). >> >> I

Re: regression in r1698239

2015-08-28 Thread Eric Covener
On Fri, Aug 28, 2015 at 8:54 AM, Stefan Eissing wrote: > Change 1698239 brings t/apache/pr17629.t into an endless loop now. I built on > r1698322 in trunk (OSX + Ubuntu). > > I revert the change now. A certain "covener" might want to look into this. ;-) > > Cheers, Thanks, go ahead and revert.

Re: Regression with range fix

2011-08-31 Thread William A. Rowe Jr.
On 8/31/2011 4:00 PM, Stefan Fritsch wrote: > On Wednesday 31 August 2011, Joe Orton wrote: >> >> Anything else to watch out for? > > c) a request with a byterange beyond the end of the file used to > return 416 but now returns 200. This is a violation of a RFC2616 > SHOULD. We didn't catch this

Re: Regression with range fix

2011-08-31 Thread Stefan Fritsch
On Wednesday 31 August 2011, Joe Orton wrote: > On Tue, Aug 30, 2011 at 08:51:55PM +0200, Stefan Fritsch wrote: > > The first regression report, though slightly too late for the > > vote: > > > > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=639825 > > > > The byterange_filter.c in the Debian

Re: Regression with range fix

2011-08-31 Thread Jim Jagielski
On Aug 31, 2011, at 8:21 AM, Plüm, Rüdiger, VF-Group wrote: > > >> -Original Message- >> From: Joe Orton [mailto:jor...@redhat.com] >> Sent: Mittwoch, 31. August 2011 11:13 >> To: dev@httpd.apache.org >> Subject: Re: Regression with range fix >&

RE: Regression with range fix

2011-08-31 Thread Plüm, Rüdiger, VF-Group
> -Original Message- > From: Joe Orton [mailto:jor...@redhat.com] > Sent: Mittwoch, 31. August 2011 11:13 > To: dev@httpd.apache.org > Subject: Re: Regression with range fix > > On Tue, Aug 30, 2011 at 08:51:55PM +0200, Stefan Fritsch wrote: > > The firs

Re: Regression with range fix

2011-08-31 Thread Joe Orton
On Tue, Aug 30, 2011 at 08:51:55PM +0200, Stefan Fritsch wrote: > The first regression report, though slightly too late for the vote: > > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=639825 > > The byterange_filter.c in the Debian update is exactly the one from > 2.2.20. I will keep you upda