Re: svn commit: r569204 - in /httpd/httpd/trunk/modules/experimental: config.m4 mod_rewrite_filter.c mod_sedfilter.c
On 08/24/2007 05:30 AM, William A. Rowe, Jr. wrote: Roy T. Fielding wrote: On Aug 23, 2007, at 7:21 PM, William A. Rowe, Jr. wrote: Joshua Slive wrote: On 8/23/07, William A. Rowe, Jr. [EMAIL PROTECTED] wrote: I changed it, I'll be happy (urp) to change it again [ ] mod_pcre_filter [ ] mod_text_filter [*] mod_subst_filter [ ] mod_rewrite_filter or [*] mod_substitute or [*] mod_regex_replace, or ... [*] mod_substitute Regards Rüdiger
Re: svn commit: r569204 - in /httpd/httpd/trunk/modules/experimental: config.m4 mod_rewrite_filter.c mod_sedfilter.c
Ruediger Pluem wrote: On 08/24/2007 05:30 AM, William A. Rowe, Jr. wrote: Roy T. Fielding wrote: On Aug 23, 2007, at 7:21 PM, William A. Rowe, Jr. wrote: Joshua Slive wrote: On 8/23/07, William A. Rowe, Jr. [EMAIL PROTECTED] wrote: I changed it, I'll be happy (urp) to change it again [ ] mod_pcre_filter [ ] mod_text_filter [*] mod_subst_filter [ ] mod_rewrite_filter or [*] mod_substitute or [*] mod_regex_replace, or ... [*] mod_substitute I'm the same as Ruediger, but would also suggest mod_replace. regards Ian Regards Rüdiger
Re: svn commit: r569204 - in /httpd/httpd/trunk/modules/experimental: config.m4 mod_rewrite_filter.c mod_sedfilter.c
Jim Jagielski wrote: On Aug 23, 2007, at 8:54 PM, [EMAIL PROTECTED] wrote: Author: wrowe Date: Thu Aug 23 17:54:15 2007 New Revision: 569204 URL: http://svn.apache.org/viewvc?rev=569204view=rev Log: SEDFILTER has several anomolies; first, it's not SED syntax, but more mod-rewrite like (and using the rewrite pcre parser). Secondly, 'FILTER' in the filter name is redundant. Simplify, by renaming this 'REWRITE' filter. IMO, changing this from sedfilter to mod_rewrite_filter actually is more confusing (or would be) to end users, since we have a mod_rewrite already. IMO mod_rewrite_content would be a better choice, esp if mod_rewrite was called mod_rewrite_url... Ack, I've heard that. Was seeking a name that might fit better, but I can certainly appreciate how this might be confusing. Plus, it doesn't deserve the swiss army knife stigma that mod_rewrite has. In any case, I don't feel strongly enough about it to do anymore than send this single post... Actually, please scroll down to the dialog, some good ideas down there. I'm only waiting for a couple people to agree on a name to adjust this once again :) Bill
Re: svn commit: r569204 - in /httpd/httpd/trunk/modules/experimental: config.m4 mod_rewrite_filter.c mod_sedfilter.c
On Aug 24, 2007, at 4:03 AM, Ian Holsman wrote: Ruediger Pluem wrote: On 08/24/2007 05:30 AM, William A. Rowe, Jr. wrote: Roy T. Fielding wrote: On Aug 23, 2007, at 7:21 PM, William A. Rowe, Jr. wrote: Joshua Slive wrote: On 8/23/07, William A. Rowe, Jr. [EMAIL PROTECTED] wrote: I changed it, I'll be happy (urp) to change it again [ ] mod_pcre_filter [ ] mod_text_filter [*] mod_subst_filter [ ] mod_rewrite_filter or [*] mod_substitute or [*] mod_regex_replace, or ... [*] mod_substitute I'm the same as Ruediger, but would also suggest mod_replace. regards I like mod_substitute... (I thought filter was redundant *duck* :) ) mod_edit_response ??
Re: svn commit: r569204 - in /httpd/httpd/trunk/modules/experimental: config.m4 mod_rewrite_filter.c mod_sedfilter.c
Jim Jagielski wrote: Ruediger Pluem wrote: Roy T. Fielding wrote: or [*] mod_substitute [*] mod_substitute I like mod_substitute... (I thought filter was redundant *duck* :) ) So mod_substitute it is :) Fixing
Re: svn commit: r569204 - in /httpd/httpd/trunk/modules/experimental: config.m4 mod_rewrite_filter.c mod_sedfilter.c
[EMAIL PROTECTED] wrote: Author: wrowe Date: Thu Aug 23 17:54:15 2007 New Revision: 569204 URL: http://svn.apache.org/viewvc?rev=569204view=rev Log: SEDFILTER has several anomolies; first, it's not SED syntax, but more mod-rewrite like (and using the rewrite pcre parser). Secondly, 'FILTER' in the filter name is redundant. Simplify, by renaming this 'REWRITE' filter. Added: httpd/httpd/trunk/modules/experimental/mod_rewrite_filter.c - copied, changed from r568483, httpd/httpd/trunk/modules/experimental/mod_sedfilter.c My -1 was out there for a number of months, without the essential objection being addressed. Since it wasn't addressed, I'm exercising my only alternative to an outright veto. If we can't find a compromise, of course we can revert the entire story, but I'd like to avoid that. I'm happy with a number of alternative names, mod_pcre_filter, mod_text_filter, mod_subst_filter, whatever, a number come to mind. The fact is, mod_sed_filter was nothing close to a sed implementation. Yes, I'm more of an awk fanboi than a sed user, but I'd expect a sed_filter to be exactly that. I'm also completely and perpetually irritated by some companies such as M$ which don't respect the existing glossaries of computer science, insisting on inventing new words or using the wrong words for old ideas :) And before anyone claims it's near enough - yes - there really is one. http//happygiraffe.net/mod_sed Bill
Re: svn commit: r569204 - in /httpd/httpd/trunk/modules/experimental: config.m4 mod_rewrite_filter.c mod_sedfilter.c
Joshua Slive wrote: On 8/23/07, William A. Rowe, Jr. [EMAIL PROTECTED] wrote: I'm happy with a number of alternative names, mod_pcre_filter, mod_text_filter, mod_subst_filter, whatever, a number come to mind. The fact is, mod_sed_filter was nothing close to a sed implementation. I hate mod_rewrite_filter. That's just asking for confusion with mod_rewrite. I prefer any of the above suggestions. (But then again, I'm not planning to make the change myself, so feel free to ignore me.) I changed it, I'll be happy (urp) to change it again [ ] mod_pcre_filter [ ] mod_text_filter [ ] mod_subst_filter [ ] mod_rewrite_filter My vote is the last one. Here's my thought... ...I believe we should extend the module to also accept env replacements from the current request. Sure, it's not there yet, but with that feature, it maps to rewrite more closely than most anything. But cast away, and I'll switch. Bill
Re: svn commit: r569204 - in /httpd/httpd/trunk/modules/experimental: config.m4 mod_rewrite_filter.c mod_sedfilter.c
On Aug 23, 2007, at 7:21 PM, William A. Rowe, Jr. wrote: Joshua Slive wrote: On 8/23/07, William A. Rowe, Jr. [EMAIL PROTECTED] wrote: I'm happy with a number of alternative names, mod_pcre_filter, mod_text_filter, mod_subst_filter, whatever, a number come to mind. The fact is, mod_sed_filter was nothing close to a sed implementation. I hate mod_rewrite_filter. That's just asking for confusion with mod_rewrite. I prefer any of the above suggestions. (But then again, I'm not planning to make the change myself, so feel free to ignore me.) That was my thought as well -- it is hard enough to document mod_rewrite already. I changed it, I'll be happy (urp) to change it again [ ] mod_pcre_filter [ ] mod_text_filter [ ] mod_subst_filter [ ] mod_rewrite_filter My vote is the last one. Here's my thought... mod_subst_filter, or mod_substitute, or mod_regex_replace, or ... ...I believe we should extend the module to also accept env replacements from the current request. Sure, it's not there yet, but with that feature, it maps to rewrite more closely than most anything. And that's a good thing? Modules are supposed to be, well, modular. Roy
Re: svn commit: r569204 - in /httpd/httpd/trunk/modules/experimental: config.m4 mod_rewrite_filter.c mod_sedfilter.c
Roy T. Fielding wrote: On Aug 23, 2007, at 7:21 PM, William A. Rowe, Jr. wrote: Joshua Slive wrote: On 8/23/07, William A. Rowe, Jr. [EMAIL PROTECTED] wrote: I'm happy with a number of alternative names, mod_pcre_filter, mod_text_filter, mod_subst_filter, whatever, a number come to mind. The fact is, mod_sed_filter was nothing close to a sed implementation. I hate mod_rewrite_filter. That's just asking for confusion with mod_rewrite. I prefer any of the above suggestions. (But then again, I'm not planning to make the change myself, so feel free to ignore me.) That was my thought as well -- it is hard enough to document mod_rewrite already. I changed it, I'll be happy (urp) to change it again [ ] mod_pcre_filter [ ] mod_text_filter [*] mod_subst_filter [ ] mod_rewrite_filter or [*] mod_substitute or [*] mod_regex_replace, or ... Yup, more good suggestions. (Transliterating your choices, and others sure can consider those too.) ...I believe we should extend the module to also accept env replacements from the current request. Sure, it's not there yet, but with that feature, it maps to rewrite more closely than most anything. And that's a good thing? Modules are supposed to be, well, modular. Of course :) Actually, the implementation looks nothing like mod_rewrite's. Given that the pattern match/replace is the most expensive, and the list of these substitutions is short, it's probably cheapest to build two pattern lists, those with env substitutions and those without. Those that have any substitions can build a temp table of those entries, appending on a copy of the constant list at request run time. (Of course the constants themselves would not be duplicated, just their indexes, and only if there are any dynamic entries to process). Bill
