Re: maintainer mode and test framework

2015-08-25 Thread William A Rowe Jr
Late declarations, all fixed now in r1697392

On Tue, Aug 25, 2015 at 10:13 AM, Jim Jagielski  wrote:

>
> > On Aug 24, 2015, at 9:23 AM, Stefan Eissing <
> stefan.eiss...@greenbytes.de> wrote:
> >
> > Just a tiny question how the senior guys here do to:
> >
> > If I build httpd in maintainer-mode (which I want), the test framework
> will no longer build since it inherits the compiler flags from apxs, I
> assume.
> >
> > Is there an easy way around this?
> >
>
> I *always* build in maintainer-mode and never have had the test
> framework not build... What issues are you having?
>
>
>


Re: maintainer mode and test framework

2015-08-25 Thread Jim Jagielski

> On Aug 24, 2015, at 9:23 AM, Stefan Eissing  
> wrote:
> 
> Just a tiny question how the senior guys here do to:
> 
> If I build httpd in maintainer-mode (which I want), the test framework will 
> no longer build since it inherits the compiler flags from apxs, I assume.
> 
> Is there an easy way around this?
> 

I *always* build in maintainer-mode and never have had the test
framework not build... What issues are you having?




Re: maintainer mode and test framework

2015-08-24 Thread William A Rowe Jr
On Aug 24, 2015 08:45, "Eric Covener"  wrote:
>
> On Mon, Aug 24, 2015 at 9:41 AM, Stefan Eissing
>  wrote:
> > mod_test_session.c did some non C90 variable declarations intermixed
with code. I'll check in the fix shortly. Btw. what is holding us back from
more recent C? Old platforms, obviously... Do we have an idea which?
>
> Ah, that is a brand new test module committed this month.
>
> I am not sure exactly where we really have the constraint.  Visual
> Studio 6 on Windows in the old releases?  I think my own pet/corporate
> overlord platforms (z/OS, AIX) are not an issue.

No issue on MS, plenty of more modern compilers, but MS C has been MS C++
with all sort of other oddities forever.

I am thinking oddballs like hpux and old Solaris compilers, but in trunk do
we really need to keep accommodating for httpd 2.6/3.0?

In the test suite, since it is used to validate legacy httpd, it seems
prudent to keep compatibility for a while longer still.


Re: maintainer mode and test framework

2015-08-24 Thread Eric Covener
On Mon, Aug 24, 2015 at 9:41 AM, Stefan Eissing
 wrote:
> mod_test_session.c did some non C90 variable declarations intermixed with 
> code. I'll check in the fix shortly. Btw. what is holding us back from more 
> recent C? Old platforms, obviously... Do we have an idea which?

Ah, that is a brand new test module committed this month.

I am not sure exactly where we really have the constraint.  Visual
Studio 6 on Windows in the old releases?  I think my own pet/corporate
overlord platforms (z/OS, AIX) are not an issue.


Re: maintainer mode and test framework

2015-08-24 Thread Stefan Eissing
OK, now you made me fix it. ;-)

mod_test_session.c did some non C90 variable declarations intermixed with code. 
I'll check in the fix shortly. Btw. what is holding us back from more recent C? 
Old platforms, obviously... Do we have an idea which?

> Am 24.08.2015 um 15:24 schrieb Eric Covener :
> 
> On Mon, Aug 24, 2015 at 9:23 AM, Stefan Eissing
>  wrote:
>> Just a tiny question how the senior guys here do to:
>> 
>> If I build httpd in maintainer-mode (which I want), the test framework will 
>> no longer build since it inherits the compiler flags from apxs, I assume.
>> 
>> Is there an easy way around this?
>> 
> 
> You could edit build/config_vars.mk in a pinch.  I don't think I've
> ever had that harm the test framework. What fails in the framework?

bytes GmbH
Hafenweg 16, 48155 Münster, Germany
Phone: +49 251 2807760. Amtsgericht Münster: HRB5782





Re: maintainer mode and test framework

2015-08-24 Thread Eric Covener
On Mon, Aug 24, 2015 at 9:23 AM, Stefan Eissing
 wrote:
> Just a tiny question how the senior guys here do to:
>
> If I build httpd in maintainer-mode (which I want), the test framework will 
> no longer build since it inherits the compiler flags from apxs, I assume.
>
> Is there an easy way around this?
>

You could edit build/config_vars.mk in a pinch.  I don't think I've
ever had that harm the test framework. What fails in the framework?


maintainer mode and test framework

2015-08-24 Thread Stefan Eissing
Just a tiny question how the senior guys here do to:

If I build httpd in maintainer-mode (which I want), the test framework will no 
longer build since it inherits the compiler flags from apxs, I assume.

Is there an easy way around this?

//Stefan

bytes GmbH
Hafenweg 16, 48155 Münster, Germany
Phone: +49 251 2807760. Amtsgericht Münster: HRB5782