Re: Maven. Issues with flatten plugin

Folks, thank you! I hope now we can now avoid transitive dependencies enlisting in each module. It will remove odd work from test development. пт, 16 мар. 2018 г. в 15:48, Nikolay Izhikov : > Hello, guys. > > We finally updated flatten plugin in master. > > Petr Ivanov,

Re: Maven. Issues with flatten plugin

Hello, guys. We finally updated flatten plugin in master. Petr Ivanov, Alex Volkov - thank you very much! В Пт, 02/03/2018 в 16:45 +0300, Petr Ivanov пишет: > Updated all maven definitions I’ve found in templates of test project. > Please, try once more. > > > > > On 2 Mar 2018, at 16:36,

Re: Maven. Issues with flatten plugin

Hello, Petr, Pavel. Petr, huge thanks for a Team City configuration! It really helps! After couple iteration of Team City configuring for a new maven it almost done. I see maven version error in: 1. Ignite Platform CPP Linux [1] 2. Ignite Platform .NET NuGet [2] Seems like maven runed some

Re: Maven. Issues with flatten plugin

Updated all maven definitions I’ve found in templates of test project. Please, try once more. > On 2 Mar 2018, at 16:36, Nikolay Izhikov wrote: > > Petr, thank you. > > But seems it doesn't help > > "Failed to execute goal

Re: Maven. Issues with flatten plugin

Petr, thank you. But seems it doesn't help "Failed to execute goal org.codehaus.mojo:flatten-maven-plugin:1.0.1:flatten (flatten) on project ignite-tools: The plugin org.codehaus.mojo:flatten-maven-plugin:1.0.1 requires Maven version 3.2.5"

Re: Maven. Issues with flatten plugin

Made some changes — 3.3.9 is now default maven. Please, rerun failed tests. > On 2 Mar 2018, at 13:21, Nikolay Izhikov wrote: > > Hello, Petr. > > I run TC for my PR [1] and have some issues on Team City: > > "Failed to execute goal

Re: Maven. Issues with flatten plugin

Hello, Petr. I run TC for my PR [1] and have some issues on Team City: "Failed to execute goal org.codehaus.mojo:flatten-maven-plugin:1.0.1:flatten (flatten) on project ignite-tools: The plugin org.codehaus.mojo:flatten-maven-plugin:1.0.1 requires Maven version 3.2.5" Can we update maven to

Re: Maven. Issues with flatten plugin

Sorry - IGNITE-7862 is the ticket. 2 марта 2018 г. 12:14 PM пользователь "Nikolay Izhikov" написал: > Dmitry. > I'm already done it. > Will return with PR and TC results soon > > 2 марта 2018 г. 11:53 AM пользователь "Dmitry Pavlov" < > dpavlov@gmail.com> написал: > >>

Re: Maven. Issues with flatten plugin

Dmitry. I'm already done it. Will return with PR and TC results soon 2 марта 2018 г. 11:53 AM пользователь "Dmitry Pavlov" написал: > Hi Petr, > > Thank you, it is great that you found the solution with low impact. > > Lets create ticket and merge PR. > > пт, 2 мар. 2018

Re: Maven. Issues with flatten plugin

Hi Petr, Thank you, it is great that you found the solution with low impact. Lets create ticket and merge PR. пт, 2 мар. 2018 г. в 10:06, Petr Ivanov : > The problem is solved by updating flatten-maven-plugin version to 1.0.1. > > Nikolay, please, double check it. > If it

Re: Maven. Issues with flatten plugin

The problem is solved by updating flatten-maven-plugin version to 1.0.1. Nikolay, please, double check it. If it really solves the problem, please, fill the ticket (or point to existing one), so I can update it and check impact on release procedure. > On 1 Mar 2018, at 17:04, Nikolay Izhikov

Re: Maven. Issues with flatten plugin

>> Anton, Vyacheslav — are you proposing assembly process shift to package >> phase, yet leaving the special profile for assembly itself? I'm talking about compile and package processes like it has been until 2.1 release. On Thu, Mar 1, 2018 at 6:00 PM, Dmitry Pavlov

Re: Maven. Issues with flatten plugin

Hi, I think we should solve initial problem: "We have to include all transitive dependencies into poms". I've faced with it during Direct IO plugin development. I am sure it is not best practice. Because 1st level dependency version change will require us to update 2nd level dependencies

Re: Maven. Issues with flatten plugin

Anton, Vyacheslav — are you proposing assembly process shift to package phase, yet leaving the special profile for assembly itself? > On 1 Mar 2018, at 14:36, Vyacheslav Daradur wrote: > > I agree with Anton, especially with the following statement: >>> Ignite should be

Re: Maven. Issues with flatten plugin

Petr. Thank you for trying! Did you remove 'test' dependencies before running commands? Because I commit in master only correct pom.xml for current build process, of course. But, to make things works I have to copy paste transitive dependencies from spark-core. 1 марта 2018 г. 4:55 PM

Re: Maven. Issues with flatten plugin

> > I don't get what is the point. > Did you try to reproduce issue? > Or should I provide full traces to you? > My point in inability to fully understand and describe the problem in terms of mechanism which causes it. For now I can see only indirect guessing. And yes, I’ve run your

Re: Maven. Issues with flatten plugin

> Which pom.xml? From the module modules/spark? Yes. > As I understand maven, test will be executed using dependencies from the reactor, not from local repository. I don't get what is the point. Did you try to reproduce issue? Or should I provide full traces to you? > What am I missing? I see

Re: Maven. Issues with flatten plugin

> 2. run: > > `~/src/ignite/modules/spark> mvn install -U > -Plgpl,examples,scala,-clean-libs,-release,ml > -Dtest=org.apache.ignite.testsuites.IgniteRDDTestSuite > -Dmaven.javadoc.skip=true -DfailIfNoTests=false` > > It will execute OK, because maven uses pom.xml from source. Which pom.xml?

Re: Maven. Issues with flatten plugin

I agree with Anton, especially with the following statement: >> Ignite should be assemblied using package phase, >> not install in case you want only to assembly it. Approach with "install" phase may lead to hidden issues in a development environment. On Thu, Mar 1, 2018 at 2:26 PM, Nikolay

Re: Maven. Issues with flatten plugin

> May be it will be enough to add a profile to parent pom.xml which activates on deploy stage only. I think it will be enough to solve my issue. > What pom.xml becomes flattened, what is removed from it and how it effects other modules of the same project? pom.xml that are installed to local

Re: Maven. Issues with flatten plugin

Nikolay, Sure, I think we have to create IEP "Assembly and Release cleanup and simplification". I see some issues can be attached to this IEP - Fabric word removal - Flatten plugin removal (in possible) - Ignite should be assemblied using package phase, not install in case you want only to

Re: Maven. Issues with flatten plugin

May be it will be enough to add a profile to parent pom.xml which activates on deploy stage only. Yet, I still do not get a mechanism that causes a problem. What pom.xml becomes flattened, what is removed from it and how it effects other modules of the same project? > On 1 Mar 2018, at

Re: Maven. Issues with flatten plugin

Andrey, thank you. If there are no other objections I will create ticket for pom structure refactoring. Anton, can you help me with it as an Ignite Release Manager? 2018-03-01 13:45 GMT+03:00 Andrey Novikov : > Nikolay, > > I think it can be removed, if parent-pom will be

Re: Maven. Issues with flatten plugin

Nikolay, I think it can be removed, if parent-pom will be installed(deployed). On Thu, Mar 1, 2018 at 5:05 PM, Nikolay Izhikov wrote: > Hello, Andrey. > > Thanks for an answer. > >> As I remember we use `flatten-maven-plugin` for flattening and removing >> parent

Re: Maven. Issues with flatten plugin

Hello, Andrey. Thanks for an answer. > As I remember we use `flatten-maven-plugin` for flattening and removing > parent relationship in deployed artifacts So we need it only in `release` profile? I found some earlier discussion about plugin [1] > in first versions of build, version was

Re: Maven. Issues with flatten plugin

Nikolay, As I remember we use `flatten-maven-plugin` for flattening and removing parent relationship in deployed artifacts (parent pom does not deploy to repository and in first versions of build, version was stored in variable in parent pom) On Thu, Mar 1, 2018 at 4:57 PM, Nikolay Izhikov

Re: Maven. Issues with flatten plugin

Hello, Petr. > Can you describe your problem In Ignite, maven doesn't include transitive dependencies to test classpath. So we have enlist all dependencies in project pom.xml. > desired behaviour All I want is default maven behavior. Please, take a look at pom.xml [1] from line 144. There is

Re: Maven. Issues with flatten plugin

Nikolay, Can you describe your problem and desired behaviour more thoroughly, please? > On 28 Feb 2018, at 21:16, Nikolay Izhikov wrote: > > Hello, Igniters. > > We have `flatten-maven-plugin` in `parent/pom.xml` [1] > As far as I can understand it minimize pom.xml