[Impala-CR](cdh5-2.6.0 5.8.0) PREVIEW: IMPALA-4223: Handle truncated file read from HDFS cache

2016-11-03 Thread Lars Volker (Code Review) 
Lars Volker has abandoned this change.

Change subject: PREVIEW: IMPALA-4223: Handle truncated file read from HDFS cache
..


Abandoned

-- 
To view, visit http://gerrit.cloudera.org:8080/4645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Id1e1fdb0211819c5938956abb13b512350a46f1a
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Lars Volker

[Impala-CR](cdh5-2.6.0 5.8.0) PREVIEW: IMPALA-4223: Handle truncated file read from HDFS cache

2016-11-03 Thread Lars Volker (Code Review) 
Lars Volker has posted comments on this change.

Change subject: PREVIEW: IMPALA-4223: Handle truncated file read from HDFS cache
..


Patch Set 1:

(1 comment)

> This should probably go in ASF's master branch, then get
 > cherry-picked.

Yes. This has been reviewed and merged into master here: 
https://gerrit.cloudera.org/#/c/4828/

I will coordinate the backporting efforts in the Jira.

http://gerrit.cloudera.org:8080/#/c/4645/1/be/src/runtime/disk-io-mgr-scan-range.cc
File be/src/runtime/disk-io-mgr-scan-range.cc:

PS1, Line 438: hadoopRzBufferFree(hdfs_file_->file(), cached_buffer_);
 : cached_buffer_ = NULL;
 : // Close file that was opened in Open().
 : io_mgr_->CacheOrCloseFileHandle(file(), hdfs_file_, false);
 : hdfs_file_ = NULL;
 : stringstream ss;
> Can't we just call ScanRange::Close()?
Done.


-- 
To view, visit http://gerrit.cloudera.org:8080/4645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1e1fdb0211819c5938956abb13b512350a46f1a
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Lars Volker 
Gerrit-HasComments: Yes

[Impala-CR](cdh5-2.6.0 5.8.0) PREVIEW: IMPALA-4223: Handle truncated file read from HDFS cache

2016-11-02 Thread Jim Apple (Code Review) 
Jim Apple has posted comments on this change.

Change subject: PREVIEW: IMPALA-4223: Handle truncated file read from HDFS cache
..


Patch Set 1:

This should probably go in ASF's master branch, then get cherry-picked.

-- 
To view, visit http://gerrit.cloudera.org:8080/4645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1e1fdb0211819c5938956abb13b512350a46f1a
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Lars Volker 
Gerrit-HasComments: No

[Impala-CR](cdh5-2.6.0 5.8.0) PREVIEW: IMPALA-4223: Handle truncated file read from HDFS cache

2016-10-18 Thread Dan Hecht (Code Review) 
Dan Hecht has posted comments on this change.

Change subject: PREVIEW: IMPALA-4223: Handle truncated file read from HDFS cache
..


Patch Set 1:

Same

-- 
To view, visit http://gerrit.cloudera.org:8080/4645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1e1fdb0211819c5938956abb13b512350a46f1a
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Lars Volker 
Gerrit-HasComments: No

[Impala-CR](cdh5-2.6.0 5.8.0) PREVIEW: IMPALA-4223: Handle truncated file read from HDFS cache

2016-10-14 Thread Bharath Vissapragada (Code Review) 
Bharath Vissapragada has posted comments on this change.

Change subject: PREVIEW: IMPALA-4223: Handle truncated file read from HDFS cache
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4645/1/be/src/runtime/disk-io-mgr-scan-range.cc
File be/src/runtime/disk-io-mgr-scan-range.cc:

PS1, Line 438: hadoopRzBufferFree(hdfs_file_->file(), cached_buffer_);
 : cached_buffer_ = NULL;
 : // Close file that was opened in Open().
 : io_mgr_->CacheOrCloseFileHandle(file(), hdfs_file_, false);
 : hdfs_file_ = NULL;
 : stringstream ss;
Can't we just call ScanRange::Close()?


-- 
To view, visit http://gerrit.cloudera.org:8080/4645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1e1fdb0211819c5938956abb13b512350a46f1a
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Lars Volker 
Gerrit-HasComments: Yes

[Impala-CR](cdh5-2.6.0 5.8.0) PREVIEW: IMPALA-4223: Handle truncated file read from HDFS cache

2016-10-14 Thread Lars Volker (Code Review) 
Lars Volker has posted comments on this change.

Change subject: PREVIEW: IMPALA-4223: Handle truncated file read from HDFS cache
..


Patch Set 1:

> > This should probably go in ASF's master branch, then get
 > > cherry-picked.
 > 
 > Any thoughts on this, Lars?

Yes, that sounds good to me. I asked everyone on the Jira for help with the 
original issue, as well as with reviewing this change, but haven't received any 
feedback on whether we want to move forward with this fix at least. However, I 
will go ahead, write a proper commit message and re-upload it to master.

-- 
To view, visit http://gerrit.cloudera.org:8080/4645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1e1fdb0211819c5938956abb13b512350a46f1a
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Lars Volker 
Gerrit-HasComments: No

[Impala-CR](cdh5-2.6.0 5.8.0) PREVIEW: IMPALA-4223: Handle truncated file read from HDFS cache

2016-10-14 Thread Jim Apple (Code Review) 
Jim Apple has posted comments on this change.

Change subject: PREVIEW: IMPALA-4223: Handle truncated file read from HDFS cache
..


Patch Set 1:

> This should probably go in ASF's master branch, then get
 > cherry-picked.

Any thoughts on this, Lars?

-- 
To view, visit http://gerrit.cloudera.org:8080/4645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1e1fdb0211819c5938956abb13b512350a46f1a
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: No

[Impala-CR](cdh5-2.6.0 5.8.0) PREVIEW: IMPALA-4223: Handle truncated file read from HDFS cache

2016-10-06 Thread Jim Apple (Code Review) 
Jim Apple has posted comments on this change.

Change subject: PREVIEW: IMPALA-4223: Handle truncated file read from HDFS cache
..


Patch Set 1:

This should probably go in ASF's master branch, then get cherry-picked.

-- 
To view, visit http://gerrit.cloudera.org:8080/4645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1e1fdb0211819c5938956abb13b512350a46f1a
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: No

[Impala-CR](cdh5-2.6.0 5.8.0) PREVIEW: IMPALA-4223: Handle truncated file read from HDFS cache

2016-10-06 Thread Lars Volker (Code Review) 
Lars Volker has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4645

Change subject: PREVIEW: IMPALA-4223: Handle truncated file read from HDFS cache
..

PREVIEW: IMPALA-4223: Handle truncated file read from HDFS cache

I need to write a proper commit message. For now see discussion in
IMPALA-4223 for details.

Change-Id: Id1e1fdb0211819c5938956abb13b512350a46f1a
---
M be/src/exec/scanner-context.cc
M be/src/runtime/disk-io-mgr-scan-range.cc
2 files changed, 15 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/45/4645/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id1e1fdb0211819c5938956abb13b512350a46f1a
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Lars Volker