[Toolchain-CR] Add CLEAN AFTER BUILD option to clean files during build
Tim Armstrong has submitted this change and it was merged. Change subject: Add CLEAN_AFTER_BUILD option to clean files during build .. Add CLEAN_AFTER_BUILD option to clean files during build This can reduce disk space usage for the build significantly. If CLEAN_AFTER_BUILD is set to 1, the source/ directory is cleaned after a successful build. These files can take up ~14GB after running buildall.sh, so cleaning them significantly reduces the disk space requirement. Change-Id: I064af33d2719592c9e2fdec3a699b4dad0e869e6 --- M functions.sh M init.sh 2 files changed, 25 insertions(+), 6 deletions(-) Approvals: Matthew Jacobs: Looks good to me, approved Tim Armstrong: Verified -- To view, visit http://gerrit.cloudera.org:8080/5313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I064af33d2719592c9e2fdec3a699b4dad0e869e6 Gerrit-PatchSet: 2 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong
[Toolchain-CR] Add CLEAN AFTER BUILD option to clean files during build
Matthew Jacobs has posted comments on this change. Change subject: Add CLEAN_AFTER_BUILD option to clean files during build .. Patch Set 2: Code-Review+2 nope -- To view, visit http://gerrit.cloudera.org:8080/5313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I064af33d2719592c9e2fdec3a699b4dad0e869e6 Gerrit-PatchSet: 2 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Toolchain-CR] Add CLEAN AFTER BUILD option to clean files during build
Tim Armstrong has posted comments on this change. Change subject: Add CLEAN_AFTER_BUILD option to clean files during build .. Patch Set 2: MJ - did you have any other comments? -- To view, visit http://gerrit.cloudera.org:8080/5313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I064af33d2719592c9e2fdec3a699b4dad0e869e6 Gerrit-PatchSet: 2 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Toolchain-CR] Add CLEAN AFTER BUILD option to clean files during build
Tim Armstrong has posted comments on this change. Change subject: Add CLEAN_AFTER_BUILD option to clean files during build .. Patch Set 2: Verified+1 http://unittest.jenkins.cloudera.com/job/verify-impala-toolchain-package-build/287/ -- To view, visit http://gerrit.cloudera.org:8080/5313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I064af33d2719592c9e2fdec3a699b4dad0e869e6 Gerrit-PatchSet: 2 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Toolchain-CR] Add CLEAN AFTER BUILD option to clean files during build
Tim Armstrong has posted comments on this change. Change subject: Add CLEAN_AFTER_BUILD option to clean files during build .. Patch Set 2: -Verified -- To view, visit http://gerrit.cloudera.org:8080/5313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I064af33d2719592c9e2fdec3a699b4dad0e869e6 Gerrit-PatchSet: 2 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Toolchain-CR] Add CLEAN AFTER BUILD option to clean files during build
Tim Armstrong has posted comments on this change. Change subject: Add CLEAN_AFTER_BUILD option to clean files during build .. Patch Set 2: Verified+1 All passed except what looks like some random flakiness. http://unittest.jenkins.cloudera.com/job/verify-impala-toolchain-package-build/286/ -- To view, visit http://gerrit.cloudera.org:8080/5313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I064af33d2719592c9e2fdec3a699b4dad0e869e6 Gerrit-PatchSet: 2 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Toolchain-CR] Add CLEAN AFTER BUILD option to clean files during build
Tim Armstrong has posted comments on this change. Change subject: Add CLEAN_AFTER_BUILD option to clean files during build .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5313/1/init.sh File init.sh: Line 53: # Clean the complete build > indicate this is before starting building Done PS1, Line 60: CLEAN_AFTER_BUILD > it might be worth naming this something that indicates it's cleaning the in Done -- To view, visit http://gerrit.cloudera.org:8080/5313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I064af33d2719592c9e2fdec3a699b4dad0e869e6 Gerrit-PatchSet: 1 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes
[Toolchain-CR] Add CLEAN AFTER BUILD option to clean files during build
Tim Armstrong has uploaded a new patch set (#2). Change subject: Add CLEAN_AFTER_BUILD option to clean files during build .. Add CLEAN_AFTER_BUILD option to clean files during build This can reduce disk space usage for the build significantly. If CLEAN_AFTER_BUILD is set to 1, the source/ directory is cleaned after a successful build. These files can take up ~14GB after running buildall.sh, so cleaning them significantly reduces the disk space requirement. Change-Id: I064af33d2719592c9e2fdec3a699b4dad0e869e6 --- M functions.sh M init.sh 2 files changed, 25 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Toolchain refs/changes/13/5313/2 -- To view, visit http://gerrit.cloudera.org:8080/5313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I064af33d2719592c9e2fdec3a699b4dad0e869e6 Gerrit-PatchSet: 2 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Matthew Jacobs
[Toolchain-CR] Add CLEAN AFTER BUILD option to clean files during build
Matthew Jacobs has posted comments on this change. Change subject: Add CLEAN_AFTER_BUILD option to clean files during build .. Patch Set 1: (2 comments) Thanks! http://gerrit.cloudera.org:8080/#/c/5313/1/init.sh File init.sh: Line 53: # Clean the complete build indicate this is before starting building PS1, Line 60: CLEAN_AFTER_BUILD it might be worth naming this something that indicates it's cleaning the intermediate build files, but I guess INTERMEDIATE is too long. Maybe CLEAN_TMP_AFTER_BUILD? Or I guess it's fine as is. -- To view, visit http://gerrit.cloudera.org:8080/5313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I064af33d2719592c9e2fdec3a699b4dad0e869e6 Gerrit-PatchSet: 1 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: Yes
[Toolchain-CR] Add CLEAN AFTER BUILD option to clean files during build
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5313 Change subject: Add CLEAN_AFTER_BUILD option to clean files during build .. Add CLEAN_AFTER_BUILD option to clean files during build This can reduce disk space usage for the build significantly. If CLEAN_AFTER_BUILD is set to 1, the source/ directory is cleaned after a successful build. These files can take up ~14GB after running buildall.sh, so cleaning them significantly reduces the disk space requirement. Change-Id: I064af33d2719592c9e2fdec3a699b4dad0e869e6 --- M functions.sh M init.sh 2 files changed, 24 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Toolchain refs/changes/13/5313/1 -- To view, visit http://gerrit.cloudera.org:8080/5313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I064af33d2719592c9e2fdec3a699b4dad0e869e6 Gerrit-PatchSet: 1 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Matthew Jacobs
