[jira] [Created] (IOTDB-206) IOTDB spark jdbc connector

2019-09-09 Thread Kaifeng Xue (Jira)
Kaifeng Xue created IOTDB-206: - Summary: IOTDB spark jdbc connector Key: IOTDB-206 URL: https://issues.apache.org/jira/browse/IOTDB-206 Project: Apache IoTDB Issue Type: New Feature

[jira] [Created] (IOTDB-205) Support retention policy

2019-09-09 Thread Jialin Qiao (Jira)
Jialin Qiao created IOTDB-205: - Summary: Support retention policy Key: IOTDB-205 URL: https://issues.apache.org/jira/browse/IOTDB-205 Project: Apache IoTDB Issue Type: New Feature

Re: Confused about one read method in TsFileInput interface

2019-09-09 Thread Yuan Tian
In fact, I am working on the hadoop-connector, so I should create a HDFSInput that implements TsFileInput interface for reading tsfile from HDFS. And actually, in DefaultTsFileInput, this method is unsupported which you can see in the following. @Override public int read(byte[] b, int off, int

Re: Confused about one read method in TsFileInput interface

2019-09-09 Thread Boris Zhu
Hi, tian DefaultTsFileInput is a class to implement TsFileInput interface. DefaultTsFileInput's method read actually change the position of itself because it uses java.io.FileChannel, and we can use a "position" method to change its position back. But I'm also confusing that why can't change the

Re: Confused about one read method in TsFileInput interface

2019-09-09 Thread Yuan Tian
Hi, Boris If the position is not specified, I think the position should be modified. There are two methods in TsFileInput interface that don’t have position parameter in their function signature. 1. int read(ByteBuffer dst) throws IOException; 2. int read() throws IOException; Actually, in

Re: Confused about one read method in TsFileInput interface

2019-09-09 Thread Boris Zhu
I check-in java doc and it says the file position is updated with the number of bytes actually read. You can see below * Reads a sequence of bytes from this channel into the given buffer. * * Bytes are read starting at this channel's current file position, and * then the file position is

Confused about one read method in TsFileInput interface

2019-09-09 Thread Yuan Tian
Hi, While implementing one read method(shown in the following) in TsFileInput interface, I don’t know whether to modify the position of TsFileInput. /** * read an array of byte from the Input. * * @param b -array of byte * @param off -offset of the Input * @param len -length */ int

Re: Confused about one read method in TsFileInput interface

2019-09-09 Thread Boris Zhu
I agree with you that shouldn’t modify the position of TsFileInput when having already specified the position. Sorry for the misunderstanding. But if not specified, should it be changed for hdfs or local? Best, Boris zhu On Mon, Sep 9, 2019 at 11:35 PM Yuan Tian wrote: > In fact, I am working

Re: Confused about one read method in TsFileInput interface

2019-09-09 Thread Yuan Tian
Hi, Boris Yes, like what I said, the method without position signature acts like the inputStream that you can’t manually change the position where you want to read. Instead, you can only read by order. The position will automatically move forward while you read data from the stream. Best,

Re: Confused about one read method in TsFileInput interface

2019-09-09 Thread Lei Rui
Hi, - `TsFileInput.read(ByteBuffer dst, long position)` does not modify this TsFileInput's position. It works just as the annotation depicts. If you do a simple experiment using the `class DefaultTsFileInput implements TsFileInput` to 1) position(), 2) read(ByteBuffer dst, long position),