Seemingly incorrect short-circuiting logic

2011-10-16 Thread Dave Brosius
Greetings, org.apache.jackrabbit.webdav.security.report.AclPrincipalReport.java does the following This logic seems wrong to me *if (href == null respMap.containsKey(href)) {* i'd expect it should be || correct? @Override public void init(DavResource resource, ReportInfo info)

Re: Seemingly incorrect short-circuiting logic

2011-10-16 Thread sebb
Wrong mailing list? This is Jakarta, not Jackrabbit ... On 17 October 2011 00:44, Dave Brosius dbros...@apache.org wrote: Greetings, org.apache.jackrabbit.webdav.security.report.AclPrincipalReport.java does the following This logic seems wrong to me *if (href == null

Re: Seemingly incorrect short-circuiting logic

2011-10-16 Thread Dave Brosius
Oops, my apologies :) On 10/16/2011 08:06 PM, sebb wrote: Wrong mailing list? This is Jakarta, not Jackrabbit ... On 17 October 2011 00:44, Dave Brosiusdbros...@apache.org wrote: Greetings, org.apache.jackrabbit.webdav.security.report.AclPrincipalReport.java does the following This logic