Github user asfgit closed the pull request at:
https://github.com/apache/jena/pull/70
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/62#issuecomment-103505735
Meaning split it into changes to
- jena-jdbc and its submodules
- all other modules
? For a total of two new PRs? Sorry to be so precise-- I just want to make
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/61#issuecomment-103520470
Should I wait for comment from @Claudenw or move to make three new PRs:
- `jena-elephas`
- `jena-querybuilder`
- everything else that was included here
Github user ajs6f closed the pull request at:
https://github.com/apache/jena/pull/61
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/61#issuecomment-103629462
Closed in favor of #67, #68, #69.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user ajs6f opened a pull request:
https://github.com/apache/jena/pull/70
JENA-938: Nonfunctional cleanup in various modules
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ajs6f/jena CleanupMisc
Alternatively you can
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/62#issuecomment-103566657
Cool. I'll get on that. Might take a day or two, because I'm going to use
it as a chance to improve my Gitcraft and try to understand how to split
commits on a condition
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/62#issuecomment-103564682
Good to be precise!
2 PRs would be fantastic - (1) jena-jdbc and everything below it; they all
go to make up jena-jdbc and (2) the rest.
---
If your project is set
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/61#issuecomment-103566061
I can process the everything else PR because I think I understand those
code modules well enough. If it's not much work, 3 PRs is a clear cut split
but if it turns into a lot
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/62#issuecomment-103158636
See my comment
[here](https://github.com/apache/jena/pull/61#issuecomment-102834531). Same
question applies.
---
If your project is set up for it, you can reply to this
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/61#issuecomment-103158295
I don't know if my Git-fu is up to splitting it, but I could certainly just
regenerate a new PR that is more restricted. Do you want to see one module :
one PR? Or can all
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/61#issuecomment-103207166
jena-elephas, querybuilder, and the rest (Fuseki's) would be great.
(Actually, looking at the querybuilder file, I wonder if that is a style for a
purpose ... @Claudenw?)
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/61#issuecomment-102834531
Would it be an easy task to possible to split this into jena-elephas
related changes and changas related to other modules? I'm not so familiar with
jena-elephas but I could
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/62#issuecomment-102834572
Would it be an easy task to possible to split this into jena-jdbc related
changes and changes related to other modules? (If it's not an easy task, I can
take a patch and edit
Github user asfgit closed the pull request at:
https://github.com/apache/jena/pull/60
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/60#issuecomment-102169543
I've picked out as much material from the PR as I can and applied according
to the discussions (so not removing interface declarations when the base type
includes it, left
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/63#issuecomment-101780114
Generally yes - fixes are better when possible. In this case though (on
`.factory`) there is a coding pattern than was fine at the time and now isn't.
The hiding effect is
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/63#issuecomment-101780453
Okay, whatever is useful is hopefully there for you without too much
trouble. Let me know if I can help-- part of my personal motive for these
wild-swinging clean up PRs is
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/63#issuecomment-101722026
I didn't see any such expansion of warnings, but that may have to do with
my IDE settings.
Generally, my take is that it's better to remove the warnings by fixing
Github user rvesse commented on the pull request:
https://github.com/apache/jena/pull/61#issuecomment-101187792
I not declaring unthrown checked exceptions is a Java 8-ism?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user rvesse commented on the pull request:
https://github.com/apache/jena/pull/61#issuecomment-101188048
Looking at this I realise that Java 8 potentially presents a problem for
Elephas because the entire Jena 3 stack is Java 8 and so Elephas has to be Java
8 yet most Hadoop
Github user kinow commented on the pull request:
https://github.com/apache/jena/pull/61#issuecomment-101210065
Umbrella ticket in Hadoop to support Java 8
https://issues.apache.org/jira/browse/HADOOP-11090
Guess it will still take a while.
---
If your project is set up for
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/63#issuecomment-101221776
This PR looks easier to process (it does not mix a lot of modules;
sometimes that mix means several people are going to be interested, but in
different parts).
How
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/63#issuecomment-101235688
They are, I hope, okay to merge in arbitrary order.
I made these PRs based on the idea that each covers enough ground to be
substantive without being too large to
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/61#issuecomment-101215479
One possibility is to keep Java8-isms out of Elephas (on a practical basis)
for the moment so backporting to 2.13.0 is a low barrier. Obviously, bug fixes
that go into 3.0.0
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/61#issuecomment-101214478
Actually, it looks like there is quite an impetus to get Hadoop on Java8
(even if Java6/7 bytecodes). EOL is making it a focus of attention.
---
If your project is set up for
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/63#issuecomment-101322670
When I applied the changes, I get a lot of hiding warnings. Seems to me
the root cause is the hiding in the first place, not the use of
`@SuppressWarnings(hiding)` which,
GitHub user ajs6f opened a pull request:
https://github.com/apache/jena/pull/60
JENA-938: Nonfunctional cleanup in various modules
Remove some forms of dead code from jena-arq, jena-base, jena-core,
jena-csv, jena-iri, an jena-permissions. Includes removals for:
Unthrown
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/60#issuecomment-101010157
The files in package thrift/wire starting `RDF_` are autogenerated by the
Thrift code generator. They'll get uncleaned if that's remade. (Thrift code
generation is not part of
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/63#discussion_r30086187
--- Diff: jena-core/src/main/java/jena/rdfcompare.java ---
@@ -108,11 +105,6 @@ protected static void usage() {
protected static void read(Model
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/60#issuecomment-101013671
Please, if it's easy to do that; ditto the javacc overwrites. (sparql_10
are sparql_11 actually code directly from SPARQL spec so anything touching them
gets special
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/60#issuecomment-101015106
Yes. (Sorry about assuming that was clear - over-familiarity with the code
layout)
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user ajs6f opened a pull request:
https://github.com/apache/jena/pull/63
JENA-938: Nonfunctional cleanup in various modules
Remove some forms of dead code from the src/main resources in jena-core and
jena-base, including:
Unnecessary @SuppressWarnings annotations
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/60#issuecomment-101011238
Hm. Do you think it's worth taking a look at those Thrift tools to see if I
can get them to gen cleaner code? (It has to be said that I've never used
Thrift.)
---
If your
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/60#issuecomment-101012864
Yeah, I know what Thrift is, but I have no direct experience with it. I've
worked with a few code generating frameworks (mostly for WSDL-related stuff)
that gave relatively
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/60#issuecomment-101014513
Okay, I will make that happen, but I'm not sure what you mean by javacc
overwrites. You mean methods `sparql_10` and `sparql_11`?
---
If your project is set up for it, you
GitHub user ajs6f opened a pull request:
https://github.com/apache/jena/pull/61
JENA-938: Nonfunctional cleanup in various modules
Remove some forms of dead code from jena-elephas and its submodules,
jena-querybuilder, and jena-fuseki1 and jena-fuseki2, including:
Unthrown
GitHub user ajs6f opened a pull request:
https://github.com/apache/jena/pull/62
JENA-938: Nonfunctional cleanup in various modules
Remove some forms of dead code from jena-jdbc and its submodules, jena-sdb,
jena-spatial, jena-tdb and jena-text, including:
Unthrown checked
38 matches
Mail list logo
