Re: svn commit: r1823083 - in /jmeter/trunk/bin: mirror-server.cmd mirror-server.sh

2018-02-05 Thread Felix Schumacher
Am 04.02.2018 14:41, schrieb Philippe Mouawad: We should also add integration tests that start jmeter using .sh/.bat (and mirror) to avoid issues like this one and the missing add-module on .bat Regards On Sunday, February 4, 2018, sebb wrote: It also might make sense to add a unit test to

Re: svn commit: r1823083 - in /jmeter/trunk/bin: mirror-server.cmd mirror-server.sh

2018-02-05 Thread Felix Schumacher
Am 04.02.2018 13:49, schrieb Milamber: Would be better if the version number uses a variable in the top of file? I can think of a few possible solutions for preventing a failure like this: * use a variable at the top like you proposed (question remains, who thinks of changing the value)

Re: svn commit: r1823083 - in /jmeter/trunk/bin: mirror-server.cmd mirror-server.sh

2018-02-04 Thread Philippe Mouawad
We should also add integration tests that start jmeter using .sh/.bat (and mirror) to avoid issues like this one and the missing add-module on .bat Regards On Sunday, February 4, 2018, sebb wrote: > It also might make sense to add a unit test to check the versions > against the build.properties

Re: svn commit: r1823083 - in /jmeter/trunk/bin: mirror-server.cmd mirror-server.sh

2018-02-04 Thread sebb
It also might make sense to add a unit test to check the versions against the build.properties file On 4 February 2018 at 12:49, Milamber wrote: > > Would be better if the version number uses a variable in the top of file? > > > On 04/02/2018 10:39, fschumac...@apache.org wrote: >> >> Author: fsc

Re: svn commit: r1823083 - in /jmeter/trunk/bin: mirror-server.cmd mirror-server.sh

2018-02-04 Thread Milamber
Would be better if the version number uses a variable in the top of file? On 04/02/2018 10:39, fschumac...@apache.org wrote: Author: fschumacher Date: Sun Feb 4 09:39:05 2018 New Revision: 1823083 URL: http://svn.apache.org/viewvc?rev=1823083&view=rev Log: Update classpath in mirror-server sc