[GitHub] kafka pull request: MINOR: Example style improvements

2016-02-20 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/940 MINOR: Example style improvements These are minor, but no reason to make our example code look worse than it has to. You can merge this pull request into a Git repository by running: $ git

[jira] [Updated] (KAFKA-3255) Extra unit tests for NetworkClient.connectionDelay(Node node, long now)

2016-02-20 Thread Frank Scholten (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Frank Scholten updated KAFKA-3255: -- Attachment: KAFKA-3255.patch > Extra unit tests for NetworkClient.connectionDelay(Node node,

[jira] [Created] (KAFKA-3255) Extra unit tests for NetworkClient.connectionDelay(Node node, long now)

2016-02-20 Thread Frank Scholten (JIRA)
Frank Scholten created KAFKA-3255: - Summary: Extra unit tests for NetworkClient.connectionDelay(Node node, long now) Key: KAFKA-3255 URL: https://issues.apache.org/jira/browse/KAFKA-3255 Project:

[jira] [Updated] (KAFKA-3255) Extra unit tests for NetworkClient.connectionDelay(Node node, long now)

2016-02-20 Thread Frank Scholten (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Frank Scholten updated KAFKA-3255: -- Labels: test (was: ) Fix Version/s: 0.9.0.1 Status: Patch Available

[jira] [Updated] (KAFKA-3255) Extra unit tests for NetworkClient.connectionDelay(Node node, long now)

2016-02-20 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-3255: --- Fix Version/s: (was: 0.9.0.1) 0.9.1.0 > Extra unit tests for

[jira] [Commented] (KAFKA-3255) Extra unit tests for NetworkClient.connectionDelay(Node node, long now)

2016-02-20 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155707#comment-15155707 ] Ismael Juma commented on KAFKA-3255: Thanks for the patch. Would you consider submitting a pull

[GitHub] kafka pull request: KAFKA-3255 Added unit tests for NetworkClient....

2016-02-20 Thread frankscholten
GitHub user frankscholten opened a pull request: https://github.com/apache/kafka/pull/941 KAFKA-3255 Added unit tests for NetworkClient.connectionDelay(Node node, long now) You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (KAFKA-3255) Extra unit tests for NetworkClient.connectionDelay(Node node, long now)

2016-02-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155719#comment-15155719 ] ASF GitHub Bot commented on KAFKA-3255: --- GitHub user frankscholten opened a pull request:

[jira] [Commented] (KAFKA-3255) Extra unit tests for NetworkClient.connectionDelay(Node node, long now)

2016-02-20 Thread Frank Scholten (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155720#comment-15155720 ] Frank Scholten commented on KAFKA-3255: --- Done https://github.com/apache/kafka/pull/941 > Extra unit

[jira] [Issue Comment Deleted] (KAFKA-3255) Extra unit tests for NetworkClient.connectionDelay(Node node, long now)

2016-02-20 Thread Frank Scholten (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Frank Scholten updated KAFKA-3255: -- Comment: was deleted (was: Done https://github.com/apache/kafka/pull/941) > Extra unit tests

[jira] [Created] (KAFKA-3256) Large number of system test failures

2016-02-20 Thread Geoff Anderson (JIRA)
Geoff Anderson created KAFKA-3256: - Summary: Large number of system test failures Key: KAFKA-3256 URL: https://issues.apache.org/jira/browse/KAFKA-3256 Project: Kafka Issue Type: Bug

[jira] [Assigned] (KAFKA-3256) Large number of system test failures

2016-02-20 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin reassigned KAFKA-3256: --- Assignee: Jiangjie Qin > Large number of system test failures >

[jira] [Commented] (KAFKA-3256) Large number of system test failures

2016-02-20 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155793#comment-15155793 ] Jiangjie Qin commented on KAFKA-3256: - [~hachikuji] Sure, I'm investigating. > Large number of system

[jira] [Commented] (KAFKA-3256) Large number of system test failures

2016-02-20 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155794#comment-15155794 ] Jiangjie Qin commented on KAFKA-3256: - [~hachikuji] It seems I am not be able to access the test

[jira] [Comment Edited] (KAFKA-3256) Large number of system test failures

2016-02-20 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155794#comment-15155794 ] Jiangjie Qin edited comment on KAFKA-3256 at 2/20/16 11:00 PM: --- [~hachikuji]

[jira] [Commented] (KAFKA-3256) Large number of system test failures

2016-02-20 Thread Geoff Anderson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155819#comment-15155819 ] Geoff Anderson commented on KAFKA-3256: --- [~becket_qin] Are you not able to navigate directly to this

[jira] [Created] (KAFKA-3257) bootstrap-test-env.sh version check fails when grep has --colour option enabled.

2016-02-20 Thread Jiangjie Qin (JIRA)
Jiangjie Qin created KAFKA-3257: --- Summary: bootstrap-test-env.sh version check fails when grep has --colour option enabled. Key: KAFKA-3257 URL: https://issues.apache.org/jira/browse/KAFKA-3257

[jira] [Commented] (KAFKA-3256) Large number of system test failures

2016-02-20 Thread Geoff Anderson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155827#comment-15155827 ] Geoff Anderson commented on KAFKA-3256: --- [~becket_qin] The bucket is publicly readable as far as I

[jira] [Commented] (KAFKA-3256) Large number of system test failures

2016-02-20 Thread Anna Povzner (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155832#comment-15155832 ] Anna Povzner commented on KAFKA-3256: - [~becket_qin] Most of these tests are reproducible locally, so

[jira] [Commented] (KAFKA-3256) Large number of system test failures

2016-02-20 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155835#comment-15155835 ] Jiangjie Qin commented on KAFKA-3256: - Yes, fix to those tests are obvious. I am looking at the other

[jira] [Comment Edited] (KAFKA-3256) Large number of system test failures

2016-02-20 Thread Anna Povzner (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155841#comment-15155841 ] Anna Povzner edited comment on KAFKA-3256 at 2/21/16 1:40 AM: -- [~becket_qin]

[jira] [Commented] (KAFKA-3256) Large number of system test failures

2016-02-20 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155846#comment-15155846 ] Jiangjie Qin commented on KAFKA-3256: - Hmm, the reason we are printing the timestamp is because that

[jira] [Commented] (KAFKA-3256) Large number of system test failures

2016-02-20 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155847#comment-15155847 ] Ismael Juma commented on KAFKA-3256: We may also consider outputting those fields only when a flag is

[jira] [Commented] (KAFKA-3256) Large number of system test failures

2016-02-20 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155848#comment-15155848 ] Ismael Juma commented on KAFKA-3256: Whatever we decide, it would be good to do it in two steps

[jira] [Comment Edited] (KAFKA-3256) Large number of system test failures

2016-02-20 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155848#comment-15155848 ] Ismael Juma edited comment on KAFKA-3256 at 2/21/16 1:57 AM: - Whatever we

[jira] [Commented] (KAFKA-3256) Large number of system test failures

2016-02-20 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155852#comment-15155852 ] Jiangjie Qin commented on KAFKA-3256: - I like this idea. We already have "print.key" as an option for

[jira] [Commented] (KAFKA-3256) Large number of system test failures

2016-02-20 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155854#comment-15155854 ] Jiangjie Qin commented on KAFKA-3256: - [~ijuma] If we add a "print.timestamp" to console consumer and

[jira] [Commented] (KAFKA-3256) Large number of system test failures

2016-02-20 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155855#comment-15155855 ] Ismael Juma commented on KAFKA-3256: Yes, one patch would be enough for that option. > Large number

[jira] [Commented] (KAFKA-3235) Unclosed stream in AppInfoParser static block

2016-02-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155887#comment-15155887 ] Ted Yu commented on KAFKA-3235: --- clients/src/main/java/org/apache/kafka/common/utils/AppInfoParser.java

[jira] [Commented] (KAFKA-3256) Large number of system test failures

2016-02-20 Thread Anna Povzner (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155910#comment-15155910 ] Anna Povzner commented on KAFKA-3256: - I looked more into system tests to find where the format is

[jira] [Comment Edited] (KAFKA-3256) Large number of system test failures

2016-02-20 Thread Anna Povzner (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155910#comment-15155910 ] Anna Povzner edited comment on KAFKA-3256 at 2/21/16 6:18 AM: -- I looked more

[jira] [Commented] (KAFKA-3256) Large number of system test failures

2016-02-20 Thread Anna Povzner (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155911#comment-15155911 ] Anna Povzner commented on KAFKA-3256: - Also for completeness, the remaining system tests:

[GitHub] kafka pull request: KAFKA-2934: Offset storage file configuration ...

2016-02-20 Thread ZoneMayor
Github user ZoneMayor closed the pull request at: https://github.com/apache/kafka/pull/734 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (KAFKA-2934) Offset storage file configuration in Connect standalone mode is not included in StandaloneConfig

2016-02-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155923#comment-15155923 ] ASF GitHub Bot commented on KAFKA-2934: --- Github user ZoneMayor closed the pull request at:

[jira] [Commented] (KAFKA-2934) Offset storage file configuration in Connect standalone mode is not included in StandaloneConfig

2016-02-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155924#comment-15155924 ] ASF GitHub Bot commented on KAFKA-2934: --- GitHub user ZoneMayor reopened a pull request: