GitHub user ijuma opened a pull request:
https://github.com/apache/kafka/pull/940
MINOR: Example style improvements
These are minor, but no reason to make our example code look
worse than it has to.
You can merge this pull request into a Git repository by running:
$ git
[
https://issues.apache.org/jira/browse/KAFKA-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Frank Scholten updated KAFKA-3255:
--
Attachment: KAFKA-3255.patch
> Extra unit tests for NetworkClient.connectionDelay(Node node,
Frank Scholten created KAFKA-3255:
-
Summary: Extra unit tests for NetworkClient.connectionDelay(Node
node, long now)
Key: KAFKA-3255
URL: https://issues.apache.org/jira/browse/KAFKA-3255
Project:
[
https://issues.apache.org/jira/browse/KAFKA-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Frank Scholten updated KAFKA-3255:
--
Labels: test (was: )
Fix Version/s: 0.9.0.1
Status: Patch Available
[
https://issues.apache.org/jira/browse/KAFKA-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-3255:
---
Fix Version/s: (was: 0.9.0.1)
0.9.1.0
> Extra unit tests for
[
https://issues.apache.org/jira/browse/KAFKA-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155707#comment-15155707
]
Ismael Juma commented on KAFKA-3255:
Thanks for the patch. Would you consider submitting a pull
GitHub user frankscholten opened a pull request:
https://github.com/apache/kafka/pull/941
KAFKA-3255 Added unit tests for NetworkClient.connectionDelay(Node node,
long now)
You can merge this pull request into a Git repository by running:
$ git pull
[
https://issues.apache.org/jira/browse/KAFKA-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155719#comment-15155719
]
ASF GitHub Bot commented on KAFKA-3255:
---
GitHub user frankscholten opened a pull request:
[
https://issues.apache.org/jira/browse/KAFKA-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155720#comment-15155720
]
Frank Scholten commented on KAFKA-3255:
---
Done https://github.com/apache/kafka/pull/941
> Extra unit
[
https://issues.apache.org/jira/browse/KAFKA-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Frank Scholten updated KAFKA-3255:
--
Comment: was deleted
(was: Done https://github.com/apache/kafka/pull/941)
> Extra unit tests
Geoff Anderson created KAFKA-3256:
-
Summary: Large number of system test failures
Key: KAFKA-3256
URL: https://issues.apache.org/jira/browse/KAFKA-3256
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiangjie Qin reassigned KAFKA-3256:
---
Assignee: Jiangjie Qin
> Large number of system test failures
>
[
https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155793#comment-15155793
]
Jiangjie Qin commented on KAFKA-3256:
-
[~hachikuji] Sure, I'm investigating.
> Large number of system
[
https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155794#comment-15155794
]
Jiangjie Qin commented on KAFKA-3256:
-
[~hachikuji] It seems I am not be able to access the test
[
https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155794#comment-15155794
]
Jiangjie Qin edited comment on KAFKA-3256 at 2/20/16 11:00 PM:
---
[~hachikuji]
[
https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155819#comment-15155819
]
Geoff Anderson commented on KAFKA-3256:
---
[~becket_qin] Are you not able to navigate directly to this
Jiangjie Qin created KAFKA-3257:
---
Summary: bootstrap-test-env.sh version check fails when grep has
--colour option enabled.
Key: KAFKA-3257
URL: https://issues.apache.org/jira/browse/KAFKA-3257
[
https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155827#comment-15155827
]
Geoff Anderson commented on KAFKA-3256:
---
[~becket_qin] The bucket is publicly readable as far as I
[
https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155832#comment-15155832
]
Anna Povzner commented on KAFKA-3256:
-
[~becket_qin] Most of these tests are reproducible locally, so
[
https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155835#comment-15155835
]
Jiangjie Qin commented on KAFKA-3256:
-
Yes, fix to those tests are obvious. I am looking at the other
[
https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155841#comment-15155841
]
Anna Povzner edited comment on KAFKA-3256 at 2/21/16 1:40 AM:
--
[~becket_qin]
[
https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155846#comment-15155846
]
Jiangjie Qin commented on KAFKA-3256:
-
Hmm, the reason we are printing the timestamp is because that
[
https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155847#comment-15155847
]
Ismael Juma commented on KAFKA-3256:
We may also consider outputting those fields only when a flag is
[
https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155848#comment-15155848
]
Ismael Juma commented on KAFKA-3256:
Whatever we decide, it would be good to do it in two steps
[
https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155848#comment-15155848
]
Ismael Juma edited comment on KAFKA-3256 at 2/21/16 1:57 AM:
-
Whatever we
[
https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155852#comment-15155852
]
Jiangjie Qin commented on KAFKA-3256:
-
I like this idea. We already have "print.key" as an option for
[
https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155854#comment-15155854
]
Jiangjie Qin commented on KAFKA-3256:
-
[~ijuma] If we add a "print.timestamp" to console consumer and
[
https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155855#comment-15155855
]
Ismael Juma commented on KAFKA-3256:
Yes, one patch would be enough for that option.
> Large number
[
https://issues.apache.org/jira/browse/KAFKA-3235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155887#comment-15155887
]
Ted Yu commented on KAFKA-3235:
---
clients/src/main/java/org/apache/kafka/common/utils/AppInfoParser.java
[
https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155910#comment-15155910
]
Anna Povzner commented on KAFKA-3256:
-
I looked more into system tests to find where the format is
[
https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155910#comment-15155910
]
Anna Povzner edited comment on KAFKA-3256 at 2/21/16 6:18 AM:
--
I looked more
[
https://issues.apache.org/jira/browse/KAFKA-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155911#comment-15155911
]
Anna Povzner commented on KAFKA-3256:
-
Also for completeness, the remaining system tests:
Github user ZoneMayor closed the pull request at:
https://github.com/apache/kafka/pull/734
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/KAFKA-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155923#comment-15155923
]
ASF GitHub Bot commented on KAFKA-2934:
---
Github user ZoneMayor closed the pull request at:
[
https://issues.apache.org/jira/browse/KAFKA-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155924#comment-15155924
]
ASF GitHub Bot commented on KAFKA-2934:
---
GitHub user ZoneMayor reopened a pull request:
35 matches
Mail list logo