[jira] [Resolved] (KAFKA-5960) Producer uses unsupported ProduceRequest version against older brokers

2017-09-25 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-5960. Resolution: Fixed > Producer uses unsupported ProduceRequest version against older brokers >

[GitHub] kafka pull request #3944: KAFKA-5960; Fix regression in produce version sele...

2017-09-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3944 ---

[jira] [Created] (KAFKA-5974) Removed unused parameter in public interface

2017-09-25 Thread Matthias J. Sax (JIRA)
Matthias J. Sax created KAFKA-5974: -- Summary: Removed unused parameter in public interface Key: KAFKA-5974 URL: https://issues.apache.org/jira/browse/KAFKA-5974 Project: Kafka Issue Type:

[GitHub] kafka pull request #3960: KAFKA-5975: No response when deleting topics and d...

2017-09-25 Thread mmolimar
GitHub user mmolimar opened a pull request: https://github.com/apache/kafka/pull/3960 KAFKA-5975: No response when deleting topics and delete.topic.enable=false You can merge this pull request into a Git repository by running: $ git pull https://github.com/mmolimar/kafka

[jira] [Resolved] (KAFKA-5865) Expiring batches with idempotence enabled could cause data loss.

2017-09-25 Thread Apurva Mehta (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apurva Mehta resolved KAFKA-5865. - Resolution: Fixed This is fixed in 1.0.0 by the changes in

[jira] [Created] (KAFKA-5975) No response when deleting topics and delete.topic.enable=false

2017-09-25 Thread Mario Molina (JIRA)
Mario Molina created KAFKA-5975: --- Summary: No response when deleting topics and delete.topic.enable=false Key: KAFKA-5975 URL: https://issues.apache.org/jira/browse/KAFKA-5975 Project: Kafka

[GitHub] kafka-site pull request #86: MINOR:Updating Rabobank description and Zalando...

2017-09-25 Thread manjuapu
GitHub user manjuapu opened a pull request: https://github.com/apache/kafka-site/pull/86 MINOR:Updating Rabobank description and Zalando image in powered-by & streams page @guozhangwang @dguy Updated text was provided by Rabobank, so in this PR I am updating it. Please review.

[GitHub] kafka pull request #3957: MIROR: Reject JoinGroup request from first member ...

2017-09-25 Thread omkreddy
GitHub user omkreddy opened a pull request: https://github.com/apache/kafka/pull/3957 MIROR: Reject JoinGroup request from first member with empty partition.assignment.strategy You can merge this pull request into a Git repository by running: $ git pull

Re: [VOTE] KIP-202

2017-09-25 Thread Richard Yu
The vote has passed with 5++. We are now closing the vote. On Mon, Sep 25, 2017 at 1:18 AM, Guozhang Wang wrote: > If no on else has opinions or votes on this thread, Richard could you close > the voting phase then? > > On Sat, Sep 23, 2017 at 4:11 PM, Ismael Juma

Re: [VOTE] KIP-202

2017-09-25 Thread Guozhang Wang
If no on else has opinions or votes on this thread, Richard could you close the voting phase then? On Sat, Sep 23, 2017 at 4:11 PM, Ismael Juma wrote: > Thanks for the KIP, +1 (binding). > > On 19 Sep 2017 12:27 am, "Richard Yu" wrote: > > >

[GitHub] kafka pull request #3949: MINOR: Update Streams quickstart to create output ...

2017-09-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3949 ---

[GitHub] kafka pull request #2165: KAFKA-4440: Make producer RecordMetadata non-final

2017-09-25 Thread rajinisivaram
Github user rajinisivaram closed the pull request at: https://github.com/apache/kafka/pull/2165 ---

[DISCUSS] KIP-201: Rationalising Policy interfaces

2017-09-25 Thread Tom Bentley
Hi, I'd like to start a discussion for KIP-201. The basic point is that new AdminClient APIs for modifying topics should have a configurable policy to allow the administrator to veto the modifications. Just adding a ModifyTopicPolicy would make for awkwardness by having separate policies for

Re: [DISCUSS] KIP-190: Handle client-ids consistently between clients and brokers

2017-09-25 Thread Mickael Maison
Hi Ewen, I understand your point of view and ideally we'd have one convention for handling all user provided strings. This KIP reused the sanitization mechanism we had in place for user principals. I think both ways have pros and cons but what I like about early sanitization (as is currently) is

[jira] [Created] (KAFKA-5970) Deadlock due to locking of DelayedProduce and group

2017-09-25 Thread Rajini Sivaram (JIRA)
Rajini Sivaram created KAFKA-5970: - Summary: Deadlock due to locking of DelayedProduce and group Key: KAFKA-5970 URL: https://issues.apache.org/jira/browse/KAFKA-5970 Project: Kafka Issue

[GitHub] kafka pull request #3438: KAFKA-3465: Clarify warning message of ConsumerOff...

2017-09-25 Thread vahidhashemian
Github user vahidhashemian closed the pull request at: https://github.com/apache/kafka/pull/3438 ---

Re: [DISCUSS] KIP-201: Rationalising Policy interfaces

2017-09-25 Thread Mickael Maison
Hi Tom, Thanks for the KIP. Is this meant to superseed KIP-170 ? If so, one of our key requirements was to be able to access the topics/partitions list from the policy, so an administrator could enforce a partition limit for example. Also instead of simply having the Java Principal object, could

Re: [DISCUSS] KIP-201: Rationalising Policy interfaces

2017-09-25 Thread Ted Yu
bq. deprecations that are added in 1.x (x>0) have to remain in all 2.y Makes sense. It is fine to exclude KIP-113 from your KIP. Thanks On Mon, Sep 25, 2017 at 9:32 AM, Tom Bentley wrote: > Hi Ted, > > Thanks for the feedback! > > bq. topic.action.policy.class.name > >

[jira] [Resolved] (KAFKA-5489) Failing test: InternalTopicIntegrationTest.shouldCompactTopicsForStateChangelogs

2017-09-25 Thread Damian Guy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Damian Guy resolved KAFKA-5489. --- Resolution: Cannot Reproduce Closing this as i haven't seen it fail in a while and i'm unable to

Re: [DISCUSS] KIP-201: Rationalising Policy interfaces

2017-09-25 Thread Ted Yu
bq. topic.action.policy.class.name Since the policy would cover more than one action, how about using actions for the second word ? For TopicState interface, the abstract modifier for its methods are not needed. bq. KIP-113 Mind adding more to the above bullet ? bq. If this KIP is accepted

Re: [DISCUSS] KIP-201: Rationalising Policy interfaces

2017-09-25 Thread Tom Bentley
Hi Ted, Thanks for the feedback! bq. topic.action.policy.class.name > > Since the policy would cover more than one action, how about using actions > for the second word ? > Good point, done. > For TopicState interface, the abstract modifier for its methods are not > needed. > Fixed. bq.

Re: [DISCUSS] KIP-190: Handle client-ids consistently between clients and brokers

2017-09-25 Thread Ewen Cheslack-Postava
On Mon, Sep 25, 2017 at 3:35 AM, Mickael Maison wrote: > Hi Ewen, > > I understand your point of view and ideally we'd have one convention > for handling all user provided strings. This KIP reused the > sanitization mechanism we had in place for user principals. > > I

Re: [DISCUSS] KIP-201: Rationalising Policy interfaces

2017-09-25 Thread Ismael Juma
On Mon, Sep 25, 2017 at 5:32 PM, Tom Bentley wrote: > > bq. If this KIP is accepted for Kafka 1.1.0 this removal could happen in > > Kafka 3.0.0 > > > > There would be no Kafka 2.0 ? > > > > As I understand it, a deprecation has to exist for a complete major version >

Re: [DISCUSS] KIP-201: Rationalising Policy interfaces

2017-09-25 Thread Tom Bentley
Hi Mickael, Thanks for the reply. Thanks for the KIP. Is this meant to superseed KIP-170 ? > If so, one of our key requirements was to be able to access the > topics/partitions list from the policy, so an administrator could > enforce a partition limit for example. > It's not meant to replace

Re: [DISCUSS] KIP-201: Rationalising Policy interfaces

2017-09-25 Thread Tom Bentley
Hi Ismael, On 25 September 2017 at 17:51, Ismael Juma wrote: > We don't have this policy today for what it's worth. > Thanks for the clarification. On re-reading I realise I misinterpreted Guozhang Wang's suggestion when 1.0.0 was first mooted: > Just to clarify, my

[jira] [Created] (KAFKA-5971) Broker keeps running even though not registered in ZK

2017-09-25 Thread Igor Canadi (JIRA)
Igor Canadi created KAFKA-5971: -- Summary: Broker keeps running even though not registered in ZK Key: KAFKA-5971 URL: https://issues.apache.org/jira/browse/KAFKA-5971 Project: Kafka Issue Type:

[GitHub] kafka pull request #3958: Re-enable KafkaAdminClientTest#testHandleTimeout

2017-09-25 Thread cmccabe
GitHub user cmccabe opened a pull request: https://github.com/apache/kafka/pull/3958 Re-enable KafkaAdminClientTest#testHandleTimeout You can merge this pull request into a Git repository by running: $ git pull https://github.com/cmccabe/kafka

[jira] [Created] (KAFKA-5972) Flatten SMT does not work with null values

2017-09-25 Thread Tomas Zuklys (JIRA)
Tomas Zuklys created KAFKA-5972: --- Summary: Flatten SMT does not work with null values Key: KAFKA-5972 URL: https://issues.apache.org/jira/browse/KAFKA-5972 Project: Kafka Issue Type: Bug

[GitHub] kafka pull request #3959: KAFKA-5901 Added Connect metrics specific to sourc...

2017-09-25 Thread rhauch
GitHub user rhauch opened a pull request: https://github.com/apache/kafka/pull/3959 KAFKA-5901 Added Connect metrics specific to source tasks Added Connect metrics specific to source tasks. This PR is built on top of #3911, and when that is merged this can be rebased and merged.

[jira] [Created] (KAFKA-5973) ShutdownableThread catching errors can lead to partial hard to diagnose broker failure

2017-09-25 Thread Tom Crayford (JIRA)
Tom Crayford created KAFKA-5973: --- Summary: ShutdownableThread catching errors can lead to partial hard to diagnose broker failure Key: KAFKA-5973 URL: https://issues.apache.org/jira/browse/KAFKA-5973

[jira] [Created] (KAFKA-5968) Remove all broker metrics during shutdown

2017-09-25 Thread Rajini Sivaram (JIRA)
Rajini Sivaram created KAFKA-5968: - Summary: Remove all broker metrics during shutdown Key: KAFKA-5968 URL: https://issues.apache.org/jira/browse/KAFKA-5968 Project: Kafka Issue Type: Bug

[jira] [Created] (KAFKA-5969) bin/kafka-preferred-replica-election.sh gives misleading error when invalid JSON file is passed as parameter

2017-09-25 Thread Jakub Scholz (JIRA)
Jakub Scholz created KAFKA-5969: --- Summary: bin/kafka-preferred-replica-election.sh gives misleading error when invalid JSON file is passed as parameter Key: KAFKA-5969 URL:

[GitHub] kafka pull request #3955: KAFKA-5969: Use correct error message when the JSO...

2017-09-25 Thread scholzj
GitHub user scholzj opened a pull request: https://github.com/apache/kafka/pull/3955 KAFKA-5969: Use correct error message when the JSON file is invalid When invalid JSON file is passed to the bin/kafka-preferred-replica-election.sh / PreferredReplicaLeaderElectionCommand tool it

Re: KIP-203: Add toLowerCase support to sasl.kerberos.principal.to.local rule

2017-09-25 Thread Manikumar
Hi all, If there are no further concerns, I will start a VOTE thread for this minor KIP. Thanks On Tue, Sep 19, 2017 at 3:14 PM, Manikumar wrote: > Thanks for the reviews. > > @Ted > Updated the KIP. > > @Tom > I think we can interpret usernames as locale

[GitHub] kafka pull request #3956: KAFKA-5970: Avoid locking group in operations that...

2017-09-25 Thread rajinisivaram
GitHub user rajinisivaram opened a pull request: https://github.com/apache/kafka/pull/3956 KAFKA-5970: Avoid locking group in operations that lock DelayedProduce You can merge this pull request into a Git repository by running: $ git pull

[GitHub] kafka pull request #3954: KAFKA-5758: Don't fail fetch request if replica is...

2017-09-25 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3954 KAFKA-5758: Don't fail fetch request if replica is no longer a follower for a partition We log a warning instead, which is what we also do if the partition hasn't been created yet. You can