Re: [VOTE] KIP-367 Introduce close(Duration) to Producer and AdminClient instead of close(long, TimeUnit)

2018-09-13 Thread Manikumar
+1 (non-binding) Thanks for the KIP. On Thu, Sep 13, 2018 at 10:38 AM Harsha wrote: > +1 (Binding). > Thanks, > Harsha > > On Wed, Sep 12, 2018, at 9:06 PM, vito jeng wrote: > > +1 > > > > > > > > --- > > Vito > > > > On Mon, Sep 10, 2018 at 4:52 PM, Dongjin Lee wrote: > > > > > +1.

[jira] [Resolved] (KAFKA-7394) Allow OffsetsForLeaderEpoch requests with topic describe ACL (KIP-320)

2018-09-13 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-7394. Resolution: Fixed Fix Version/s: 2.1.0 > Allow OffsetsForLeaderEpoch requests with

Re: A question about kafka streams API

2018-09-13 Thread Yui Yoi
Hi Adam and John, thank you for your effort! We are implementing full idem-potency in our projects so that's nothing to worry about. As to what John said - we only have one partition, I personally assured that. So as i wrote in section 2. of my first message in this conversation - my stream should

Build failed in Jenkins: kafka-trunk-jdk8 #2962

2018-09-13 Thread Apache Jenkins Server
See Changes: [ismael] MINOR: KafkaAdminClient Java 8 code cleanup (#5594) [ismael] KAFKA-6926: Simplified some logic to eliminate some suppressions of -- [...truncated

[jira] [Resolved] (KAFKA-2139) Add a separate controller messge queue with higher priority on broker side

2018-09-13 Thread Manikumar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-2139. -- Resolution: Duplicate Closing this in-favor of KAFKA-4453/KIP-291. > Add a separate controller messge

Build failed in Jenkins: kafka-trunk-jdk10 #481

2018-09-13 Thread Apache Jenkins Server
See Changes: [github] KAFKA-7394; OffsetsForLeaderEpoch supports topic describe access (#5634) -- [...truncated 2.22 MB...]

[jira] [Resolved] (KAFKA-1825) leadership election state is stale and never recovers without all brokers restarting

2018-09-13 Thread Manikumar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-1825. -- Resolution: Auto Closed Closing inactive issue. Please reopen if the issue still exists on newer

Build failed in Jenkins: kafka-trunk-jdk10 #480

2018-09-13 Thread Apache Jenkins Server
See Changes: [ismael] MINOR: KafkaAdminClient Java 8 code cleanup (#5594) [ismael] KAFKA-6926: Simplified some logic to eliminate some suppressions of -- [...truncated

Re: [DISCUSS] KIP-372: Naming Joins and Grouping

2018-09-13 Thread Eno Thereska
Hi folks, I know we don't normally have a "Related work" section in KIPs, but sometimes I find it useful to see what others have done in similar cases. Since this will be important for rolling re-deployments, I wonder what other frameworks like Flink (or Samza) have done in these cases. Perhaps

[jira] [Resolved] (KAFKA-2219) reassign partition fails with offset 0 being asked for but obviously not there

2018-09-13 Thread Manikumar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-2219. -- Resolution: Auto Closed Closing inactive issue. Please reopen if the issue still exists in newer

[jira] [Resolved] (KAFKA-1509) Restart of destination broker after unreplicated partition move leaves partitions without leader

2018-09-13 Thread Manikumar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-1509. -- Resolution: Auto Closed Not able reproduce on new versions. might have fixed in newer versions. Please

Re: [VOTE] KIP-367 Introduce close(Duration) to Producer and AdminClient instead of close(long, TimeUnit)

2018-09-13 Thread Mickael Maison
+1 (non-binding) Thanks! On Thu, Sep 13, 2018 at 7:05 AM Manikumar wrote: > > +1 (non-binding) > > Thanks for the KIP. > > On Thu, Sep 13, 2018 at 10:38 AM Harsha wrote: > > > +1 (Binding). > > Thanks, > > Harsha > > > > On Wed, Sep 12, 2018, at 9:06 PM, vito jeng wrote: > > > +1 > > > > > > > >

Re: [VOTE] KIP-110: Add Codec for ZStandard Compression

2018-09-13 Thread Mickael Maison
+1 (non binding) Thanks for your perseverance, it's great to see this KIP finally reaching completion! On Thu, Sep 13, 2018 at 4:58 AM Harsha wrote: > > +1 (binding). > > Thanks, > Harsha > > On Wed, Sep 12, 2018, at 4:56 PM, Jason Gustafson wrote: > > Great contribution! +1 > > > > On Wed, Sep

[jira] [Created] (KAFKA-7407) Kafka Connect validation ignores errors for undefined configs

2018-09-13 Thread Andrey Pustovetov (JIRA)
Andrey Pustovetov created KAFKA-7407: Summary: Kafka Connect validation ignores errors for undefined configs Key: KAFKA-7407 URL: https://issues.apache.org/jira/browse/KAFKA-7407 Project: Kafka

Build failed in Jenkins: kafka-trunk-jdk8 #2963

2018-09-13 Thread Apache Jenkins Server
See Changes: [github] KAFKA-7394; OffsetsForLeaderEpoch supports topic describe access (#5634) -- [...truncated 2.69 MB...]

Re: [DISCUSS] KIP-372: Naming Joins and Grouping

2018-09-13 Thread Matthias J. Sax
I don't know what Samza does, however, Flink requires users to specify names similar to this proposal to be able to re-identify state in case the topology gets altered between deployments. Flink only has state they need to worry about. For Kafka Streams, it's state plus repartition topics.

Re: [VOTE] KIP-367 Introduce close(Duration) to Producer and AdminClient instead of close(long, TimeUnit)

2018-09-13 Thread Bill Bejeck
+1 -Bill On Thu, Sep 13, 2018 at 4:44 AM Mickael Maison wrote: > +1 (non-binding) > Thanks! > On Thu, Sep 13, 2018 at 7:05 AM Manikumar > wrote: > > > > +1 (non-binding) > > > > Thanks for the KIP. > > > > On Thu, Sep 13, 2018 at 10:38 AM Harsha wrote: > > > > > +1 (Binding). > > > Thanks, >

[jira] [Created] (KAFKA-7408) Truncate to LSO on unclean leader election

2018-09-13 Thread Jason Gustafson (JIRA)
Jason Gustafson created KAFKA-7408: -- Summary: Truncate to LSO on unclean leader election Key: KAFKA-7408 URL: https://issues.apache.org/jira/browse/KAFKA-7408 Project: Kafka Issue Type:

Build failed in Jenkins: kafka-trunk-jdk8 #2964

2018-09-13 Thread Apache Jenkins Server
See Changes: [ismael] MINOR: Update minimum required Gradle version to 4.7 (#5642) -- [...truncated 2.70 MB...] org.apache.kafka.streams.test.OutputVerifierTest >

Re: [DISCUSS] KIP-372: Naming Joins and Grouping

2018-09-13 Thread Guozhang Wang
Just to clarify on 2): currently KIP-307 do not have proposed APIs for `groupBy/groupByKey` naming schemes, and for joins its current proposal is to extend ValueJoiner with Named and hence this part is what I meant to have "overlaps". Thinking about it a bit more, since Joined is only used for

Build failed in Jenkins: kafka-trunk-jdk10 #484

2018-09-13 Thread Apache Jenkins Server
See Changes: [github] MINOR: Insure that KafkaStreams client is closed if test fails (#5618) -- [...truncated 2.47 MB...] at

Build failed in Jenkins: kafka-trunk-jdk10 #485

2018-09-13 Thread Apache Jenkins Server
See -- Started by an SCM change Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H23 (ubuntu xenial) in workspace

Re: [DISCUSS] KIP-372: Naming Joins and Grouping

2018-09-13 Thread John Roesler
Hey all, I think it's slightly out of scope for this KIP, but I'm not sure it's right to add a name to ValueJoiner or KeyValueMapper. Both of those are "functional interfaces", that is, they are basically named functions. It seems like we should preserve this property both to provide a clean

Re: [VOTE] KIP-365: Materialized, Serialized, Joined, Consumed and Produced with implicit Serde

2018-09-13 Thread Joan Goyeau
Ok so a +1 is non binding by default. On Tue, 11 Sep 2018 at 17:25 Matthias J. Sax wrote: > I only count 3 binding votes (Guozhang, Matthias, Damian). Plus 4 > non-binding (John, Ted, Bill, Dongjin) -- or 5 if you vote your own KIP :) > > -Matthias > > On 9/11/18 12:53 AM, Joan Goyeau wrote: >

Build failed in Jenkins: kafka-trunk-jdk10 #486

2018-09-13 Thread Apache Jenkins Server
See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H27 (ubuntu xenial) in workspace

[jira] [Created] (KAFKA-7410) Rack aware partitions assignment create unbalanced broker assignments on unbalanced racks

2018-09-13 Thread Lucas Bradstreet (JIRA)
Lucas Bradstreet created KAFKA-7410: --- Summary: Rack aware partitions assignment create unbalanced broker assignments on unbalanced racks Key: KAFKA-7410 URL: https://issues.apache.org/jira/browse/KAFKA-7410

Build failed in Jenkins: kafka-trunk-jdk8 #2966

2018-09-13 Thread Apache Jenkins Server
See Changes: [github] MINOR: Insure that KafkaStreams client is closed if test fails (#5618) [wangguoz] MINOR: Enable ignored upgrade system tests - trunk (#5605) --

Jenkins build is back to normal : kafka-trunk-jdk8 #2965

2018-09-13 Thread Apache Jenkins Server
See

Jenkins build is back to normal : kafka-trunk-jdk10 #488

2018-09-13 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-361: Add Consumer Configuration to Disable Auto Topic Creation

2018-09-13 Thread Dhruvil Shah
Hi all, I updated the KIP with the discussion from this thread. I left the warning message and deprecation out for now because we require the configuration be set to true (i.e. auto topic creation allowed) when using brokers older than 0.11.0. If there is no more feedback, I will start a VOTE

Build failed in Jenkins: kafka-trunk-jdk10 #487

2018-09-13 Thread Apache Jenkins Server
See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H23 (ubuntu xenial) in workspace

[jira] [Created] (KAFKA-7409) Validate topic configs prior to topic creation

2018-09-13 Thread Jason Gustafson (JIRA)
Jason Gustafson created KAFKA-7409: -- Summary: Validate topic configs prior to topic creation Key: KAFKA-7409 URL: https://issues.apache.org/jira/browse/KAFKA-7409 Project: Kafka Issue Type:

Re: [VOTE] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-09-13 Thread Guozhang Wang
+1 (binding), thank you Nikolay! Guozhang On Thu, Sep 13, 2018 at 9:39 AM, Matthias J. Sax wrote: > Thanks for the KIP. > > +1 (binding) > > > -Matthias > > On 9/5/18 8:52 AM, John Roesler wrote: > > I'm a +1 (non-binding) > > > > On Mon, Sep 3, 2018 at 8:33 AM Nikolay Izhikov > wrote: > > >

Re: [DISCUSS] Apache Kafka 2.1.0 Release Plan

2018-09-13 Thread Dongjin Lee
Great. Thanks! - Dongjin On Mon, Sep 10, 2018 at 11:48 AM Matthias J. Sax wrote: > Thanks a lot! You are on a run after 1.1.1 release. > > I see something coming up for myself in 4 month. :) > > On 9/9/18 6:15 PM, Guozhang Wang wrote: > > Dong, thanks for driving the release! > > > > On Sun,

Re: [DISCUSS] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-09-13 Thread Nikolay Izhikov
Hello, Matthias. > I like the KIP as-is. Feel free to start a VOTE thread. I'm already started one [1]. Can you vote in it or I should create a new one? I've updated KIP. This has been changed: ReadOnlyWindowStore { //Deprecated methods. WindowStoreIterator fetch(K key, long

Re: [DISCUSS] KIP-372: Naming Joins and Grouping

2018-09-13 Thread Matthias J. Sax
Three more comments: (1) For `Grouped` should we add `with(String name, Serde key, Serde value)` to allow specifying all parameters at once? Produced/Consumed/Serialized etc follow a similar pattern. There is one static method for each config parameter, plus one static method that accepts all

Re: [VOTE] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-09-13 Thread Matthias J. Sax
Thanks for the KIP. +1 (binding) -Matthias On 9/5/18 8:52 AM, John Roesler wrote: > I'm a +1 (non-binding) > > On Mon, Sep 3, 2018 at 8:33 AM Nikolay Izhikov wrote: > >> Dear commiters. >> >> Please, vote on a KIP. >> >> В Пт, 31/08/2018 в 12:05 -0500, John Roesler пишет: >>> Hi Nikolay,

Build failed in Jenkins: kafka-trunk-jdk10 #482

2018-09-13 Thread Apache Jenkins Server
See Changes: [ismael] MINOR: Update minimum required Gradle version to 4.7 (#5642) -- [...truncated 2.22 MB...] org.apache.kafka.streams.test.OutputVerifierTest >

Re: [DISCUSS] KIP 368: Allow SASL Connections to Periodically Re-Authenticate

2018-09-13 Thread Ron Dagostino
Hi Rajini. I'm thinking about how we deal with migration. For example, let's say we have an existing 2.0.0 cluster using SASL/OAUTHBEARER and we want to use this feature. The desired end state is to have all clients and brokers migrated to a version that supports the feature (call it 2.x) with

Re: [DISCUSS] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-09-13 Thread Matthias J. Sax
No need to start a new voting thread :) For the KIP update, I think it should be: > ReadOnlyWindowStore { > //Deprecated methods. > WindowStoreIterator fetch(K key, long timeFrom, long timeTo); > KeyValueIterator, V> fetch(K from, K to, long timeFrom, long > timeTo); >

Re: [DISCUSS] KIP-358: Migrate Streams API to Duration instead of long ms times

2018-09-13 Thread Nikolay Izhikov
Fixed. Thanks, for help! Please, take a look and vote. В Чт, 13/09/2018 в 08:40 -0700, Matthias J. Sax пишет: > No need to start a new voting thread :) > > For the KIP update, I think it should be: > > > ReadOnlyWindowStore { > > //Deprecated methods. > > WindowStoreIterator fetch(K

[jira] [Resolved] (KAFKA-6926) Reduce NPath exceptions in Connect

2018-09-13 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-6926. Resolution: Fixed Fix Version/s: 2.1.0 > Reduce NPath exceptions in Connect >

Jenkins build is back to normal : kafka-trunk-jdk10 #483

2018-09-13 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-349 Priorities for Source Topics

2018-09-13 Thread Matthias J. Sax
I think, we can keep incremental fetch request with the design idea I described in my previous email. Of course, brokers would need to be updated and understand topic priorities, ie, we would also need to change the protocol to send topic priority information to the brokers. Thus, if somebody

Re: [VOTE] KIP-349 Priorities for Source Topics

2018-09-13 Thread Matthias J. Sax
That sound correct, Colin. At runtime (we just merged an improvement this week, cf KIP-353), Kafka Streams synchronizes different topics based on record timestamps. Records are buffered internally before processed and we `pause()` partitions for which the number of records in the buffer exceeds a