[
https://issues.apache.org/jira/browse/KAFKA-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506917#comment-13506917
]
Jay Kreps commented on KAFKA-633:
-
But that's a problem, no? Those test harnesses are
[
https://issues.apache.org/jira/browse/KAFKA-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-597:
Attachment: KAFKA-597-v1.patch
This patch refactors the scheduler as described above except that I didn't
[
https://issues.apache.org/jira/browse/KAFKA-595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-595:
Labels: feature (was: feature features)
Description:
In 0.7 Kafka always appended messages to the
[
https://issues.apache.org/jira/browse/KAFKA-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13511489#comment-13511489
]
Jay Kreps commented on KAFKA-642:
-
60. This isn't an implict conversion. In java the method
[
https://issues.apache.org/jira/browse/KAFKA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-252:
Priority: Major (was: Critical)
Description:
The relevant discussion is here -
Jay Kreps created KAFKA-659:
---
Summary: Support request pipelining in the network server
Key: KAFKA-659
URL: https://issues.apache.org/jira/browse/KAFKA-659
Project: Kafka
Issue Type: New Feature
[
https://issues.apache.org/jira/browse/KAFKA-560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-560:
Labels: project (was: )
Garbage Collect obsolete topics
---
[
https://issues.apache.org/jira/browse/KAFKA-554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-554:
Labels: project (was: )
Move all per-topic configuration into ZK and add to the CreateTopicCommand
[
https://issues.apache.org/jira/browse/KAFKA-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13511571#comment-13511571
]
Jay Kreps commented on KAFKA-642:
-
Ack, you're right.
Protocol tweaks for
[
https://issues.apache.org/jira/browse/KAFKA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-330:
Labels: features project (was: features)
Add delete topic support
-
[
https://issues.apache.org/jira/browse/KAFKA-642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-642:
Attachment: KAFKA-642-remove-response-versions.patch
This patch removes the response version. There was a
[
https://issues.apache.org/jira/browse/KAFKA-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13526125#comment-13526125
]
Jay Kreps commented on KAFKA-642:
-
It also baselines all versions, including the message
[
https://issues.apache.org/jira/browse/KAFKA-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-597:
Attachment: KAFKA-597-v4.patch
Patch v4.
- Rebased
- Makes use of thread factory
- Fixed broken scaladoc
[
https://issues.apache.org/jira/browse/KAFKA-636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-636:
Attachment: KAFKA-636-v1.patch
This patch implements asynchronous delete in the log.
To do this Log.scala
[
https://issues.apache.org/jira/browse/KAFKA-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13526887#comment-13526887
]
Jay Kreps commented on KAFKA-664:
-
Another issue is that we are saving the full producer
[
https://issues.apache.org/jira/browse/KAFKA-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-597:
Attachment: KAFKA-597-v5.patch
Thanks, new patch v5 addresses your comments:
- Improved javadoc
- This is
[
https://issues.apache.org/jira/browse/KAFKA-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13527168#comment-13527168
]
Jay Kreps commented on KAFKA-597:
-
Nice catch on the brace, will fix before check in.
With
Jay Kreps created KAFKA-667:
---
Summary: Rename .highwatermark file
Key: KAFKA-667
URL: https://issues.apache.org/jira/browse/KAFKA-667
Project: Kafka
Issue Type: Improvement
Affects Versions:
[
https://issues.apache.org/jira/browse/KAFKA-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13528432#comment-13528432
]
Jay Kreps commented on KAFKA-513:
-
It would be nice if we updated our log4j.properties as
[
https://issues.apache.org/jira/browse/KAFKA-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13528932#comment-13528932
]
Jay Kreps commented on KAFKA-374:
-
Yes, this should go on trunk.
Move to
[
https://issues.apache.org/jira/browse/KAFKA-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13528948#comment-13528948
]
Jay Kreps commented on KAFKA-664:
-
This seems to iterate the whole list for every
[
https://issues.apache.org/jira/browse/KAFKA-667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-667:
Attachment: KAFKA-667-v1.patch
Trivial patch to change the name of the highwatermark file. Ready for
[
https://issues.apache.org/jira/browse/KAFKA-636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps resolved KAFKA-636.
-
Resolution: Fixed
Checked in with the suggested changes.
Make log segment delete
[
https://issues.apache.org/jira/browse/KAFKA-631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps reassigned KAFKA-631:
---
Assignee: Jay Kreps
Implement log compaction
Key:
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529583#comment-13529583
]
Jay Kreps commented on KAFKA-657:
-
This looks great. To confirm, the final format for the
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529589#comment-13529589
]
Jay Kreps commented on KAFKA-657:
-
Oh yes, two other things:
1. We don't have a response in
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529617#comment-13529617
]
Jay Kreps commented on KAFKA-657:
-
The existing API describes the offset ranges contained
Jay Kreps created KAFKA-670:
---
Summary: Cleanup spurious .index files if present in the log
directory on initialization
Key: KAFKA-670
URL: https://issues.apache.org/jira/browse/KAFKA-670
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-670:
Priority: Blocker (was: Major)
Cleanup spurious .index files if present in the log directory on
[
https://issues.apache.org/jira/browse/KAFKA-670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-670:
Attachment: KAFKA-670-v1.patch
Cleanup any bogus index files (those without a corresponding .log file)
Jay Kreps created KAFKA-672:
---
Summary: Merge 0.8 changes to trunk
Key: KAFKA-672
URL: https://issues.apache.org/jira/browse/KAFKA-672
Project: Kafka
Issue Type: Bug
Reporter: Jay Kreps
[
https://issues.apache.org/jira/browse/KAFKA-672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-672:
Attachment: KAFKA-672.patch
Here is the merge changes in case anyone wants to take a look. I will probably
[
https://issues.apache.org/jira/browse/KAFKA-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13530674#comment-13530674
]
Jay Kreps commented on KAFKA-374:
-
Hey Scott, currently the implementation of the consumer
[
https://issues.apache.org/jira/browse/KAFKA-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13530694#comment-13530694
]
Jay Kreps commented on KAFKA-669:
-
I don't see the source of the logging you added to print
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13530700#comment-13530700
]
Jay Kreps commented on KAFKA-657:
-
I wonder if you could take a look at the updated docs
[
https://issues.apache.org/jira/browse/KAFKA-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13531344#comment-13531344
]
Jay Kreps commented on KAFKA-664:
-
+1 on doing cleanup in the expiry thread--expiry is a
Jay Kreps created KAFKA-673:
---
Summary: Broker recovery check logic is reversed
Key: KAFKA-673
URL: https://issues.apache.org/jira/browse/KAFKA-673
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-673:
Affects Version/s: 0.8
Broker recovery check logic is reversed
[
https://issues.apache.org/jira/browse/KAFKA-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13531525#comment-13531525
]
Jay Kreps commented on KAFKA-669:
-
To close the loop on this there are multiple issues
[
https://issues.apache.org/jira/browse/KAFKA-616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-616:
Labels: newbie (was: )
Implement acks=0
Key: KAFKA-616
[
https://issues.apache.org/jira/browse/KAFKA-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps resolved KAFKA-374.
-
Resolution: Fixed
Assignee: Jay Kreps
Checked in the java version.
Move to java
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13534122#comment-13534122
]
Jay Kreps commented on KAFKA-657:
-
This looks great!
Three minor things:
1. Can you change
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13534162#comment-13534162
]
Jay Kreps commented on KAFKA-657:
-
I think that actually covers an orthogonal problem
[
https://issues.apache.org/jira/browse/KAFKA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13534439#comment-13534439
]
Jay Kreps commented on KAFKA-675:
-
Nice. So does the default make it bind to all hosts?
[
https://issues.apache.org/jira/browse/KAFKA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13534462#comment-13534462
]
Jay Kreps commented on KAFKA-675:
-
I think I probably broke this without realizing it so I
[
https://issues.apache.org/jira/browse/KAFKA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13535104#comment-13535104
]
Jay Kreps commented on KAFKA-675:
-
+1
I will check this in on 0.8 if no objections from
[
https://issues.apache.org/jira/browse/KAFKA-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13537231#comment-13537231
]
Jay Kreps commented on KAFKA-496:
-
I found this helpful in thinking about futures:
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13537368#comment-13537368
]
Jay Kreps commented on KAFKA-657:
-
It probably makes sense to do this in two phases. Let's
[
https://issues.apache.org/jira/browse/KAFKA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-675:
Attachment: KAFKA-675-v3.patch
Here is a slightly tweaked version of your patch. I just fixed some problems
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13543277#comment-13543277
]
Jay Kreps commented on KAFKA-657:
-
Yeah that is the right place for a new config. It is
[
https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13544370#comment-13544370
]
Jay Kreps commented on KAFKA-657:
-
I updated the property name. Normally I am against
Jay Kreps created KAFKA-686:
---
Summary: 0.8 Kafka broker should give a better error message when
running against 0.7 zookeeper
Key: KAFKA-686
URL: https://issues.apache.org/jira/browse/KAFKA-686
Project:
[
https://issues.apache.org/jira/browse/KAFKA-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13548613#comment-13548613
]
Jay Kreps commented on KAFKA-689:
-
This is pretty hacky though, no? fetching metadata
[
https://issues.apache.org/jira/browse/KAFKA-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13548646#comment-13548646
]
Jay Kreps commented on KAFKA-689:
-
Well I guess what I am saying is that getting metadata
[
https://issues.apache.org/jira/browse/KAFKA-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13549276#comment-13549276
]
Jay Kreps commented on KAFKA-691:
-
That would be awesome. If you don't mind just give the
[
https://issues.apache.org/jira/browse/KAFKA-692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552133#comment-13552133
]
Jay Kreps commented on KAFKA-692:
-
Is this the right fix, I don't think the console
[
https://issues.apache.org/jira/browse/KAFKA-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552135#comment-13552135
]
Jay Kreps commented on KAFKA-695:
-
Hmm, so this can happen. Currently in 0.8 when we delete
[
https://issues.apache.org/jira/browse/KAFKA-649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-649:
Affects Version/s: (was: 0.8.1)
0.8
Hey guys, I think this is really just a
[
https://issues.apache.org/jira/browse/KAFKA-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552363#comment-13552363
]
Jay Kreps commented on KAFKA-691:
-
Does batching make sense versus just having people
[
https://issues.apache.org/jira/browse/KAFKA-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554062#comment-13554062
]
Jay Kreps commented on KAFKA-347:
-
Well i think there are really two mappings here:
key =
[
https://issues.apache.org/jira/browse/KAFKA-631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-631:
Attachment: KAFKA-631-v1.patch
This patch implements more or less what was described above.
Specific
[
https://issues.apache.org/jira/browse/KAFKA-702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-702:
Attachment: KAFKA-702-v1.patch
TLDR: attached one-line patch should fix the deadlock, but there is a larger
[
https://issues.apache.org/jira/browse/KAFKA-631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13555470#comment-13555470
]
Jay Kreps commented on KAFKA-631:
-
362eba981de40a69ae509a291649531ead6f6aee
[
https://issues.apache.org/jira/browse/KAFKA-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13555782#comment-13555782
]
Jay Kreps commented on KAFKA-709:
-
Yeah I agree. Everyone who tries to use it hits this and
[
https://issues.apache.org/jira/browse/KAFKA-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13556973#comment-13556973
]
Jay Kreps commented on KAFKA-709:
-
+1
Default queue.enqueue.timeout.ms to
[
https://issues.apache.org/jira/browse/KAFKA-707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13556974#comment-13556974
]
Jay Kreps commented on KAFKA-707:
-
What is the resulting error the user will see in this
[
https://issues.apache.org/jira/browse/KAFKA-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13556975#comment-13556975
]
Jay Kreps commented on KAFKA-682:
-
Yes, Joel, that makes sense. Ricky, do you know the acks
[
https://issues.apache.org/jira/browse/KAFKA-711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps reassigned KAFKA-711:
---
Assignee: Jay Kreps
NPE in TRUNK broker
---
Key: KAFKA-711
[
https://issues.apache.org/jira/browse/KAFKA-631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-631:
Attachment: KAFKA-631-v2.patch
New patch, only minor changes:
1. Rebased against trunk at
[
https://issues.apache.org/jira/browse/KAFKA-703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-703:
Fix Version/s: (was: 0.8)
0.8.1
A fetch request in Fetch Purgatory can double
[
https://issues.apache.org/jira/browse/KAFKA-631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-631:
Attachment: KAFKA-631-v4.patch
Did some testing with multithreading, resulting in...
Patch v4:
1. Bug: Log
Jay Kreps created KAFKA-718:
---
Summary: kafka-run-class.sh should use reasonable gc settings
Key: KAFKA-718
URL: https://issues.apache.org/jira/browse/KAFKA-718
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13559875#comment-13559875
]
Jay Kreps commented on KAFKA-719:
-
Isn't this the same as KAFKA-695?
[
https://issues.apache.org/jira/browse/KAFKA-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13560410#comment-13560410
]
Jay Kreps commented on KAFKA-727:
-
Fantastic catch.
I think another fix is to just save
[
https://issues.apache.org/jira/browse/KAFKA-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13560999#comment-13560999
]
Jay Kreps commented on KAFKA-139:
-
It also looks like package no longer builds a test
[
https://issues.apache.org/jira/browse/KAFKA-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561005#comment-13561005
]
Jay Kreps commented on KAFKA-139:
-
Also is it right that kafka-run-class is hardcoding
[
https://issues.apache.org/jira/browse/KAFKA-631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-631:
Attachment: KAFKA-631-v5.patch
Great review. Attached patch v5 that addresses most of these issues:
1.1
[
https://issues.apache.org/jira/browse/KAFKA-631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-631:
Attachment: KAFKA-631-v6.patch
Updated patch v6:
- Fixed a bug: messages larger than the I/O buffer would
[
https://issues.apache.org/jira/browse/KAFKA-631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-631:
Attachment: KAFKA-631-v7.patch
Patch v7, rebased.
Minor changes:
- Rebased
- Removed some printlns that
[
https://issues.apache.org/jira/browse/KAFKA-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13564030#comment-13564030
]
Jay Kreps commented on KAFKA-695:
-
This is a pretty brilliant catch.
That code should not
[
https://issues.apache.org/jira/browse/KAFKA-631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-631:
Attachment: KAFKA-631-v8.patch
Patch v8 includes Jun's comments. Specifically:
Cleaner:
70.1 Nice catch.
Jay Kreps created KAFKA-739:
---
Summary: Handle null values in Message payload
Key: KAFKA-739
URL: https://issues.apache.org/jira/browse/KAFKA-739
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps reassigned KAFKA-739:
---
Assignee: Jay Kreps
Handle null values in Message payload
-
[
https://issues.apache.org/jira/browse/KAFKA-741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-741:
Fix Version/s: 0.8.1
Assignee: Jay Kreps
Issue Type: Improvement (was: Bug)
Improve
[
https://issues.apache.org/jira/browse/KAFKA-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13565696#comment-13565696
]
Jay Kreps commented on KAFKA-742:
-
Getting an error is not really bad since we assume we
[
https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps reopened KAFKA-683:
-
Guys, this patch adds request specific stuff to RequestChannel. RequestChannel
is really not the place to be
[
https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13566188#comment-13566188
]
Jay Kreps commented on KAFKA-671:
-
Took a look at this. Looks reasonable.
Other atrocities
[
https://issues.apache.org/jira/browse/KAFKA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13566215#comment-13566215
]
Jay Kreps commented on KAFKA-736:
-
This is basically good, but the comments and naming are
[
https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13566234#comment-13566234
]
Jay Kreps commented on KAFKA-683:
-
Yeah, I am on the fence about the metrics stuff, maybe
[
https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13566240#comment-13566240
]
Jay Kreps commented on KAFKA-671:
-
Okay let's sync up. I think requestObj is the devil. :-)
[
https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13566599#comment-13566599
]
Jay Kreps commented on KAFKA-683:
-
The design was that the network layer is fully generic
[
https://issues.apache.org/jira/browse/KAFKA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13566883#comment-13566883
]
Jay Kreps commented on KAFKA-736:
-
1. It would be good to remove getShutdownReceive() too.
Jay Kreps created KAFKA-747:
---
Summary: RequestChannel re-design
Key: KAFKA-747
URL: https://issues.apache.org/jira/browse/KAFKA-747
Project: Kafka
Issue Type: New Feature
Reporter: Jay
[
https://issues.apache.org/jira/browse/KAFKA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13569224#comment-13569224
]
Jay Kreps commented on KAFKA-736:
-
Reviewing the draft patch in case we end up going that
[
https://issues.apache.org/jira/browse/KAFKA-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13571071#comment-13571071
]
Jay Kreps commented on KAFKA-749:
-
The ugly part here is the extra layer of synchronization
[
https://issues.apache.org/jira/browse/KAFKA-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13571355#comment-13571355
]
Jay Kreps commented on KAFKA-749:
-
Err, should be
while(true) {
queue.clear()
[
https://issues.apache.org/jira/browse/KAFKA-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13571427#comment-13571427
]
Jay Kreps commented on KAFKA-695:
-
Can we just remove the interrupt entirely instead of
[
https://issues.apache.org/jira/browse/KAFKA-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13571427#comment-13571427
]
Jay Kreps commented on KAFKA-695:
-
Can we just remove the interrupt entirely instead of
[
https://issues.apache.org/jira/browse/KAFKA-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13571585#comment-13571585
]
Jay Kreps commented on KAFKA-749:
-
Also, not sure if I get it. If the I/O threads are able
[
https://issues.apache.org/jira/browse/KAFKA-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13573996#comment-13573996
]
Jay Kreps commented on KAFKA-750:
-
Are you sure this is a clean shutdown? Do we have the
1 - 100 of 1195 matches
Mail list logo
