[jira] [Commented] (KAFKA-2066) Replace FetchRequest / FetchResponse with their org.apache.kafka.common.requests equivalents

2016-11-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665565#comment-15665565 ] ASF GitHub Bot commented on KAFKA-2066: --- Github user asfgit closed the pull request

[jira] [Commented] (KAFKA-2066) Replace FetchRequest / FetchResponse with their org.apache.kafka.common.requests equivalents

2016-10-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15609393#comment-15609393 ] ASF GitHub Bot commented on KAFKA-2066: --- GitHub user hachikuji opened a pull request

[jira] [Commented] (KAFKA-2066) Replace FetchRequest / FetchResponse with their org.apache.kafka.common.requests equivalents

2016-10-13 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571793#comment-15571793 ] Ismael Juma commented on KAFKA-2066: Thanks David. Assigned to Jason as he said he's a

[jira] [Commented] (KAFKA-2066) Replace FetchRequest / FetchResponse with their org.apache.kafka.common.requests equivalents

2016-10-13 Thread David Jacot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571702#comment-15571702 ] David Jacot commented on KAFKA-2066: Unfortunately, I won't have time in the next week

[jira] [Commented] (KAFKA-2066) Replace FetchRequest / FetchResponse with their org.apache.kafka.common.requests equivalents

2016-10-12 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15570135#comment-15570135 ] Jason Gustafson commented on KAFKA-2066: I am available to pick this up since I'm

[jira] [Commented] (KAFKA-2066) Replace FetchRequest / FetchResponse with their org.apache.kafka.common.requests equivalents

2016-10-12 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15570087#comment-15570087 ] Ismael Juma commented on KAFKA-2066: [~dajac], it would be good to make progress on th

[jira] [Commented] (KAFKA-2066) Replace FetchRequest / FetchResponse with their org.apache.kafka.common.requests equivalents

2016-03-08 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185779#comment-15185779 ] Grant Henke commented on KAFKA-2066: [~dajac] Are you still working on this? > Replac

[jira] [Commented] (KAFKA-2066) Replace FetchRequest / FetchResponse with their org.apache.kafka.common.requests equivalents

2016-02-23 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15158985#comment-15158985 ] Ismael Juma commented on KAFKA-2066: [~dajac], the PR for KIP-31 and KIP-32 has been m

[jira] [Commented] (KAFKA-2066) Replace FetchRequest / FetchResponse with their org.apache.kafka.common.requests equivalents

2016-01-22 Thread David Jacot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15112619#comment-15112619 ] David Jacot commented on KAFKA-2066: [~becket_qin] That makes sense. I'll take a look

[jira] [Commented] (KAFKA-2066) Replace FetchRequest / FetchResponse with their org.apache.kafka.common.requests equivalents

2016-01-22 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15112481#comment-15112481 ] Jiangjie Qin commented on KAFKA-2066: - [~dajac] I think it would be better if you can

[jira] [Commented] (KAFKA-2066) Replace FetchRequest / FetchResponse with their org.apache.kafka.common.requests equivalents

2016-01-22 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15112285#comment-15112285 ] Ismael Juma commented on KAFKA-2066: [~dajac], I suggest you submit a PR for review on

[jira] [Commented] (KAFKA-2066) Replace FetchRequest / FetchResponse with their org.apache.kafka.common.requests equivalents

2016-01-21 Thread David Jacot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15112045#comment-15112045 ] David Jacot commented on KAFKA-2066: [~becket_qin], indeed replacing MessageSet with R

[jira] [Commented] (KAFKA-2066) Replace FetchRequest / FetchResponse with their org.apache.kafka.common.requests equivalents

2016-01-21 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1507#comment-1507 ] Ismael Juma commented on KAFKA-2066: [~becket_qin], that makes sense to me (although I

[jira] [Commented] (KAFKA-2066) Replace FetchRequest / FetchResponse with their org.apache.kafka.common.requests equivalents

2016-01-21 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15111034#comment-15111034 ] Jiangjie Qin commented on KAFKA-2066: - [~dajac] [~ijuma] I was thinking about this whe

[jira] [Commented] (KAFKA-2066) Replace FetchRequest / FetchResponse with their org.apache.kafka.common.requests equivalents

2016-01-19 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15107070#comment-15107070 ] Ismael Juma commented on KAFKA-2066: Yes, a way to convert from MessageSet to Record i

[jira] [Commented] (KAFKA-2066) Replace FetchRequest / FetchResponse with their org.apache.kafka.common.requests equivalents

2016-01-19 Thread David Jacot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15107051#comment-15107051 ] David Jacot commented on KAFKA-2066: [~ijuma], - Inheritance might not be the best way

[jira] [Commented] (KAFKA-2066) Replace FetchRequest / FetchResponse with their org.apache.kafka.common.requests equivalents

2016-01-19 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15106721#comment-15106721 ] Ismael Juma commented on KAFKA-2066: [~dajac], I am not sure about making `MessageSet`

[jira] [Commented] (KAFKA-2066) Replace FetchRequest / FetchResponse with their org.apache.kafka.common.requests equivalents

2016-01-17 Thread David Jacot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15104883#comment-15104883 ] David Jacot commented on KAFKA-2066: In the current implementation, FetchResponse cont