Re: [DISCUSS] KIP-265: Make Windowed Serde to public APIs

2018-03-02 Thread Guozhang Wang
@Xi: 1. SimpleConsumerShell is marked as deprecated in 0.11.0 and will be removed soon in the future releases, so I did not consider it in this KIP. 2. Yes, it is contained in the Public Interfaces section of the wiki, please read the section and let me know (it is slightly different with your pro

Re: [DISCUSS] KIP-265: Make Windowed Serde to public APIs

2018-03-02 Thread Damian Guy
Thanks Guozhang, LGTM On Fri, 2 Mar 2018 at 03:00 Hu Xi wrote: > Guozhang, > > > Thanks for this KIP. Please help confirm questions below: > > 1. Do we also need to retrofit `SimpleConsumerShell` to have it > support these newly-added serdes? > 2. Does this KIP cover the changes for Cons