Re: [DISCUSS] KIP-308: GetOffsetShell: new KafkaConsumer API, support for multiple topics, minimize the number of requests to server

2020-06-30 Thread Dániel Urbán
That's a good question. In the PR I submitted, it would result in a list of partitions contained by a topic for which the user has DESCRIBE privilege. The tool utilizes Consumer.listTopics, so unauthorized topics are not present in the response at all. The current version in trunk simply reports

Re: [DISCUSS] KIP-308: GetOffsetShell: new KafkaConsumer API, support for multiple topics, minimize the number of requests to server

2020-06-30 Thread Dániel Urbán
Hi Manikumar, Thanks, went ahead and assigned a new ID, it is KIP-635 now: https://cwiki.apache.org/confluence/display/KAFKA/KIP-635%3A+GetOffsetShell%3A+support+for+multiple+topics+and+consumer+configuration+override Daniel Manikumar ezt írta (időpont: 2020. jún. 30., K, 16:03): > Hi, > > Yes,

Re: [DISCUSS] KIP-308: GetOffsetShell: new KafkaConsumer API, support for multiple topics, minimize the number of requests to server

2020-06-30 Thread Manikumar
Hi, Yes, we can assign new id to this KIP. Thanks. On Tue, Jun 30, 2020 at 6:59 PM Dániel Urbán wrote: > Hi, > > To help with the discussion, I also have a PR for this KIP now. reflecting > the current state of the KIP: https://github.com/apache/kafka/pull/8957. > I would like to ask a

Re: [DISCUSS] KIP-308: GetOffsetShell: new KafkaConsumer API, support for multiple topics, minimize the number of requests to server

2020-06-30 Thread Dániel Urbán
Hi, To help with the discussion, I also have a PR for this KIP now. reflecting the current state of the KIP: https://github.com/apache/kafka/pull/8957. I would like to ask a committer to start the test job on it. One thing I realised though is that there is a KIP id collision, there is another

Re: [DISCUSS] KIP-308: GetOffsetShell: new KafkaConsumer API, support for multiple topics, minimize the number of requests to server

2020-06-30 Thread Dániel Urbán
Hi Manikumar, Thanks for the comments. 1. Will change this - thought that "command-config" is used for admin clients. 2. It's not necessary, just felt like a nice quality-of-life feature - will remove it. Thanks, Daniel On Tue, Jun 30, 2020 at 4:16 AM Manikumar wrote: > Hi Daniel, > > Thanks

Re: [DISCUSS] KIP-308: GetOffsetShell: new KafkaConsumer API, support for multiple topics, minimize the number of requests to server

2020-06-29 Thread Manikumar
Hi Daniel, Thanks for working on this KIP. Proposed changes looks good to me, minor comments: 1. We use "command-config" option name in most of the cmdline tools to pass config properties file. We can use the same name here. 2. Not sure, if we need a separate option to pass an consumer

Re: [DISCUSS] KIP-308: GetOffsetShell: new KafkaConsumer API, support for multiple topics, minimize the number of requests to server

2020-06-24 Thread Dániel Urbán
Hi, I see that this KIP turned somewhat inactive - I'd like to pick it up and work on it if it is okay. Part of the work is done, as switching to the Consumer API is already in trunk, but some functionality is still missing. I've seen the current PR and the discussion so far, only have a few

Re: [DISCUSS] KIP-308: GetOffsetShell: new KafkaConsumer API, support for multiple topics, minimize the number of requests to server

2019-02-08 Thread Stanislav Kozlovski
Hey Arseniy, Do you plan on continuing the work for this KIP? I would gladly take over. I find myself needing the GetOffsetShell tool to work on secured cluster time and time again, I had even implemented a duplicate JIRA (KAFKA-7373 ) about it

Re: [DISCUSS] KIP-308: GetOffsetShell: new KafkaConsumer API, support for multiple topics, minimize the number of requests to server

2018-09-25 Thread Manikumar
Hi Arseniy, It is good have GetOffsetShell tool to work on secure clusters. Passing additional configuration to the underlying KafkaConsumer is sufficient for the requirement. Can you revive this discussion thread? Let us know if you need any help. Thanks, On Mon, Jun 4, 2018 at 3:27 PM

Re: [DISCUSS] KIP-308: GetOffsetShell: new KafkaConsumer API, support for multiple topics, minimize the number of requests to server

2018-06-04 Thread Viktor Somogyi
Hi Arseniy, A few comments from me collected in points: 1. Usually the commands use "bootstrap-server" as in singular and not the plural "bootstrap-servers", so I suggest to keep this functionality. Otherwise their behavior is still the same. 2. kafka-get-offsets.sh --bootstrap-servers vm:9092