[jira] [Updated] (KNOX-2953) Uniform name of http method of client metric to lowerCase

2023-08-31 Thread Sandeep More (Jira)


 [ 
https://issues.apache.org/jira/browse/KNOX-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sandeep More updated KNOX-2953:
---
Fix Version/s: 2.1.0
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

> Uniform name of http method of client metric to lowerCase
> -
>
> Key: KNOX-2953
> URL: https://issues.apache.org/jira/browse/KNOX-2953
> Project: Apache Knox
>  Issue Type: Improvement
>  Components: Metrics
>Reporter: liang.feng
>Priority: Minor
> Fix For: 2.1.0
>
> Attachments: gateway-client-metric.png, 
> gateway-metric-client-after-fix.png
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The metric name starting with client should set httpMethod to lowercase, when 
> build metric name, just like the service metric name at [#
> [https://github.com/apache/knox/blob/master/gateway-server/src/main/java/org/apache/knox/gateway/services/metrics/impl/instr/InstrHttpClientBuilderProvider.java#L68]]
>  
> There are many similar metric names now,due to name of httpMethod is 
> non-uniform. 
> For example:
> When I query from HBase with curl command , The command curl -X Get 和 curl -X 
> GET will generate two similar metric name
> !gateway-client-metric.png!  
> We should uniformly change the method name to lowercase  so that the metric 
> names of service and client are unified.
>  
> The effect after applying the [PR789|https://github.com/apache/knox/pull/789]
> !gateway-metric-client-after-fix.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (KNOX-2953) Uniform name of http method of client metric to lowerCase

2023-08-29 Thread liang.feng (Jira)


 [ 
https://issues.apache.org/jira/browse/KNOX-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

liang.feng updated KNOX-2953:
-
Description: 
The metric name starting with client should set httpMethod to lowercase, when 
build metric name, just like the service metric name at [#
[https://github.com/apache/knox/blob/master/gateway-server/src/main/java/org/apache/knox/gateway/services/metrics/impl/instr/InstrHttpClientBuilderProvider.java#L68]]
 
There are many similar metric names now,due to name of httpMethod is 
non-uniform. 
For example:
When I query from HBase with curl command , The command curl -X Get 和 curl -X 
GET will generate two similar metric name

!gateway-client-metric.png!  
We should uniformly change the method name to lowercase  so that the metric 
names of service and client are unified.

 

The effect after applying the [PR789|https://github.com/apache/knox/pull/789]

!gateway-metric-client-after-fix.png!

  was:
The metric name starting with client should set httpMethod to lowercase, when 
build metric name, just like the service metric name at [#
[https://github.com/apache/knox/blob/master/gateway-server/src/main/java/org/apache/knox/gateway/services/metrics/impl/instr/InstrHttpClientBuilderProvider.java#L68]]
 
There are many similar metric names now,due to name of httpMethod is 
non-uniform. 
For example:
When I query from HBase with curl command , The command curl -X Get 和 curl -X 
GET will generate two similar metric name

!gateway-client-metric.png!  
We should uniformly change the method name to lowercase  so that the metric 
names of service and client are unified


> Uniform name of http method of client metric to lowerCase
> -
>
> Key: KNOX-2953
> URL: https://issues.apache.org/jira/browse/KNOX-2953
> Project: Apache Knox
>  Issue Type: Improvement
>  Components: Metrics
>Reporter: liang.feng
>Priority: Minor
> Attachments: gateway-client-metric.png, 
> gateway-metric-client-after-fix.png
>
>
> The metric name starting with client should set httpMethod to lowercase, when 
> build metric name, just like the service metric name at [#
> [https://github.com/apache/knox/blob/master/gateway-server/src/main/java/org/apache/knox/gateway/services/metrics/impl/instr/InstrHttpClientBuilderProvider.java#L68]]
>  
> There are many similar metric names now,due to name of httpMethod is 
> non-uniform. 
> For example:
> When I query from HBase with curl command , The command curl -X Get 和 curl -X 
> GET will generate two similar metric name
> !gateway-client-metric.png!  
> We should uniformly change the method name to lowercase  so that the metric 
> names of service and client are unified.
>  
> The effect after applying the [PR789|https://github.com/apache/knox/pull/789]
> !gateway-metric-client-after-fix.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (KNOX-2953) Uniform name of http method of client metric to lowerCase

2023-08-29 Thread liang.feng (Jira)


 [ 
https://issues.apache.org/jira/browse/KNOX-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

liang.feng updated KNOX-2953:
-
Attachment: gateway-metric-client-after-fix.png

> Uniform name of http method of client metric to lowerCase
> -
>
> Key: KNOX-2953
> URL: https://issues.apache.org/jira/browse/KNOX-2953
> Project: Apache Knox
>  Issue Type: Improvement
>  Components: Metrics
>Reporter: liang.feng
>Priority: Minor
> Attachments: gateway-client-metric.png, 
> gateway-metric-client-after-fix.png
>
>
> The metric name starting with client should set httpMethod to lowercase, when 
> build metric name, just like the service metric name at [#
> [https://github.com/apache/knox/blob/master/gateway-server/src/main/java/org/apache/knox/gateway/services/metrics/impl/instr/InstrHttpClientBuilderProvider.java#L68]]
>  
> There are many similar metric names now,due to name of httpMethod is 
> non-uniform. 
> For example:
> When I query from HBase with curl command , The command curl -X Get 和 curl -X 
> GET will generate two similar metric name
> !gateway-client-metric.png!  
> We should uniformly change the method name to lowercase  so that the metric 
> names of service and client are unified



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (KNOX-2953) Uniform name of http method of client metric to lowerCase

2023-08-29 Thread liang.feng (Jira)


 [ 
https://issues.apache.org/jira/browse/KNOX-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

liang.feng updated KNOX-2953:
-
Description: 
The metric name starting with client should set httpMethod to lowercase, when 
build metric name, just like the service metric name at [#
[https://github.com/apache/knox/blob/master/gateway-server/src/main/java/org/apache/knox/gateway/services/metrics/impl/instr/InstrHttpClientBuilderProvider.java#L68]]
 
There are many similar metric names now,due to name of httpMethod is 
non-uniform. 
For example:
When I query from HBase with curl command , The command curl -X Get 和 curl -X 
GET will generate two similar metric name

!gateway-client-metric.png!  
We should uniformly change the method name to lowercase  so that the metric 
names of service and client are unified

  was:
The metric name starting with client should set httpMethod to lowercase, when 
build metric name, just like the service metric name at [#
[https://github.com/apache/knox/blob/master/gateway-server/src/main/java/org/apache/knox/gateway/services/metrics/impl/instr/InstrHttpClientBuilderProvider.java#L68]]
 
There are many similar metric names now,due to name of httpMethod is 
non-uniform. 
For example:
When I query from HBase with curl command , The command curl -X Get 和 curl -X 
GET will generate two similar metric name

 
We should uniformly change the method name to lowercase  so that the metric 
names of service and client are unified


> Uniform name of http method of client metric to lowerCase
> -
>
> Key: KNOX-2953
> URL: https://issues.apache.org/jira/browse/KNOX-2953
> Project: Apache Knox
>  Issue Type: Improvement
>  Components: Metrics
>Reporter: liang.feng
>Priority: Minor
> Attachments: gateway-client-metric.png
>
>
> The metric name starting with client should set httpMethod to lowercase, when 
> build metric name, just like the service metric name at [#
> [https://github.com/apache/knox/blob/master/gateway-server/src/main/java/org/apache/knox/gateway/services/metrics/impl/instr/InstrHttpClientBuilderProvider.java#L68]]
>  
> There are many similar metric names now,due to name of httpMethod is 
> non-uniform. 
> For example:
> When I query from HBase with curl command , The command curl -X Get 和 curl -X 
> GET will generate two similar metric name
> !gateway-client-metric.png!  
> We should uniformly change the method name to lowercase  so that the metric 
> names of service and client are unified



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (KNOX-2953) Uniform name of http method of client metric to lowerCase

2023-08-29 Thread liang.feng (Jira)


 [ 
https://issues.apache.org/jira/browse/KNOX-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

liang.feng updated KNOX-2953:
-
Attachment: gateway-client-metric.png

> Uniform name of http method of client metric to lowerCase
> -
>
> Key: KNOX-2953
> URL: https://issues.apache.org/jira/browse/KNOX-2953
> Project: Apache Knox
>  Issue Type: Improvement
>  Components: Metrics
>Reporter: liang.feng
>Priority: Minor
> Attachments: gateway-client-metric.png
>
>
> The metric name starting with client should set httpMethod to lowercase, when 
> build metric name, just like the service metric name at [#
> https://github.com/apache/knox/blob/master/gateway-server/src/main/java/org/apache/knox/gateway/services/metrics/impl/instr/InstrHttpClientBuilderProvider.java#L68]
>  
> There are many similar metric names now,due to name of httpMethod is 
> non-uniform. 
> For example:
> When I query from HBase with curl command , The command curl -X Get 和 curl -X 
> GET will generate two similar metric name
> !gateway-client-metric.png!
>  
> We should uniformly change the method name to lowercase  so that the metric 
> names of service and client are unified



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (KNOX-2953) Uniform name of http method of client metric to lowerCase

2023-08-29 Thread liang.feng (Jira)


 [ 
https://issues.apache.org/jira/browse/KNOX-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

liang.feng updated KNOX-2953:
-
Description: 
The metric name starting with client should set httpMethod to lowercase, when 
build metric name, just like the service metric name at [#
[https://github.com/apache/knox/blob/master/gateway-server/src/main/java/org/apache/knox/gateway/services/metrics/impl/instr/InstrHttpClientBuilderProvider.java#L68]]
 
There are many similar metric names now,due to name of httpMethod is 
non-uniform. 
For example:
When I query from HBase with curl command , The command curl -X Get 和 curl -X 
GET will generate two similar metric name

 
We should uniformly change the method name to lowercase  so that the metric 
names of service and client are unified

  was:
The metric name starting with client should set httpMethod to lowercase, when 
build metric name, just like the service metric name at [#
https://github.com/apache/knox/blob/master/gateway-server/src/main/java/org/apache/knox/gateway/services/metrics/impl/instr/InstrHttpClientBuilderProvider.java#L68]
 
There are many similar metric names now,due to name of httpMethod is 
non-uniform. 
For example:
When I query from HBase with curl command , The command curl -X Get 和 curl -X 
GET will generate two similar metric name
!gateway-client-metric.png!
 
We should uniformly change the method name to lowercase  so that the metric 
names of service and client are unified


> Uniform name of http method of client metric to lowerCase
> -
>
> Key: KNOX-2953
> URL: https://issues.apache.org/jira/browse/KNOX-2953
> Project: Apache Knox
>  Issue Type: Improvement
>  Components: Metrics
>Reporter: liang.feng
>Priority: Minor
> Attachments: gateway-client-metric.png
>
>
> The metric name starting with client should set httpMethod to lowercase, when 
> build metric name, just like the service metric name at [#
> [https://github.com/apache/knox/blob/master/gateway-server/src/main/java/org/apache/knox/gateway/services/metrics/impl/instr/InstrHttpClientBuilderProvider.java#L68]]
>  
> There are many similar metric names now,due to name of httpMethod is 
> non-uniform. 
> For example:
> When I query from HBase with curl command , The command curl -X Get 和 curl -X 
> GET will generate two similar metric name
>  
> We should uniformly change the method name to lowercase  so that the metric 
> names of service and client are unified



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (KNOX-2953) Uniform name of http method of client metric to lowerCase

2023-08-29 Thread liang.feng (Jira)


 [ 
https://issues.apache.org/jira/browse/KNOX-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

liang.feng updated KNOX-2953:
-
Attachment: (was: gateway-client-metric.png)

> Uniform name of http method of client metric to lowerCase
> -
>
> Key: KNOX-2953
> URL: https://issues.apache.org/jira/browse/KNOX-2953
> Project: Apache Knox
>  Issue Type: Improvement
>  Components: Metrics
>Reporter: liang.feng
>Priority: Minor
> Attachments: gateway-client-metric.png
>
>
> The metric name starting with client should set httpMethod to lowercase, when 
> build metric name, just like the service metric name at [#
> https://github.com/apache/knox/blob/master/gateway-server/src/main/java/org/apache/knox/gateway/services/metrics/impl/instr/InstrHttpClientBuilderProvider.java#L68]
>  
> There are many similar metric names now,due to name of httpMethod is 
> non-uniform. 
> For example:
> When I query from HBase with curl command , The command curl -X Get 和 curl -X 
> GET will generate two similar metric name
> !gateway-client-metric.png!
>  
> We should uniformly change the method name to lowercase  so that the metric 
> names of service and client are unified



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (KNOX-2953) Uniform name of http method of client metric to lowerCase

2023-08-29 Thread liang.feng (Jira)


 [ 
https://issues.apache.org/jira/browse/KNOX-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

liang.feng updated KNOX-2953:
-
Status: Patch Available  (was: Open)

[PR789|https://github.com/apache/knox/pull/789]

> Uniform name of http method of client metric to lowerCase
> -
>
> Key: KNOX-2953
> URL: https://issues.apache.org/jira/browse/KNOX-2953
> Project: Apache Knox
>  Issue Type: Improvement
>  Components: Metrics
>Reporter: liang.feng
>Priority: Minor
> Attachments: gateway-client-metric.png
>
>
> The metric name starting with client should set httpMethod to lowercase, when 
> build metric name, just like the service metric name at [#
> https://github.com/apache/knox/blob/master/gateway-server/src/main/java/org/apache/knox/gateway/services/metrics/impl/instr/InstrHttpClientBuilderProvider.java#L68]
>  
> There are many similar metric names now,due to name of httpMethod is 
> non-uniform. 
> For example:
> When I query from HBase with curl command , The command curl -X Get 和 curl -X 
> GET will generate two similar metric name
> !gateway-client-metric.png!
>  
> We should uniformly change the method name to lowercase  so that the metric 
> names of service and client are unified



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (KNOX-2953) Uniform name of http method of client metric to lowerCase

2023-08-29 Thread liang.feng (Jira)


 [ 
https://issues.apache.org/jira/browse/KNOX-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

liang.feng updated KNOX-2953:
-
Description: 
The metric name starting with client should set httpMethod to lowercase, when 
build metric name, just like the service metric name at [#
https://github.com/apache/knox/blob/master/gateway-server/src/main/java/org/apache/knox/gateway/services/metrics/impl/instr/InstrHttpClientBuilderProvider.java#L68]
 
There are many similar metric names now,due to name of httpMethod is 
non-uniform. 
For example:
When I query from HBase with curl command , The command curl -X Get 和 curl -X 
GET will generate two similar metric name
!gateway-client-metric.png!
 
We should uniformly change the method name to lowercase  so that the metric 
names of service and client are unified

  was:
The metric name starting with client should set httpMethod to lowercase, when 
build metric name, just like the service metric name at 
[InstrHttpClientBuilderProvider.methodNameString|https://github.com/apache/knox/blob/master/gateway-server/src/main/java/org/apache/knox/gateway/services/metrics/impl/instr/InstrHttpClientBuilderProvider.java#L68
]
 
There are many similar metric names now,due to name of httpMethod is 
non-uniform. 
For example:
When I query from HBase with curl command , The command curl -X Get 和 curl -X 
GET will generate two similar metric name
!gateway-client-metric.png!
 
We should uniformly change the method name to lowercase  so that the metric 
names of service and client are unified


> Uniform name of http method of client metric to lowerCase
> -
>
> Key: KNOX-2953
> URL: https://issues.apache.org/jira/browse/KNOX-2953
> Project: Apache Knox
>  Issue Type: Improvement
>  Components: Metrics
>Reporter: liang.feng
>Priority: Minor
> Attachments: gateway-client-metric.png
>
>
> The metric name starting with client should set httpMethod to lowercase, when 
> build metric name, just like the service metric name at [#
> https://github.com/apache/knox/blob/master/gateway-server/src/main/java/org/apache/knox/gateway/services/metrics/impl/instr/InstrHttpClientBuilderProvider.java#L68]
>  
> There are many similar metric names now,due to name of httpMethod is 
> non-uniform. 
> For example:
> When I query from HBase with curl command , The command curl -X Get 和 curl -X 
> GET will generate two similar metric name
> !gateway-client-metric.png!
>  
> We should uniformly change the method name to lowercase  so that the metric 
> names of service and client are unified



--
This message was sent by Atlassian Jira
(v8.20.10#820010)