subject:"Re\: Review Request 37530\: LENS\-629 \- A new improved web client"

Re: Review Request 37530: LENS-629 - A new improved web client

2015-09-23 Thread Ankeet Maini


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/
---

(Updated Sept. 23, 2015, 7:40 a.m.)


Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat 
Khandelwal, sharad agarwal, and Yash Sharma.


Changes
---

Fixes POM typo/.


Bugs: LENS-629
https://issues.apache.org/jira/browse/LENS-629


Repository: lens


Description
---

LENS-629 - A new improved web client


Diffs (updated)
-

  .gitignore 5a356e0 
  lens-ui/LICENSE PRE-CREATION 
  lens-ui/README.markdown PRE-CREATION 
  lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION 
  lens-ui/app/actions/LoginActions.js PRE-CREATION 
  lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION 
  lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION 
  lens-ui/app/adapters/BaseAdapter.js PRE-CREATION 
  lens-ui/app/app.js PRE-CREATION 
  lens-ui/app/components/AboutComponent.js PRE-CREATION 
  lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION 
  lens-ui/app/components/AppComponent.js PRE-CREATION 
  lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION 
  lens-ui/app/components/CubeTreeComponent.js PRE-CREATION 
  lens-ui/app/components/DatabaseComponent.js PRE-CREATION 
  lens-ui/app/components/HeaderComponent.js PRE-CREATION 
  lens-ui/app/components/LoaderComponent.js PRE-CREATION 
  lens-ui/app/components/LoginComponent.js PRE-CREATION 
  lens-ui/app/components/LogoutComponent.js PRE-CREATION 
  lens-ui/app/components/QueryBoxComponent.js PRE-CREATION 
  lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION 
  lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION 
  lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION 
  lens-ui/app/components/QueryResultsComponent.js PRE-CREATION 
  lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION 
  lens-ui/app/components/SidebarComponent.js PRE-CREATION 
  lens-ui/app/components/TableSchemaComponent.js PRE-CREATION 
  lens-ui/app/components/TableTreeComponent.js PRE-CREATION 
  lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION 
  lens-ui/app/constants/AppConstants.js PRE-CREATION 
  lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION 
  lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION 
  lens-ui/app/stores/CubeStore.js PRE-CREATION 
  lens-ui/app/stores/DatabaseStore.js PRE-CREATION 
  lens-ui/app/stores/TableStore.js PRE-CREATION 
  lens-ui/app/stores/UserStore.js PRE-CREATION 
  lens-ui/app/styles/css/global.css PRE-CREATION 
  lens-ui/app/styles/css/login.css PRE-CREATION 
  lens-ui/app/styles/css/query-component.css PRE-CREATION 
  lens-ui/app/styles/css/tree.css PRE-CREATION 
  lens-ui/app/styles/less/globals.less PRE-CREATION 
  lens-ui/config.json PRE-CREATION 
  lens-ui/index.html PRE-CREATION 
  lens-ui/package.json PRE-CREATION 
  lens-ui/pom.xml PRE-CREATION 
  lens-ui/server.js PRE-CREATION 
  lens-ui/webpack.config.js PRE-CREATION 
  pom.xml 10f9bc1 
  src/site/apt/admin/config.apt 3500441 

Diff: https://reviews.apache.org/r/37530/diff/


Testing
---

No server code added/modified. Just JavaScript!


File Attachments


License details of NPM packages
  
https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt


Thanks,

Ankeet Maini

Re: Review Request 37530: LENS-629 - A new improved web client

2015-09-23 Thread Ankeet Maini


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/
---

(Updated Sept. 23, 2015, 7:44 a.m.)


Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat 
Khandelwal, sharad agarwal, and Yash Sharma.


Changes
---

Reverting unintended src/site/apt/admin/config.apt modifications


Bugs: LENS-629
https://issues.apache.org/jira/browse/LENS-629


Repository: lens


Description
---

LENS-629 - A new improved web client


Diffs (updated)
-

  .gitignore 5a356e0 
  lens-ui/LICENSE PRE-CREATION 
  lens-ui/README.markdown PRE-CREATION 
  lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION 
  lens-ui/app/actions/LoginActions.js PRE-CREATION 
  lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION 
  lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION 
  lens-ui/app/adapters/BaseAdapter.js PRE-CREATION 
  lens-ui/app/app.js PRE-CREATION 
  lens-ui/app/components/AboutComponent.js PRE-CREATION 
  lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION 
  lens-ui/app/components/AppComponent.js PRE-CREATION 
  lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION 
  lens-ui/app/components/CubeTreeComponent.js PRE-CREATION 
  lens-ui/app/components/DatabaseComponent.js PRE-CREATION 
  lens-ui/app/components/HeaderComponent.js PRE-CREATION 
  lens-ui/app/components/LoaderComponent.js PRE-CREATION 
  lens-ui/app/components/LoginComponent.js PRE-CREATION 
  lens-ui/app/components/LogoutComponent.js PRE-CREATION 
  lens-ui/app/components/QueryBoxComponent.js PRE-CREATION 
  lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION 
  lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION 
  lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION 
  lens-ui/app/components/QueryResultsComponent.js PRE-CREATION 
  lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION 
  lens-ui/app/components/SidebarComponent.js PRE-CREATION 
  lens-ui/app/components/TableSchemaComponent.js PRE-CREATION 
  lens-ui/app/components/TableTreeComponent.js PRE-CREATION 
  lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION 
  lens-ui/app/constants/AppConstants.js PRE-CREATION 
  lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION 
  lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION 
  lens-ui/app/stores/CubeStore.js PRE-CREATION 
  lens-ui/app/stores/DatabaseStore.js PRE-CREATION 
  lens-ui/app/stores/TableStore.js PRE-CREATION 
  lens-ui/app/stores/UserStore.js PRE-CREATION 
  lens-ui/app/styles/css/global.css PRE-CREATION 
  lens-ui/app/styles/css/login.css PRE-CREATION 
  lens-ui/app/styles/css/query-component.css PRE-CREATION 
  lens-ui/app/styles/css/tree.css PRE-CREATION 
  lens-ui/app/styles/less/globals.less PRE-CREATION 
  lens-ui/config.json PRE-CREATION 
  lens-ui/index.html PRE-CREATION 
  lens-ui/package.json PRE-CREATION 
  lens-ui/pom.xml PRE-CREATION 
  lens-ui/server.js PRE-CREATION 
  lens-ui/webpack.config.js PRE-CREATION 
  pom.xml 10f9bc1 

Diff: https://reviews.apache.org/r/37530/diff/


Testing
---

No server code added/modified. Just JavaScript!


File Attachments


License details of NPM packages
  
https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt


Thanks,

Ankeet Maini

Re: Review Request 37530: LENS-629 - A new improved web client

2015-09-22 Thread Rajat Khandelwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review99961
---



lens-ui/package.json (line 7)


Can we change `localhost` everywhere to `0.0.0.0`?

I think Lens server also listens on all interfaces instead of just loopback.


- Rajat Khandelwal


On Sept. 22, 2015, 12:04 p.m., Ankeet Maini wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> ---
> 
> (Updated Sept. 22, 2015, 12:04 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat 
> Khandelwal, sharad agarwal, and Yash Sharma.
> 
> 
> Bugs: LENS-629
> https://issues.apache.org/jira/browse/LENS-629
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-629 - A new improved web client
> 
> 
> Diffs
> -
> 
>   .gitignore 5a356e0 
>   lens-ui/LICENSE PRE-CREATION 
>   lens-ui/README.markdown PRE-CREATION 
>   lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION 
>   lens-ui/app/actions/LoginActions.js PRE-CREATION 
>   lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION 
>   lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION 
>   lens-ui/app/adapters/BaseAdapter.js PRE-CREATION 
>   lens-ui/app/app.js PRE-CREATION 
>   lens-ui/app/components/AboutComponent.js PRE-CREATION 
>   lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION 
>   lens-ui/app/components/AppComponent.js PRE-CREATION 
>   lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION 
>   lens-ui/app/components/CubeTreeComponent.js PRE-CREATION 
>   lens-ui/app/components/DatabaseComponent.js PRE-CREATION 
>   lens-ui/app/components/HeaderComponent.js PRE-CREATION 
>   lens-ui/app/components/LoaderComponent.js PRE-CREATION 
>   lens-ui/app/components/LoginComponent.js PRE-CREATION 
>   lens-ui/app/components/LogoutComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryBoxComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryResultsComponent.js PRE-CREATION 
>   lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION 
>   lens-ui/app/components/SidebarComponent.js PRE-CREATION 
>   lens-ui/app/components/TableSchemaComponent.js PRE-CREATION 
>   lens-ui/app/components/TableTreeComponent.js PRE-CREATION 
>   lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION 
>   lens-ui/app/constants/AppConstants.js PRE-CREATION 
>   lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION 
>   lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION 
>   lens-ui/app/stores/CubeStore.js PRE-CREATION 
>   lens-ui/app/stores/DatabaseStore.js PRE-CREATION 
>   lens-ui/app/stores/TableStore.js PRE-CREATION 
>   lens-ui/app/stores/UserStore.js PRE-CREATION 
>   lens-ui/app/styles/css/global.css PRE-CREATION 
>   lens-ui/app/styles/css/login.css PRE-CREATION 
>   lens-ui/app/styles/css/query-component.css PRE-CREATION 
>   lens-ui/app/styles/css/tree.css PRE-CREATION 
>   lens-ui/app/styles/less/globals.less PRE-CREATION 
>   lens-ui/config.json PRE-CREATION 
>   lens-ui/index.html PRE-CREATION 
>   lens-ui/package.json PRE-CREATION 
>   lens-ui/pom.xml PRE-CREATION 
>   lens-ui/server.js PRE-CREATION 
>   lens-ui/webpack.config.js PRE-CREATION 
>   pom.xml adba544 
> 
> Diff: https://reviews.apache.org/r/37530/diff/
> 
> 
> Testing
> ---
> 
> No server code added/modified. Just JavaScript!
> 
> 
> File Attachments
> 
> 
> License details of NPM packages
>   
> https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt
> 
> 
> Thanks,
> 
> Ankeet Maini
> 
>

Re: Review Request 37530: LENS-629 - A new improved web client

2015-09-21 Thread Amareshwari Sriramadasu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review99921
---



pom.xml (line 111)


I think we are already using 1.8, this would be conflicting.


- Amareshwari Sriramadasu


On Sept. 21, 2015, 12:14 p.m., Ankeet Maini wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> ---
> 
> (Updated Sept. 21, 2015, 12:14 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat 
> Khandelwal, sharad agarwal, and Yash Sharma.
> 
> 
> Bugs: LENS-629
> https://issues.apache.org/jira/browse/LENS-629
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-629 - A new improved web client
> 
> 
> Diffs
> -
> 
>   .gitignore 5a356e0 
>   lens-ui/LICENSE PRE-CREATION 
>   lens-ui/README.markdown PRE-CREATION 
>   lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION 
>   lens-ui/app/actions/LoginActions.js PRE-CREATION 
>   lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION 
>   lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION 
>   lens-ui/app/adapters/BaseAdapter.js PRE-CREATION 
>   lens-ui/app/app.js PRE-CREATION 
>   lens-ui/app/components/AboutComponent.js PRE-CREATION 
>   lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION 
>   lens-ui/app/components/AppComponent.js PRE-CREATION 
>   lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION 
>   lens-ui/app/components/CubeTreeComponent.js PRE-CREATION 
>   lens-ui/app/components/DatabaseComponent.js PRE-CREATION 
>   lens-ui/app/components/HeaderComponent.js PRE-CREATION 
>   lens-ui/app/components/LoaderComponent.js PRE-CREATION 
>   lens-ui/app/components/LoginComponent.js PRE-CREATION 
>   lens-ui/app/components/LogoutComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryBoxComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryResultsComponent.js PRE-CREATION 
>   lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION 
>   lens-ui/app/components/SidebarComponent.js PRE-CREATION 
>   lens-ui/app/components/TableSchemaComponent.js PRE-CREATION 
>   lens-ui/app/components/TableTreeComponent.js PRE-CREATION 
>   lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION 
>   lens-ui/app/constants/AppConstants.js PRE-CREATION 
>   lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION 
>   lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION 
>   lens-ui/app/stores/CubeStore.js PRE-CREATION 
>   lens-ui/app/stores/DatabaseStore.js PRE-CREATION 
>   lens-ui/app/stores/TableStore.js PRE-CREATION 
>   lens-ui/app/stores/UserStore.js PRE-CREATION 
>   lens-ui/app/styles/css/global.css PRE-CREATION 
>   lens-ui/app/styles/css/login.css PRE-CREATION 
>   lens-ui/app/styles/css/query-component.css PRE-CREATION 
>   lens-ui/app/styles/css/tree.css PRE-CREATION 
>   lens-ui/app/styles/less/globals.less PRE-CREATION 
>   lens-ui/config.json PRE-CREATION 
>   lens-ui/index.html PRE-CREATION 
>   lens-ui/package.json PRE-CREATION 
>   lens-ui/pom.xml PRE-CREATION 
>   lens-ui/server.js PRE-CREATION 
>   lens-ui/webpack.config.js PRE-CREATION 
>   pom.xml adba544 
> 
> Diff: https://reviews.apache.org/r/37530/diff/
> 
> 
> Testing
> ---
> 
> No server code added/modified. Just JavaScript!
> 
> 
> File Attachments
> 
> 
> License details of NPM packages
>   
> https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt
> 
> 
> Thanks,
> 
> Ankeet Maini
> 
>

Re: Review Request 37530: LENS-629 - A new improved web client

2015-09-21 Thread Ankeet Maini


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/
---

(Updated Sept. 21, 2015, 12:14 p.m.)


Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat 
Khandelwal, sharad agarwal, and Yash Sharma.


Changes
---

1. POM versions mpoved to parent.
2. assets moved to target.


Bugs: LENS-629
https://issues.apache.org/jira/browse/LENS-629


Repository: lens


Description
---

LENS-629 - A new improved web client


Diffs (updated)
-

  .gitignore 5a356e0 
  lens-ui/LICENSE PRE-CREATION 
  lens-ui/README.markdown PRE-CREATION 
  lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION 
  lens-ui/app/actions/LoginActions.js PRE-CREATION 
  lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION 
  lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION 
  lens-ui/app/adapters/BaseAdapter.js PRE-CREATION 
  lens-ui/app/app.js PRE-CREATION 
  lens-ui/app/components/AboutComponent.js PRE-CREATION 
  lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION 
  lens-ui/app/components/AppComponent.js PRE-CREATION 
  lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION 
  lens-ui/app/components/CubeTreeComponent.js PRE-CREATION 
  lens-ui/app/components/DatabaseComponent.js PRE-CREATION 
  lens-ui/app/components/HeaderComponent.js PRE-CREATION 
  lens-ui/app/components/LoaderComponent.js PRE-CREATION 
  lens-ui/app/components/LoginComponent.js PRE-CREATION 
  lens-ui/app/components/LogoutComponent.js PRE-CREATION 
  lens-ui/app/components/QueryBoxComponent.js PRE-CREATION 
  lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION 
  lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION 
  lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION 
  lens-ui/app/components/QueryResultsComponent.js PRE-CREATION 
  lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION 
  lens-ui/app/components/SidebarComponent.js PRE-CREATION 
  lens-ui/app/components/TableSchemaComponent.js PRE-CREATION 
  lens-ui/app/components/TableTreeComponent.js PRE-CREATION 
  lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION 
  lens-ui/app/constants/AppConstants.js PRE-CREATION 
  lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION 
  lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION 
  lens-ui/app/stores/CubeStore.js PRE-CREATION 
  lens-ui/app/stores/DatabaseStore.js PRE-CREATION 
  lens-ui/app/stores/TableStore.js PRE-CREATION 
  lens-ui/app/stores/UserStore.js PRE-CREATION 
  lens-ui/app/styles/css/global.css PRE-CREATION 
  lens-ui/app/styles/css/login.css PRE-CREATION 
  lens-ui/app/styles/css/query-component.css PRE-CREATION 
  lens-ui/app/styles/css/tree.css PRE-CREATION 
  lens-ui/app/styles/less/globals.less PRE-CREATION 
  lens-ui/config.json PRE-CREATION 
  lens-ui/index.html PRE-CREATION 
  lens-ui/package.json PRE-CREATION 
  lens-ui/pom.xml PRE-CREATION 
  lens-ui/server.js PRE-CREATION 
  lens-ui/webpack.config.js PRE-CREATION 
  pom.xml adba544 

Diff: https://reviews.apache.org/r/37530/diff/


Testing
---

No server code added/modified. Just JavaScript!


File Attachments


License details of NPM packages
  
https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt


Thanks,

Ankeet Maini

Re: Review Request 37530: LENS-629 - A new improved web client

2015-09-19 Thread Amareshwari Sriramadasu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review99666
---



lens-ui/README.markdown (lines 35 - 36)


Does this require changes after mavenizing now ?



lens-ui/pom.xml (line 40)


Please dont define versions here. Move all version definitions to parent pom



lens-ui/pom.xml (line 50)


Move version definition to parent pom



lens-ui/pom.xml (lines 58 - 59)


Can these be defined in parent pom?



pom.xml (lines 550 - 552)


Can these folders be moved to target/ ? Otherwise, how will they get 
cleaned up in next build?


- Amareshwari Sriramadasu


On Sept. 19, 2015, 8:44 a.m., Ankeet Maini wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> ---
> 
> (Updated Sept. 19, 2015, 8:44 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat 
> Khandelwal, sharad agarwal, and Yash Sharma.
> 
> 
> Bugs: LENS-629
> https://issues.apache.org/jira/browse/LENS-629
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-629 - A new improved web client
> 
> 
> Diffs
> -
> 
>   .gitignore 5a356e0 
>   lens-ui/LICENSE PRE-CREATION 
>   lens-ui/README.markdown PRE-CREATION 
>   lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION 
>   lens-ui/app/actions/LoginActions.js PRE-CREATION 
>   lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION 
>   lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION 
>   lens-ui/app/adapters/BaseAdapter.js PRE-CREATION 
>   lens-ui/app/app.js PRE-CREATION 
>   lens-ui/app/components/AboutComponent.js PRE-CREATION 
>   lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION 
>   lens-ui/app/components/AppComponent.js PRE-CREATION 
>   lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION 
>   lens-ui/app/components/CubeTreeComponent.js PRE-CREATION 
>   lens-ui/app/components/DatabaseComponent.js PRE-CREATION 
>   lens-ui/app/components/HeaderComponent.js PRE-CREATION 
>   lens-ui/app/components/LoaderComponent.js PRE-CREATION 
>   lens-ui/app/components/LoginComponent.js PRE-CREATION 
>   lens-ui/app/components/LogoutComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryBoxComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryResultsComponent.js PRE-CREATION 
>   lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION 
>   lens-ui/app/components/SidebarComponent.js PRE-CREATION 
>   lens-ui/app/components/TableSchemaComponent.js PRE-CREATION 
>   lens-ui/app/components/TableTreeComponent.js PRE-CREATION 
>   lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION 
>   lens-ui/app/constants/AppConstants.js PRE-CREATION 
>   lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION 
>   lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION 
>   lens-ui/app/stores/CubeStore.js PRE-CREATION 
>   lens-ui/app/stores/DatabaseStore.js PRE-CREATION 
>   lens-ui/app/stores/TableStore.js PRE-CREATION 
>   lens-ui/app/stores/UserStore.js PRE-CREATION 
>   lens-ui/app/styles/css/global.css PRE-CREATION 
>   lens-ui/app/styles/css/login.css PRE-CREATION 
>   lens-ui/app/styles/css/query-component.css PRE-CREATION 
>   lens-ui/app/styles/css/tree.css PRE-CREATION 
>   lens-ui/app/styles/less/globals.less PRE-CREATION 
>   lens-ui/config.json PRE-CREATION 
>   lens-ui/index.html PRE-CREATION 
>   lens-ui/package.json PRE-CREATION 
>   lens-ui/pom.xml PRE-CREATION 
>   lens-ui/server.js PRE-CREATION 
>   lens-ui/webpack.config.js PRE-CREATION 
>   pom.xml adba544 
> 
> Diff: https://reviews.apache.org/r/37530/diff/
> 
> 
> Testing
> ---
> 
> No server code added/modified. Just JavaScript!
> 
> 
> File Attachments
> 
> 
> License details of NPM packages
>   
> https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt
> 
> 
> Thanks,
> 
> Ankeet Maini
> 
>

Re: Review Request 37530: LENS-629 - A new improved web client

2015-09-18 Thread Rajat Khandelwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review99393
---



lens-ui/pom.xml (line 50)


remove redundant space


- Rajat Khandelwal


On Sept. 17, 2015, 5:49 p.m., Ankeet Maini wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> ---
> 
> (Updated Sept. 17, 2015, 5:49 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat 
> Khandelwal, sharad agarwal, and Yash Sharma.
> 
> 
> Bugs: LENS-629
> https://issues.apache.org/jira/browse/LENS-629
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-629 - A new improved web client
> 
> 
> Diffs
> -
> 
>   .gitignore 5a356e0 
>   lens-ui/LICENSE PRE-CREATION 
>   lens-ui/README.markdown PRE-CREATION 
>   lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION 
>   lens-ui/app/actions/LoginActions.js PRE-CREATION 
>   lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION 
>   lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION 
>   lens-ui/app/adapters/BaseAdapter.js PRE-CREATION 
>   lens-ui/app/app.js PRE-CREATION 
>   lens-ui/app/components/AboutComponent.js PRE-CREATION 
>   lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION 
>   lens-ui/app/components/AppComponent.js PRE-CREATION 
>   lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION 
>   lens-ui/app/components/CubeTreeComponent.js PRE-CREATION 
>   lens-ui/app/components/DatabaseComponent.js PRE-CREATION 
>   lens-ui/app/components/HeaderComponent.js PRE-CREATION 
>   lens-ui/app/components/LoaderComponent.js PRE-CREATION 
>   lens-ui/app/components/LoginComponent.js PRE-CREATION 
>   lens-ui/app/components/LogoutComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryBoxComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryResultsComponent.js PRE-CREATION 
>   lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION 
>   lens-ui/app/components/SidebarComponent.js PRE-CREATION 
>   lens-ui/app/components/TableSchemaComponent.js PRE-CREATION 
>   lens-ui/app/components/TableTreeComponent.js PRE-CREATION 
>   lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION 
>   lens-ui/app/constants/AppConstants.js PRE-CREATION 
>   lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION 
>   lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION 
>   lens-ui/app/stores/CubeStore.js PRE-CREATION 
>   lens-ui/app/stores/DatabaseStore.js PRE-CREATION 
>   lens-ui/app/stores/TableStore.js PRE-CREATION 
>   lens-ui/app/stores/UserStore.js PRE-CREATION 
>   lens-ui/app/styles/css/global.css PRE-CREATION 
>   lens-ui/app/styles/css/login.css PRE-CREATION 
>   lens-ui/app/styles/css/query-component.css PRE-CREATION 
>   lens-ui/app/styles/css/tree.css PRE-CREATION 
>   lens-ui/app/styles/less/globals.less PRE-CREATION 
>   lens-ui/config.json PRE-CREATION 
>   lens-ui/index.html PRE-CREATION 
>   lens-ui/package.json PRE-CREATION 
>   lens-ui/pom.xml PRE-CREATION 
>   lens-ui/server.js PRE-CREATION 
>   lens-ui/webpack.config.js PRE-CREATION 
>   pom.xml adba544 
> 
> Diff: https://reviews.apache.org/r/37530/diff/
> 
> 
> Testing
> ---
> 
> No server code added/modified. Just JavaScript!
> 
> 
> File Attachments
> 
> 
> License details of NPM packages
>   
> https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt
> 
> 
> Thanks,
> 
> Ankeet Maini
> 
>

Re: Review Request 37530: LENS-629 - A new improved web client

2015-09-18 Thread Ankeet Maini



> On Aug. 19, 2015, 5:38 a.m., Amareshwari Sriramadasu wrote:
> > lens-ui/app/adapters/AdhocQueryAdapter.js, line 9
> > 
> >
> > Not accepting adhoc queries on dimensions?
> > 
> > do we need metastore/dimensions as well ?
> 
> Ankeet Maini wrote:
> When I fetch cubes, its measures and dimensions come as well, and are 
> discoverable and people can query them. Not sure if I understand your 
> question completely!
> 
> Amareshwari Sriramadasu wrote:
> Parallel to Cubes (which have measures and dim-attributes), we have 
> Dimensions which have dimension tables. I'm talking about querying them 
> directly.
> 
> Ankeet Maini wrote:
> As per the current implementation and AFAIK we can query the dimensions 
> via native table, because for every dimension created a native table would've 
> been created.
> 
> Amareshwari Sriramadasu wrote:
> We can query dimensions similar to cubes with cube select. See example 
> queries 
> https://github.com/apache/incubator-lens/blob/master/lens-examples/src/main/resources/dimension-queries.sql.
>  It would good to explore and query dimensions as well through ui.
> 
> Rajat Khandelwal wrote:
> Yes, on the left side you're showing cubes which on click show the 
> queryable fields. Dimensions(not dim tables or native tables) also have 
> queryable fields. 
> 
> Secondly, native tables basically take away the abstractions provided to 
> the user. They are only for debugging purposes, we're not supposed to build 
> any feature depending on the "functionality" of native tables. Native tables 
> are not a "functionality", they are a back-door pass.
> 
> Amareshwari Sriramadasu wrote:
> Native tables are for debugging purpose only if logical tables are 
> created on top them. Without any cubes/dimensions created, users can query 
> native tables and make use of features provided by lens wrt query life cycle. 
> For the same reason, querying native tables should not be discouraged. To 
> distinguish between existing native tables and physical tables of logical 
> abstraction, native tables api can take a flag to specify whether it should 
> include physical tables or not.

I can definitely take this up in the next cut!


- Ankeet


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review95819
---


On Sept. 18, 2015, 10:28 a.m., Ankeet Maini wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> ---
> 
> (Updated Sept. 18, 2015, 10:28 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat 
> Khandelwal, sharad agarwal, and Yash Sharma.
> 
> 
> Bugs: LENS-629
> https://issues.apache.org/jira/browse/LENS-629
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-629 - A new improved web client
> 
> 
> Diffs
> -
> 
>   .gitignore 5a356e0 
>   lens-ui/LICENSE PRE-CREATION 
>   lens-ui/README.markdown PRE-CREATION 
>   lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION 
>   lens-ui/app/actions/LoginActions.js PRE-CREATION 
>   lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION 
>   lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION 
>   lens-ui/app/adapters/BaseAdapter.js PRE-CREATION 
>   lens-ui/app/app.js PRE-CREATION 
>   lens-ui/app/components/AboutComponent.js PRE-CREATION 
>   lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION 
>   lens-ui/app/components/AppComponent.js PRE-CREATION 
>   lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION 
>   lens-ui/app/components/CubeTreeComponent.js PRE-CREATION 
>   lens-ui/app/components/DatabaseComponent.js PRE-CREATION 
>   lens-ui/app/components/HeaderComponent.js PRE-CREATION 
>   lens-ui/app/components/LoaderComponent.js PRE-CREATION 
>   lens-ui/app/components/LoginComponent.js PRE-CREATION 
>   lens-ui/app/components/LogoutComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryBoxComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryResultsComponent.js PRE-CREATION 
>   lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION 
>   lens-ui/app/components/SidebarComponent.js PRE-CREATION 
>   lens-ui/app/components/TableSchemaComponent.js PRE-CREATION 
>   lens-ui/app/components/TableTreeComponent.js PRE-CREATION 
>   lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION 
>   lens-ui/app/constants/AppConstants.js PRE-CREATION 
>   lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION

Re: Review Request 37530: LENS-629 - A new improved web client

2015-09-18 Thread Amareshwari Sriramadasu



> On Aug. 19, 2015, 5:38 a.m., Amareshwari Sriramadasu wrote:
> > lens-ui/app/adapters/AdhocQueryAdapter.js, line 9
> > 
> >
> > Not accepting adhoc queries on dimensions?
> > 
> > do we need metastore/dimensions as well ?
> 
> Ankeet Maini wrote:
> When I fetch cubes, its measures and dimensions come as well, and are 
> discoverable and people can query them. Not sure if I understand your 
> question completely!
> 
> Amareshwari Sriramadasu wrote:
> Parallel to Cubes (which have measures and dim-attributes), we have 
> Dimensions which have dimension tables. I'm talking about querying them 
> directly.
> 
> Ankeet Maini wrote:
> As per the current implementation and AFAIK we can query the dimensions 
> via native table, because for every dimension created a native table would've 
> been created.
> 
> Amareshwari Sriramadasu wrote:
> We can query dimensions similar to cubes with cube select. See example 
> queries 
> https://github.com/apache/incubator-lens/blob/master/lens-examples/src/main/resources/dimension-queries.sql.
>  It would good to explore and query dimensions as well through ui.
> 
> Rajat Khandelwal wrote:
> Yes, on the left side you're showing cubes which on click show the 
> queryable fields. Dimensions(not dim tables or native tables) also have 
> queryable fields. 
> 
> Secondly, native tables basically take away the abstractions provided to 
> the user. They are only for debugging purposes, we're not supposed to build 
> any feature depending on the "functionality" of native tables. Native tables 
> are not a "functionality", they are a back-door pass.
> 
> Amareshwari Sriramadasu wrote:
> Native tables are for debugging purpose only if logical tables are 
> created on top them. Without any cubes/dimensions created, users can query 
> native tables and make use of features provided by lens wrt query life cycle. 
> For the same reason, querying native tables should not be discouraged. To 
> distinguish between existing native tables and physical tables of logical 
> abstraction, native tables api can take a flag to specify whether it should 
> include physical tables or not.
> 
> Ankeet Maini wrote:
> I can definitely take this up in the next cut!

Sure. you can park an improvement issue for the same.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review95819
---


On Sept. 18, 2015, 10:28 a.m., Ankeet Maini wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> ---
> 
> (Updated Sept. 18, 2015, 10:28 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat 
> Khandelwal, sharad agarwal, and Yash Sharma.
> 
> 
> Bugs: LENS-629
> https://issues.apache.org/jira/browse/LENS-629
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-629 - A new improved web client
> 
> 
> Diffs
> -
> 
>   .gitignore 5a356e0 
>   lens-ui/LICENSE PRE-CREATION 
>   lens-ui/README.markdown PRE-CREATION 
>   lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION 
>   lens-ui/app/actions/LoginActions.js PRE-CREATION 
>   lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION 
>   lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION 
>   lens-ui/app/adapters/BaseAdapter.js PRE-CREATION 
>   lens-ui/app/app.js PRE-CREATION 
>   lens-ui/app/components/AboutComponent.js PRE-CREATION 
>   lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION 
>   lens-ui/app/components/AppComponent.js PRE-CREATION 
>   lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION 
>   lens-ui/app/components/CubeTreeComponent.js PRE-CREATION 
>   lens-ui/app/components/DatabaseComponent.js PRE-CREATION 
>   lens-ui/app/components/HeaderComponent.js PRE-CREATION 
>   lens-ui/app/components/LoaderComponent.js PRE-CREATION 
>   lens-ui/app/components/LoginComponent.js PRE-CREATION 
>   lens-ui/app/components/LogoutComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryBoxComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryResultsComponent.js PRE-CREATION 
>   lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION 
>   lens-ui/app/components/SidebarComponent.js PRE-CREATION 
>   lens-ui/app/components/TableSchemaComponent.js PRE-CREATION 
>   lens-ui/app/components/TableTreeComponent.js PRE-CREATION 
>   lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION 
>

Re: Review Request 37530: LENS-629 - A new improved web client

2015-09-17 Thread Ankeet Maini


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/
---

(Updated Sept. 17, 2015, 12:19 p.m.)


Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat 
Khandelwal, sharad agarwal, and Yash Sharma.


Changes
---

1. Mavenized the Lens UI package.
2. Customizable port number
3. All dependencies will be downloaded along with NodeJS locally by mvn 
compile/install/package
4. Need only do ```npm run start``` from lens/lens-ui to start the app.


Bugs: LENS-629
https://issues.apache.org/jira/browse/LENS-629


Repository: lens


Description
---

LENS-629 - A new improved web client


Diffs (updated)
-

  .gitignore 5a356e0 
  lens-ui/LICENSE PRE-CREATION 
  lens-ui/README.markdown PRE-CREATION 
  lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION 
  lens-ui/app/actions/LoginActions.js PRE-CREATION 
  lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION 
  lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION 
  lens-ui/app/adapters/BaseAdapter.js PRE-CREATION 
  lens-ui/app/app.js PRE-CREATION 
  lens-ui/app/components/AboutComponent.js PRE-CREATION 
  lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION 
  lens-ui/app/components/AppComponent.js PRE-CREATION 
  lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION 
  lens-ui/app/components/CubeTreeComponent.js PRE-CREATION 
  lens-ui/app/components/DatabaseComponent.js PRE-CREATION 
  lens-ui/app/components/HeaderComponent.js PRE-CREATION 
  lens-ui/app/components/LoaderComponent.js PRE-CREATION 
  lens-ui/app/components/LoginComponent.js PRE-CREATION 
  lens-ui/app/components/LogoutComponent.js PRE-CREATION 
  lens-ui/app/components/QueryBoxComponent.js PRE-CREATION 
  lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION 
  lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION 
  lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION 
  lens-ui/app/components/QueryResultsComponent.js PRE-CREATION 
  lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION 
  lens-ui/app/components/SidebarComponent.js PRE-CREATION 
  lens-ui/app/components/TableSchemaComponent.js PRE-CREATION 
  lens-ui/app/components/TableTreeComponent.js PRE-CREATION 
  lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION 
  lens-ui/app/constants/AppConstants.js PRE-CREATION 
  lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION 
  lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION 
  lens-ui/app/stores/CubeStore.js PRE-CREATION 
  lens-ui/app/stores/DatabaseStore.js PRE-CREATION 
  lens-ui/app/stores/TableStore.js PRE-CREATION 
  lens-ui/app/stores/UserStore.js PRE-CREATION 
  lens-ui/app/styles/css/global.css PRE-CREATION 
  lens-ui/app/styles/css/login.css PRE-CREATION 
  lens-ui/app/styles/css/query-component.css PRE-CREATION 
  lens-ui/app/styles/css/tree.css PRE-CREATION 
  lens-ui/app/styles/less/globals.less PRE-CREATION 
  lens-ui/config.json PRE-CREATION 
  lens-ui/index.html PRE-CREATION 
  lens-ui/package.json PRE-CREATION 
  lens-ui/pom.xml PRE-CREATION 
  lens-ui/server.js PRE-CREATION 
  lens-ui/webpack.config.js PRE-CREATION 
  pom.xml adba544 

Diff: https://reviews.apache.org/r/37530/diff/


Testing
---

No server code added/modified. Just JavaScript!


File Attachments


License details of NPM packages
  
https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt


Thanks,

Ankeet Maini

Re: Review Request 37530: LENS-629 - A new improved web client

2015-09-17 Thread Ankeet Maini



> On Aug. 19, 2015, 7:27 a.m., Amareshwari Sriramadasu wrote:
> > lens-ui/package.json, line 12
> > 
> >
> > How are these dependencies downloaded?
> > 
> > Can you also update license of each of the dependency here for us to 
> > check with apache compatibility.
> 
> Ankeet Maini wrote:
> These dependencies are downloaded by npm (Node Package Manager). These 
> are the licenses which the app uses *(LICENSES: Apache, Apache-2.0, BSD, 
> BSD-3-Clause, BSD-3-Clause AND MIT, CC-BY, GPL, ISC, LGPL, MIT, MIT/X11, MPL, 
> Unknown, WTFPL)*
> 
> Rajat Khandelwal wrote:
> Which one is unknown?
> 
> Also, I think earlier versions of lgpl are not compatible with apache. 
> Can you check wrt the actual version?
> 
> Amareshwari Sriramadasu wrote:
> You can check http://www.apache.org/legal/resolved.html for compatability 
> with apache license. With respect to the same, out of the licenses mentioned 
> above  Apache, Apache-2.0, BSD, BSD-3-Clause, BSD-3-Clause AND MIT, MIT, 
> MIT/X11, ISC (licence is similar to BSD), 
> 
> The following can be included (Category-B), some of these might require a 
> mention in NOTICE (if they are getting bundled) : CC-BY (See 
> http://www.apache.org/legal/resolved.html#cc-sa), MPL, 
> 
> All versions of GPL and LGPL can not be included - see 
> http://www.apache.org/legal/resolved.html#category-x.
> After going through attached licenses.txt, I see that the only dependency 
> with GPL and LGPL license is : tough-cookie@2.0.0 [license(s): BSD-3-Clause, 
> GPL, LGPL, MPL]. The package is with more than one license and BSD-3-Clause 
> and MPL are accepted licenses. Verified the same at 
> https://www.npmjs.com/package/tough-cookie and 
> https://github.com/SalesforceEng/tough-cookie/blob/master/LICENSE. 
> 
> Not seeing any issue with dependency licenses. 
> Ankeet Maini, Can you please attach the licenses.txt at 
> https://cwiki.apache.org/confluence/display/LENS/Licensing+in+Apache+Lens. 
> You can put a new section licensing with UI module and mention the same.
> 
> If we are planning to provide a convienient binary distribution for UI, 
> we need to add appropriate LICENSE and NOTICE files with respect to above 
> licenses listed.

Requested access to edit, or someone with access can upload in the confluence. 
:)


- Ankeet


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review95838
---


On Sept. 17, 2015, 12:19 p.m., Ankeet Maini wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> ---
> 
> (Updated Sept. 17, 2015, 12:19 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat 
> Khandelwal, sharad agarwal, and Yash Sharma.
> 
> 
> Bugs: LENS-629
> https://issues.apache.org/jira/browse/LENS-629
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-629 - A new improved web client
> 
> 
> Diffs
> -
> 
>   .gitignore 5a356e0 
>   lens-ui/LICENSE PRE-CREATION 
>   lens-ui/README.markdown PRE-CREATION 
>   lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION 
>   lens-ui/app/actions/LoginActions.js PRE-CREATION 
>   lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION 
>   lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION 
>   lens-ui/app/adapters/BaseAdapter.js PRE-CREATION 
>   lens-ui/app/app.js PRE-CREATION 
>   lens-ui/app/components/AboutComponent.js PRE-CREATION 
>   lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION 
>   lens-ui/app/components/AppComponent.js PRE-CREATION 
>   lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION 
>   lens-ui/app/components/CubeTreeComponent.js PRE-CREATION 
>   lens-ui/app/components/DatabaseComponent.js PRE-CREATION 
>   lens-ui/app/components/HeaderComponent.js PRE-CREATION 
>   lens-ui/app/components/LoaderComponent.js PRE-CREATION 
>   lens-ui/app/components/LoginComponent.js PRE-CREATION 
>   lens-ui/app/components/LogoutComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryBoxComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryResultsComponent.js PRE-CREATION 
>   lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION 
>   lens-ui/app/components/SidebarComponent.js PRE-CREATION 
>   lens-ui/app/components/TableSchemaComponent.js PRE-CREATION 
>   lens-ui/app/components/TableTreeComponent.js PRE-CREATION 
>   lens-ui/app/constants/AdhocQueryConstants.js

Re: Review Request 37530: LENS-629 - A new improved web client

2015-08-31 Thread Amareshwari Sriramadasu



> On Aug. 19, 2015, 7:27 a.m., Amareshwari Sriramadasu wrote:
> > lens-ui/package.json, line 12
> > 
> >
> > How are these dependencies downloaded?
> > 
> > Can you also update license of each of the dependency here for us to 
> > check with apache compatibility.
> 
> Ankeet Maini wrote:
> These dependencies are downloaded by npm (Node Package Manager). These 
> are the licenses which the app uses *(LICENSES: Apache, Apache-2.0, BSD, 
> BSD-3-Clause, BSD-3-Clause AND MIT, CC-BY, GPL, ISC, LGPL, MIT, MIT/X11, MPL, 
> Unknown, WTFPL)*
> 
> Rajat Khandelwal wrote:
> Which one is unknown?
> 
> Also, I think earlier versions of lgpl are not compatible with apache. 
> Can you check wrt the actual version?

You can check http://www.apache.org/legal/resolved.html for compatability with 
apache license. With respect to the same, out of the licenses mentioned above  
Apache, Apache-2.0, BSD, BSD-3-Clause, BSD-3-Clause AND MIT, MIT, MIT/X11, ISC 
(licence is similar to BSD), 

The following can be included (Category-B), some of these might require a 
mention in NOTICE (if they are getting bundled) : CC-BY (See 
http://www.apache.org/legal/resolved.html#cc-sa), MPL, 

All versions of GPL and LGPL can not be included - see 
http://www.apache.org/legal/resolved.html#category-x.
After going through attached licenses.txt, I see that the only dependency with 
GPL and LGPL license is : tough-cookie@2.0.0 [license(s): BSD-3-Clause, GPL, 
LGPL, MPL]. The package is with more than one license and BSD-3-Clause and MPL 
are accepted licenses. Verified the same at 
https://www.npmjs.com/package/tough-cookie and 
https://github.com/SalesforceEng/tough-cookie/blob/master/LICENSE. 

Not seeing any issue with dependency licenses. 
Ankeet Maini, Can you please attach the licenses.txt at 
https://cwiki.apache.org/confluence/display/LENS/Licensing+in+Apache+Lens. You 
can put a new section licensing with UI module and mention the same.

If we are planning to provide a convienient binary distribution for UI, we need 
to add appropriate LICENSE and NOTICE files with respect to above licenses 
listed.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review95838
---


On Aug. 24, 2015, 6:45 p.m., Ankeet Maini wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> ---
> 
> (Updated Aug. 24, 2015, 6:45 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat 
> Khandelwal, sharad agarwal, and Yash Sharma.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-629 - A new improved web client
> 
> 
> Diffs
> -
> 
>   .gitignore d0fa424 
>   lens-ui/README.markdown PRE-CREATION 
>   lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION 
>   lens-ui/app/actions/LoginActions.js PRE-CREATION 
>   lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION 
>   lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION 
>   lens-ui/app/adapters/BaseAdapter.js PRE-CREATION 
>   lens-ui/app/app.js PRE-CREATION 
>   lens-ui/app/components/AboutComponent.js PRE-CREATION 
>   lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION 
>   lens-ui/app/components/AppComponent.js PRE-CREATION 
>   lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION 
>   lens-ui/app/components/CubeTreeComponent.js PRE-CREATION 
>   lens-ui/app/components/DatabaseComponent.js PRE-CREATION 
>   lens-ui/app/components/HeaderComponent.js PRE-CREATION 
>   lens-ui/app/components/LoaderComponent.js PRE-CREATION 
>   lens-ui/app/components/LoginComponent.js PRE-CREATION 
>   lens-ui/app/components/LogoutComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryBoxComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryResultsComponent.js PRE-CREATION 
>   lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION 
>   lens-ui/app/components/SidebarComponent.js PRE-CREATION 
>   lens-ui/app/components/TableSchemaComponent.js PRE-CREATION 
>   lens-ui/app/components/TableTreeComponent.js PRE-CREATION 
>   lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION 
>   lens-ui/app/constants/AppConstants.js PRE-CREATION 
>   lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION 
>   lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION 
>   lens-ui/app/stores/CubeStore.js PRE-CREATION 
>   lens-ui/app/stores/DatabaseStore.js PRE-CREATION 
>   lens-ui/app/stores/TableStore.js

Re: Review Request 37530: LENS-629 - A new improved web client

2015-08-31 Thread Amareshwari Sriramadasu



> On Aug. 19, 2015, 5:38 a.m., Amareshwari Sriramadasu wrote:
> > lens-ui/app/adapters/AdhocQueryAdapter.js, line 9
> > 
> >
> > Not accepting adhoc queries on dimensions?
> > 
> > do we need metastore/dimensions as well ?
> 
> Ankeet Maini wrote:
> When I fetch cubes, its measures and dimensions come as well, and are 
> discoverable and people can query them. Not sure if I understand your 
> question completely!
> 
> Amareshwari Sriramadasu wrote:
> Parallel to Cubes (which have measures and dim-attributes), we have 
> Dimensions which have dimension tables. I'm talking about querying them 
> directly.
> 
> Ankeet Maini wrote:
> As per the current implementation and AFAIK we can query the dimensions 
> via native table, because for every dimension created a native table would've 
> been created.
> 
> Amareshwari Sriramadasu wrote:
> We can query dimensions similar to cubes with cube select. See example 
> queries 
> https://github.com/apache/incubator-lens/blob/master/lens-examples/src/main/resources/dimension-queries.sql.
>  It would good to explore and query dimensions as well through ui.
> 
> Rajat Khandelwal wrote:
> Yes, on the left side you're showing cubes which on click show the 
> queryable fields. Dimensions(not dim tables or native tables) also have 
> queryable fields. 
> 
> Secondly, native tables basically take away the abstractions provided to 
> the user. They are only for debugging purposes, we're not supposed to build 
> any feature depending on the "functionality" of native tables. Native tables 
> are not a "functionality", they are a back-door pass.

Native tables are for debugging purpose only if logical tables are created on 
top them. Without any cubes/dimensions created, users can query native tables 
and make use of features provided by lens wrt query life cycle. 
For the same reason, querying native tables should not be discouraged. To 
distinguish between existing native tables and physical tables of logical 
abstraction, native tables api can take a flag to specify whether it should 
include physical tables or not.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/#review95819
---


On Aug. 24, 2015, 6:45 p.m., Ankeet Maini wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37530/
> ---
> 
> (Updated Aug. 24, 2015, 6:45 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat 
> Khandelwal, sharad agarwal, and Yash Sharma.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-629 - A new improved web client
> 
> 
> Diffs
> -
> 
>   .gitignore d0fa424 
>   lens-ui/README.markdown PRE-CREATION 
>   lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION 
>   lens-ui/app/actions/LoginActions.js PRE-CREATION 
>   lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION 
>   lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION 
>   lens-ui/app/adapters/BaseAdapter.js PRE-CREATION 
>   lens-ui/app/app.js PRE-CREATION 
>   lens-ui/app/components/AboutComponent.js PRE-CREATION 
>   lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION 
>   lens-ui/app/components/AppComponent.js PRE-CREATION 
>   lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION 
>   lens-ui/app/components/CubeTreeComponent.js PRE-CREATION 
>   lens-ui/app/components/DatabaseComponent.js PRE-CREATION 
>   lens-ui/app/components/HeaderComponent.js PRE-CREATION 
>   lens-ui/app/components/LoaderComponent.js PRE-CREATION 
>   lens-ui/app/components/LoginComponent.js PRE-CREATION 
>   lens-ui/app/components/LogoutComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryBoxComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION 
>   lens-ui/app/components/QueryResultsComponent.js PRE-CREATION 
>   lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION 
>   lens-ui/app/components/SidebarComponent.js PRE-CREATION 
>   lens-ui/app/components/TableSchemaComponent.js PRE-CREATION 
>   lens-ui/app/components/TableTreeComponent.js PRE-CREATION 
>   lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION 
>   lens-ui/app/constants/AppConstants.js PRE-CREATION 
>   lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION 
>   lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION 
>   lens-ui/app/stores/CubeStore.js PRE-CREATION 
>   lens-ui/app/stores/DatabaseStore.js PRE-CREATION 
>   lens-ui/app/stores/TableStore.js PRE-CREATION 
>

Re: Review Request 37530: LENS-629 - A new improved web client

2015-08-31 Thread Ankeet Maini


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37530/
---

(Updated Sept. 1, 2015, 5:30 a.m.)


Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat 
Khandelwal, sharad agarwal, and Yash Sharma.


Bugs: LENS-629
https://issues.apache.org/jira/browse/LENS-629


Repository: lens


Description
---

LENS-629 - A new improved web client


Diffs
-

  .gitignore d0fa424 
  lens-ui/README.markdown PRE-CREATION 
  lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION 
  lens-ui/app/actions/LoginActions.js PRE-CREATION 
  lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION 
  lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION 
  lens-ui/app/adapters/BaseAdapter.js PRE-CREATION 
  lens-ui/app/app.js PRE-CREATION 
  lens-ui/app/components/AboutComponent.js PRE-CREATION 
  lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION 
  lens-ui/app/components/AppComponent.js PRE-CREATION 
  lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION 
  lens-ui/app/components/CubeTreeComponent.js PRE-CREATION 
  lens-ui/app/components/DatabaseComponent.js PRE-CREATION 
  lens-ui/app/components/HeaderComponent.js PRE-CREATION 
  lens-ui/app/components/LoaderComponent.js PRE-CREATION 
  lens-ui/app/components/LoginComponent.js PRE-CREATION 
  lens-ui/app/components/LogoutComponent.js PRE-CREATION 
  lens-ui/app/components/QueryBoxComponent.js PRE-CREATION 
  lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION 
  lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION 
  lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION 
  lens-ui/app/components/QueryResultsComponent.js PRE-CREATION 
  lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION 
  lens-ui/app/components/SidebarComponent.js PRE-CREATION 
  lens-ui/app/components/TableSchemaComponent.js PRE-CREATION 
  lens-ui/app/components/TableTreeComponent.js PRE-CREATION 
  lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION 
  lens-ui/app/constants/AppConstants.js PRE-CREATION 
  lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION 
  lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION 
  lens-ui/app/stores/CubeStore.js PRE-CREATION 
  lens-ui/app/stores/DatabaseStore.js PRE-CREATION 
  lens-ui/app/stores/TableStore.js PRE-CREATION 
  lens-ui/app/stores/UserStore.js PRE-CREATION 
  lens-ui/app/styles/css/global.css PRE-CREATION 
  lens-ui/app/styles/css/login.css PRE-CREATION 
  lens-ui/app/styles/css/query-component.css PRE-CREATION 
  lens-ui/app/styles/css/tree.css PRE-CREATION 
  lens-ui/app/styles/less/globals.less PRE-CREATION 
  lens-ui/config.json PRE-CREATION 
  lens-ui/index.html PRE-CREATION 
  lens-ui/package.json PRE-CREATION 
  lens-ui/server.js PRE-CREATION 
  lens-ui/webpack.config.js PRE-CREATION 

Diff: https://reviews.apache.org/r/37530/diff/


Testing
---

No server code added/modified. Just JavaScript!


File Attachments


License details of NPM packages
  
https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt


Thanks,

Ankeet Maini

Re: Review Request 37530: LENS-629 - A new improved web client

Re: Review Request 37530: LENS-629 - A new improved web client

Re: Review Request 37530: LENS-629 - A new improved web client

Re: Review Request 37530: LENS-629 - A new improved web client

Re: Review Request 37530: LENS-629 - A new improved web client

Re: Review Request 37530: LENS-629 - A new improved web client

Re: Review Request 37530: LENS-629 - A new improved web client

Re: Review Request 37530: LENS-629 - A new improved web client

Re: Review Request 37530: LENS-629 - A new improved web client

Re: Review Request 37530: LENS-629 - A new improved web client

Re: Review Request 37530: LENS-629 - A new improved web client

Re: Review Request 37530: LENS-629 - A new improved web client

Re: Review Request 37530: LENS-629 - A new improved web client

Re: Review Request 37530: LENS-629 - A new improved web client

14 matches

Site Navigation

Mail list logo

Footer information