[GitHub] incubator-livy issue #114: [LIVY-495] Add thriftserver UI

2018-09-27 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/incubator-livy/pull/114 cc @vanzin ---

[GitHub] incubator-livy issue #112: [LIVY-511][LIVY-512] Remove support for old Spark...

2018-09-27 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/incubator-livy/pull/112 @vanzin thanks, I have no more comments apart from https://github.com/apache/incubator-livy/pull/112#discussion_r220647323. I have not reviewed it carefully, but I am still quite new

[GitHub] incubator-livy pull request #112: [LIVY-511][LIVY-512] Remove support for ol...

2018-09-27 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/incubator-livy/pull/112#discussion_r220122923 --- Diff: README.md --- @@ -57,12 +57,8 @@ Required python packages for building Livy: To run Livy, you will also need a Spark installation

[GitHub] incubator-livy issue #113: [LIVY-500] Add beeline client for dev

2018-09-27 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/incubator-livy/pull/113 cc @vanzin ---

[GitHub] incubator-livy pull request #107: [LIVY-494] Add thriftserver to Livy server

2018-09-27 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/incubator-livy/pull/107#discussion_r219769059 --- Diff: server/src/main/scala/org/apache/livy/server/LivyServer.scala --- @@ -115,6 +117,16 @@ class LivyServer extends Logging

[GitHub] incubator-livy issue #107: [LIVY-494] Add thriftserver to Livy server

2018-09-27 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/incubator-livy/pull/107 Travis failure is intermittent, the branch build passed: https://travis-ci.org/mgaido91/incubator-livy/builds/432380763 ---

[GitHub] incubator-livy issue #120: Upgrade jetty version

2018-10-09 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/incubator-livy/pull/120 @arunmahadevan there is a consistent UT failure. We need to address it. I think we should also have a JIRA (to be referenced here) proposing the Jetty version upgrade. Thanks. ---

[GitHub] incubator-livy pull request #113: [LIVY-500] Add beeline client for dev

2018-10-02 Thread mgaido91
Github user mgaido91 closed the pull request at: https://github.com/apache/incubator-livy/pull/113 ---

[GitHub] incubator-livy issue #117: [WIP][LIVY-502] Remove dependency on hive-exec

2018-10-02 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/incubator-livy/pull/117 thanks for the review @vanzin. I have updated the PR description. Let me know if it still needs to be improved. > I think as a first step getting the Hive code in, with the mini

[GitHub] incubator-livy pull request #116: [LIVY-520] Add log when session is GC-ed

2018-10-01 Thread mgaido91
Github user mgaido91 closed the pull request at: https://github.com/apache/incubator-livy/pull/116 ---

[GitHub] incubator-livy issue #120: [LIVY-526] Upgrade jetty version

2018-10-10 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/incubator-livy/pull/120 thanks. LGTM ---

[GitHub] incubator-livy pull request #113: [LIVY-500] Add beeline client for dev

2018-10-01 Thread mgaido91
Github user mgaido91 closed the pull request at: https://github.com/apache/incubator-livy/pull/113 ---

[GitHub] incubator-livy pull request #114: [LIVY-495] Add thriftserver UI

2018-10-01 Thread mgaido91
GitHub user mgaido91 reopened a pull request: https://github.com/apache/incubator-livy/pull/114 [LIVY-495] Add thriftserver UI ## What changes were proposed in this pull request? The PR adds a new UI tab dedicated to thrift-server sessions. The UI shows the active sessions

[GitHub] incubator-livy pull request #113: [LIVY-500] Add beeline client for dev

2018-10-01 Thread mgaido91
GitHub user mgaido91 reopened a pull request: https://github.com/apache/incubator-livy/pull/113 [LIVY-500] Add beeline client for dev ## What changes were proposed in this pull request? The PR adds a new `thriftserver/client` module and a `beeline` script which are useful

[GitHub] incubator-livy pull request #114: [LIVY-495] Add thriftserver UI

2018-10-01 Thread mgaido91
Github user mgaido91 closed the pull request at: https://github.com/apache/incubator-livy/pull/114 ---

[GitHub] incubator-livy pull request #117: [WIP][LIVY-502] Remove dependency on hive-...

2018-10-02 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/incubator-livy/pull/117#discussion_r221881729 --- Diff: thriftserver/server/src/main/scala/org/apache/livy/thriftserver/auth/AuthenticationProvider.scala --- @@ -0,0 +1,74

[GitHub] incubator-livy pull request #117: [WIP][LIVY-502] Remove dependency on hive-...

2018-10-02 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/incubator-livy/pull/117#discussion_r221883081 --- Diff: thriftserver/server/src/main/scala/org/apache/livy/thriftserver/auth/LivyDelegationTokenSecretManager.scala --- @@ -0,0 +1,81

[GitHub] incubator-livy pull request #117: [WIP][LIVY-502] Remove dependency on hive-...

2018-10-02 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/incubator-livy/pull/117#discussion_r221885113 --- Diff: thriftserver/server/src/main/scala/org/apache/livy/thriftserver/cli/ThriftHttpCLIService.scala --- @@ -0,0 +1,210

[GitHub] incubator-livy pull request #117: [WIP][LIVY-502] Remove dependency on hive-...

2018-10-02 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/incubator-livy/pull/117#discussion_r221887180 --- Diff: thriftserver/server/src/main/scala/org/apache/livy/thriftserver/operation/GetTypeInfoOperation.scala --- @@ -0,0 +1,130

[GitHub] incubator-livy pull request #117: [WIP][LIVY-502] Remove dependency on hive-...

2018-10-02 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/incubator-livy/pull/117#discussion_r221883802 --- Diff: thriftserver/server/src/main/scala/org/apache/livy/thriftserver/cli/ThriftCLIService.scala --- @@ -0,0 +1,745

[GitHub] incubator-livy pull request #117: [WIP][LIVY-502] Remove dependency on hive-...

2018-10-02 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/incubator-livy/pull/117#discussion_r221886399 --- Diff: thriftserver/server/src/main/scala/org/apache/livy/thriftserver/cli/ThriftHttpServlet.scala --- @@ -0,0 +1,500

[GitHub] incubator-livy pull request #117: [WIP][LIVY-502] Remove dependency on hive-...

2018-10-02 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/incubator-livy/pull/117#discussion_r221890669 --- Diff: thriftserver/server/src/main/scala/org/apache/livy/thriftserver/auth/AuthBridgeServer.scala --- @@ -0,0 +1,296

[GitHub] incubator-livy pull request #116: [LIVY-520] Add log when session is GC-ed

2018-09-30 Thread mgaido91
GitHub user mgaido91 reopened a pull request: https://github.com/apache/incubator-livy/pull/116 [LIVY-520] Add log when session is GC-ed ## What changes were proposed in this pull request? When a session is inactive for a long time, it is GC-ed, ie. it is closed. Currently

[GitHub] incubator-livy issue #116: [LIVY-520] Add log when session is GC-ed

2018-09-27 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/incubator-livy/pull/116 cc @alex-the-man @jerryshao @vanzin ---

[GitHub] incubator-livy issue #117: [WIP][LIVY-502] Remove dependency on hive-exec

2018-09-28 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/incubator-livy/pull/117 cc @jerryshao @vanzin ---

[GitHub] incubator-livy pull request #117: [WIP][LIVY-502] Remove dependency on hive-...

2018-09-28 Thread mgaido91
GitHub user mgaido91 opened a pull request: https://github.com/apache/incubator-livy/pull/117 [WIP][LIVY-502] Remove dependency on hive-exec ## What changes were proposed in this pull request? This PR removes the dependency on `hive-exec`. Only modules of Hive which