[GitHub] lucene-solr pull request:

2016-05-31 Thread alessandrobenedetti
Github user alessandrobenedetti commented on the pull request: https://github.com/apache/lucene-solr/commit/1489085807cb10981a7ea5b5663ada4e3f85953e#commitcomment-17682489 In solr/core/src/java/org/apache/solr/request/SimpleFacets.java: In solr/core/src/java/org/apache/solr

[GitHub] lucene-solr pull request: SOLR-8542: Integrate Learning to Rank in...

2016-03-09 Thread alessandrobenedetti
Github user alessandrobenedetti commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/4#discussion_r7481 --- Diff: solr/contrib/ltr/src/java/org/apache/solr/ltr/ranking/ModelQuery.java --- @@ -0,0 +1,540 @@ +package org.apache.solr.ltr.ranking

[GitHub] lucene-solr pull request: SOLR-8542: Integrate Learning to Rank in...

2016-03-09 Thread alessandrobenedetti
Github user alessandrobenedetti commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/4#discussion_r55499494 --- Diff: solr/contrib/ltr/README.txt --- @@ -0,0 +1,330 @@ +Apache Solr Learning to Rank + + +This is the main

[GitHub] lucene-solr pull request #191: Lucene-7498

2017-04-18 Thread alessandrobenedetti
GitHub user alessandrobenedetti opened a pull request: https://github.com/apache/lucene-solr/pull/191 Lucene-7498 This Pull Request related to the JIRA issue : LUCENE-7498 It involves the introduction of a big refactor of the More Like This module and the introduction

[GitHub] lucene-solr pull request #365: [SOLR-12243] span query generalization + quer...

2018-04-27 Thread alessandrobenedetti
GitHub user alessandrobenedetti opened a pull request: https://github.com/apache/lucene-solr/pull/365 [SOLR-12243] span query generalization + query parser tests This is an extension of @Elizabeth Haubert patch, the addition is : - spanNearQuery generalized to SpanQuery

[GitHub] lucene-solr pull request #380: Lucene 8326

2018-05-22 Thread alessandrobenedetti
GitHub user alessandrobenedetti opened a pull request: https://github.com/apache/lucene-solr/pull/380 Lucene 8326 More Like This can be refactored to improve the code readability, test coverage and maintenance. Scope of this Jira issue is to start the More Like This refactor

[GitHub] lucene-solr pull request #381: [LUCENE-8329] disk size estimator MB bug fixe...

2018-05-23 Thread alessandrobenedetti
GitHub user alessandrobenedetti opened a pull request: https://github.com/apache/lucene-solr/pull/381 [LUCENE-8329] disk size estimator MB bug fixes The size estimator dev tool ( dev-tools/size-estimator-lucene-solr.xls )currently : Wrongly calculates disk size in MB ( showing

[GitHub] lucene-solr pull request #398: Lucene 8343 data type migration

2018-06-10 Thread alessandrobenedetti
Github user alessandrobenedetti commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/398#discussion_r194254789 --- Diff: lucene/suggest/src/java/org/apache/lucene/search/suggest/analyzing/BlendedInfixSuggester.java --- @@ -200,7 +201,13 @@ protected

[GitHub] lucene-solr pull request #398: Lucene 8343 data type migration

2018-06-08 Thread alessandrobenedetti
GitHub user alessandrobenedetti opened a pull request: https://github.com/apache/lucene-solr/pull/398 Lucene 8343 data type migration Different approach, data type migration to fix the bugs : 1) Weight for the Document dictionary moved to Long from long 2

[GitHub] lucene-solr pull request #398: Lucene 8343 data type migration

2018-06-15 Thread alessandrobenedetti
Github user alessandrobenedetti commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/398#discussion_r195689810 --- Diff: lucene/suggest/src/java/org/apache/lucene/search/suggest/InputIterator.java --- @@ -34,7 +34,7 @@ public interface

[GitHub] lucene-solr pull request #398: Lucene 8343 data type migration

2018-06-15 Thread alessandrobenedetti
Github user alessandrobenedetti commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/398#discussion_r195698769 --- Diff: lucene/suggest/src/java/org/apache/lucene/search/suggest/Lookup.java --- @@ -53,7 +53,7 @@ public final Object

[GitHub] lucene-solr pull request #391: [LUCENE-8343] introduced weight 0 check and p...

2018-06-01 Thread alessandrobenedetti
GitHub user alessandrobenedetti opened a pull request: https://github.com/apache/lucene-solr/pull/391 [LUCENE-8343] introduced weight 0 check and positional coefficient scaling Currently the BlendedInfixSuggester return a (long) score to rank the suggestions. This score

[GitHub] lucene-solr pull request #389: [LUCENE-6687] not necessary nested for loop r...

2018-05-31 Thread alessandrobenedetti
GitHub user alessandrobenedetti opened a pull request: https://github.com/apache/lucene-solr/pull/389 [LUCENE-6687] not necessary nested for loop removed for terms retriev… Bug in term frequencies calculation for the MLT You can merge this pull request into a Git repository

[GitHub] lucene-solr pull request #393: Lucene 8347

2018-06-04 Thread alessandrobenedetti
GitHub user alessandrobenedetti opened a pull request: https://github.com/apache/lucene-solr/pull/393 Lucene 8347 Introduced multi term management for the BlendedInfix suggester. The score of each suggestion will be calculated based on : - the positional coefficient

[GitHub] lucene-solr pull request #368: [SOLR-12304] More Like This component interes...

2018-05-02 Thread alessandrobenedetti
GitHub user alessandrobenedetti opened a pull request: https://github.com/apache/lucene-solr/pull/368 [SOLR-12304] More Like This component interesting term fix +tests This Pull Request cover the bug fix and tests for the Interesting Term parameter of the More Like This component

[GitHub] lucene-solr pull request #369: SOLR-12299

2018-05-03 Thread alessandrobenedetti
GitHub user alessandrobenedetti opened a pull request: https://github.com/apache/lucene-solr/pull/369 SOLR-12299 This Pull Request is about the first step in the More Like This refactor. The overall scope of the refactor is to improve the test coverage, readability

[GitHub] lucene-solr pull request #357: [SOLR-12238] Synonym Queries boost by payload...

2018-04-18 Thread alessandrobenedetti
GitHub user alessandrobenedetti opened a pull request: https://github.com/apache/lucene-solr/pull/357 [SOLR-12238] Synonym Queries boost by payload This patch involves the synonym management in the query building/parser phase. It adds the possibility of getting the payloads

[GitHub] lucene-solr pull request #482: LUCENE-8539: fix some typos and improve style...

2018-10-23 Thread alessandrobenedetti
Github user alessandrobenedetti commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/482#discussion_r227469439 --- Diff: lucene/core/src/test/org/apache/lucene/analysis/TestStopFilter.java --- @@ -47,58 +48,65 @@ public void testStopFilt() throws

[GitHub] lucene-solr pull request #482: LUCENE-8539: fix some typos and improve style...

2018-10-23 Thread alessandrobenedetti
Github user alessandrobenedetti commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/482#discussion_r227461971 --- Diff: lucene/core/src/test/org/apache/lucene/analysis/TestStopFilter.java --- @@ -47,58 +48,65 @@ public void testStopFilt() throws

[GitHub] lucene-solr pull request #482: LUCENE-8539: fix some typos and improve style...

2018-10-23 Thread alessandrobenedetti
Github user alessandrobenedetti commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/482#discussion_r227471350 --- Diff: lucene/core/src/test/org/apache/lucene/analysis/TestStopFilter.java --- @@ -47,58 +48,65 @@ public void testStopFilt() throws

[GitHub] lucene-solr pull request #482: LUCENE-8539: fix some typos and improve style...

2018-10-23 Thread alessandrobenedetti
Github user alessandrobenedetti commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/482#discussion_r227464824 --- Diff: lucene/core/src/test/org/apache/lucene/analysis/TestStopFilter.java --- @@ -111,20 +119,24 @@ public void testEndStopword

[GitHub] lucene-solr pull request #482: LUCENE-8539: fix some typos and improve style...

2018-10-23 Thread alessandrobenedetti
Github user alessandrobenedetti commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/482#discussion_r227462125 --- Diff: lucene/core/src/test/org/apache/lucene/analysis/TestStopFilter.java --- @@ -47,58 +48,65 @@ public void testStopFilt() throws

[GitHub] lucene-solr pull request #389: [LUCENE-6687] not necessary nested for loop r...

2018-10-09 Thread alessandrobenedetti
Github user alessandrobenedetti commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/389#discussion_r223775673 --- Diff: lucene/queries/src/test/org/apache/lucene/queries/mlt/TestMoreLikeThis.java --- @@ -186,6 +200,117 @@ public void testMultiValues

[GitHub] lucene-solr pull request #389: [LUCENE-6687] not necessary nested for loop r...

2018-10-09 Thread alessandrobenedetti
Github user alessandrobenedetti commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/389#discussion_r223774170 --- Diff: lucene/queries/src/test/org/apache/lucene/queries/mlt/TestMoreLikeThis.java --- @@ -186,6 +200,117 @@ public void testMultiValues

[GitHub] lucene-solr pull request #389: [LUCENE-6687] not necessary nested for loop r...

2018-10-09 Thread alessandrobenedetti
Github user alessandrobenedetti commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/389#discussion_r223764522 --- Diff: lucene/queries/src/test/org/apache/lucene/queries/mlt/TestMoreLikeThis.java --- @@ -186,6 +200,117 @@ public void testMultiValues

[GitHub] lucene-solr pull request #389: [LUCENE-6687] not necessary nested for loop r...

2018-10-09 Thread alessandrobenedetti
Github user alessandrobenedetti commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/389#discussion_r223770725 --- Diff: lucene/queries/src/test/org/apache/lucene/queries/mlt/TestMoreLikeThis.java --- @@ -186,6 +200,117 @@ public void testMultiValues

[GitHub] lucene-solr pull request #389: [LUCENE-6687] not necessary nested for loop r...

2018-10-09 Thread alessandrobenedetti
Github user alessandrobenedetti commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/389#discussion_r223769747 --- Diff: lucene/queries/src/test/org/apache/lucene/queries/mlt/TestMoreLikeThis.java --- @@ -186,6 +200,117 @@ public void testMultiValues

[GitHub] lucene-solr pull request #389: [LUCENE-6687] not necessary nested for loop r...

2018-10-09 Thread alessandrobenedetti
Github user alessandrobenedetti commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/389#discussion_r223773915 --- Diff: lucene/queries/src/test/org/apache/lucene/queries/mlt/TestMoreLikeThis.java --- @@ -186,6 +200,117 @@ public void testMultiValues