[jira] [Commented] (LUCENE-4167) Remove the use of SpatialOperation

2012-07-26 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13423072#comment-13423072 ] David Smiley commented on LUCENE-4167: -- I spent some time working on

[jira] [Commented] (LUCENE-4167) Remove the use of SpatialOperation

2012-07-26 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13423636#comment-13423636 ] David Smiley commented on LUCENE-4167: -- We concluded in private chat that the status

[jira] [Commented] (LUCENE-4167) Remove the use of SpatialOperation

2012-07-24 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13421987#comment-13421987 ] Chris Male commented on LUCENE-4167: I think somewhere along the lines we lost track

[jira] [Commented] (LUCENE-4167) Remove the use of SpatialOperation

2012-07-16 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13415154#comment-13415154 ] David Smiley commented on LUCENE-4167: -- bq. We can maybe move the makeQuery as you

[jira] [Commented] (LUCENE-4167) Remove the use of SpatialOperation

2012-07-16 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13415180#comment-13415180 ] Chris Male commented on LUCENE-4167: bq. Why not just a static method on Strategy?

[jira] [Commented] (LUCENE-4167) Remove the use of SpatialOperation

2012-07-16 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13415199#comment-13415199 ] David Smiley commented on LUCENE-4167: -- Keeping score... we're +1 for makeQuery()

[jira] [Commented] (LUCENE-4167) Remove the use of SpatialOperation

2012-07-16 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13415206#comment-13415206 ] Chris Male commented on LUCENE-4167: bq. Okay then. So a SpatialUtil class with a

[jira] [Commented] (LUCENE-4167) Remove the use of SpatialOperation

2012-07-15 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13414857#comment-13414857 ] Chris Male commented on LUCENE-4167: Okay I'm going to try to find some middle ground

[jira] [Commented] (LUCENE-4167) Remove the use of SpatialOperation

2012-06-28 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402883#comment-13402883 ] Ryan McKinley commented on LUCENE-4167: --- This is essentially a java API vs 'query

[jira] [Commented] (LUCENE-4167) Remove the use of SpatialOperation

2012-06-28 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402888#comment-13402888 ] David Smiley commented on LUCENE-4167: -- Thanks for your input Ryan. bq. Chris

[jira] [Commented] (LUCENE-4167) Remove the use of SpatialOperation

2012-06-28 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13403055#comment-13403055 ] Chris Male commented on LUCENE-4167: {quote} makeFilter makeQuery receives a

[jira] [Commented] (LUCENE-4167) Remove the use of SpatialOperation

2012-06-28 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13403056#comment-13403056 ] Chris Male commented on LUCENE-4167: {quote} This is essentially a java API vs 'query

[jira] [Commented] (LUCENE-4167) Remove the use of SpatialOperation

2012-06-28 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13403059#comment-13403059 ] Chris Male commented on LUCENE-4167: {quote} Somewhat related to this is the

[jira] [Commented] (LUCENE-4167) Remove the use of SpatialOperation

2012-06-28 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13403181#comment-13403181 ] David Smiley commented on LUCENE-4167: -- bq. We don't need SpatialArgs at the moment.

[jira] [Commented] (LUCENE-4167) Remove the use of SpatialOperation

2012-06-28 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13403444#comment-13403444 ] David Smiley commented on LUCENE-4167: -- Shall I move com.spatial4j.core.query.* into

[jira] [Commented] (LUCENE-4167) Remove the use of SpatialOperation

2012-06-28 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13403642#comment-13403642 ] Chris Male commented on LUCENE-4167: I don't see consensus being reached on how the

[jira] [Commented] (LUCENE-4167) Remove the use of SpatialOperation

2012-06-27 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402274#comment-13402274 ] David Smiley commented on LUCENE-4167: -- I agree with your complaint. The only two

[jira] [Commented] (LUCENE-4167) Remove the use of SpatialOperation

2012-06-27 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402286#comment-13402286 ] Chris Male commented on LUCENE-4167: {quote} Intersects – equivalent to IsWithin when

[jira] [Commented] (LUCENE-4167) Remove the use of SpatialOperation

2012-06-27 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402531#comment-13402531 ] David Smiley commented on LUCENE-4167: -- bq. I don't see the need to differentiate

[jira] [Commented] (LUCENE-4167) Remove the use of SpatialOperation

2012-06-27 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402591#comment-13402591 ] David Smiley commented on LUCENE-4167: -- bq. I can see the need for different

[jira] [Commented] (LUCENE-4167) Remove the use of SpatialOperation

2012-06-27 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402783#comment-13402783 ] Chris Male commented on LUCENE-4167: {quote} The stategy shouldn't care about the

[jira] [Commented] (LUCENE-4167) Remove the use of SpatialOperation

2012-06-27 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402827#comment-13402827 ] David Smiley commented on LUCENE-4167: -- I agree that something could/should be done

[jira] [Commented] (LUCENE-4167) Remove the use of SpatialOperation

2012-06-27 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402830#comment-13402830 ] Chris Male commented on LUCENE-4167: {quote} This is of course just one aspect of a

[jira] [Commented] (LUCENE-4167) Remove the use of SpatialOperation

2012-06-27 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402865#comment-13402865 ] Chris Male commented on LUCENE-4167: A follow up to this patch is to break out the

[jira] [Commented] (LUCENE-4167) Remove the use of SpatialOperation

2012-06-27 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402867#comment-13402867 ] David Smiley commented on LUCENE-4167: -- I looked at the patch. {{shrug}} Some

[jira] [Commented] (LUCENE-4167) Remove the use of SpatialOperation

2012-06-27 Thread Chris Male (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402870#comment-13402870 ] Chris Male commented on LUCENE-4167: I don't see how it makes it harder to support