[jira] [Commented] (LUCENE-7128) Fix spatial and sandbox geo APIs to consistently take lat before lon
[ https://issues.apache.org/jira/browse/LUCENE-7128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207469#comment-15207469 ] ASF subversion and git services commented on LUCENE-7128: - Commit 137dd158fa5d4a1b1d6ad7cb369c69738f02401d in lucene-solr's branch refs/heads/branch_6_0 from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=137dd15 ] LUCENE-7128: fix a few more lon/lat places; remove more dead code > Fix spatial and sandbox geo APIs to consistently take lat before lon > > > Key: LUCENE-7128 > URL: https://issues.apache.org/jira/browse/LUCENE-7128 > Project: Lucene - Core > Issue Type: Bug >Reporter: Michael McCandless >Assignee: Michael McCandless > Fix For: master, 6.0 > > Attachments: LUCENE-7128.patch > > > Right now sometimes it's lat, lon and other times it's lon, lat which > is just asking for horrors of biblical proportions. > I went through and carefully fixed them to take lat, lon in all places > I could find, and renamed y -> lat and x -> lon. I also removed > unused code, or code only called from tests: I think Lucene shouldn't > just export spatial APIs unless we also ourselves need them for > indexing and searching. Finally, I tried to shrink wrap the APIs, > making previously public apis private if nobody external invoked them. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7128) Fix spatial and sandbox geo APIs to consistently take lat before lon
[ https://issues.apache.org/jira/browse/LUCENE-7128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207424#comment-15207424 ] ASF subversion and git services commented on LUCENE-7128: - Commit f2234dccb35ac11e1028890b20b61cdd2c9b9bf7 in lucene-solr's branch refs/heads/branch_6x from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f2234dc ] LUCENE-7128: fix a few more lon/lat places; remove more dead code > Fix spatial and sandbox geo APIs to consistently take lat before lon > > > Key: LUCENE-7128 > URL: https://issues.apache.org/jira/browse/LUCENE-7128 > Project: Lucene - Core > Issue Type: Bug >Reporter: Michael McCandless >Assignee: Michael McCandless > Fix For: master, 6.0 > > Attachments: LUCENE-7128.patch > > > Right now sometimes it's lat, lon and other times it's lon, lat which > is just asking for horrors of biblical proportions. > I went through and carefully fixed them to take lat, lon in all places > I could find, and renamed y -> lat and x -> lon. I also removed > unused code, or code only called from tests: I think Lucene shouldn't > just export spatial APIs unless we also ourselves need them for > indexing and searching. Finally, I tried to shrink wrap the APIs, > making previously public apis private if nobody external invoked them. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7128) Fix spatial and sandbox geo APIs to consistently take lat before lon
[ https://issues.apache.org/jira/browse/LUCENE-7128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207422#comment-15207422 ] ASF subversion and git services commented on LUCENE-7128: - Commit 99c3bb23710b22bdfb6908ea587b24308bf50ba9 in lucene-solr's branch refs/heads/master from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=99c3bb2 ] LUCENE-7128: fix a few more lon/lat places; remove more dead code > Fix spatial and sandbox geo APIs to consistently take lat before lon > > > Key: LUCENE-7128 > URL: https://issues.apache.org/jira/browse/LUCENE-7128 > Project: Lucene - Core > Issue Type: Bug >Reporter: Michael McCandless >Assignee: Michael McCandless > Fix For: master, 6.0 > > Attachments: LUCENE-7128.patch > > > Right now sometimes it's lat, lon and other times it's lon, lat which > is just asking for horrors of biblical proportions. > I went through and carefully fixed them to take lat, lon in all places > I could find, and renamed y -> lat and x -> lon. I also removed > unused code, or code only called from tests: I think Lucene shouldn't > just export spatial APIs unless we also ourselves need them for > indexing and searching. Finally, I tried to shrink wrap the APIs, > making previously public apis private if nobody external invoked them. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7128) Fix spatial and sandbox geo APIs to consistently take lat before lon
[ https://issues.apache.org/jira/browse/LUCENE-7128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15206672#comment-15206672 ] ASF subversion and git services commented on LUCENE-7128: - Commit 09013e09761c1493342826088bef0c62c9233810 in lucene-solr's branch refs/heads/branch_6_0 from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=09013e0 ] LUCENE-7128: clean up new geo APIs to consistently take lat before lon, make methods private when possible, use lat/lon instead of y/x naming, remove unused code > Fix spatial and sandbox geo APIs to consistently take lat before lon > > > Key: LUCENE-7128 > URL: https://issues.apache.org/jira/browse/LUCENE-7128 > Project: Lucene - Core > Issue Type: Bug >Reporter: Michael McCandless >Assignee: Michael McCandless > Fix For: master, 6.0 > > Attachments: LUCENE-7128.patch > > > Right now sometimes it's lat, lon and other times it's lon, lat which > is just asking for horrors of biblical proportions. > I went through and carefully fixed them to take lat, lon in all places > I could find, and renamed y -> lat and x -> lon. I also removed > unused code, or code only called from tests: I think Lucene shouldn't > just export spatial APIs unless we also ourselves need them for > indexing and searching. Finally, I tried to shrink wrap the APIs, > making previously public apis private if nobody external invoked them. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7128) Fix spatial and sandbox geo APIs to consistently take lat before lon
[ https://issues.apache.org/jira/browse/LUCENE-7128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15206627#comment-15206627 ] ASF subversion and git services commented on LUCENE-7128: - Commit c5da271b9d9b05e31a592b8bbdb416529a2c1770 in lucene-solr's branch refs/heads/branch_6x from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c5da271 ] LUCENE-7128: clean up new geo APIs to consistently take lat before lon, make methods private when possible, use lat/lon instead of y/x naming, remove unused code > Fix spatial and sandbox geo APIs to consistently take lat before lon > > > Key: LUCENE-7128 > URL: https://issues.apache.org/jira/browse/LUCENE-7128 > Project: Lucene - Core > Issue Type: Bug >Reporter: Michael McCandless >Assignee: Michael McCandless > Fix For: master, 6.0 > > Attachments: LUCENE-7128.patch > > > Right now sometimes it's lat, lon and other times it's lon, lat which > is just asking for horrors of biblical proportions. > I went through and carefully fixed them to take lat, lon in all places > I could find, and renamed y -> lat and x -> lon. I also removed > unused code, or code only called from tests: I think Lucene shouldn't > just export spatial APIs unless we also ourselves need them for > indexing and searching. Finally, I tried to shrink wrap the APIs, > making previously public apis private if nobody external invoked them. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7128) Fix spatial and sandbox geo APIs to consistently take lat before lon
[ https://issues.apache.org/jira/browse/LUCENE-7128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15206617#comment-15206617 ] ASF subversion and git services commented on LUCENE-7128: - Commit 275a259b1fa0d94aec95f554c2c7451b8678bd8e in lucene-solr's branch refs/heads/master from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=275a259 ] LUCENE-7128: clean up new geo APIs to consistently take lat before lon, make methods private when possible, use lat/lon instead of y/x naming, remove unused code > Fix spatial and sandbox geo APIs to consistently take lat before lon > > > Key: LUCENE-7128 > URL: https://issues.apache.org/jira/browse/LUCENE-7128 > Project: Lucene - Core > Issue Type: Bug >Reporter: Michael McCandless >Assignee: Michael McCandless > Fix For: master, 6.0 > > Attachments: LUCENE-7128.patch > > > Right now sometimes it's lat, lon and other times it's lon, lat which > is just asking for horrors of biblical proportions. > I went through and carefully fixed them to take lat, lon in all places > I could find, and renamed y -> lat and x -> lon. I also removed > unused code, or code only called from tests: I think Lucene shouldn't > just export spatial APIs unless we also ourselves need them for > indexing and searching. Finally, I tried to shrink wrap the APIs, > making previously public apis private if nobody external invoked them. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7128) Fix spatial and sandbox geo APIs to consistently take lat before lon
[ https://issues.apache.org/jira/browse/LUCENE-7128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15206340#comment-15206340 ] Michael McCandless commented on LUCENE-7128: Thanks [~rcmuir] ... I'll rename the X's off and push. > Fix spatial and sandbox geo APIs to consistently take lat before lon > > > Key: LUCENE-7128 > URL: https://issues.apache.org/jira/browse/LUCENE-7128 > Project: Lucene - Core > Issue Type: Bug >Reporter: Michael McCandless >Assignee: Michael McCandless > Fix For: master, 6.0 > > Attachments: LUCENE-7128.patch > > > Right now sometimes it's lat, lon and other times it's lon, lat which > is just asking for horrors of biblical proportions. > I went through and carefully fixed them to take lat, lon in all places > I could find, and renamed y -> lat and x -> lon. I also removed > unused code, or code only called from tests: I think Lucene shouldn't > just export spatial APIs unless we also ourselves need them for > indexing and searching. Finally, I tried to shrink wrap the APIs, > making previously public apis private if nobody external invoked them. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7128) Fix spatial and sandbox geo APIs to consistently take lat before lon
[ https://issues.apache.org/jira/browse/LUCENE-7128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15206243#comment-15206243 ] Robert Muir commented on LUCENE-7128: - I tripped up on this very issue (lon/lat vs lat/lon) several times yesterday just working on tests. big +1 for fixing this issue! its a real one. We just gotta bite the bullet and fix it now. > Fix spatial and sandbox geo APIs to consistently take lat before lon > > > Key: LUCENE-7128 > URL: https://issues.apache.org/jira/browse/LUCENE-7128 > Project: Lucene - Core > Issue Type: Bug >Reporter: Michael McCandless >Assignee: Michael McCandless > Fix For: master, 6.0 > > Attachments: LUCENE-7128.patch > > > Right now sometimes it's lat, lon and other times it's lon, lat which > is just asking for horrors of biblical proportions. > I went through and carefully fixed them to take lat, lon in all places > I could find, and renamed y -> lat and x -> lon. I also removed > unused code, or code only called from tests: I think Lucene shouldn't > just export spatial APIs unless we also ourselves need them for > indexing and searching. Finally, I tried to shrink wrap the APIs, > making previously public apis private if nobody external invoked them. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
