[jira] [Commented] (LUCENE-8038) Decouple payload decoding from Similarity

2018-07-23 Thread Tapan Vaishnav (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552852#comment-16552852 ] Tapan Vaishnav commented on LUCENE-8038: Hi [~romseygeek] , Thank you for your quick response.

[jira] [Commented] (LUCENE-8038) Decouple payload decoding from Similarity

2018-07-23 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552456#comment-16552456 ] Alan Woodward commented on LUCENE-8038: --- I think it's a bug... we don't really have enough tests

[jira] [Commented] (LUCENE-8038) Decouple payload decoding from Similarity

2018-07-23 Thread Tapan Vaishnav (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552374#comment-16552374 ] Tapan Vaishnav commented on LUCENE-8038: [~romseygeek]   Hello,  Can you(or anyone) tell me what

[jira] [Commented] (LUCENE-8038) Decouple payload decoding from Similarity

2018-03-13 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396781#comment-16396781 ] Alan Woodward commented on LUCENE-8038: --- Hi [~xabbu42], this is because the DelimiterPayloadFilter

[jira] [Commented] (LUCENE-8038) Decouple payload decoding from Similarity

2018-03-08 Thread Nathan Gass (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391189#comment-16391189 ] Nathan Gass commented on LUCENE-8038: - With my current test setup (elasticsearch 6.2.2 and

[jira] [Commented] (LUCENE-8038) Decouple payload decoding from Similarity

2017-11-09 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245725#comment-16245725 ] ASF subversion and git services commented on LUCENE-8038: - Commit

[jira] [Commented] (LUCENE-8038) Decouple payload decoding from Similarity

2017-11-09 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245722#comment-16245722 ] ASF subversion and git services commented on LUCENE-8038: - Commit

[jira] [Commented] (LUCENE-8038) Decouple payload decoding from Similarity

2017-11-09 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245719#comment-16245719 ] ASF subversion and git services commented on LUCENE-8038: - Commit

[jira] [Commented] (LUCENE-8038) Decouple payload decoding from Similarity

2017-11-08 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243566#comment-16243566 ] Alan Woodward commented on LUCENE-8038: --- PayloadScoreQuery just multiplies the score returned by

[jira] [Commented] (LUCENE-8038) Decouple payload decoding from Similarity

2017-11-07 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241900#comment-16241900 ] Robert Muir commented on LUCENE-8038: - They need to be restricted though, thats why we opened this

[jira] [Commented] (LUCENE-8038) Decouple payload decoding from Similarity

2017-11-07 Thread Nathan Gass (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241894#comment-16241894 ] Nathan Gass commented on LUCENE-8038: - {quote}I want to urge caution about adding more flexibility.

[jira] [Commented] (LUCENE-8038) Decouple payload decoding from Similarity

2017-11-06 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240276#comment-16240276 ] Alan Woodward commented on LUCENE-8038: --- I think the extra flexibility could be limited to just

[jira] [Commented] (LUCENE-8038) Decouple payload decoding from Similarity

2017-11-06 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240220#comment-16240220 ] Robert Muir commented on LUCENE-8038: - I want to urge caution about adding more flexibility. There is

[jira] [Commented] (LUCENE-8038) Decouple payload decoding from Similarity

2017-11-06 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240182#comment-16240182 ] Alan Woodward commented on LUCENE-8038: --- bq. It might be useful to let PayloadDecoder return null

[jira] [Commented] (LUCENE-8038) Decouple payload decoding from Similarity

2017-11-06 Thread Nathan Gass (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240170#comment-16240170 ] Nathan Gass commented on LUCENE-8038: - It might be feature creep for the current issue. But what is

[jira] [Commented] (LUCENE-8038) Decouple payload decoding from Similarity

2017-11-06 Thread Nathan Gass (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240165#comment-16240165 ] Nathan Gass commented on LUCENE-8038: - Yes this also fixes LUCENE-7744. As I read the code however,