[jira] [Commented] (SOLR-12304) Interesting Terms parameter is ignored by MLT Component
[ https://issues.apache.org/jira/browse/SOLR-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853002#comment-16853002 ] Alessandro Benedetti commented on SOLR-12304: - That's great! Thank you [~dsmiley] for your support! The MLT looks a bit abandoned to me but I believe it's an important feature. I will continue working on that, step by step. I will provide a patch to support sharding (for the seed document retrieval) soon. Cheers > Interesting Terms parameter is ignored by MLT Component > --- > > Key: SOLR-12304 > URL: https://issues.apache.org/jira/browse/SOLR-12304 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: MoreLikeThis >Affects Versions: 7.2 >Reporter: Alessandro Benedetti >Assignee: David Smiley >Priority: Major > Fix For: 8.2 > > Attachments: SOLR-12304.patch, SOLR-12304.patch, SOLR-12304.patch, > SOLR-12304.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Currently the More Like This component just ignores the mlt.InterestingTerms > parameter ( which is usable by the MoreLikeThisHandler). > Scope of this issue is to fix the bug and add related tests ( which will > succeed after the fix ) > *N.B.* MoreLikeThisComponent and MoreLikeThisHandler are very coupled and the > tests for the MoreLikeThisHandler are intersecting the MoreLikeThisComponent > ones . > It is out of scope for this issue any consideration or refactor of that. > Other issues will follow. > *N.B.* out of scope for this issue is the distributed case, which is much > more complicated and requires much deeper investigations -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12304) Interesting Terms parameter is ignored by MLT Component
[
https://issues.apache.org/jira/browse/SOLR-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842053#comment-16842053
]
Lucene/Solr QA commented on SOLR-12304:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 9s{color}
| {color:red} SOLR-12304 does not apply to master. Rebase required? Wrong
Branch? See
https://wiki.apache.org/solr/HowToContribute#Creating_the_patch_file for help.
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-12304 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12956556/SOLR-12304.patch |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/396/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Interesting Terms parameter is ignored by MLT Component
> ---
>
> Key: SOLR-12304
> URL: https://issues.apache.org/jira/browse/SOLR-12304
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: MoreLikeThis
>Affects Versions: 7.2
>Reporter: Alessandro Benedetti
>Assignee: David Smiley
>Priority: Major
> Fix For: 8.2
>
> Attachments: SOLR-12304.patch, SOLR-12304.patch, SOLR-12304.patch,
> SOLR-12304.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently the More Like This component just ignores the mlt.InterestingTerms
> parameter ( which is usable by the MoreLikeThisHandler).
> Scope of this issue is to fix the bug and add related tests ( which will
> succeed after the fix )
> *N.B.* MoreLikeThisComponent and MoreLikeThisHandler are very coupled and the
> tests for the MoreLikeThisHandler are intersecting the MoreLikeThisComponent
> ones .
> It is out of scope for this issue any consideration or refactor of that.
> Other issues will follow.
> *N.B.* out of scope for this issue is the distributed case, which is much
> more complicated and requires much deeper investigations
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12304) Interesting Terms parameter is ignored by MLT Component
[ https://issues.apache.org/jira/browse/SOLR-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841870#comment-16841870 ] ASF subversion and git services commented on SOLR-12304: Commit 6f83dad301a011d5e390b793ffa09bfb75fe7b48 in lucene-solr's branch refs/heads/branch_8x from Alessandro Benedetti [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=6f83dad ] SOLR-12304: MLT component now supports mlt.interestingTerms (cherry picked from commit b9db118ed3f60e0eb431126a1f5401b59c22808a) > Interesting Terms parameter is ignored by MLT Component > --- > > Key: SOLR-12304 > URL: https://issues.apache.org/jira/browse/SOLR-12304 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: MoreLikeThis >Affects Versions: 7.2 >Reporter: Alessandro Benedetti >Assignee: David Smiley >Priority: Major > Attachments: SOLR-12304.patch, SOLR-12304.patch, SOLR-12304.patch, > SOLR-12304.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Currently the More Like This component just ignores the mlt.InterestingTerms > parameter ( which is usable by the MoreLikeThisHandler). > Scope of this issue is to fix the bug and add related tests ( which will > succeed after the fix ) > *N.B.* MoreLikeThisComponent and MoreLikeThisHandler are very coupled and the > tests for the MoreLikeThisHandler are intersecting the MoreLikeThisComponent > ones . > It is out of scope for this issue any consideration or refactor of that. > Other issues will follow. > *N.B.* out of scope for this issue is the distributed case, which is much > more complicated and requires much deeper investigations -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12304) Interesting Terms parameter is ignored by MLT Component
[ https://issues.apache.org/jira/browse/SOLR-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841869#comment-16841869 ] ASF subversion and git services commented on SOLR-12304: Commit b9db118ed3f60e0eb431126a1f5401b59c22808a in lucene-solr's branch refs/heads/master from Alessandro Benedetti [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=b9db118e ] SOLR-12304: MLT component now supports mlt.interestingTerms > Interesting Terms parameter is ignored by MLT Component > --- > > Key: SOLR-12304 > URL: https://issues.apache.org/jira/browse/SOLR-12304 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: MoreLikeThis >Affects Versions: 7.2 >Reporter: Alessandro Benedetti >Assignee: David Smiley >Priority: Major > Attachments: SOLR-12304.patch, SOLR-12304.patch, SOLR-12304.patch, > SOLR-12304.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Currently the More Like This component just ignores the mlt.InterestingTerms > parameter ( which is usable by the MoreLikeThisHandler). > Scope of this issue is to fix the bug and add related tests ( which will > succeed after the fix ) > *N.B.* MoreLikeThisComponent and MoreLikeThisHandler are very coupled and the > tests for the MoreLikeThisHandler are intersecting the MoreLikeThisComponent > ones . > It is out of scope for this issue any consideration or refactor of that. > Other issues will follow. > *N.B.* out of scope for this issue is the distributed case, which is much > more complicated and requires much deeper investigations -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12304) Interesting Terms parameter is ignored by MLT Component
[
https://issues.apache.org/jira/browse/SOLR-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754609#comment-16754609
]
Lucene/Solr QA commented on SOLR-12304:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
30s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 3m 25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 3m 25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 3m 25s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 79m 56s{color}
| {color:red} core in the patch failed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 91m 10s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | solr.cloud.LeaderTragicEventTest |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-12304 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12956556/SOLR-12304.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP
Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 8bee03f |
| ant | version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018 |
| Default Java | 1.8.0_191 |
| unit |
https://builds.apache.org/job/PreCommit-SOLR-Build/274/artifact/out/patch-unit-solr_core.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/274/testReport/ |
| modules | C: solr/core U: solr/core |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/274/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Interesting Terms parameter is ignored by MLT Component
> ---
>
> Key: SOLR-12304
> URL: https://issues.apache.org/jira/browse/SOLR-12304
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: MoreLikeThis
>Affects Versions: 7.2
>Reporter: Alessandro Benedetti
>Priority: Major
> Attachments: SOLR-12304.patch, SOLR-12304.patch, SOLR-12304.patch,
> SOLR-12304.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently the More Like This component just ignores the mlt.InterestingTerms
> parameter ( which is usable by the MoreLikeThisHandler).
> Scope of this issue is to fix the bug and add related tests ( which will
> succeed after the fix )
> *N.B.* MoreLikeThisComponent and MoreLikeThisHandler are very coupled and the
> tests for the MoreLikeThisHandler are intersecting the MoreLikeThisComponent
> ones .
> It is out of scope for this issue any consideration or refactor of that.
> Other issues will follow.
> *N.B.* out of scope for this issue is the distributed case, which is much
> more complicated and requires much deeper investigations
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12304) Interesting Terms parameter is ignored by MLT Component
[ https://issues.apache.org/jira/browse/SOLR-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753857#comment-16753857 ] Alessandro Benedetti commented on SOLR-12304: - The bot doesn't check the Pull Request code and the patch was somewhat corrupt. Just uploaded an healthy one. > Interesting Terms parameter is ignored by MLT Component > --- > > Key: SOLR-12304 > URL: https://issues.apache.org/jira/browse/SOLR-12304 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: MoreLikeThis >Affects Versions: 7.2 >Reporter: Alessandro Benedetti >Priority: Major > Attachments: SOLR-12304.patch, SOLR-12304.patch, SOLR-12304.patch, > SOLR-12304.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Currently the More Like This component just ignores the mlt.InterestingTerms > parameter ( which is usable by the MoreLikeThisHandler). > Scope of this issue is to fix the bug and add related tests ( which will > succeed after the fix ) > *N.B.* MoreLikeThisComponent and MoreLikeThisHandler are very coupled and the > tests for the MoreLikeThisHandler are intersecting the MoreLikeThisComponent > ones . > It is out of scope for this issue any consideration or refactor of that. > Other issues will follow. > *N.B.* out of scope for this issue is the distributed case, which is much > more complicated and requires much deeper investigations -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12304) Interesting Terms parameter is ignored by MLT Component
[ https://issues.apache.org/jira/browse/SOLR-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753858#comment-16753858 ] Alessandro Benedetti commented on SOLR-12304: - The bot doesn't check the Pull Request code and the patch was somewhat corrupt. Just uploaded an healthy one. > Interesting Terms parameter is ignored by MLT Component > --- > > Key: SOLR-12304 > URL: https://issues.apache.org/jira/browse/SOLR-12304 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: MoreLikeThis >Affects Versions: 7.2 >Reporter: Alessandro Benedetti >Priority: Major > Attachments: SOLR-12304.patch, SOLR-12304.patch, SOLR-12304.patch, > SOLR-12304.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Currently the More Like This component just ignores the mlt.InterestingTerms > parameter ( which is usable by the MoreLikeThisHandler). > Scope of this issue is to fix the bug and add related tests ( which will > succeed after the fix ) > *N.B.* MoreLikeThisComponent and MoreLikeThisHandler are very coupled and the > tests for the MoreLikeThisHandler are intersecting the MoreLikeThisComponent > ones . > It is out of scope for this issue any consideration or refactor of that. > Other issues will follow. > *N.B.* out of scope for this issue is the distributed case, which is much > more complicated and requires much deeper investigations -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12304) Interesting Terms parameter is ignored by MLT Component
[
https://issues.apache.org/jira/browse/SOLR-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753646#comment-16753646
]
Lucene/Solr QA commented on SOLR-12304:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s{color}
| {color:red} SOLR-12304 does not apply to master. Rebase required? Wrong
Branch? See
https://wiki.apache.org/solr/HowToContribute#Creating_the_patch_file for help.
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-12304 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12956495/SOLR-12304.patch |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/273/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Interesting Terms parameter is ignored by MLT Component
> ---
>
> Key: SOLR-12304
> URL: https://issues.apache.org/jira/browse/SOLR-12304
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: MoreLikeThis
>Affects Versions: 7.2
>Reporter: Alessandro Benedetti
>Priority: Major
> Attachments: SOLR-12304.patch, SOLR-12304.patch, SOLR-12304.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently the More Like This component just ignores the mlt.InterestingTerms
> parameter ( which is usable by the MoreLikeThisHandler).
> Scope of this issue is to fix the bug and add related tests ( which will
> succeed after the fix )
> *N.B.* MoreLikeThisComponent and MoreLikeThisHandler are very coupled and the
> tests for the MoreLikeThisHandler are intersecting the MoreLikeThisComponent
> ones .
> It is out of scope for this issue any consideration or refactor of that.
> Other issues will follow.
> *N.B.* out of scope for this issue is the distributed case, which is much
> more complicated and requires much deeper investigations
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12304) Interesting Terms parameter is ignored by MLT Component
[ https://issues.apache.org/jira/browse/SOLR-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753377#comment-16753377 ] Alessandro Benedetti commented on SOLR-12304: - Hi [~dsmiley], I created the other issue that will take care of the More Like This Handler removal : https://issues.apache.org/jira/browse/SOLR-13172 . Then I updated the Pull Request with the minor change you proposed and merging back upstream master, it is up to date, no conflict and related tests are green. The reason I considered it a bug(or better an half baked functionality) is because there was the Lucene implementation available, Apache Solr had the request parameters meant to provide the functionality but then, they were just not used to actually properly generate the Interesting Terms. Ready for review! > Interesting Terms parameter is ignored by MLT Component > --- > > Key: SOLR-12304 > URL: https://issues.apache.org/jira/browse/SOLR-12304 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: MoreLikeThis >Affects Versions: 7.2 >Reporter: Alessandro Benedetti >Priority: Major > Attachments: SOLR-12304.patch, SOLR-12304.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Currently the More Like This component just ignores the mlt.InterestingTerms > parameter ( which is usable by the MoreLikeThisHandler). > Scope of this issue is to fix the bug and add related tests ( which will > succeed after the fix ) > *N.B.* MoreLikeThisComponent and MoreLikeThisHandler are very coupled and the > tests for the MoreLikeThisHandler are intersecting the MoreLikeThisComponent > ones . > It is out of scope for this issue any consideration or refactor of that. > Other issues will follow. > *N.B.* out of scope for this issue is the distributed case, which is much > more complicated and requires much deeper investigations -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12304) Interesting Terms parameter is ignored by MLT Component
[ https://issues.apache.org/jira/browse/SOLR-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753375#comment-16753375 ] Alessandro Benedetti commented on SOLR-12304: - [~dsmiley], I just created the separated issue for the deprecation of the handler. > Interesting Terms parameter is ignored by MLT Component > --- > > Key: SOLR-12304 > URL: https://issues.apache.org/jira/browse/SOLR-12304 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: MoreLikeThis >Affects Versions: 7.2 >Reporter: Alessandro Benedetti >Priority: Major > Attachments: SOLR-12304.patch, SOLR-12304.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Currently the More Like This component just ignores the mlt.InterestingTerms > parameter ( which is usable by the MoreLikeThisHandler). > Scope of this issue is to fix the bug and add related tests ( which will > succeed after the fix ) > *N.B.* MoreLikeThisComponent and MoreLikeThisHandler are very coupled and the > tests for the MoreLikeThisHandler are intersecting the MoreLikeThisComponent > ones . > It is out of scope for this issue any consideration or refactor of that. > Other issues will follow. > *N.B.* out of scope for this issue is the distributed case, which is much > more complicated and requires much deeper investigations -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12304) Interesting Terms parameter is ignored by MLT Component
[ https://issues.apache.org/jira/browse/SOLR-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16738436#comment-16738436 ] David Smiley commented on SOLR-12304: - Okay; deprecate then delete just the handler then. That can be worked out in another issue. It's debatable wether that's 8.0 dependent, I suppose. Yes this patch seems valid. I took a little look at the patch. In the spot where you create interestingTermsResponse, you used a NamedList. But I think a SimpleOrderedMap since the keys will not repeat (that's the difference – yeah I know that's confusing). Otherwise it seems good. I like all the tests. Curious; why do you consider this a bug? Seems like an enhancement to the MLT component. > Interesting Terms parameter is ignored by MLT Component > --- > > Key: SOLR-12304 > URL: https://issues.apache.org/jira/browse/SOLR-12304 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: MoreLikeThis >Affects Versions: 7.2 >Reporter: Alessandro Benedetti >Priority: Major > Attachments: SOLR-12304.patch, SOLR-12304.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Currently the More Like This component just ignores the mlt.InterestingTerms > parameter ( which is usable by the MoreLikeThisHandler). > Scope of this issue is to fix the bug and add related tests ( which will > succeed after the fix ) > *N.B.* MoreLikeThisComponent and MoreLikeThisHandler are very coupled and the > tests for the MoreLikeThisHandler are intersecting the MoreLikeThisComponent > ones . > It is out of scope for this issue any consideration or refactor of that. > Other issues will follow. > *N.B.* out of scope for this issue is the distributed case, which is much > more complicated and requires much deeper investigations -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12304) Interesting Terms parameter is ignored by MLT Component
[ https://issues.apache.org/jira/browse/SOLR-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16738355#comment-16738355 ] Alessandro Benedetti commented on SOLR-12304: - thanks for your response David, investigating a bit more, there is a functionality that is offered by the component that is not achievable through the query parser: *Using MoreLikeThis as a search component returns similar documents for each document in the response set.* Given that, it should be ok to keep it and this patch is still valid. Deprecating the MLT handler is still recommended though. Ideally I prefer to remove it as I fear deprecated stuff could pend around for a while. I will work in the next month on that, I will open a Jira and keep the progress there. > Interesting Terms parameter is ignored by MLT Component > --- > > Key: SOLR-12304 > URL: https://issues.apache.org/jira/browse/SOLR-12304 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: MoreLikeThis >Affects Versions: 7.2 >Reporter: Alessandro Benedetti >Priority: Major > Attachments: SOLR-12304.patch, SOLR-12304.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Currently the More Like This component just ignores the mlt.InterestingTerms > parameter ( which is usable by the MoreLikeThisHandler). > Scope of this issue is to fix the bug and add related tests ( which will > succeed after the fix ) > *N.B.* MoreLikeThisComponent and MoreLikeThisHandler are very coupled and the > tests for the MoreLikeThisHandler are intersecting the MoreLikeThisComponent > ones . > It is out of scope for this issue any consideration or refactor of that. > Other issues will follow. > *N.B.* out of scope for this issue is the distributed case, which is much > more complicated and requires much deeper investigations -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12304) Interesting Terms parameter is ignored by MLT Component
[ https://issues.apache.org/jira/browse/SOLR-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737471#comment-16737471 ] David Smiley commented on SOLR-12304: - My preferences is to deprecate the MLT handler & component based on its apparent redundancy. Thanks for summarizing the differences. If you agree with that, and if you post an issue accomplishing that, then I would jump on it to get that into 8.0 & 7.x. For starters, that could simply be a deprecated annotation, and some notes in the ref guide at appropriate places. Bonus would be a warning logged on first use. Personally I've been directing my efforts of late to anything related to 8.0, and this issue is not aligned with that. After 8.0 I hope to assist with people's patches more, especially ones that are ready to go. > Interesting Terms parameter is ignored by MLT Component > --- > > Key: SOLR-12304 > URL: https://issues.apache.org/jira/browse/SOLR-12304 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: MoreLikeThis >Affects Versions: 7.2 >Reporter: Alessandro Benedetti >Priority: Major > Attachments: SOLR-12304.patch, SOLR-12304.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Currently the More Like This component just ignores the mlt.InterestingTerms > parameter ( which is usable by the MoreLikeThisHandler). > Scope of this issue is to fix the bug and add related tests ( which will > succeed after the fix ) > *N.B.* MoreLikeThisComponent and MoreLikeThisHandler are very coupled and the > tests for the MoreLikeThisHandler are intersecting the MoreLikeThisComponent > ones . > It is out of scope for this issue any consideration or refactor of that. > Other issues will follow. > *N.B.* out of scope for this issue is the distributed case, which is much > more complicated and requires much deeper investigations -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12304) Interesting Terms parameter is ignored by MLT Component
[ https://issues.apache.org/jira/browse/SOLR-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737213#comment-16737213 ] Alessandro Benedetti commented on SOLR-12304: - [~dsmiley] any feedback on the latest messages? I would be happy to help, but it seems this issue got forgotten. Should we proceed in the deprecation path? Or just keep the component and handler for backward compatibility ? > Interesting Terms parameter is ignored by MLT Component > --- > > Key: SOLR-12304 > URL: https://issues.apache.org/jira/browse/SOLR-12304 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: MoreLikeThis >Affects Versions: 7.2 >Reporter: Alessandro Benedetti >Priority: Major > Attachments: SOLR-12304.patch, SOLR-12304.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Currently the More Like This component just ignores the mlt.InterestingTerms > parameter ( which is usable by the MoreLikeThisHandler). > Scope of this issue is to fix the bug and add related tests ( which will > succeed after the fix ) > *N.B.* MoreLikeThisComponent and MoreLikeThisHandler are very coupled and the > tests for the MoreLikeThisHandler are intersecting the MoreLikeThisComponent > ones . > It is out of scope for this issue any consideration or refactor of that. > Other issues will follow. > *N.B.* out of scope for this issue is the distributed case, which is much > more complicated and requires much deeper investigations -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12304) Interesting Terms parameter is ignored by MLT Component
[
https://issues.apache.org/jira/browse/SOLR-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724342#comment-16724342
]
Lucene/Solr QA commented on SOLR-12304:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
51s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 1m 36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 1m 36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 1m 36s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 38m
40s{color} | {color:green} core in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 44m 53s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-12304 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12921774/SOLR-12304.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene1-us-west 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon
Sep 24 17:14:57 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / dcd4a28 |
| ant | version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018 |
| Default Java | 1.8.0_191 |
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/252/testReport/ |
| modules | C: solr/core U: solr/core |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/252/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Interesting Terms parameter is ignored by MLT Component
> ---
>
> Key: SOLR-12304
> URL: https://issues.apache.org/jira/browse/SOLR-12304
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: MoreLikeThis
>Affects Versions: 7.2
>Reporter: Alessandro Benedetti
>Priority: Major
> Attachments: SOLR-12304.patch, SOLR-12304.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently the More Like This component just ignores the mlt.InterestingTerms
> parameter ( which is usable by the MoreLikeThisHandler).
> Scope of this issue is to fix the bug and add related tests ( which will
> succeed after the fix )
> *N.B.* MoreLikeThisComponent and MoreLikeThisHandler are very coupled and the
> tests for the MoreLikeThisHandler are intersecting the MoreLikeThisComponent
> ones .
> It is out of scope for this issue any consideration or refactor of that.
> Other issues will follow.
> *N.B.* out of scope for this issue is the distributed case, which is much
> more complicated and requires much deeper investigations
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12304) Interesting Terms parameter is ignored by MLT Component
[ https://issues.apache.org/jira/browse/SOLR-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722863#comment-16722863 ] Alessandro Benedetti commented on SOLR-12304: - I will just repeat myself, but I don't have anything to add apart the fact I am happy to contribute a different patch or help. So I would love some update on this from the community. > Interesting Terms parameter is ignored by MLT Component > --- > > Key: SOLR-12304 > URL: https://issues.apache.org/jira/browse/SOLR-12304 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: MoreLikeThis >Affects Versions: 7.2 >Reporter: Alessandro Benedetti >Priority: Major > Attachments: SOLR-12304.patch, SOLR-12304.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Currently the More Like This component just ignores the mlt.InterestingTerms > parameter ( which is usable by the MoreLikeThisHandler). > Scope of this issue is to fix the bug and add related tests ( which will > succeed after the fix ) > *N.B.* MoreLikeThisComponent and MoreLikeThisHandler are very coupled and the > tests for the MoreLikeThisHandler are intersecting the MoreLikeThisComponent > ones . > It is out of scope for this issue any consideration or refactor of that. > Other issues will follow. > *N.B.* out of scope for this issue is the distributed case, which is much > more complicated and requires much deeper investigations -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12304) Interesting Terms parameter is ignored by MLT Component
[ https://issues.apache.org/jira/browse/SOLR-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516905#comment-16516905 ] Alessandro Benedetti commented on SOLR-12304: - Any update on this ? I am happy to contribute a different patch or help. If deprecation is the path to go I am happy to contribute a patch that way... > Interesting Terms parameter is ignored by MLT Component > --- > > Key: SOLR-12304 > URL: https://issues.apache.org/jira/browse/SOLR-12304 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: MoreLikeThis >Affects Versions: 7.2 >Reporter: Alessandro Benedetti >Priority: Major > Attachments: SOLR-12304.patch, SOLR-12304.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Currently the More Like This component just ignores the mlt.InterestingTerms > parameter ( which is usable by the MoreLikeThisHandler). > Scope of this issue is to fix the bug and add related tests ( which will > succeed after the fix ) > *N.B.* MoreLikeThisComponent and MoreLikeThisHandler are very coupled and the > tests for the MoreLikeThisHandler are intersecting the MoreLikeThisComponent > ones . > It is out of scope for this issue any consideration or refactor of that. > Other issues will follow. > *N.B.* out of scope for this issue is the distributed case, which is much > more complicated and requires much deeper investigations -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12304) Interesting Terms parameter is ignored by MLT Component
[ https://issues.apache.org/jira/browse/SOLR-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493924#comment-16493924 ] Alessandro Benedetti commented on SOLR-12304: - Any update on this ? happy to contribute a different patch or help > Interesting Terms parameter is ignored by MLT Component > --- > > Key: SOLR-12304 > URL: https://issues.apache.org/jira/browse/SOLR-12304 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: MoreLikeThis >Affects Versions: 7.2 >Reporter: Alessandro Benedetti >Priority: Major > Attachments: SOLR-12304.patch, SOLR-12304.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Currently the More Like This component just ignores the mlt.InterestingTerms > parameter ( which is usable by the MoreLikeThisHandler). > Scope of this issue is to fix the bug and add related tests ( which will > succeed after the fix ) > *N.B.* MoreLikeThisComponent and MoreLikeThisHandler are very coupled and the > tests for the MoreLikeThisHandler are intersecting the MoreLikeThisComponent > ones . > It is out of scope for this issue any consideration or refactor of that. > Other issues will follow. > *N.B.* out of scope for this issue is the distributed case, which is much > more complicated and requires much deeper investigations -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12304) Interesting Terms parameter is ignored by MLT Component
[ https://issues.apache.org/jira/browse/SOLR-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479704#comment-16479704 ] Alessandro Benedetti commented on SOLR-12304: - Anything I can do my side to proceed with the review and merge of this patch ? Should I open a new Jira issue to deprecate the redundant More Like This components and just leave the query parser as official supported approach ? > Interesting Terms parameter is ignored by MLT Component > --- > > Key: SOLR-12304 > URL: https://issues.apache.org/jira/browse/SOLR-12304 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: MoreLikeThis >Affects Versions: 7.2 >Reporter: Alessandro Benedetti >Priority: Major > Attachments: SOLR-12304.patch, SOLR-12304.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Currently the More Like This component just ignores the mlt.InterestingTerms > parameter ( which is usable by the MoreLikeThisHandler). > Scope of this issue is to fix the bug and add related tests ( which will > succeed after the fix ) > *N.B.* MoreLikeThisComponent and MoreLikeThisHandler are very coupled and the > tests for the MoreLikeThisHandler are intersecting the MoreLikeThisComponent > ones . > It is out of scope for this issue any consideration or refactor of that. > Other issues will follow. > *N.B.* out of scope for this issue is the distributed case, which is much > more complicated and requires much deeper investigations -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12304) Interesting Terms parameter is ignored by MLT Component
[ https://issues.apache.org/jira/browse/SOLR-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463792#comment-16463792 ] Alessandro Benedetti commented on SOLR-12304: - [~dsmiley] thanks for your comment. Generally in Software Engineering I am a strong supporter of the KISS principle so in short I agree with you, I would love to see both the handler and the component gone, and only the Query Parser left as only entry point for More Like This Lucene functionality. Given that, let me analyse what the handler and the component are offering, which the query parser does not. This could generate few other Jira issues to complete before we remove the handler and component : 1) *more advanced debug* - in my opinion is neglectable, the normal debug will show the query parsed which will be more than enough to understand how the MLT query was built. 2) *Interesting Terms* - which was the scope of this issue, also in this case I do agree that getting the interesting terms out of a corpus of documents should be a separate feature ( close to faceting than MLT). getting the interesting terms out of the More Like This source document can be done indirectly verifying the debug information for the query parsing +1 to officially deprecate both the handler and component, those classes are very coupled and not very readable anyway ( with no offese to any author) This will also simplify the work I am doing refactoring the Lucene More Like This ( https://issues.apache.org/jira/browse/SOLR-12299 ) > Interesting Terms parameter is ignored by MLT Component > --- > > Key: SOLR-12304 > URL: https://issues.apache.org/jira/browse/SOLR-12304 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: MoreLikeThis >Affects Versions: 7.2 >Reporter: Alessandro Benedetti >Priority: Major > Attachments: SOLR-12304.patch, SOLR-12304.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Currently the More Like This component just ignores the mlt.InterestingTerms > parameter ( which is usable by the MoreLikeThisHandler). > Scope of this issue is to fix the bug and add related tests ( which will > succeed after the fix ) > *N.B.* MoreLikeThisComponent and MoreLikeThisHandler are very coupled and the > tests for the MoreLikeThisHandler are intersecting the MoreLikeThisComponent > ones . > It is out of scope for this issue any consideration or refactor of that. > Other issues will follow. > *N.B.* out of scope for this issue is the distributed case, which is much > more complicated and requires much deeper investigations -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12304) Interesting Terms parameter is ignored by MLT Component
[
https://issues.apache.org/jira/browse/SOLR-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463099#comment-16463099
]
Lucene/Solr QA commented on SOLR-12304:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
21s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 2m 20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 2m 20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 2m 20s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 80m 35s{color}
| {color:red} core in the patch failed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 88m 39s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
solr.cloud.api.collections.TestCollectionsAPIViaSolrCloudCluster |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-12304 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12921774/SOLR-12304.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene1-us-west 3.13.0-88-generic #135-Ubuntu SMP Wed Jun 8
21:10:42 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / ab11867 |
| ant | version: Apache Ant(TM) version 1.9.3 compiled on April 8 2014 |
| Default Java | 1.8.0_172 |
| unit |
https://builds.apache.org/job/PreCommit-SOLR-Build/76/artifact/out/patch-unit-solr_core.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/76/testReport/ |
| modules | C: solr/core U: solr/core |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/76/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Interesting Terms parameter is ignored by MLT Component
> ---
>
> Key: SOLR-12304
> URL: https://issues.apache.org/jira/browse/SOLR-12304
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: MoreLikeThis
>Affects Versions: 7.2
>Reporter: Alessandro Benedetti
>Priority: Major
> Attachments: SOLR-12304.patch, SOLR-12304.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently the More Like This component just ignores the mlt.InterestingTerms
> parameter ( which is usable by the MoreLikeThisHandler).
> Scope of this issue is to fix the bug and add related tests ( which will
> succeed after the fix )
> *N.B.* MoreLikeThisComponent and MoreLikeThisHandler are very coupled and the
> tests for the MoreLikeThisHandler are intersecting the MoreLikeThisComponent
> ones .
> It is out of scope for this issue any consideration or refactor of that.
> Other issues will follow.
> *N.B.* out of scope for this issue is the distributed case, which is much
> more complicated and requires much deeper investigations
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12304) Interesting Terms parameter is ignored by MLT Component
[ https://issues.apache.org/jira/browse/SOLR-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462903#comment-16462903 ] David Smiley commented on SOLR-12304: - Just curious, but in your opinion is there any purpose to MLT component & handler anymore now that we have an MLT query parser? > Interesting Terms parameter is ignored by MLT Component > --- > > Key: SOLR-12304 > URL: https://issues.apache.org/jira/browse/SOLR-12304 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: MoreLikeThis >Affects Versions: 7.2 >Reporter: Alessandro Benedetti >Priority: Major > Attachments: SOLR-12304.patch, SOLR-12304.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Currently the More Like This component just ignores the mlt.InterestingTerms > parameter ( which is usable by the MoreLikeThisHandler). > Scope of this issue is to fix the bug and add related tests ( which will > succeed after the fix ) > *N.B.* MoreLikeThisComponent and MoreLikeThisHandler are very coupled and the > tests for the MoreLikeThisHandler are intersecting the MoreLikeThisComponent > ones . > It is out of scope for this issue any consideration or refactor of that. > Other issues will follow. > *N.B.* out of scope for this issue is the distributed case, which is much > more complicated and requires much deeper investigations -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12304) Interesting Terms parameter is ignored by MLT Component
[ https://issues.apache.org/jira/browse/SOLR-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461269#comment-16461269 ] Alessandro Benedetti commented on SOLR-12304: - [https://github.com/apache/lucene-solr/pull/368.patch] > Interesting Terms parameter is ignored by MLT Component > --- > > Key: SOLR-12304 > URL: https://issues.apache.org/jira/browse/SOLR-12304 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: MoreLikeThis >Affects Versions: 7.2 >Reporter: Alessandro Benedetti >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Currently the More Like This component just ignores the mlt.InterestingTerms > parameter ( which is usable by the MoreLikeThisHandler). > Scope of this issue is to fix the bug and add related tests ( which will > succeed after the fix ) > *N.B.* MoreLikeThisComponent and MoreLikeThisHandler are very coupled and the > tests for the MoreLikeThisHandler are intersecting the MoreLikeThisComponent > ones . > It is out of scope for this issue any consideration or refactor of that. > Other issues will follow. > *N.B.* out of scope for this issue is the distributed case, which is much > more complicated and requires much deeper investigations -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
