subject:"\[jira\] \[Commented\] \(SOLR\-2452\) rewrite solr build system"


[ 
https://issues.apache.org/jira/browse/SOLR-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13051907#comment-13051907
 ] 

Chris Male commented on SOLR-2452:
--

I haven't reviewed the changes but just a comment on the philosophy:

{quote}
I merged solr/src/common/ into the solrj/ directory
{quote}

I don't hugely like this decision.  Core Solr code (like SolrDocument for 
example) should be in Solr core, not in SolrJ which is just a client library.  
Like Lucene, Solr core should contain all the code it needs.  Any other modules 
(which SolrJ can be considered as one) should then depend on the core.  

Whats the reason for making the choice to put the common code in SolrJ? 



 rewrite solr build system
 -

 Key: SOLR-2452
 URL: https://issues.apache.org/jira/browse/SOLR-2452
 Project: Solr
  Issue Type: Task
  Components: Build
Reporter: Robert Muir
 Fix For: 3.3

 Attachments: SOLR-2452-post-reshuffling.patch, 
 SOLR-2452.dir.reshuffle.sh


 As discussed some in SOLR-2002 (but that issue is long and hard to follow), I 
 think we should rewrite the solr build system.
 Its slow, cumbersome, and messy, and makes it hard for us to improve things.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-2452) rewrite solr build system


[ 
https://issues.apache.org/jira/browse/SOLR-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13051912#comment-13051912
 ] 

Steven Rowe commented on SOLR-2452:
---

bq. Whats the reason for making the choice to put the common code in SolrJ? 

The current packaging arrangement has the the {{common/}} code in the solrj 
jar; similarly, the solr-core jar contains the {{webapp/src/}} code.

The only thing I've done here is eliminated separate source directories.  I 
haven't changed the packaging.

 rewrite solr build system
 -

 Key: SOLR-2452
 URL: https://issues.apache.org/jira/browse/SOLR-2452
 Project: Solr
  Issue Type: Task
  Components: Build
Reporter: Robert Muir
 Fix For: 3.3

 Attachments: SOLR-2452-post-reshuffling.patch, 
 SOLR-2452.dir.reshuffle.sh


 As discussed some in SOLR-2002 (but that issue is long and hard to follow), I 
 think we should rewrite the solr build system.
 Its slow, cumbersome, and messy, and makes it hard for us to improve things.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-2452) rewrite solr build system


[ 
https://issues.apache.org/jira/browse/SOLR-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13051916#comment-13051916
 ] 

Chris Male commented on SOLR-2452:
--

I see.  Can we address the packaging or is that out of scope of this work?

 rewrite solr build system
 -

 Key: SOLR-2452
 URL: https://issues.apache.org/jira/browse/SOLR-2452
 Project: Solr
  Issue Type: Task
  Components: Build
Reporter: Robert Muir
 Fix For: 3.3

 Attachments: SOLR-2452-post-reshuffling.patch, 
 SOLR-2452.dir.reshuffle.sh


 As discussed some in SOLR-2002 (but that issue is long and hard to follow), I 
 think we should rewrite the solr build system.
 Its slow, cumbersome, and messy, and makes it hard for us to improve things.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-2452) rewrite solr build system


[ 
https://issues.apache.org/jira/browse/SOLR-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13051919#comment-13051919
 ] 

Steven Rowe commented on SOLR-2452:
---

bq. SolrJ [...] is just a client library

That's not all it is; on 8/18/2010 on #lucene IRC, yonik wrote:

bq. solrj used to not be included in the war, but solr core uses solrj for 
distributed search


 rewrite solr build system
 -

 Key: SOLR-2452
 URL: https://issues.apache.org/jira/browse/SOLR-2452
 Project: Solr
  Issue Type: Task
  Components: Build
Reporter: Robert Muir
 Fix For: 3.3

 Attachments: SOLR-2452-post-reshuffling.patch, 
 SOLR-2452.dir.reshuffle.sh


 As discussed some in SOLR-2002 (but that issue is long and hard to follow), I 
 think we should rewrite the solr build system.
 Its slow, cumbersome, and messy, and makes it hard for us to improve things.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-2452) rewrite solr build system


[ 
https://issues.apache.org/jira/browse/SOLR-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13051920#comment-13051920
 ] 

Steven Rowe commented on SOLR-2452:
---

bq. Can we address the packaging or is that out of scope of this work?

What did you have in mind?



 rewrite solr build system
 -

 Key: SOLR-2452
 URL: https://issues.apache.org/jira/browse/SOLR-2452
 Project: Solr
  Issue Type: Task
  Components: Build
Reporter: Robert Muir
 Fix For: 3.3

 Attachments: SOLR-2452-post-reshuffling.patch, 
 SOLR-2452.dir.reshuffle.sh


 As discussed some in SOLR-2002 (but that issue is long and hard to follow), I 
 think we should rewrite the solr build system.
 Its slow, cumbersome, and messy, and makes it hard for us to improve things.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-2452) rewrite solr build system


[ 
https://issues.apache.org/jira/browse/SOLR-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13051923#comment-13051923
 ] 

Chris Male commented on SOLR-2452:
--

Hmmm I hadn't considered the issue of SolrJ being used for distributed search. 

 rewrite solr build system
 -

 Key: SOLR-2452
 URL: https://issues.apache.org/jira/browse/SOLR-2452
 Project: Solr
  Issue Type: Task
  Components: Build
Reporter: Robert Muir
 Fix For: 3.3

 Attachments: SOLR-2452-post-reshuffling.patch, 
 SOLR-2452.dir.reshuffle.sh


 As discussed some in SOLR-2002 (but that issue is long and hard to follow), I 
 think we should rewrite the solr build system.
 Its slow, cumbersome, and messy, and makes it hard for us to improve things.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-2452) rewrite solr build system


[ 
https://issues.apache.org/jira/browse/SOLR-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13051928#comment-13051928
 ] 

Chris Male commented on SOLR-2452:
--

I think my comments can be addressed later on maybe and shouldn't stop these 
improvements from going forward so +1

 rewrite solr build system
 -

 Key: SOLR-2452
 URL: https://issues.apache.org/jira/browse/SOLR-2452
 Project: Solr
  Issue Type: Task
  Components: Build
Reporter: Robert Muir
 Fix For: 3.3

 Attachments: SOLR-2452-post-reshuffling.patch, 
 SOLR-2452.dir.reshuffle.sh


 As discussed some in SOLR-2002 (but that issue is long and hard to follow), I 
 think we should rewrite the solr build system.
 Its slow, cumbersome, and messy, and makes it hard for us to improve things.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-2452) rewrite solr build system


[ 
https://issues.apache.org/jira/browse/SOLR-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13051939#comment-13051939
 ] 

Robert Muir commented on SOLR-2452:
---

{quote}
but solrj tests depend on core tests
{quote}

Curious why this is? some base classes that could be moved into test-framework 
instead?


 rewrite solr build system
 -

 Key: SOLR-2452
 URL: https://issues.apache.org/jira/browse/SOLR-2452
 Project: Solr
  Issue Type: Task
  Components: Build
Reporter: Robert Muir
 Fix For: 3.3

 Attachments: SOLR-2452-post-reshuffling.patch, 
 SOLR-2452.dir.reshuffle.sh


 As discussed some in SOLR-2002 (but that issue is long and hard to follow), I 
 think we should rewrite the solr build system.
 Its slow, cumbersome, and messy, and makes it hard for us to improve things.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-2452) rewrite solr build system


[ 
https://issues.apache.org/jira/browse/SOLR-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13051943#comment-13051943
 ] 

Steven Rowe commented on SOLR-2452:
---

{quote}
bq. but solrj tests depend on core tests

Curious why this is? some base classes that could be moved into test-framework 
instead?
{quote}

At a minimum, {{o.a.s.client.solrj.SolrJettyTestBase}} (likely should be moved 
to another package, given that Solr core {{o.a.s.servlet.\*CacheHeaderTest\*}} 
tests extend this class) and {{o.a.s.util.ExternalPaths}}.


 rewrite solr build system
 -

 Key: SOLR-2452
 URL: https://issues.apache.org/jira/browse/SOLR-2452
 Project: Solr
  Issue Type: Task
  Components: Build
Reporter: Robert Muir
 Fix For: 3.3

 Attachments: SOLR-2452-post-reshuffling.patch, 
 SOLR-2452.dir.reshuffle.sh


 As discussed some in SOLR-2002 (but that issue is long and hard to follow), I 
 think we should rewrite the solr build system.
 Its slow, cumbersome, and messy, and makes it hard for us to improve things.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-2452) rewrite solr build system


[ 
https://issues.apache.org/jira/browse/SOLR-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13051953#comment-13051953
 ] 

Robert Muir commented on SOLR-2452:
---

ok, i was just curious, sounds like something that could possibly be dealt with 
later.

I think i said it before too, I find it confusing the way these directories all 
depend upon each other today and how each one is not its own 'subproject' of 
the build (that basically acts like a contrib or module itself and states its 
dependencies). So I would *really* like to see this fixed.

However, I think I would recommend thinking about when you want to make the 
change: it will make merging code up to this branch nearly impossible... is it 
holding back other changes or is this a final step?


 rewrite solr build system
 -

 Key: SOLR-2452
 URL: https://issues.apache.org/jira/browse/SOLR-2452
 Project: Solr
  Issue Type: Task
  Components: Build
Reporter: Robert Muir
 Fix For: 3.3

 Attachments: SOLR-2452-post-reshuffling.patch, 
 SOLR-2452.dir.reshuffle.sh


 As discussed some in SOLR-2002 (but that issue is long and hard to follow), I 
 think we should rewrite the solr build system.
 Its slow, cumbersome, and messy, and makes it hard for us to improve things.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-2452) rewrite solr build system


[ 
https://issues.apache.org/jira/browse/SOLR-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13051957#comment-13051957
 ] 

Robert Muir commented on SOLR-2452:
---

by the way, obviously since you have been doing all the work here, i don't want 
you to read this as me questioning/objecting to the change, just trying to 
maybe help save you some sanity... if you don't mind dealing with the merging I 
would just say go for it.

 rewrite solr build system
 -

 Key: SOLR-2452
 URL: https://issues.apache.org/jira/browse/SOLR-2452
 Project: Solr
  Issue Type: Task
  Components: Build
Reporter: Robert Muir
 Fix For: 3.3

 Attachments: SOLR-2452-post-reshuffling.patch, 
 SOLR-2452.dir.reshuffle.sh


 As discussed some in SOLR-2002 (but that issue is long and hard to follow), I 
 think we should rewrite the solr build system.
 Its slow, cumbersome, and messy, and makes it hard for us to improve things.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-2452) rewrite solr build system

[
https://issues.apache.org/jira/browse/SOLR-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13052250#comment-13052250
]

Steven Rowe commented on SOLR-2452:
---

bq. However, I think I would recommend thinking about when you want to make the
change: it will make merging code up to this branch nearly impossible... is it
holding back other changes or is this a final step?

It's not a final step. All of the targets you removed need to be put back (I
counted 40 or so). But I think this will be a minor amount of work
comparitively.

I think for the moment I'll keep iterating on the patch, rather than committing
it to the branch, to minimize merge costs, until I have all of the Solr targets
re-implemented. I don't think it'll take too long, maybe another day or two.

Once that's done, I'll commit the moves/copies from the shell script and the
patch, then generate a full patch for review. Assuming there are no objections
then, I plan to commit within a day or so to minimize merge costs.

So I hope to have this issue resolved this week.

rewrite solr build system
-

Key: SOLR-2452
URL: https://issues.apache.org/jira/browse/SOLR-2452
Project: Solr
Issue Type: Task
Components: Build
Reporter: Robert Muir
Fix For: 3.3, 4.0

Attachments: SOLR-2452-post-reshuffling.patch,
SOLR-2452.dir.reshuffle.sh

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-2452) rewrite solr build system